177737 2017-10-02 02:05:21 -0700 [GTK][WPE] Enable interactive forms validation by default 2017-10-02 07:33:01 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply cdumez mcatanzaro oldest_to_newest 1355174 0 cgarcia 2017-10-02 02:05:21 -0700 It's currently disabled for no reason. 1355175 1 322363 cgarcia 2017-10-02 02:07:14 -0700 Created attachment 322363 Patch 1355191 2 322363 mcatanzaro 2017-10-02 04:40:48 -0700 Comment on attachment 322363 Patch No r+ from me because you've left it disabled on Windows for no reason. We should get rid of DEFAULT_HTML_INTERACTIVE_FORM_VALIDATION_ENABLED and just hardcode the default value as true. 1355197 3 cgarcia 2017-10-02 04:59:05 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 322363 [details] > Patch > > No r+ from me because you've left it disabled on Windows for no reason. We > should get rid of DEFAULT_HTML_INTERACTIVE_FORM_VALIDATION_ENABLED and just > hardcode the default value as true. Windows? there's no windows wk2 port? I can remove the ifdef before landing 1355203 4 322363 mcatanzaro 2017-10-02 05:34:43 -0700 Comment on attachment 322363 Patch OK, with the ifdef removed Windows WK2 port is WIP. The PlatformWin.cmake is already in place. 1355226 5 cgarcia 2017-10-02 07:33:01 -0700 Committed r222708: <http://trac.webkit.org/changeset/222708> 322363 2017-10-02 02:07:14 -0700 2017-10-02 05:34:43 -0700 Patch wk-forms-validation.diff text/plain 1185 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZWQwODNjN2Y4YzUuLjVkMjUyNDlmMWYwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDE3LTEwLTAyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIEVuYWJsZSBpbnRlcmFjdGl2ZSBmb3JtcyB2YWxp ZGF0aW9uIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3NzczNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEl0J3MgY3VycmVudGx5IGRpc2FibGVkIGZvciBubyByZWFzb24uCisKKyAgICAg ICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oOgorCiAyMDE3LTA5LTMwICBE YXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBIYXZlIElQQzo6Q29ubmVj dGlvbjo6Q2xpZW50IG9iamVjdHMgY29uc2lzdGVudGx5IGludmFsaWRhdGUgdGhlIGNvbm5lY3Rp b24gd2hlbiBkZXN0cm95ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlBy ZWZlcmVuY2VzRGVmaW5pdGlvbnMuaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVu Y2VzRGVmaW5pdGlvbnMuaAppbmRleCA4M2M2MzYxMzI4Yi4uNTg5ZjY4NmYyM2YgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmaW5pdGlvbnMuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgKQEAgLTU3 LDcgKzU3LDcgQEAKICNkZWZpbmUgREVGQVVMVF9QREZQTFVHSU5fRU5BQkxFRCBmYWxzZQogI2Vu ZGlmCiAKLSNpZiBQTEFURk9STShDT0NPQSkKKyNpZiBQTEFURk9STShDT0NPQSkgfHwgUExBVEZP Uk0oR1RLKSB8fCBQTEFURk9STShXUEUpCiAjZGVmaW5lIERFRkFVTFRfSFRNTF9JTlRFUkFDVElW RV9GT1JNX1ZBTElEQVRJT05fRU5BQkxFRCB0cnVlCiAjZWxzZQogI2RlZmluZSBERUZBVUxUX0hU TUxfSU5URVJBQ1RJVkVfRk9STV9WQUxJREFUSU9OX0VOQUJMRUQgZmFsc2UK