177735 2017-10-02 00:38:09 -0700 Fix memory leaks in RenderMultiColumnFlow 2017-10-02 09:01:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue hyatt simon.fraser webkit-bug-importer zalan oldest_to_newest 1355150 0 koivisto 2017-10-02 00:38:09 -0700 Fix memory management. 1355156 1 322359 koivisto 2017-10-02 01:03:09 -0700 Created attachment 322359 patch 1355241 2 322359 commit-queue 2017-10-02 09:00:32 -0700 Comment on attachment 322359 patch Clearing flags on attachment: 322359 Committed r222710: <http://trac.webkit.org/changeset/222710> 1355242 3 commit-queue 2017-10-02 09:00:33 -0700 All reviewed patches have been landed. Closing bug. 1355243 4 webkit-bug-importer 2017-10-02 09:01:29 -0700 <rdar://problem/34767890> 322359 2017-10-02 01:03:09 -0700 2017-10-02 09:00:32 -0700 patch multicol-leak-fix.patch text/plain 4383 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMjcwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE3LTEwLTAyICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggbWVtb3J5IGxlYWtzIGlu IFJlbmRlck11bHRpQ29sdW1uRmxvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc3NzM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5GbG93LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlck11bHRpQ29sdW1uRmxvdzo6ZXZhY3VhdGVBbmREZXN0cm95 KToKKworICAgICAgICAgICAgU3dpdGNoIGZyb20gZGVzdHJveSgpIHRvIHJlbW92ZUZyb21QYXJl bnRBbmREZXN0cm95KCkgKHRoZXkgYXJlIGN1cnJlbnRseSBlcXVpdmFsZW50IGluIHByYWN0aWNl KS4KKworICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTXVsdGlDb2x1bW5GbG93OjpmcmFnbWVudGVk Rmxvd0Rlc2NlbmRhbnRJbnNlcnRlZCk6CisKKyAgICAgICAgICAgIERlc3Ryb3kgdGhlIHBsYWNl aG9sZGVycyBpbnN0ZWFkIG9mIGxlYWtpbmcgdGhlbS4KKworICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyTXVsdGlDb2x1bW5GbG93OjpoYW5kbGVTcGFubmVyUmVtb3ZhbCk6CisKKyAgICAgICAgICAg IERlc3Ryb3kgdGhlIHBsYWNlaG9sZGVyIGluc3RlYWQgb2YgbGVha2luZyBpdC4KKwogMjAxNy0x MC0wMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBXaW5kb3dz IGJ1aWxkIGZpeCBhdHRlbXB0IGFmdGVyIHIyMjI2OTcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5GbG93LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5GbG93LmNwcAkocmV2aXNpb24gMjIy Njk4KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uRmxvdy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTE4OSwxNiArMTg5LDE2IEBAIHZvaWQgUmVuZGVyTXVsdGlD b2x1bW5GbG93OjpldmFjdWF0ZUFuZEQKICAgICAgICAgaWYgKFJlbmRlck11bHRpQ29sdW1uU3Bh bm5lclBsYWNlaG9sZGVyKiBwbGFjZWhvbGRlciA9IGl0LT52YWx1ZS5nZXQoKSkgewogICAgICAg ICAgICAgUmVuZGVyQmxvY2tGbG93JiBvcmlnaW5hbENvbnRhaW5lciA9IGRvd25jYXN0PFJlbmRl ckJsb2NrRmxvdz4oKnBsYWNlaG9sZGVyLT5wYXJlbnQoKSk7CiAgICAgICAgICAgICBvcmlnaW5h bENvbnRhaW5lci5hZGRDaGlsZChXVEZNb3ZlKHRha2VuU3Bhbm5lciksIHBsYWNlaG9sZGVyKTsK LSAgICAgICAgICAgIHBsYWNlaG9sZGVyLT5kZXN0cm95KCk7CisgICAgICAgICAgICBwbGFjZWhv bGRlci0+cmVtb3ZlRnJvbVBhcmVudEFuZERlc3Ryb3koKTsKICAgICAgICAgfQogICAgICAgICBt X3NwYW5uZXJNYXAucmVtb3ZlKGl0KTsKICAgICB9CiAKICAgICAvLyBSZW1vdmUgYWxsIHNldHMu CiAgICAgd2hpbGUgKFJlbmRlck11bHRpQ29sdW1uU2V0KiBjb2x1bW5TZXQgPSBmaXJzdE11bHRp Q29sdW1uU2V0KCkpCi0gICAgICAgIGNvbHVtblNldC0+ZGVzdHJveSgpOworICAgICAgICBjb2x1 bW5TZXQtPnJlbW92ZUZyb21QYXJlbnRBbmREZXN0cm95KCk7CiAgICAgCi0gICAgZGVzdHJveSgp OworICAgIHJlbW92ZUZyb21QYXJlbnRBbmREZXN0cm95KCk7CiB9CiAKIHZvaWQgUmVuZGVyTXVs dGlDb2x1bW5GbG93OjphZGRGcmFnbWVudFRvVGhyZWFkKFJlbmRlckZyYWdtZW50Q29udGFpbmVy KiBSZW5kZXJGcmFnbWVudENvbnRhaW5lcikKQEAgLTQwNyw2ICs0MDcsOSBAQCB2b2lkIFJlbmRl ck11bHRpQ29sdW1uRmxvdzo6ZnJhZ21lbnRlZEZsCiB7CiAgICAgaWYgKGdTaGlmdGluZ1NwYW5u ZXIgfHwgbV9iZWluZ0V2YWN1YXRlZCB8fCBuZXdEZXNjZW5kYW50LmlzSW5GbG93UmVuZGVyRnJh Z21lbnRlZEZsb3coKSkKICAgICAgICAgcmV0dXJuOworCisgICAgVmVjdG9yPFJlbmRlclB0cjxS ZW5kZXJPYmplY3Q+PiBzcGFubmVyc1RvRGVsZXRlOworCiAgICAgUmVuZGVyT2JqZWN0KiBzdWJ0 cmVlUm9vdCA9ICZuZXdEZXNjZW5kYW50OwogICAgIGZvciAoYXV0byogZGVzY2VuZGFudCA9ICZu ZXdEZXNjZW5kYW50OyBkZXNjZW5kYW50OyBkZXNjZW5kYW50ID0gKGRlc2NlbmRhbnQgPyBkZXNj ZW5kYW50LT5uZXh0SW5QcmVPcmRlcihzdWJ0cmVlUm9vdCkgOiBudWxscHRyKSkgewogICAgICAg ICBpZiAoaXM8UmVuZGVyTXVsdGlDb2x1bW5TcGFubmVyUGxhY2Vob2xkZXI+KCpkZXNjZW5kYW50 KSkgewpAQCAtNDMwLDEwICs0MzMsNyBAQCB2b2lkIFJlbmRlck11bHRpQ29sdW1uRmxvdzo6ZnJh Z21lbnRlZEZsCiAgICAgICAgICAgICAgICAgLy8gd2Ugc2hpZnRlZCB0aGUgcGxhY2Vob2xkZXIg ZG93biBpbnRvIHRoaXMgZmxvdyB0aHJlYWQuCiAgICAgICAgICAgICAgICAgcGxhY2Vob2xkZXIu ZnJhZ21lbnRlZEZsb3coKS0+bV9zcGFubmVyTWFwLnJlbW92ZShzcGFubmVyKTsKIAotICAgICAg ICAgICAgICAgIGF1dG8gdGFrZW5DaGlsZCA9IHBsYWNlaG9sZGVyLnBhcmVudCgpLT50YWtlQ2hp bGQocGxhY2Vob2xkZXIpOwotICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBNZW1vcnkgbWFuYWdl bWVudC4KLSAgICAgICAgICAgICAgICBhdXRvKiBsZWFrZW5QdHIgPSB0YWtlbkNoaWxkLmxlYWtQ dHIoKTsKLSAgICAgICAgICAgICAgICBVTlVTRURfUEFSQU0obGVha2VuUHRyKTsKKyAgICAgICAg ICAgICAgICBzcGFubmVyc1RvRGVsZXRlLmFwcGVuZChwbGFjZWhvbGRlci5wYXJlbnQoKS0+dGFr ZUNoaWxkKHBsYWNlaG9sZGVyKSk7CiAKICAgICAgICAgICAgICAgICBpZiAoc3VidHJlZVJvb3Qg PT0gZGVzY2VuZGFudCkKICAgICAgICAgICAgICAgICAgICAgc3VidHJlZVJvb3QgPSBzcGFubmVy OwpAQCAtNDU0LDIwICs0NTQsMTQgQEAgdm9pZCBSZW5kZXJNdWx0aUNvbHVtbkZsb3c6OmZyYWdt ZW50ZWRGbAogdm9pZCBSZW5kZXJNdWx0aUNvbHVtbkZsb3c6OmhhbmRsZVNwYW5uZXJSZW1vdmFs KFJlbmRlck9iamVjdCYgc3Bhbm5lcikKIHsKICAgICAvLyBUaGUgcGxhY2Vob2xkZXIgbWF5IGFs cmVhZHkgaGF2ZSBiZWVuIHJlbW92ZWQsIGJ1dCBpZiBpdCBoYXNuJ3QsIGRvIHNvIG5vdy4KLSAg ICBpZiAoUmVuZGVyTXVsdGlDb2x1bW5TcGFubmVyUGxhY2Vob2xkZXIqIHBsYWNlaG9sZGVyID0g bV9zcGFubmVyTWFwLmdldCgmZG93bmNhc3Q8UmVuZGVyQm94PihzcGFubmVyKSkuZ2V0KCkpIHsK LSAgICAgICAgYXV0byB0YWtlbkNoaWxkID0gcGxhY2Vob2xkZXItPnBhcmVudCgpLT50YWtlQ2hp bGQoKnBsYWNlaG9sZGVyKTsKLSAgICAgICAgLy8gRklYTUU6IE1lbW9yeSBtYW5hZ2VtZW50Lgot ICAgICAgICBhdXRvKiBsZWFrZW5QdHIgPSB0YWtlbkNoaWxkLmxlYWtQdHIoKTsKLSAgICAgICAg VU5VU0VEX1BBUkFNKGxlYWtlblB0cik7Ci0KLSAgICAgICAgbV9zcGFubmVyTWFwLnJlbW92ZSgm ZG93bmNhc3Q8UmVuZGVyQm94PihzcGFubmVyKSk7Ci0gICAgfQorICAgIGlmIChhdXRvIHBsYWNl aG9sZGVyID0gbV9zcGFubmVyTWFwLnRha2UoJmRvd25jYXN0PFJlbmRlckJveD4oc3Bhbm5lcikp KQorICAgICAgICBwbGFjZWhvbGRlci0+cmVtb3ZlRnJvbVBhcmVudEFuZERlc3Ryb3koKTsKIAog ICAgIGlmIChSZW5kZXJPYmplY3QqIG5leHQgPSBzcGFubmVyLm5leHRTaWJsaW5nKCkpIHsKICAg ICAgICAgaWYgKFJlbmRlck9iamVjdCogcHJldmlvdXMgPSBzcGFubmVyLnByZXZpb3VzU2libGlu ZygpKSB7CiAgICAgICAgICAgICBpZiAocHJldmlvdXMtPmlzUmVuZGVyTXVsdGlDb2x1bW5TZXQo KSAmJiBuZXh0LT5pc1JlbmRlck11bHRpQ29sdW1uU2V0KCkpIHsKICAgICAgICAgICAgICAgICAv LyBNZXJnZSB0d28gc2V0cyB0aGF0IG5vIGxvbmdlciB3aWxsIGJlIHNlcGFyYXRlZCBieSBhIHNw YW5uZXIuCi0gICAgICAgICAgICAgICAgbmV4dC0+ZGVzdHJveSgpOworICAgICAgICAgICAgICAg IG5leHQtPnJlbW92ZUZyb21QYXJlbnRBbmREZXN0cm95KCk7CiAgICAgICAgICAgICAgICAgcHJl dmlvdXMtPnNldE5lZWRzTGF5b3V0KCk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0K