177729 2017-10-01 17:06:38 -0700 Use ThreadIdentifier instead of thread::this_thread::get_id 2017-10-02 10:54:12 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki sam webkit-bug-importer oldest_to_newest 1355086 0 ysuzuki 2017-10-01 17:06:38 -0700 Use ThreadIdentifier instead of thread::this_thread::get_id 1355087 1 322338 ysuzuki 2017-10-01 17:07:14 -0700 Created attachment 322338 Patch 1355089 2 322338 sam 2017-10-01 17:26:31 -0700 Comment on attachment 322338 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322338&action=review > Source/WebCore/ChangeLog:8 > + We can use WTF::ThreadIdentifier instead of thread::this_thread::get_id. Can you explain why this is preferable? I assume it is more efficient. 1355160 3 322338 ysuzuki 2017-10-02 01:16:38 -0700 Comment on attachment 322338 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322338&action=review I'll fix build failure by including <wtf/Threading.h> >> Source/WebCore/ChangeLog:8 >> + We can use WTF::ThreadIdentifier instead of thread::this_thread::get_id. > > Can you explain why this is preferable? I assume it is more efficient. There are two reasons, 1. thread::this_thread::get_id is slower in Windows 2. using ThreadIdentifier is consistent to the other code in WebKit. Other part of WebKit just uses ThreadIdentifier for the exact same purpose (debugging threadID). Only this place uses thread::this_thread::get_id. 1355161 4 322361 ysuzuki 2017-10-02 01:18:58 -0700 Created attachment 322361 Patch 1355278 5 322361 sam 2017-10-02 10:19:26 -0700 Comment on attachment 322361 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322361&action=review > Source/WebCore/ChangeLog:8 > + We can use WTF::ThreadIdentifier instead of thread::this_thread::get_id. Please put your more detailed explanation of why in the ChangeLog. 1355297 6 322361 ysuzuki 2017-10-02 10:37:58 -0700 Comment on attachment 322361 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322361&action=review >> Source/WebCore/ChangeLog:8 >> + We can use WTF::ThreadIdentifier instead of thread::this_thread::get_id. > > Please put your more detailed explanation of why in the ChangeLog. Thanks, I've just added these explanation to this ChangeLog :) 1355311 7 ysuzuki 2017-10-02 10:53:00 -0700 Committed r222719: <http://trac.webkit.org/changeset/222719> 1355313 8 webkit-bug-importer 2017-10-02 10:54:12 -0700 <rdar://problem/34770618> 322338 2017-10-01 17:07:14 -0700 2017-10-02 01:18:57 -0700 Patch bug-177729-20171002090713.patch text/plain 3323 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI3MDY1NGNmNDFhODI2 ZjFmMDc0ZmE0Y2MwNGFhYWM2MWIyYzA4MC4uMzI2ZGFmNjYyMzIzMWZmYWQwOWM2OTk2MGI4NTFk MTg1MTU1MzZlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEwLTAxICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIFVzZSBUaHJlYWRJ ZGVudGlmaWVyIGluc3RlYWQgb2YgdGhyZWFkOjp0aGlzX3RocmVhZDo6Z2V0X2lkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc3MjkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBjYW4gdXNlIFdURjo6 VGhyZWFkSWRlbnRpZmllciBpbnN0ZWFkIG9mIHRocmVhZDo6dGhpc190aHJlYWQ6OmdldF9pZC4K KworICAgICAgICAqIE1vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2VEZXRhaWxzLmg6CisgICAg ICAgIChXZWJDb3JlOjpEYXRhYmFzZURldGFpbHM6OkRhdGFiYXNlRGV0YWlscyk6CisgICAgICAg IChXZWJDb3JlOjpEYXRhYmFzZURldGFpbHM6OnRocmVhZElEIGNvbnN0KToKKyAgICAgICAgKiBN b2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpEYXRhYmFzZU1hbmFnZXI6OmRldGFpbHNGb3JOYW1lQW5kT3JpZ2luKToKKwogMjAxNy0xMC0w MSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZv ciBET00gYWJvcnRpbmcgKGh0dHBzOi8vZG9tLnNwZWMud2hhdHdnLm9yZy8jYWJvcnRpbmctb25n b2luZy1hY3Rpdml0aWVzKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJk YXRhYmFzZS9EYXRhYmFzZURldGFpbHMuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0 YWJhc2UvRGF0YWJhc2VEZXRhaWxzLmgKaW5kZXggMjM5ODAzODg0YjdmM2E4NDgyMzMyMTY0YzEx NTRiZGUwMGE3MDhjNy4uZWM5YjQ1ZDQ4YmJkNWRkMzgxNGVhZDY3NWM0NTFhZjkzOWVmNjFmNiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9EYXRhYmFzZURl dGFpbHMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNl RGV0YWlscy5oCkBAIC00MSw3ICs0MSw3IEBAIGNsYXNzIERhdGFiYXNlRGV0YWlscyB7CiAgICAg ICAgICwgbV9jcmVhdGlvblRpbWUoMCkKICAgICAgICAgLCBtX21vZGlmaWNhdGlvblRpbWUoMCkK ICNpZm5kZWYgTkRFQlVHCi0gICAgICAgICwgbV90aHJlYWRJRChzdGQ6OnRoaXNfdGhyZWFkOjpn ZXRfaWQoKSkKKyAgICAgICAgLCBtX3RocmVhZElEKFRocmVhZDo6Y3VycmVudElEKCkpCiAjZW5k aWYKICAgICB7CiAgICAgfQpAQCAtNTQsNyArNTQsNyBAQCBjbGFzcyBEYXRhYmFzZURldGFpbHMg ewogICAgICAgICAsIG1fY3JlYXRpb25UaW1lKGNyZWF0aW9uVGltZSkKICAgICAgICAgLCBtX21v ZGlmaWNhdGlvblRpbWUobW9kaWZpY2F0aW9uVGltZSkKICNpZm5kZWYgTkRFQlVHCi0gICAgICAg ICwgbV90aHJlYWRJRChzdGQ6OnRoaXNfdGhyZWFkOjpnZXRfaWQoKSkKKyAgICAgICAgLCBtX3Ro cmVhZElEKFRocmVhZDo6Y3VycmVudElEKCkpCiAjZW5kaWYKICAgICB7CiAgICAgfQpAQCAtNjYs NyArNjYsNyBAQCBjbGFzcyBEYXRhYmFzZURldGFpbHMgewogICAgIGRvdWJsZSBjcmVhdGlvblRp bWUoKSBjb25zdCB7IHJldHVybiBtX2NyZWF0aW9uVGltZTsgfQogICAgIGRvdWJsZSBtb2RpZmlj YXRpb25UaW1lKCkgY29uc3QgeyByZXR1cm4gbV9tb2RpZmljYXRpb25UaW1lOyB9CiAjaWZuZGVm IE5ERUJVRwotICAgIHN0ZDo6dGhyZWFkOjppZCB0aHJlYWRJRCgpIGNvbnN0IHsgcmV0dXJuIG1f dGhyZWFkSUQ7IH0KKyAgICBUaHJlYWRJZGVudGlmaWVyIHRocmVhZElEKCkgY29uc3QgeyByZXR1 cm4gbV90aHJlYWRJRDsgfQogI2VuZGlmCiAKIHByaXZhdGU6CkBAIC03Nyw3ICs3Nyw3IEBAIGNs YXNzIERhdGFiYXNlRGV0YWlscyB7CiAgICAgZG91YmxlIG1fY3JlYXRpb25UaW1lOwogICAgIGRv dWJsZSBtX21vZGlmaWNhdGlvblRpbWU7CiAjaWZuZGVmIE5ERUJVRwotICAgIHN0ZDo6dGhyZWFk OjppZCBtX3RocmVhZElEOworICAgIFRocmVhZElkZW50aWZpZXIgbV90aHJlYWRJRDsKICNlbmRp ZgogfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9E YXRhYmFzZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9E YXRhYmFzZU1hbmFnZXIuY3BwCmluZGV4IGExODEwNGM0Y2ZlYzRhZTM1ODViNzRhZDUwMjcwOTFj ODQyOWQ4ZmUuLjQ4ZTBjNDc2NzhjOGYyNjU1NDhkOTc1MTFhNTk5MDcxOTZhYTk5MjcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2VNYW5hZ2Vy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlTWFu YWdlci5jcHAKQEAgLTI1Nyw3ICsyNTcsNyBAQCBEYXRhYmFzZURldGFpbHMgRGF0YWJhc2VNYW5h Z2VyOjpkZXRhaWxzRm9yTmFtZUFuZE9yaWdpbihjb25zdCBTdHJpbmcmIG5hbWUsIFNlYwogICAg ICAgICBzdGQ6OmxvY2tfZ3VhcmQ8TG9jaz4gbG9jayB7IG1fcHJvcG9zZWREYXRhYmFzZXNNdXRl eCB9OwogICAgICAgICBmb3IgKGF1dG8qIHByb3Bvc2VkRGF0YWJhc2UgOiBtX3Byb3Bvc2VkRGF0 YWJhc2VzKSB7CiAgICAgICAgICAgICBpZiAocHJvcG9zZWREYXRhYmFzZS0+ZGV0YWlscygpLm5h bWUoKSA9PSBuYW1lICYmIHByb3Bvc2VkRGF0YWJhc2UtPm9yaWdpbigpLmVxdWFsKCZvcmlnaW4p KSB7Ci0gICAgICAgICAgICAgICAgQVNTRVJUKHByb3Bvc2VkRGF0YWJhc2UtPmRldGFpbHMoKS50 aHJlYWRJRCgpID09IHN0ZDo6dGhpc190aHJlYWQ6OmdldF9pZCgpIHx8IGlzTWFpblRocmVhZCgp KTsKKyAgICAgICAgICAgICAgICBBU1NFUlQocHJvcG9zZWREYXRhYmFzZS0+ZGV0YWlscygpLnRo cmVhZElEKCkgPT0gVGhyZWFkOjpjdXJyZW50SUQoKSB8fCBpc01haW5UaHJlYWQoKSk7CiAgICAg ICAgICAgICAgICAgcmV0dXJuIHByb3Bvc2VkRGF0YWJhc2UtPmRldGFpbHMoKTsKICAgICAgICAg ICAgIH0KICAgICAgICAgfQo= 322361 2017-10-02 01:18:58 -0700 2017-10-02 10:19:26 -0700 Patch bug-177729-20171002171857.patch text/plain 3462 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI3MDY1NGNmNDFhODI2 ZjFmMDc0ZmE0Y2MwNGFhYWM2MWIyYzA4MC4uMzhjYjVkYTNiM2ExZjExOTMzOWMzYmFlNGY5MDY1 MDU3MTVhNmI1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEwLTAyICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIFVzZSBUaHJlYWRJ ZGVudGlmaWVyIGluc3RlYWQgb2YgdGhyZWFkOjp0aGlzX3RocmVhZDo6Z2V0X2lkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc3MjkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBjYW4gdXNlIFdURjo6 VGhyZWFkSWRlbnRpZmllciBpbnN0ZWFkIG9mIHRocmVhZDo6dGhpc190aHJlYWQ6OmdldF9pZC4K KworICAgICAgICAqIE1vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2VEZXRhaWxzLmg6CisgICAg ICAgIChXZWJDb3JlOjpEYXRhYmFzZURldGFpbHM6OkRhdGFiYXNlRGV0YWlscyk6CisgICAgICAg IChXZWJDb3JlOjpEYXRhYmFzZURldGFpbHM6OnRocmVhZElEIGNvbnN0KToKKyAgICAgICAgKiBN b2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpEYXRhYmFzZU1hbmFnZXI6OmRldGFpbHNGb3JOYW1lQW5kT3JpZ2luKToKKwogMjAxNy0xMC0w MSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZv ciBET00gYWJvcnRpbmcgKGh0dHBzOi8vZG9tLnNwZWMud2hhdHdnLm9yZy8jYWJvcnRpbmctb25n b2luZy1hY3Rpdml0aWVzKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJk YXRhYmFzZS9EYXRhYmFzZURldGFpbHMuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0 YWJhc2UvRGF0YWJhc2VEZXRhaWxzLmgKaW5kZXggMjM5ODAzODg0YjdmM2E4NDgyMzMyMTY0YzEx NTRiZGUwMGE3MDhjNy4uYTRlOTlhZDBiZGZmOTA2YjA2YjNkN2ZiOGM0N2QzMWNjOTRhODQyNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9EYXRhYmFzZURl dGFpbHMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNl RGV0YWlscy5oCkBAIC0yOCw3ICsyOCw3IEBACiAKICNwcmFnbWEgb25jZQogCi0jaW5jbHVkZSA8 dGhyZWFkPgorI2luY2x1ZGUgPHd0Zi9UaHJlYWRpbmcuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9X VEZTdHJpbmcuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNDEsNyArNDEsNyBAQCBjbGFz cyBEYXRhYmFzZURldGFpbHMgewogICAgICAgICAsIG1fY3JlYXRpb25UaW1lKDApCiAgICAgICAg ICwgbV9tb2RpZmljYXRpb25UaW1lKDApCiAjaWZuZGVmIE5ERUJVRwotICAgICAgICAsIG1fdGhy ZWFkSUQoc3RkOjp0aGlzX3RocmVhZDo6Z2V0X2lkKCkpCisgICAgICAgICwgbV90aHJlYWRJRChU aHJlYWQ6OmN1cnJlbnRJRCgpKQogI2VuZGlmCiAgICAgewogICAgIH0KQEAgLTU0LDcgKzU0LDcg QEAgY2xhc3MgRGF0YWJhc2VEZXRhaWxzIHsKICAgICAgICAgLCBtX2NyZWF0aW9uVGltZShjcmVh dGlvblRpbWUpCiAgICAgICAgICwgbV9tb2RpZmljYXRpb25UaW1lKG1vZGlmaWNhdGlvblRpbWUp CiAjaWZuZGVmIE5ERUJVRwotICAgICAgICAsIG1fdGhyZWFkSUQoc3RkOjp0aGlzX3RocmVhZDo6 Z2V0X2lkKCkpCisgICAgICAgICwgbV90aHJlYWRJRChUaHJlYWQ6OmN1cnJlbnRJRCgpKQogI2Vu ZGlmCiAgICAgewogICAgIH0KQEAgLTY2LDcgKzY2LDcgQEAgY2xhc3MgRGF0YWJhc2VEZXRhaWxz IHsKICAgICBkb3VibGUgY3JlYXRpb25UaW1lKCkgY29uc3QgeyByZXR1cm4gbV9jcmVhdGlvblRp bWU7IH0KICAgICBkb3VibGUgbW9kaWZpY2F0aW9uVGltZSgpIGNvbnN0IHsgcmV0dXJuIG1fbW9k aWZpY2F0aW9uVGltZTsgfQogI2lmbmRlZiBOREVCVUcKLSAgICBzdGQ6OnRocmVhZDo6aWQgdGhy ZWFkSUQoKSBjb25zdCB7IHJldHVybiBtX3RocmVhZElEOyB9CisgICAgVGhyZWFkSWRlbnRpZmll ciB0aHJlYWRJRCgpIGNvbnN0IHsgcmV0dXJuIG1fdGhyZWFkSUQ7IH0KICNlbmRpZgogCiBwcml2 YXRlOgpAQCAtNzcsNyArNzcsNyBAQCBjbGFzcyBEYXRhYmFzZURldGFpbHMgewogICAgIGRvdWJs ZSBtX2NyZWF0aW9uVGltZTsKICAgICBkb3VibGUgbV9tb2RpZmljYXRpb25UaW1lOwogI2lmbmRl ZiBOREVCVUcKLSAgICBzdGQ6OnRocmVhZDo6aWQgbV90aHJlYWRJRDsKKyAgICBUaHJlYWRJZGVu dGlmaWVyIG1fdGhyZWFkSUQ7CiAjZW5kaWYKIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2VNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2VNYW5hZ2VyLmNwcAppbmRleCBhMTgxMDRj NGNmZWM0YWUzNTg1Yjc0YWQ1MDI3MDkxYzg0MjlkOGZlLi40OGUwYzQ3Njc4YzhmMjY1NTQ4ZDk3 NTExYTU5OTA3MTk2YWE5OTI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dl YmRhdGFiYXNlL0RhdGFiYXNlTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy93ZWJkYXRhYmFzZS9EYXRhYmFzZU1hbmFnZXIuY3BwCkBAIC0yNTcsNyArMjU3LDcgQEAgRGF0 YWJhc2VEZXRhaWxzIERhdGFiYXNlTWFuYWdlcjo6ZGV0YWlsc0Zvck5hbWVBbmRPcmlnaW4oY29u c3QgU3RyaW5nJiBuYW1lLCBTZWMKICAgICAgICAgc3RkOjpsb2NrX2d1YXJkPExvY2s+IGxvY2sg eyBtX3Byb3Bvc2VkRGF0YWJhc2VzTXV0ZXggfTsKICAgICAgICAgZm9yIChhdXRvKiBwcm9wb3Nl ZERhdGFiYXNlIDogbV9wcm9wb3NlZERhdGFiYXNlcykgewogICAgICAgICAgICAgaWYgKHByb3Bv c2VkRGF0YWJhc2UtPmRldGFpbHMoKS5uYW1lKCkgPT0gbmFtZSAmJiBwcm9wb3NlZERhdGFiYXNl LT5vcmlnaW4oKS5lcXVhbCgmb3JpZ2luKSkgewotICAgICAgICAgICAgICAgIEFTU0VSVChwcm9w b3NlZERhdGFiYXNlLT5kZXRhaWxzKCkudGhyZWFkSUQoKSA9PSBzdGQ6OnRoaXNfdGhyZWFkOjpn ZXRfaWQoKSB8fCBpc01haW5UaHJlYWQoKSk7CisgICAgICAgICAgICAgICAgQVNTRVJUKHByb3Bv c2VkRGF0YWJhc2UtPmRldGFpbHMoKS50aHJlYWRJRCgpID09IFRocmVhZDo6Y3VycmVudElEKCkg fHwgaXNNYWluVGhyZWFkKCkpOwogICAgICAgICAgICAgICAgIHJldHVybiBwcm9wb3NlZERhdGFi YXNlLT5kZXRhaWxzKCk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0K