177727 2017-10-01 15:38:49 -0700 [Settings] Enums should not be passed by const reference 2017-10-18 12:44:57 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 177835 1 sam sam commit-queue darin webkit-bug-importer oldest_to_newest 1355077 0 sam 2017-10-01 15:38:49 -0700 [Settings] Enums should not be passed by const reference 1355078 1 322336 sam 2017-10-01 15:54:33 -0700 Created attachment 322336 Patch 1355118 2 322336 commit-queue 2017-10-01 20:17:22 -0700 Comment on attachment 322336 Patch Clearing flags on attachment: 322336 Committed r222695: <http://trac.webkit.org/changeset/222695> 1355119 3 commit-queue 2017-10-01 20:17:23 -0700 All reviewed patches have been landed. Closing bug. 1355120 4 webkit-bug-importer 2017-10-01 20:18:42 -0700 <rdar://problem/34762536> 1356014 5 commit-queue 2017-10-03 13:46:14 -0700 Re-opened since this is blocked by bug 177835 1361846 6 sam 2017-10-18 12:44:57 -0700 Re-fixed this in a different bug. 322336 2017-10-01 15:54:33 -0700 2017-10-01 20:17:22 -0700 Patch bug-177727-20171001155432.patch text/plain 6609 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMjY5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE3LTEwLTAxICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1NldHRpbmdzXSBFbnVtcyBzaG91bGQg bm90IGJlIHBhc3NlZCBieSBjb25zdCByZWZlcmVuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzcyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9HZW5lcmF0ZVNldHRpbmdzL0dlbmVy YXRlU2V0dGluZ3NJbXBsZW1lbnRhdGlvbkZpbGUucHk6CisgICAgICAgICogU2NyaXB0cy9HZW5l cmF0ZVNldHRpbmdzL0dlbmVyYXRlU2V0dGluZ3NIZWFkZXJGaWxlLnB5OgorICAgICAgICAocHJp bnRHZXR0ZXJBbmRTZXR0ZXIpOgorICAgICAgICAKKyAgICAgICAgICAgIFVzZSB0aGUgbmV3IHR5 cGVJc0FnZ3JlZ2F0ZSBwcmVkaWNhdGUgdG8gZGV0ZXJtaW5lIHdoZXRoZXIgdG8KKyAgICAgICAg ICAgIHVzZSBjb25zdCByZWZlcmVuY2Ugb3Igbm90LgorICAgICAgICAKKyAgICAgICAgKGluY2x1 ZGVGb3JTZXR0aW5nKTogRGVsZXRlZC4KKworICAgICAgICAgICAgTW92ZSBpbmNsdWRlRm9yU2V0 dGluZyB0byBTZXR0aW5ncy5weSB3aXRoIHRoZSByZXN0IG9mIHRoZSBTZXR0aW5nCisgICAgICAg ICAgICBoZWxwZXJzLgorCisgICAgICAgICogU2NyaXB0cy9HZW5lcmF0ZVNldHRpbmdzL1NldHRp bmdzLnB5OgorICAgICAgICAobWFwVG9JRExUeXBlKToKKyAgICAgICAgKHR5cGVJc1ByaW1pdGl2 ZSk6CisgICAgICAgICh0eXBlSXNBZ2dyZWdhdGUpOgorICAgICAgICAKKyAgICAgICAgICAgIEFk ZCBwcmVkaWNhdGUgdG8gZGV0ZXJtaW5lIGlmIGEgc2V0dGluZydzIHR5cGUgaXMgYW4gYWdncmVn YXRlIChzdHJ1Y3Qgb3IgY2xhc3MpCisgICAgICAgICAgICBvciBhIHByaW1pdGl2ZS4gUmVtb3Zl IHJlZmVyZW5jZXMgdG8gc2l6ZV90LCB3aGljaCBpcyBub3QgdXNlZC4KKwogMjAxNy0xMC0wMSAg U2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBE T00gYWJvcnRpbmcgKGh0dHBzOi8vZG9tLnNwZWMud2hhdHdnLm9yZy8jYWJvcnRpbmctb25nb2lu Zy1hY3Rpdml0aWVzKQpJbmRleDogU291cmNlL1dlYkNvcmUvU2NyaXB0cy9HZW5lcmF0ZVNldHRp bmdzL0dlbmVyYXRlU2V0dGluZ3NIZWFkZXJGaWxlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL1NjcmlwdHMvR2VuZXJhdGVTZXR0aW5ncy9HZW5lcmF0ZVNldHRpbmdzSGVhZGVyRmls ZS5weQkocmV2aXNpb24gMjIyNjkxKQorKysgU291cmNlL1dlYkNvcmUvU2NyaXB0cy9HZW5lcmF0 ZVNldHRpbmdzL0dlbmVyYXRlU2V0dGluZ3NIZWFkZXJGaWxlLnB5CSh3b3JraW5nIGNvcHkpCkBA IC0yNSw3ICsyNSw3IEBACiAKIGltcG9ydCBvcy5wYXRoCiAKLWZyb20gU2V0dGluZ3MgaW1wb3J0 IGxpY2Vuc2UsIG1ha2VDb25kaXRpb25hbFN0cmluZywgbWFrZVNldHRlckZ1bmN0aW9uTmFtZQor ZnJvbSBTZXR0aW5ncyBpbXBvcnQgbGljZW5zZSwgbWFrZUNvbmRpdGlvbmFsU3RyaW5nLCBtYWtl U2V0dGVyRnVuY3Rpb25OYW1lLCBpbmNsdWRlRm9yU2V0dGluZywgdHlwZUlzQWdncmVnYXRlCiAK IAogZGVmIGdlbmVyYXRlU2V0dGluZ3NIZWFkZXJGaWxlKG91dHB1dERpcmVjdG9yeSwgc2V0dGlu Z3MpOgpAQCAtNzcsMzIgKzc3LDYgQEAgZGVmIGdlbmVyYXRlU2V0dGluZ3NIZWFkZXJGaWxlKG91 dHB1dERpcgogICAgIG91dHB1dEZpbGUuY2xvc2UoKQogCiAKLWRlZiBpbmNsdWRlRm9yU2V0dGlu ZyhzZXR0aW5nKToKLSAgICAjIEFsd2F5cyBwcmVmZXIgYW4gZXhwbGljaXQgaW5jbHVkZS4KLSAg ICBpZiBzZXR0aW5nLmluY2x1ZGU6Ci0gICAgICAgIHJldHVybiBzZXR0aW5nLmluY2x1ZGUKLQot ICAgICMgSW5jbHVkZSBub3RoaW5nIGZvciBwcmltaXRpdmUgdHlwZXMuCi0gICAgaWYgc2V0dGlu Zy50eXBlID09ICdpbnQnOgotICAgICAgICByZXR1cm4gTm9uZQotICAgIGlmIHNldHRpbmcudHlw ZSA9PSAndW5zaWduZWQnOgotICAgICAgICByZXR1cm4gTm9uZQotICAgIGlmIHNldHRpbmcudHlw ZSA9PSAnZG91YmxlJzoKLSAgICAgICAgcmV0dXJuIE5vbmUKLSAgICBpZiBzZXR0aW5nLnR5cGUg PT0gJ2Zsb2F0JzoKLSAgICAgICAgcmV0dXJuIE5vbmUKLSAgICBpZiBzZXR0aW5nLnR5cGUgPT0g J2Jvb2wnOgotICAgICAgICByZXR1cm4gTm9uZQotCi0gICAgIyBTcGVjaWFsIGNhc2UgU3RyaW5n LCBhcyBpdCBkb2Vzbid0IGZvbGxvdyB0aGUgcGF0dGVybiBvZiBiZWluZyBpbiBhIGZpbGUgd2l0 aCB0aGUKLSAgICAjIHNhbWUgbmFtZSBhcyB0aGUgY2xhc3MuCi0gICAgaWYgc2V0dGluZy50eXBl ID09ICdTdHJpbmcnOgotICAgICAgICByZXR1cm4gIjx3dGYvdGV4dC9XVEZTdHJpbmcuaD4iCi0K LSAgICAjIERlZmF1bHQgdG8gdXNpbmcgdGhlIHR5cGUgbmFtZSBmb3IgdGhlIGluY2x1ZGUuCi0g ICAgcmV0dXJuICJcIiIgKyBzZXR0aW5nLnR5cGUgKyAiLmhcIiIKLQotCiBkZWYgcHJpbnRJbmNs dWRlcyhvdXRwdXRGaWxlLCBzb3J0ZWRVbmNvbmRpdGlvbmFsU2V0dGluZ3NOYW1lcywgc29ydGVk Q29uZGl0aW9uYWxzLCBzZXR0aW5nc0J5Q29uZGl0aW9uYWwsIHNldHRpbmdzKToKICAgICB1bmNv bmRpdGlvbmFsSW5jbHVkZXMgPSBzZXQoKQogICAgIGluY2x1ZGVzQnlDb25kaXRpb25hbCA9IHt9 CkBAIC0xNDIsNyArMTE2LDcgQEAgZGVmIHByaW50R2V0dGVyQW5kU2V0dGVyKG91dHB1dEZpbGUs IHNldAogICAgICMgRXhwb3J0IGlzIG9ubHkgbmVlZGVkIGlmIHRoZSBkZWZpbml0aW9uIGlzIG5v dCBpbiB0aGUgaGVhZGVyLgogICAgIHdlYmNvcmVFeHBvcnQgPSAiV0VCQ09SRV9FWFBPUlQgIiBp ZiBzZXR0aW5nLnNldE5lZWRzU3R5bGVSZWNhbGNJbkFsbEZyYW1lcyBlbHNlICIiCiAKLSAgICBp ZiBzZXR0aW5nLnR5cGVbMF0uaXNsb3dlcigpOgorICAgIGlmIG5vdCB0eXBlSXNBZ2dyZWdhdGUo c2V0dGluZyk6CiAgICAgICAgIG91dHB1dEZpbGUud3JpdGUoIiAgICAiICsgc2V0dGluZy50eXBl ICsgIiAiICsgc2V0dGluZy5uYW1lICsgIigpIGNvbnN0IHsgcmV0dXJuIG1fIiArIHNldHRpbmcu bmFtZSArICI7IH0gXG4iKQogICAgICAgICBvdXRwdXRGaWxlLndyaXRlKCIgICAgIiArIHdlYmNv cmVFeHBvcnQgKyAidm9pZCAiICsgc2V0dGVyRnVuY3Rpb25OYW1lICsgIigiICsgc2V0dGluZy50 eXBlICsgIiAiICsgc2V0dGluZy5uYW1lICsgIikiKQogICAgIGVsc2U6CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9TY3JpcHRzL0dlbmVyYXRlU2V0dGluZ3MvR2VuZXJhdGVTZXR0aW5nc0ltcGxlbWVu dGF0aW9uRmlsZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9TY3JpcHRzL0dlbmVy YXRlU2V0dGluZ3MvR2VuZXJhdGVTZXR0aW5nc0ltcGxlbWVudGF0aW9uRmlsZS5weQkocmV2aXNp b24gMjIyNjkxKQorKysgU291cmNlL1dlYkNvcmUvU2NyaXB0cy9HZW5lcmF0ZVNldHRpbmdzL0dl bmVyYXRlU2V0dGluZ3NJbXBsZW1lbnRhdGlvbkZpbGUucHkJKHdvcmtpbmcgY29weSkKQEAgLTI1 LDcgKzI1LDcgQEAKIAogaW1wb3J0IG9zLnBhdGgKIAotZnJvbSBTZXR0aW5ncyBpbXBvcnQgbGlj ZW5zZSwgbWFrZUNvbmRpdGlvbmFsU3RyaW5nLCBtYWtlU2V0dGVyRnVuY3Rpb25OYW1lCitmcm9t IFNldHRpbmdzIGltcG9ydCBsaWNlbnNlLCBtYWtlQ29uZGl0aW9uYWxTdHJpbmcsIG1ha2VTZXR0 ZXJGdW5jdGlvbk5hbWUsIHR5cGVJc0FnZ3JlZ2F0ZQogCiAKIGRlZiBnZW5lcmF0ZVNldHRpbmdz SW1wbGVtZW50YXRpb25GaWxlKG91dHB1dERpcmVjdG9yeSwgc2V0dGluZ3MpOgpAQCAtMTU1LDcg KzE1NSw3IEBAIGRlZiBwcmludFNldHRlckJvZHkob3V0cHV0RmlsZSwgc2V0dGluZykKIAogICAg IHNldHRlckZ1bmN0aW9uTmFtZSA9IG1ha2VTZXR0ZXJGdW5jdGlvbk5hbWUoc2V0dGluZykKIAot ICAgIGlmIHNldHRpbmcudHlwZVswXS5pc2xvd2VyKCk6CisgICAgaWYgbm90IHR5cGVJc0FnZ3Jl Z2F0ZShzZXR0aW5nKToKICAgICAgICAgb3V0cHV0RmlsZS53cml0ZSgidm9pZCBTZXR0aW5nc0dl bmVyYXRlZDo6IiArIHNldHRlckZ1bmN0aW9uTmFtZSArICIoIiArIHNldHRpbmcudHlwZSArICIg IiArIHNldHRpbmcubmFtZSArICIpXG4iKQogICAgIGVsc2U6CiAgICAgICAgIG91dHB1dEZpbGUu d3JpdGUoInZvaWQgU2V0dGluZ3NHZW5lcmF0ZWQ6OiIgKyBzZXR0ZXJGdW5jdGlvbk5hbWUgKyAi KGNvbnN0ICIgKyBzZXR0aW5nLnR5cGUgKyAiJiAiICsgc2V0dGluZy5uYW1lICsgIilcbiIpCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9TY3JpcHRzL0dlbmVyYXRlU2V0dGluZ3MvU2V0dGluZ3MucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvU2NyaXB0cy9HZW5lcmF0ZVNldHRpbmdzL1Nl dHRpbmdzLnB5CShyZXZpc2lvbiAyMjI2OTEpCisrKyBTb3VyY2UvV2ViQ29yZS9TY3JpcHRzL0dl bmVyYXRlU2V0dGluZ3MvU2V0dGluZ3MucHkJKHdvcmtpbmcgY29weSkKQEAgLTEwNCw3ICsxMDQs NyBAQCBkZWYgbWFwVG9JRExUeXBlKHNldHRpbmcpOgogICAgICMgRklYTUU6IEFkZCBzdXBwb3J0 IGZvciBtb3JlIHR5cGVzIGluY2x1ZGluZyBlbnVtZXJhdGUgdHlwZXMuCiAgICAgaWYgc2V0dGlu Zy50eXBlID09ICdpbnQnOgogICAgICAgICByZXR1cm4gJ2xvbmcnCi0gICAgaWYgc2V0dGluZy50 eXBlID09ICd1bnNpZ25lZCcgb3Igc2V0dGluZy50eXBlID09ICdzaXplX3QnOgorICAgIGlmIHNl dHRpbmcudHlwZSA9PSAndW5zaWduZWQnOgogICAgICAgICByZXR1cm4gJ3Vuc2lnbmVkIGxvbmcn CiAgICAgaWYgc2V0dGluZy50eXBlID09ICdkb3VibGUnOgogICAgICAgICByZXR1cm4gJ2RvdWJs ZScKQEAgLTExNyw2ICsxMTcsNTAgQEAgZGVmIG1hcFRvSURMVHlwZShzZXR0aW5nKToKICAgICBy ZXR1cm4gTm9uZQogCiAKK2RlZiB0eXBlSXNQcmltaXRpdmUoc2V0dGluZyk6CisgICAgaWYgc2V0 dGluZy50eXBlID09ICdpbnQnOgorICAgICAgICByZXR1cm4gVHJ1ZQorICAgIGlmIHNldHRpbmcu dHlwZSA9PSAndW5zaWduZWQnOgorICAgICAgICByZXR1cm4gVHJ1ZQorICAgIGlmIHNldHRpbmcu dHlwZSA9PSAnZG91YmxlJzoKKyAgICAgICAgcmV0dXJuIFRydWUKKyAgICBpZiBzZXR0aW5nLnR5 cGUgPT0gJ2Zsb2F0JzoKKyAgICAgICAgcmV0dXJuIFRydWUKKyAgICBpZiBzZXR0aW5nLnR5cGUg PT0gJ2Jvb2wnOgorICAgICAgICByZXR1cm4gVHJ1ZQorICAgIHJldHVybiBGYWxzZQorCisKK2Rl ZiB0eXBlSXNBZ2dyZWdhdGUoc2V0dGluZyk6CisgICAgIyBTcGVjaWFsIGNhc2Ugc3VwcG9ydGVk IGFnZ3JlZ2F0ZXMgKGUuZy4gY2xhc3Nlcy9zdHJ1Y3RzKQorICAgIGlmIHNldHRpbmcudHlwZSA9 PSAnU3RyaW5nJzoKKyAgICAgICAgcmV0dXJuIFRydWUKKyAgICBpZiBzZXR0aW5nLnR5cGUgPT0g J0ludFNpemUnOgorICAgICAgICByZXR1cm4gVHJ1ZQorCisgICAgIyBFdmVyeXRoaW5nIGVsc2Ug aXMgYW4gZW51bQorICAgICMgRklYTUU6IFNob3VsZCB3ZSBtYWtlIGl0IGEgcmVxdWlyZW1lbnQg dG8gYW5ub3RhdGUgZW51bXMgb3IgY2xhc3Nlcy9zdHJ1Y3RzIGluIHNvbWV3YXk/CisgICAgcmV0 dXJuIEZhbHNlCisKKworZGVmIGluY2x1ZGVGb3JTZXR0aW5nKHNldHRpbmcpOgorICAgICMgQWx3 YXlzIHByZWZlciBhbiBleHBsaWNpdCBpbmNsdWRlLgorICAgIGlmIHNldHRpbmcuaW5jbHVkZToK KyAgICAgICAgcmV0dXJuIHNldHRpbmcuaW5jbHVkZQorCisgICAgIyBJbmNsdWRlIG5vdGhpbmcg Zm9yIHByaW1pdGl2ZSB0eXBlcy4KKyAgICBpZiB0eXBlSXNQcmltaXRpdmUoc2V0dGluZyk6Cisg ICAgICAgIHJldHVybiBOb25lCisKKyAgICAjIFNwZWNpYWwgY2FzZSBTdHJpbmcsIGFzIGl0IGRv ZXNuJ3QgZm9sbG93IHRoZSBwYXR0ZXJuIG9mIGJlaW5nIGluIGEgZmlsZSB3aXRoIHRoZQorICAg ICMgc2FtZSBuYW1lIGFzIHRoZSBjbGFzcy4KKyAgICBpZiBzZXR0aW5nLnR5cGUgPT0gJ1N0cmlu Zyc6CisgICAgICAgIHJldHVybiAiPHd0Zi90ZXh0L1dURlN0cmluZy5oPiIKKworICAgICMgRGVm YXVsdCB0byB1c2luZyB0aGUgdHlwZSBuYW1lIGZvciB0aGUgaW5jbHVkZS4KKyAgICByZXR1cm4g IlwiIiArIHNldHRpbmcudHlwZSArICIuaFwiIgorCisKIGRlZiBwYXJzZUlucHV0KGlucHV0KToK ICAgICBzZXR0aW5ncyA9IHt9CiAgICAgZm9yIGxpbmUgaW4gb3BlbihpbnB1dCwgInIiKToK