<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>177698</bug_id>
          
          <creation_ts>2017-09-29 19:13:03 -0700</creation_ts>
          <short_desc>[iOS WK2] API test EditorStateTests.ContentViewHasTextInContentEditableElement is a flaky failure</short_desc>
          <delta_ts>2017-10-03 20:14:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Wenson Hsieh">wenson_hsieh</reporter>
          <assigned_to name="Wenson Hsieh">wenson_hsieh</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>jlewis3</cc>
    
    <cc>joepeck</cc>
    
    <cc>rniwa</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1354821</commentid>
    <comment_count>0</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-09-29 19:13:03 -0700</bug_when>
    <thetext>This test occasionally fails on the bots:

&quot;Expected -[WKContentView hasText] to be NO, but observed: YES (after inserting an image element)&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1354827</commentid>
    <comment_count>1</comment_count>
      <attachid>322268</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-09-29 19:47:06 -0700</bug_when>
    <thetext>Created attachment 322268
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1354864</commentid>
    <comment_count>2</comment_count>
      <attachid>322282</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-09-29 22:35:59 -0700</bug_when>
    <thetext>Created attachment 322282
Fix some awkward ChangeLog wording</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1354915</commentid>
    <comment_count>3</comment_count>
      <attachid>322282</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2017-09-30 13:23:44 -0700</bug_when>
    <thetext>Comment on attachment 322282
Fix some awkward ChangeLog wording

View in context: https://bugs.webkit.org/attachment.cgi?id=322282&amp;action=review

&gt; Source/WebCore/editing/VisibleUnits.cpp:1895
&gt; -    Vector&lt;UChar32&gt; characters(maxCharacters);
&gt; +    Vector&lt;UChar32&gt; characters(maxCharacters, 0);

Can we just make this an array of length 3 as in?
UChar32 maxCharacters[maxCharacters] = {0};
or at least give it an inline capacity so that it won&apos;t do a heap allocation?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1354917</commentid>
    <comment_count>4</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-09-30 13:36:42 -0700</bug_when>
    <thetext>(In reply to Ryosuke Niwa from comment #3)
&gt; Comment on attachment 322282 [details]
&gt; Fix some awkward ChangeLog wording
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=322282&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/editing/VisibleUnits.cpp:1895
&gt; &gt; -    Vector&lt;UChar32&gt; characters(maxCharacters);
&gt; &gt; +    Vector&lt;UChar32&gt; characters(maxCharacters, 0);
&gt; 
&gt; Can we just make this an array of length 3 as in?
&gt; UChar32 maxCharacters[maxCharacters] = {0};
&gt; or at least give it an inline capacity so that it won&apos;t do a heap allocation?

Sounds good! Changed `characters` into a 0-initialized UChar32 array.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1354918</commentid>
    <comment_count>5</comment_count>
      <attachid>322299</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-09-30 13:46:20 -0700</bug_when>
    <thetext>Created attachment 322299
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1354920</commentid>
    <comment_count>6</comment_count>
      <attachid>322299</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-09-30 14:25:54 -0700</bug_when>
    <thetext>Comment on attachment 322299
Patch for landing

Clearing flags on attachment: 322299

Committed r222683: &lt;http://trac.webkit.org/changeset/222683&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1355623</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-10-02 17:04:44 -0700</bug_when>
    <thetext>&lt;rdar://problem/34780869&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1356227</commentid>
    <comment_count>8</comment_count>
      <attachid>322299</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2017-10-03 20:14:32 -0700</bug_when>
    <thetext>Comment on attachment 322299
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=322299&amp;action=review

&gt; Source/WebCore/ChangeLog:23
&gt; +        members in the PostLayoutData struct). We also turn `characters` into a UChar32 array on the stack, to avoid the
&gt; +        heap allocations using a Vector&lt;UChar32&gt;.

I think that adding inline capacity to the vector would be a better fix for the latter part.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>322268</attachid>
            <date>2017-09-29 19:47:06 -0700</date>
            <delta_ts>2017-09-29 22:35:58 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-177698-20170929194705.patch</filename>
            <type>text/plain</type>
            <size>2989</size>
            <attacher name="Wenson Hsieh">wenson_hsieh</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzdkMDAzOWI1Y2I4Nzk0
NTdhMDM5ZDY0NTg5Y2JkN2NiMzc4ZDExYi4uZWRiODNkYWY2ZWViYjE4MWY0MWY4NDVjMTI2NzZi
MjQwZjBlYmY1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDE3LTA5LTI5ICBXZW5z
b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0syXSBB
UEkgdGVzdCBFZGl0b3JTdGF0ZVRlc3RzLkNvbnRlbnRWaWV3SGFzVGV4dEluQ29udGVudEVkaXRh
YmxlRWxlbWVudCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzY5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBXZWJLaXQyIEFQSSB0ZXN0IEVkaXRvclN0YXRlVGVz
dHMuQ29udGVudFZpZXdIYXNUZXh0SW5Db250ZW50RWRpdGFibGVFbGVtZW50IGlzIGN1cnJlbnRs
eSBoaXR0aW5nCisgICAgICAgIGludGVybWl0dGVudCBmYWlsdXJlcyBvbiB0ZXN0IHJ1bm5lcnMu
IEFmdGVyIGluc2VydGluZyBqdXN0IGFuIGltYWdlIGluIHRoZSBlZGl0YWJsZSBlbGVtZW50LCB3
ZSB3b3VsZCBleHBlY3QKKyAgICAgICAgdGhhdCAtaGFzVGV4dCBzaG91bGQgcmV0dXJuIE5PIGJl
Y2F1c2UgdGhlIHRleHQgY29udGVudCBpcyBhbiBlbXB0eSBzdHJpbmcsIGJ1dCB3ZSBmaW5kIHRo
YXQgLWhhc1RleHQgaXMgWUVTLgorICAgICAgICBVcG9uIGNsb3NlciBpbnNwZWN0aW9uLCB0aGlz
IGlzIGJlY2F1c2Ugd2UncmUgYmFpbGluZyBvbiBhbiBlYXJseSByZXR1cm4gaW4KKyAgICAgICAg
Y29tcHV0ZUVkaXRhYmxlUm9vdEhhc0NvbnRlbnRBbmRQbGFpblRleHQgYmVjYXVzZSB0aGUgRWRp
dG9yU3RhdGUncyBQb3N0TGF5b3V0RGF0YSBjb250YWlucyBub24temVybyBjaGFyYWN0ZXJzCisg
ICAgICAgIG5lYXIgdGhlIHNlbGVjdGlvbiwgd2hpY2ggaXMgaW5jb3JyZWN0LgorCisgICAgICAg
IEhvd2V2ZXIsIHVwb24gY2xvc2VyIGluc3BlY3Rpb24sIHRoaXMgaXMgZHVlIHRvIGEgbGF0ZW50
IGJ1ZyBpbiB0aGUgY2hhcmFjdGVyc0Fyb3VuZFBvc2l0aW9uIGhlbHBlciBmdW5jdGlvbi4KKyAg
ICAgICAgVGhpcyBmdW5jdGlvbiBhdHRlbXB0cyB0byBjb21wdXRlIGNoYXJhY3RlcnMgYmVmb3Jl
IGFuZCBhZnRlciB0aGUgY3VycmVudCBzZWxlY3Rpb24gYnkgaW5pdGlhbGl6aW5nIGEgVmVjdG9y
CisgICAgICAgIG9mIHNpemUgMyB3aXRoIHRoZSByZWxldmFudCBjaGFyYWN0ZXIgZGF0YSwgYW5k
IHRoZW4gc2V0cyBvbmVBZnRlciwgb25lQmVmb3JlIGFuZCB0d29CZWZvcmUgdG8gdGhlIFVDaGFy
MzIKKyAgICAgICAgdmFsdWVzIGluIHRoZSB2ZWN0b3IuIEhvd2V2ZXIsIGluIHRoZSBjYXNlIHdo
ZXJlIHRoZXJlIGFyZSBsZXNzIHRoYW4gdGhyZWUgY2hhcmFjdGVycywgd2UgZW5kIHVwIGFzc2ln
bmluZworICAgICAgICB0aGUgdW5pbml0aWFsaXplZCB2YWx1ZXMgaW4gdGhlIHZlY3RvciB0byBv
bmUgb3IgbW9yZSBvZiBvbmVBZnRlciwgb25lQmVmb3JlIGFuZCB0d29CZWZvcmUsIHdoaWNoIGNh
dXNlcyB0aGUKKyAgICAgICAgaGVscGVyIGFkZGVkIGluIHIyMjI2NTQgdG8gYmFpbCBlYXJseSB3
aGVuIGl0IHNob3VsZCBub3QuCisKKyAgICAgICAgVG8gZml4IHRoaXMsIHdlIGluaXRpYWxpemUg
dGhlIFZlY3RvcjxVQ2hhcjMyPiBvZiBjaGFyYWN0ZXJzIGluIGNoYXJhY3RlcnNBcm91bmRQb3Np
dGlvbiB0byAwICh3aGljaCBpcyB0aGUKKyAgICAgICAgaW5pdGlhbCB2YWx1ZSBmb3IgdGhlIDMg
Y29ycmVzcG9uZGluZyBtZW1iZXJzIGluIHRoZSBQb3N0TGF5b3V0RGF0YSBzdHJ1Y3QpLgorCisg
ICAgICAgIE5vIG5ldyB0ZXN0czsgZml4ZXMgYSBmbGFreSBBUEkgdGVzdC4KKworICAgICAgICAq
IGVkaXRpbmcvVmlzaWJsZVVuaXRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNoYXJhY3RlcnNB
cm91bmRQb3NpdGlvbik6CisKIDIwMTctMDktMjkgIEJhc3VrZSBTdXp1a2kgIDxCYXN1a2UuU3V6
dWtpQHNvbnkuY29tPgogCiAgICAgICAgIFtDdXJsXSBFeHRyYWN0IGEgZmVhdHVyZXMgdG8gbWFu
YWdlIEhUVFAgY29tbXVuaWNhdGlvbiBmcm9tIFJlc291cmNlSGFuZGxlCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zpc2libGVVbml0cy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9l
ZGl0aW5nL1Zpc2libGVVbml0cy5jcHAKaW5kZXggMzllZDUwM2VkMTk4NDc4ZmI4NmIyMzE3NTBj
Mzk2ZTIwYmY1Y2VlNi4uMGE1YTRkNzVhYzliMWQ3MjkzYjQwOTljZjIwNzhkOWU3MmQ2NjU5MCAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9WaXNpYmxlVW5pdHMuY3BwCisrKyBi
L1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVmlzaWJsZVVuaXRzLmNwcApAQCAtMTg5Miw3ICsxODky
LDcgQEAgaW50IGRpc3RhbmNlQmV0d2VlblBvc2l0aW9ucyhjb25zdCBWaXNpYmxlUG9zaXRpb24m
IHZwLCBjb25zdCBWaXNpYmxlUG9zaXRpb24mIG8KIHZvaWQgY2hhcmFjdGVyc0Fyb3VuZFBvc2l0
aW9uKGNvbnN0IFZpc2libGVQb3NpdGlvbiYgcG9zaXRpb24sIFVDaGFyMzImIG9uZUFmdGVyLCBV
Q2hhcjMyJiBvbmVCZWZvcmUsIFVDaGFyMzImIHR3b0JlZm9yZSkKIHsKICAgICBjb25zdCBpbnQg
bWF4Q2hhcmFjdGVycyA9IDM7Ci0gICAgVmVjdG9yPFVDaGFyMzI+IGNoYXJhY3RlcnMobWF4Q2hh
cmFjdGVycyk7CisgICAgVmVjdG9yPFVDaGFyMzI+IGNoYXJhY3RlcnMobWF4Q2hhcmFjdGVycywg
MCk7CiAKICAgICBpZiAocG9zaXRpb24uaXNOdWxsKCkgfHwgaXNTdGFydE9mRG9jdW1lbnQocG9z
aXRpb24pKQogICAgICAgICByZXR1cm47Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>322282</attachid>
            <date>2017-09-29 22:35:59 -0700</date>
            <delta_ts>2017-09-30 13:23:44 -0700</delta_ts>
            <desc>Fix some awkward ChangeLog wording</desc>
            <filename>bug-177698-20170929223558.patch</filename>
            <type>text/plain</type>
            <size>2956</size>
            <attacher name="Wenson Hsieh">wenson_hsieh</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzdkMDAzOWI1Y2I4Nzk0
NTdhMDM5ZDY0NTg5Y2JkN2NiMzc4ZDExYi4uMGM0NmJhM2Q3ODA2OTM3MTA5NWVjMDY0YzI3MjFh
MGE4ZjI3M2FkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE3LTA5LTI5ICBXZW5z
b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0syXSBB
UEkgdGVzdCBFZGl0b3JTdGF0ZVRlc3RzLkNvbnRlbnRWaWV3SGFzVGV4dEluQ29udGVudEVkaXRh
YmxlRWxlbWVudCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzY5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBXZWJLaXQyIEFQSSB0ZXN0IEVkaXRvclN0YXRlVGVz
dHMuQ29udGVudFZpZXdIYXNUZXh0SW5Db250ZW50RWRpdGFibGVFbGVtZW50IGlzIGN1cnJlbnRs
eSBoaXR0aW5nCisgICAgICAgIGludGVybWl0dGVudCBmYWlsdXJlcyBvbiB0ZXN0IHJ1bm5lcnMu
IEFmdGVyIGluc2VydGluZyBqdXN0IGFuIGltYWdlIGluIHRoZSBlZGl0YWJsZSBlbGVtZW50LCB3
ZSB3b3VsZCBleHBlY3QKKyAgICAgICAgdGhhdCAtaGFzVGV4dCBzaG91bGQgcmV0dXJuIE5PIGJl
Y2F1c2UgdGhlIHRleHQgY29udGVudCBpcyBhbiBlbXB0eSBzdHJpbmcsIGJ1dCB3ZSBmaW5kIHRo
YXQgLWhhc1RleHQgaXMgWUVTLgorICAgICAgICBUaGlzIGlzIGJlY2F1c2Ugd2UncmUgYmFpbGlu
ZyBvbiBhbiBlYXJseSByZXR1cm4gaW4gY29tcHV0ZUVkaXRhYmxlUm9vdEhhc0NvbnRlbnRBbmRQ
bGFpblRleHQgYmVjYXVzZSB0aGUKKyAgICAgICAgRWRpdG9yU3RhdGUncyBQb3N0TGF5b3V0RGF0
YSBjb250YWlucyBub24temVybyBjaGFyYWN0ZXJzIG5lYXIgdGhlIHNlbGVjdGlvbiwgd2hpY2gg
aXMgaW5jb3JyZWN0LgorCisgICAgICAgIEhvd2V2ZXIsIHVwb24gY2xvc2VyIGluc3BlY3Rpb24s
IHRoaXMgaXMgZHVlIHRvIGEgbGF0ZW50IGJ1ZyBpbiB0aGUgY2hhcmFjdGVyc0Fyb3VuZFBvc2l0
aW9uIGhlbHBlciBmdW5jdGlvbi4KKyAgICAgICAgVGhpcyBmdW5jdGlvbiBhdHRlbXB0cyB0byBj
b21wdXRlIGNoYXJhY3RlcnMgYmVmb3JlIGFuZCBhZnRlciB0aGUgY3VycmVudCBzZWxlY3Rpb24g
YnkgaW5pdGlhbGl6aW5nIGEgVmVjdG9yCisgICAgICAgIG9mIHNpemUgMyB3aXRoIHRoZSByZWxl
dmFudCBjaGFyYWN0ZXIgZGF0YSwgYW5kIHRoZW4gc2V0cyBvbmVBZnRlciwgb25lQmVmb3JlIGFu
ZCB0d29CZWZvcmUgdG8gdGhlIFVDaGFyMzIKKyAgICAgICAgdmFsdWVzIGluIHRoZSB2ZWN0b3Iu
IEhvd2V2ZXIsIGluIHRoZSBjYXNlIHdoZXJlIHRoZXJlIGFyZSBsZXNzIHRoYW4gdGhyZWUgY2hh
cmFjdGVycywgd2UgZW5kIHVwIGFzc2lnbmluZworICAgICAgICB0aGUgdW5pbml0aWFsaXplZCB2
YWx1ZXMgaW4gdGhlIHZlY3RvciB0byBvbmUgb3IgbW9yZSBvZiBvbmVBZnRlciwgb25lQmVmb3Jl
IGFuZCB0d29CZWZvcmUsIHdoaWNoIGNhdXNlcyB0aGUKKyAgICAgICAgaGVscGVyIGFkZGVkIGlu
IHIyMjI2NTQgdG8gYmFpbCBlYXJseSB3aGVuIGl0IHNob3VsZCBub3QuCisKKyAgICAgICAgVG8g
Zml4IHRoaXMsIHdlIGluaXRpYWxpemUgdGhlIFZlY3RvcjxVQ2hhcjMyPiBvZiBjaGFyYWN0ZXJz
IGluIGNoYXJhY3RlcnNBcm91bmRQb3NpdGlvbiB0byAwICh3aGljaCBpcyB0aGUKKyAgICAgICAg
aW5pdGlhbCB2YWx1ZSBmb3IgdGhlIDMgY29ycmVzcG9uZGluZyBtZW1iZXJzIGluIHRoZSBQb3N0
TGF5b3V0RGF0YSBzdHJ1Y3QpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0czsgZml4ZXMgYSBmbGFr
eSBBUEkgdGVzdC4KKworICAgICAgICAqIGVkaXRpbmcvVmlzaWJsZVVuaXRzLmNwcDoKKyAgICAg
ICAgKFdlYkNvcmU6OmNoYXJhY3RlcnNBcm91bmRQb3NpdGlvbik6CisKIDIwMTctMDktMjkgIEJh
c3VrZSBTdXp1a2kgIDxCYXN1a2UuU3V6dWtpQHNvbnkuY29tPgogCiAgICAgICAgIFtDdXJsXSBF
eHRyYWN0IGEgZmVhdHVyZXMgdG8gbWFuYWdlIEhUVFAgY29tbXVuaWNhdGlvbiBmcm9tIFJlc291
cmNlSGFuZGxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zpc2libGVVbml0
cy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zpc2libGVVbml0cy5jcHAKaW5kZXggMzll
ZDUwM2VkMTk4NDc4ZmI4NmIyMzE3NTBjMzk2ZTIwYmY1Y2VlNi4uMGE1YTRkNzVhYzliMWQ3Mjkz
YjQwOTljZjIwNzhkOWU3MmQ2NjU5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGlu
Zy9WaXNpYmxlVW5pdHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVmlzaWJsZVVu
aXRzLmNwcApAQCAtMTg5Miw3ICsxODkyLDcgQEAgaW50IGRpc3RhbmNlQmV0d2VlblBvc2l0aW9u
cyhjb25zdCBWaXNpYmxlUG9zaXRpb24mIHZwLCBjb25zdCBWaXNpYmxlUG9zaXRpb24mIG8KIHZv
aWQgY2hhcmFjdGVyc0Fyb3VuZFBvc2l0aW9uKGNvbnN0IFZpc2libGVQb3NpdGlvbiYgcG9zaXRp
b24sIFVDaGFyMzImIG9uZUFmdGVyLCBVQ2hhcjMyJiBvbmVCZWZvcmUsIFVDaGFyMzImIHR3b0Jl
Zm9yZSkKIHsKICAgICBjb25zdCBpbnQgbWF4Q2hhcmFjdGVycyA9IDM7Ci0gICAgVmVjdG9yPFVD
aGFyMzI+IGNoYXJhY3RlcnMobWF4Q2hhcmFjdGVycyk7CisgICAgVmVjdG9yPFVDaGFyMzI+IGNo
YXJhY3RlcnMobWF4Q2hhcmFjdGVycywgMCk7CiAKICAgICBpZiAocG9zaXRpb24uaXNOdWxsKCkg
fHwgaXNTdGFydE9mRG9jdW1lbnQocG9zaXRpb24pKQogICAgICAgICByZXR1cm47Cg==
</data>
<flag name="review"
          id="342164"
          type_id="1"
          status="+"
          setter="rniwa"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>322299</attachid>
            <date>2017-09-30 13:46:20 -0700</date>
            <delta_ts>2017-09-30 14:25:54 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-177698-20170930134619.patch</filename>
            <type>text/plain</type>
            <size>3041</size>
            <attacher name="Wenson Hsieh">wenson_hsieh</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzdkMDAzOWI1Y2I4Nzk0
NTdhMDM5ZDY0NTg5Y2JkN2NiMzc4ZDExYi4uNTIxMjg2YmZkNTllMmZmMWFkNzVhMzIyYzMzOWMx
ZTg3NDlmMTc3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDE3LTA5LTI5ICBXZW5z
b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0syXSBB
UEkgdGVzdCBFZGl0b3JTdGF0ZVRlc3RzLkNvbnRlbnRWaWV3SGFzVGV4dEluQ29udGVudEVkaXRh
YmxlRWxlbWVudCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzY5OAorCisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1
a2UgTml3YS4KKworICAgICAgICBUaGUgV2ViS2l0MiBBUEkgdGVzdCBFZGl0b3JTdGF0ZVRlc3Rz
LkNvbnRlbnRWaWV3SGFzVGV4dEluQ29udGVudEVkaXRhYmxlRWxlbWVudCBpcyBjdXJyZW50bHkg
aGl0dGluZworICAgICAgICBpbnRlcm1pdHRlbnQgZmFpbHVyZXMgb24gdGVzdCBydW5uZXJzLiBB
ZnRlciBpbnNlcnRpbmcganVzdCBhbiBpbWFnZSBpbiB0aGUgZWRpdGFibGUgZWxlbWVudCwgd2Ug
d291bGQgZXhwZWN0CisgICAgICAgIHRoYXQgLWhhc1RleHQgc2hvdWxkIHJldHVybiBOTyBiZWNh
dXNlIHRoZSB0ZXh0IGNvbnRlbnQgaXMgYW4gZW1wdHkgc3RyaW5nLCBidXQgd2UgZmluZCB0aGF0
IC1oYXNUZXh0IGlzIFlFUy4KKyAgICAgICAgVGhpcyBpcyBiZWNhdXNlIHdlJ3JlIGJhaWxpbmcg
b24gYW4gZWFybHkgcmV0dXJuIGluIGNvbXB1dGVFZGl0YWJsZVJvb3RIYXNDb250ZW50QW5kUGxh
aW5UZXh0IGJlY2F1c2UgdGhlCisgICAgICAgIEVkaXRvclN0YXRlJ3MgUG9zdExheW91dERhdGEg
Y29udGFpbnMgbm9uLXplcm8gY2hhcmFjdGVycyBuZWFyIHRoZSBzZWxlY3Rpb24sIHdoaWNoIGlz
IGluY29ycmVjdC4KKworICAgICAgICBIb3dldmVyLCB1cG9uIGNsb3NlciBpbnNwZWN0aW9uLCB0
aGlzIGlzIGR1ZSB0byBhIGxhdGVudCBidWcgaW4gdGhlIGNoYXJhY3RlcnNBcm91bmRQb3NpdGlv
biBoZWxwZXIgZnVuY3Rpb24uCisgICAgICAgIFRoaXMgZnVuY3Rpb24gYXR0ZW1wdHMgdG8gY29t
cHV0ZSBjaGFyYWN0ZXJzIGJlZm9yZSBhbmQgYWZ0ZXIgdGhlIGN1cnJlbnQgc2VsZWN0aW9uIGJ5
IGluaXRpYWxpemluZyBhIFZlY3RvcgorICAgICAgICBvZiBzaXplIDMgd2l0aCB0aGUgcmVsZXZh
bnQgY2hhcmFjdGVyIGRhdGEsIGFuZCB0aGVuIHNldHMgb25lQWZ0ZXIsIG9uZUJlZm9yZSBhbmQg
dHdvQmVmb3JlIHRvIHRoZSBVQ2hhcjMyCisgICAgICAgIHZhbHVlcyBpbiB0aGUgdmVjdG9yLiBI
b3dldmVyLCBpbiB0aGUgY2FzZSB3aGVyZSB0aGVyZSBhcmUgbGVzcyB0aGFuIHRocmVlIGNoYXJh
Y3RlcnMsIHdlIGVuZCB1cCBhc3NpZ25pbmcKKyAgICAgICAgdGhlIHVuaW5pdGlhbGl6ZWQgdmFs
dWVzIGluIHRoZSB2ZWN0b3IgdG8gb25lIG9yIG1vcmUgb2Ygb25lQWZ0ZXIsIG9uZUJlZm9yZSBh
bmQgdHdvQmVmb3JlLCB3aGljaCBjYXVzZXMgdGhlCisgICAgICAgIGhlbHBlciBhZGRlZCBpbiBy
MjIyNjU0IHRvIGJhaWwgZWFybHkgd2hlbiBpdCBzaG91bGQgbm90LgorCisgICAgICAgIFRvIGZp
eCB0aGlzLCB3ZSBpbml0aWFsaXplIHRoZSB2YWx1ZXMgaW4gYGNoYXJhY3RlcnNgIHRvIDAgKHdo
aWNoIGlzIHRoZSBpbml0aWFsIHZhbHVlIGZvciB0aGUgMyBjb3JyZXNwb25kaW5nCisgICAgICAg
IG1lbWJlcnMgaW4gdGhlIFBvc3RMYXlvdXREYXRhIHN0cnVjdCkuIFdlIGFsc28gdHVybiBgY2hh
cmFjdGVyc2AgaW50byBhIFVDaGFyMzIgYXJyYXkgb24gdGhlIHN0YWNrLCB0byBhdm9pZCB0aGUK
KyAgICAgICAgaGVhcCBhbGxvY2F0aW9ucyB1c2luZyBhIFZlY3RvcjxVQ2hhcjMyPi4KKworICAg
ICAgICBObyBuZXcgdGVzdHM7IGZpeGVzIGEgZmxha3kgQVBJIHRlc3QuCisKKyAgICAgICAgKiBl
ZGl0aW5nL1Zpc2libGVVbml0cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjaGFyYWN0ZXJzQXJv
dW5kUG9zaXRpb24pOgorCiAyMDE3LTA5LTI5ICBCYXN1a2UgU3V6dWtpICA8QmFzdWtlLlN1enVr
aUBzb255LmNvbT4KIAogICAgICAgICBbQ3VybF0gRXh0cmFjdCBhIGZlYXR1cmVzIHRvIG1hbmFn
ZSBIVFRQIGNvbW11bmljYXRpb24gZnJvbSBSZXNvdXJjZUhhbmRsZQpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvZWRpdGluZy9WaXNpYmxlVW5pdHMuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRp
dGluZy9WaXNpYmxlVW5pdHMuY3BwCmluZGV4IDM5ZWQ1MDNlZDE5ODQ3OGZiODZiMjMxNzUwYzM5
NmUyMGJmNWNlZTYuLjE2ZTk2YWIxOTY4ZjE0NjRmNDU1ZWYwZWMwYzYzMjc1ZmEwZjE2YzMgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVmlzaWJsZVVuaXRzLmNwcAorKysgYi9T
b3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zpc2libGVVbml0cy5jcHAKQEAgLTE4OTIsNyArMTg5Miw3
IEBAIGludCBkaXN0YW5jZUJldHdlZW5Qb3NpdGlvbnMoY29uc3QgVmlzaWJsZVBvc2l0aW9uJiB2
cCwgY29uc3QgVmlzaWJsZVBvc2l0aW9uJiBvCiB2b2lkIGNoYXJhY3RlcnNBcm91bmRQb3NpdGlv
bihjb25zdCBWaXNpYmxlUG9zaXRpb24mIHBvc2l0aW9uLCBVQ2hhcjMyJiBvbmVBZnRlciwgVUNo
YXIzMiYgb25lQmVmb3JlLCBVQ2hhcjMyJiB0d29CZWZvcmUpCiB7CiAgICAgY29uc3QgaW50IG1h
eENoYXJhY3RlcnMgPSAzOwotICAgIFZlY3RvcjxVQ2hhcjMyPiBjaGFyYWN0ZXJzKG1heENoYXJh
Y3RlcnMpOworICAgIFVDaGFyMzIgY2hhcmFjdGVyc1ttYXhDaGFyYWN0ZXJzXSA9IHsgMCB9Owog
CiAgICAgaWYgKHBvc2l0aW9uLmlzTnVsbCgpIHx8IGlzU3RhcnRPZkRvY3VtZW50KHBvc2l0aW9u
KSkKICAgICAgICAgcmV0dXJuOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>