177679 2017-09-29 13:24:09 -0700 [High Sierra Release WK2] LayoutTest http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html is a flaky failure 2017-10-06 16:07:02 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad ryanhaddad ap commit-queue jlewis3 lforschler webkit-bug-importer wilander oldest_to_newest 1354667 0 ryanhaddad 2017-09-29 13:24:09 -0700 LayoutTest http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html is a flaky failure https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r222634%20(46)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Floading%2FresourceLoadStatistics%2Fpartitioned-cookies-with-and-without-user-interaction.html --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction-actual.txt @@ -4,7 +4,7 @@ main frame - didChangeLocationWithinPageForFrame main frame - willPerformClientRedirectToURL: http://localhost:8000/loading/resourceLoadStatistics/resources/set-cookie.php?name=firstPartyCookie&value=value#http://127.0.0.1:8000/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html#step2 main frame - didFinishDocumentLoadForFrame -main frame - didFinishLoadForFrame +main frame - didFailLoadWithError main frame - didStartProvisionalLoadForFrame main frame - didCancelClientRedirectForFrame main frame - didCommitLoadForFrame 1356238 1 ap 2017-10-03 20:49:07 -0700 I suspect that this is a mistake in the test, which races parsing and navigation. Moving runTest() from inline script to load event handler may fix the problem. Ryan or Matt, would you be willing to try this out? 1356724 2 ryanhaddad 2017-10-04 16:49:19 -0700 (In reply to Alexey Proskuryakov from comment #1) > I suspect that this is a mistake in the test, which races parsing and > navigation. Moving runTest() from inline script to load event handler may > fix the problem. > > Ryan or Matt, would you be willing to try this out? I'll look at this. 1356736 3 ryanhaddad 2017-10-04 17:02:06 -0700 I can reproduce the failure with: run-webkit-tests --release http/tests/loading/resourceLoadStatistics/ --no-retry-failure -fg I cannot reproduce the failure after moving runTest() as suggested. 1356741 4 322745 ryanhaddad 2017-10-04 17:12:51 -0700 Created attachment 322745 Patch 1357795 5 322745 commit-queue 2017-10-06 16:06:10 -0700 Comment on attachment 322745 Patch Clearing flags on attachment: 322745 Committed r223008: <http://trac.webkit.org/changeset/223008> 1357796 6 commit-queue 2017-10-06 16:06:12 -0700 All reviewed patches have been landed. Closing bug. 1357797 7 webkit-bug-importer 2017-10-06 16:07:02 -0700 <rdar://problem/34866712> 322745 2017-10-04 17:12:51 -0700 2017-10-06 16:06:10 -0700 Patch bug-177679-20171004171251.patch text/plain 4889 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyODkwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGQzM2EwYmQzYjRiNWNlYjMyNjI2 ZmYyNGZjMGI5NThmMTk0YzNkOS4uOTczODIzZTViNTQyODU0ZGM2NWY0MGUyOGFjZDY4MjNmNzA3 ZTYxNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEwLTA0ICBSeWFuIEhhZGRhZCAgPHJ5 YW5oYWRkYWRAYXBwbGUuY29tPgorCisgICAgICAgIExheW91dFRlc3QgaHR0cC90ZXN0cy9sb2Fk aW5nL3Jlc291cmNlTG9hZFN0YXRpc3RpY3MvcGFydGl0aW9uZWQtY29va2llcy13aXRoLWFuZC13 aXRob3V0LXVzZXItaW50ZXJhY3Rpb24uaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzY3OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgcnVuVGVzdCgpIGZy b20gYW4gaW5saW5lIHNjcmlwdCB0byBhIGxvYWQgZXZlbnQgaGFuZGxlciB0byBhdm9pZCBhIHJh Y2UgYmV0d2VlbiBwYXJzaW5nIGFuZCBuYXZpZ2F0aW9uLgorCisgICAgICAgICogaHR0cC90ZXN0 cy9sb2FkaW5nL3Jlc291cmNlTG9hZFN0YXRpc3RpY3MvcGFydGl0aW9uZWQtY29va2llcy13aXRo LWFuZC13aXRob3V0LXVzZXItaW50ZXJhY3Rpb24tZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0 dHAvdGVzdHMvbG9hZGluZy9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzL3BhcnRpdGlvbmVkLWNvb2tp ZXMtd2l0aC1hbmQtd2l0aG91dC11c2VyLWludGVyYWN0aW9uLmh0bWw6CisKIDIwMTctMTAtMDQg IE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEltcHJvdmUgQ2FudmFzTWFuYWdlciByZWNvcmRpbmcgZXZlbnRzCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xvYWRpbmcvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9wYXJ0 aXRpb25lZC1jb29raWVzLXdpdGgtYW5kLXdpdGhvdXQtdXNlci1pbnRlcmFjdGlvbi1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xvYWRpbmcvcmVzb3VyY2VMb2FkU3RhdGlz dGljcy9wYXJ0aXRpb25lZC1jb29raWVzLXdpdGgtYW5kLXdpdGhvdXQtdXNlci1pbnRlcmFjdGlv bi1leHBlY3RlZC50eHQKaW5kZXggNjAxOWY3NDRmYmVjZDU3MDA3OWM0YjA3NTI1YzRmMjJhODIw NmUxMy4uZGFjZDI5ODBjOGU5ZWFlZTkwNThkYWUyZmY2YzBhM2Y1NmNmZjkzYiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9sb2FkaW5nL3Jlc291cmNlTG9hZFN0YXRpc3RpY3Mv cGFydGl0aW9uZWQtY29va2llcy13aXRoLWFuZC13aXRob3V0LXVzZXItaW50ZXJhY3Rpb24tZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbG9hZGluZy9yZXNvdXJjZUxv YWRTdGF0aXN0aWNzL3BhcnRpdGlvbmVkLWNvb2tpZXMtd2l0aC1hbmQtd2l0aG91dC11c2VyLWlu dGVyYWN0aW9uLWV4cGVjdGVkLnR4dApAQCAtMiw4ICsyLDkgQEAgbWFpbiBmcmFtZSAtIGRpZFN0 YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUKIG1haW4gZnJhbWUgLSBkaWRDb21taXRMb2FkRm9y RnJhbWUKIG1haW4gZnJhbWUgLSBkaWRSZWNlaXZlVGl0bGU6IFRlc3QgZm9yIFBhcnRpdGlvbmVk IENvb2tpZXMgV2l0aCBhbmQgV2l0aG91dCBVc2VyIEludGVyYWN0aW9uCiBtYWluIGZyYW1lIC0g ZGlkQ2hhbmdlTG9jYXRpb25XaXRoaW5QYWdlRm9yRnJhbWUKLW1haW4gZnJhbWUgLSB3aWxsUGVy Zm9ybUNsaWVudFJlZGlyZWN0VG9VUkw6IGh0dHA6Ly9sb2NhbGhvc3Q6ODAwMC9sb2FkaW5nL3Jl c291cmNlTG9hZFN0YXRpc3RpY3MvcmVzb3VyY2VzL3NldC1jb29raWUucGhwP25hbWU9Zmlyc3RQ YXJ0eUNvb2tpZSZ2YWx1ZT12YWx1ZSNodHRwOi8vMTI3LjAuMC4xOjgwMDAvbG9hZGluZy9yZXNv dXJjZUxvYWRTdGF0aXN0aWNzL3BhcnRpdGlvbmVkLWNvb2tpZXMtd2l0aC1hbmQtd2l0aG91dC11 c2VyLWludGVyYWN0aW9uLmh0bWwjc3RlcDIgCiBtYWluIGZyYW1lIC0gZGlkRmluaXNoRG9jdW1l bnRMb2FkRm9yRnJhbWUKK21haW4gZnJhbWUgLSB3aWxsUGVyZm9ybUNsaWVudFJlZGlyZWN0VG9V Ukw6IGh0dHA6Ly9sb2NhbGhvc3Q6ODAwMC9sb2FkaW5nL3Jlc291cmNlTG9hZFN0YXRpc3RpY3Mv cmVzb3VyY2VzL3NldC1jb29raWUucGhwP25hbWU9Zmlyc3RQYXJ0eUNvb2tpZSZ2YWx1ZT12YWx1 ZSNodHRwOi8vMTI3LjAuMC4xOjgwMDAvbG9hZGluZy9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzL3Bh cnRpdGlvbmVkLWNvb2tpZXMtd2l0aC1hbmQtd2l0aG91dC11c2VyLWludGVyYWN0aW9uLmh0bWwj c3RlcDIgCittYWluIGZyYW1lIC0gZGlkSGFuZGxlT25sb2FkRXZlbnRzRm9yRnJhbWUKIG1haW4g ZnJhbWUgLSBkaWRGaW5pc2hMb2FkRm9yRnJhbWUKIG1haW4gZnJhbWUgLSBkaWRTdGFydFByb3Zp c2lvbmFsTG9hZEZvckZyYW1lCiBtYWluIGZyYW1lIC0gZGlkQ2FuY2VsQ2xpZW50UmVkaXJlY3RG b3JGcmFtZQpAQCAtMTYsMTIgKzE3LDEyIEBAIG1haW4gZnJhbWUgLSBkaWRTdGFydFByb3Zpc2lv bmFsTG9hZEZvckZyYW1lCiBtYWluIGZyYW1lIC0gZGlkQ2FuY2VsQ2xpZW50UmVkaXJlY3RGb3JG cmFtZQogbWFpbiBmcmFtZSAtIGRpZENvbW1pdExvYWRGb3JGcmFtZQogbWFpbiBmcmFtZSAtIGRp ZFJlY2VpdmVUaXRsZTogVGVzdCBmb3IgUGFydGl0aW9uZWQgQ29va2llcyBXaXRoIGFuZCBXaXRo b3V0IFVzZXIgSW50ZXJhY3Rpb24KK21haW4gZnJhbWUgLSBkaWRGaW5pc2hEb2N1bWVudExvYWRG b3JGcmFtZQogbWFpbiBmcmFtZSAtIGRpZENoYW5nZUxvY2F0aW9uV2l0aGluUGFnZUZvckZyYW1l CiBmcmFtZSAiPCEtLWZyYW1lUGF0aCAvLzwhLS1mcmFtZTAtLT4tLT4iIC0gZGlkU3RhcnRQcm92 aXNpb25hbExvYWRGb3JGcmFtZQotbWFpbiBmcmFtZSAtIGRpZEZpbmlzaERvY3VtZW50TG9hZEZv ckZyYW1lCittYWluIGZyYW1lIC0gZGlkSGFuZGxlT25sb2FkRXZlbnRzRm9yRnJhbWUKIGZyYW1l ICI8IS0tZnJhbWVQYXRoIC8vPCEtLWZyYW1lMC0tPi0tPiIgLSBkaWRDb21taXRMb2FkRm9yRnJh bWUKIGZyYW1lICI8IS0tZnJhbWVQYXRoIC8vPCEtLWZyYW1lMC0tPi0tPiIgLSBkaWRGaW5pc2hE b2N1bWVudExvYWRGb3JGcmFtZQotbWFpbiBmcmFtZSAtIGRpZEhhbmRsZU9ubG9hZEV2ZW50c0Zv ckZyYW1lCiBtYWluIGZyYW1lIC0gZGlkQ2hhbmdlTG9jYXRpb25XaXRoaW5QYWdlRm9yRnJhbWUK IGZyYW1lICI8IS0tZnJhbWVQYXRoIC8vPCEtLWZyYW1lMS0tPi0tPiIgLSBkaWRTdGFydFByb3Zp c2lvbmFsTG9hZEZvckZyYW1lCiBmcmFtZSAiPCEtLWZyYW1lUGF0aCAvLzwhLS1mcmFtZTAtLT4t LT4iIC0gZGlkSGFuZGxlT25sb2FkRXZlbnRzRm9yRnJhbWUKQEAgLTQyLDcgKzQzLDcgQEAgZnJh bWUgIjwhLS1mcmFtZVBhdGggLy88IS0tZnJhbWUzLS0+LS0+IiAtIGRpZEZpbmlzaERvY3VtZW50 TG9hZEZvckZyYW1lCiBmcmFtZSAiPCEtLWZyYW1lUGF0aCAvLzwhLS1mcmFtZTMtLT4tLT4iIC0g ZGlkSGFuZGxlT25sb2FkRXZlbnRzRm9yRnJhbWUKIGZyYW1lICI8IS0tZnJhbWVQYXRoIC8vPCEt LWZyYW1lMy0tPi0tPiIgLSBkaWRGaW5pc2hMb2FkRm9yRnJhbWUKIG1haW4gZnJhbWUgLSBkaWRG aW5pc2hMb2FkRm9yRnJhbWUKLSAgCisKIAogLS0tLS0tLS0KIEZyYW1lOiAnPCEtLWZyYW1lUGF0 aCAvLzwhLS1mcmFtZTAtLT4tLT4nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L2xvYWRpbmcvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9wYXJ0aXRpb25lZC1jb29raWVzLXdpdGgt YW5kLXdpdGhvdXQtdXNlci1pbnRlcmFjdGlvbi5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9sb2FkaW5nL3Jlc291cmNlTG9hZFN0YXRpc3RpY3MvcGFydGl0aW9uZWQtY29va2llcy13aXRo LWFuZC13aXRob3V0LXVzZXItaW50ZXJhY3Rpb24uaHRtbAppbmRleCA1ZTcwMTI3ZDEyNGFlZGUw ZTEzMzRhMTdmOTcxNTFjNmJiZmU0ZmE3Li4yMzBhODZkOGJlZGViMzZjMmQ0MGRkOGQzYmUxNzRm ODU3NTY4YmIyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xvYWRpbmcvcmVz b3VyY2VMb2FkU3RhdGlzdGljcy9wYXJ0aXRpb25lZC1jb29raWVzLXdpdGgtYW5kLXdpdGhvdXQt dXNlci1pbnRlcmFjdGlvbi5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbG9hZGlu Zy9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzL3BhcnRpdGlvbmVkLWNvb2tpZXMtd2l0aC1hbmQtd2l0 aG91dC11c2VyLWludGVyYWN0aW9uLmh0bWwKQEAgLTUsNyArNSw3IEBACiAgICAgPHRpdGxlPlRl c3QgZm9yIFBhcnRpdGlvbmVkIENvb2tpZXMgV2l0aCBhbmQgV2l0aG91dCBVc2VyIEludGVyYWN0 aW9uPC90aXRsZT4KICAgICA8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4KIDwvaGVhZD4KLTxib2R5PgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCki PgogPHNjcmlwdD4KICAgICBjb25zdCBwYXJ0aXRpb25Ib3N0ID0gIjEyNy4wLjAuMTo4MDAwIjsK ICAgICBjb25zdCB0aGlyZFBhcnR5T3JpZ2luID0gImh0dHA6Ly9sb2NhbGhvc3Q6ODAwMCI7CkBA IC03OSw4ICs3OSw2IEBACiAgICAgICAgIHRlc3RSdW5uZXIuZHVtcENoaWxkRnJhbWVzQXNUZXh0 KCk7CiAgICAgICAgIGRvY3VtZW50LmxvY2F0aW9uLmhhc2ggPSAic3RlcDEiOwogICAgIH0KLQot ICAgIHJ1blRlc3QoKTsKIDwvc2NyaXB0PgogPC9ib2R5PgogPC9odG1sPgo=