177672 2017-09-29 11:11:26 -0700 Web Inspector: Uncaught exception with populate find keyboard shortcut 2017-09-29 12:48:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1354608 0 joepeck 2017-09-29 11:11:26 -0700 Possible exception with populate find keyboard shortcut I've occasionally seen an exception: TypeError: null is not an object (evaluating 'focusedContentView.supportsCustomFindBanner') _populateFind @ Main.js ? @ [native code] _handleKeyDown @ KeyboardShortcut.js While I'm not sure what conditions this can happen, it does seem like focusedContentView can be null so we should protect against that. 1354609 1 322214 joepeck 2017-09-29 11:12:32 -0700 Created attachment 322214 [PATCH] Proposed Fix 1354637 2 322214 mattbaker 2017-09-29 12:15:48 -0700 Comment on attachment 322214 [PATCH] Proposed Fix r=me 1354651 3 322214 commit-queue 2017-09-29 12:47:31 -0700 Comment on attachment 322214 [PATCH] Proposed Fix Clearing flags on attachment: 322214 Committed r222661: <http://trac.webkit.org/changeset/222661> 1354652 4 commit-queue 2017-09-29 12:47:33 -0700 All reviewed patches have been landed. Closing bug. 1354653 5 webkit-bug-importer 2017-09-29 12:48:16 -0700 <rdar://problem/34745385> 322214 2017-09-29 11:12:32 -0700 2017-09-29 12:47:31 -0700 [PATCH] Proposed Fix exception-1.patch text/plain 1938 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDhjNWQ3ZGFjOGM3Li45NDgyMDAyOGE1ZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDktMjkgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBVbmNhdWdodCBleGNlcHRpb24gd2l0aCBwb3B1bGF0ZSBmaW5kIGtleWJvYXJkIHNob3J0Y3V0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc2NzIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICBUaGUgZm9jdXNlZENvbnRlbnRWaWV3IGNh biBiZSBudWxsIHNvIGJhaWwgaWYgdGhhdCBpcyB0aGUgY2FzZS4KKwogMjAxNy0wOS0yOCAgSm9z ZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IE9wZW4gUmVzb3VyY2UgRGlhbG9nIGljb25zIGFyZSBibHVycnkgKDI0eDI0IGluc3RlYWQg b2YgMzJ4MzIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNl L01haW4uanMKaW5kZXggNGJlMDljODAxYzEuLjZmNDI5NGFmOGM5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC0yMDEzLDYgKzIw MTMsOSBAQCBXSS5fY2xlYXIgPSBmdW5jdGlvbihldmVudCkKIFdJLl9wb3B1bGF0ZUZpbmQgPSBm dW5jdGlvbihldmVudCkKIHsKICAgICBsZXQgZm9jdXNlZENvbnRlbnRWaWV3ID0gdGhpcy5fZm9j dXNlZENvbnRlbnRWaWV3KCk7CisgICAgaWYgKCFmb2N1c2VkQ29udGVudFZpZXcpCisgICAgICAg IHJldHVybjsKKwogICAgIGlmIChmb2N1c2VkQ29udGVudFZpZXcuc3VwcG9ydHNDdXN0b21GaW5k QmFubmVyKSB7CiAgICAgICAgIGZvY3VzZWRDb250ZW50Vmlldy5oYW5kbGVQb3B1bGF0ZUZpbmRT aG9ydGN1dCgpOwogICAgICAgICByZXR1cm47CkBAIC0yMDI4LDYgKzIwMzEsOSBAQCBXSS5fcG9w dWxhdGVGaW5kID0gZnVuY3Rpb24oZXZlbnQpCiBXSS5fZmluZE5leHQgPSBmdW5jdGlvbihldmVu dCkKIHsKICAgICBsZXQgZm9jdXNlZENvbnRlbnRWaWV3ID0gdGhpcy5fZm9jdXNlZENvbnRlbnRW aWV3KCk7CisgICAgaWYgKCFmb2N1c2VkQ29udGVudFZpZXcpCisgICAgICAgIHJldHVybjsKKwog ICAgIGlmIChmb2N1c2VkQ29udGVudFZpZXcuc3VwcG9ydHNDdXN0b21GaW5kQmFubmVyKSB7CiAg ICAgICAgIGZvY3VzZWRDb250ZW50Vmlldy5oYW5kbGVGaW5kTmV4dFNob3J0Y3V0KCk7CiAgICAg ICAgIHJldHVybjsKQEAgLTIwNDMsNiArMjA0OSw5IEBAIFdJLl9maW5kTmV4dCA9IGZ1bmN0aW9u KGV2ZW50KQogV0kuX2ZpbmRQcmV2aW91cyA9IGZ1bmN0aW9uKGV2ZW50KQogewogICAgIGxldCBm b2N1c2VkQ29udGVudFZpZXcgPSB0aGlzLl9mb2N1c2VkQ29udGVudFZpZXcoKTsKKyAgICBpZiAo IWZvY3VzZWRDb250ZW50VmlldykKKyAgICAgICAgcmV0dXJuOworCiAgICAgaWYgKGZvY3VzZWRD b250ZW50Vmlldy5zdXBwb3J0c0N1c3RvbUZpbmRCYW5uZXIpIHsKICAgICAgICAgZm9jdXNlZENv bnRlbnRWaWV3LmhhbmRsZUZpbmRQcmV2aW91c1Nob3J0Y3V0KCk7CiAgICAgICAgIHJldHVybjsK