177634 2017-09-28 18:32:24 -0700 REGRESSION(r222640) [GTK] Build broken with ATK 2.14 2017-10-02 05:17:29 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 177542 1 clopez jdiggs aboxhall apinheiro bugs-noreply buildbot cfleizach commit-queue dmazzoni jcraig jdiggs mcatanzaro samuel_white oldest_to_newest 1354403 0 clopez 2017-09-28 18:32:24 -0700 It seems ATK_STATE_READ_ONLY Requires ATK >= 2.16 And Debian 8 still ships 2.14, and per our dependencies policy https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy we still should support the default build there. Build log failure: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Debian%20Stable%20%28Build%29/builds/5902/steps/compile-webkit/logs/stdio Its not needed to make the feature work with ATK 2.14. We only need to fix the build, so building WebKitGTK+ on Debian 8 (Jessie) can continue to be possible. Therefore just #ifdef'ing the code for ATK >= 2.16 is ok. 1355182 1 322366 jdiggs 2017-10-02 02:43:38 -0700 Created attachment 322366 Patch 1355201 2 322366 commit-queue 2017-10-02 05:17:27 -0700 Comment on attachment 322366 Patch Clearing flags on attachment: 322366 Committed r222705: <http://trac.webkit.org/changeset/222705> 1355202 3 commit-queue 2017-10-02 05:17:29 -0700 All reviewed patches have been landed. Closing bug. 322366 2017-10-02 02:43:38 -0700 2017-10-02 05:17:27 -0700 Patch bug-177634-20171002114336.patch text/plain 1514 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE1NjcwNTEwMDYyNGM0 Zjk5MGE2Nzk5ZjhlNDk4MmZmMzg0YmMzYi4uNDkzOWJkYjJiNzE5N2M1YmMxNTVlODM2OGNjMjQy NjEyMzQ1NTI5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEwLTAyICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIy MjI2NDApIFtHVEtdIEJ1aWxkIGJyb2tlbiB3aXRoIEFUSyAyLjE0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc2MzQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgQVRLX0NIRUNLX1ZFUlNJT04gdG8g cHJldmVudCB0aGUgYnVpbGQgZmFpbHVyZS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMg Zml4ZXMgYSBkb3duc3RyZWFtIGJ1aWxkIGZhaWx1cmUuCisKKyAgICAgICAgKiBhY2Nlc3NpYmls aXR5L2F0ay9BWE9iamVjdENhY2hlQXRrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0 Q2FjaGU6OnBvc3RQbGF0Zm9ybU5vdGlmaWNhdGlvbik6CisKIDIwMTctMTAtMDEgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUGFzdGVib2FyZCBzaG91bGRuJ3Qg YWRkICJGaWxlcyIgYXMgYSB0eXBlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L2F0ay9BWE9iamVjdENhY2hlQXRrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvYXRrL0FYT2JqZWN0Q2FjaGVBdGsuY3BwCmluZGV4IDA4NWRmODhkYzk5YzY2MzY0ZmI3 OWE5MzMwMzY5NWVmYzNkYTY4ZTYuLjk2ZWI4OWU3NDZiMjRjMjk3MzBkYjg5Yzc0MzgzZDc5NGE2 MGNhZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL0FYT2Jq ZWN0Q2FjaGVBdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL0FY T2JqZWN0Q2FjaGVBdGsuY3BwCkBAIC0yNzEsNyArMjcxLDkgQEAgdm9pZCBBWE9iamVjdENhY2hl Ojpwb3N0UGxhdGZvcm1Ob3RpZmljYXRpb24oQWNjZXNzaWJpbGl0eU9iamVjdCogY29yZU9iamVj dCwgQVgKICAgICAgICAgYnJlYWs7CiAKICAgICBjYXNlIEFYUmVhZE9ubHlTdGF0dXNDaGFuZ2Vk OgorI2lmIEFUS19DSEVDS19WRVJTSU9OKDIsMTUsMykKICAgICAgICAgYXRrX29iamVjdF9ub3Rp Znlfc3RhdGVfY2hhbmdlKGF4T2JqZWN0LCBBVEtfU1RBVEVfUkVBRF9PTkxZLCAhY29yZU9iamVj dC0+Y2FuU2V0VmFsdWVBdHRyaWJ1dGUoKSk7CisjZW5kaWYKICAgICAgICAgYnJlYWs7CiAKICAg ICBjYXNlIEFYUmVxdWlyZWRTdGF0dXNDaGFuZ2VkOgo=