177624 2017-09-28 14:48:01 -0700 Simplify PLATFORM ifdefs within Editor around writing selections 2017-09-28 17:17:18 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead achristensen commit-queue pvollan webkit-bug-importer yoshiaki.jitsukawa oldest_to_newest 1354309 0 don.olmstead 2017-09-28 14:48:01 -0700 Only PLATFORM(WIN) is not implementing writeSelectionToPasteboard, writeImageToPasteboard and writeSelection. 1354311 1 322119 don.olmstead 2017-09-28 14:48:58 -0700 Created attachment 322119 Patch 1354312 2 322120 don.olmstead 2017-09-28 14:50:35 -0700 Created attachment 322120 Patch 1354387 3 322120 commit-queue 2017-09-28 17:15:37 -0700 Comment on attachment 322120 Patch Clearing flags on attachment: 322120 Committed r222642: <http://trac.webkit.org/changeset/222642> 1354388 4 commit-queue 2017-09-28 17:15:39 -0700 All reviewed patches have been landed. Closing bug. 1354390 5 webkit-bug-importer 2017-09-28 17:17:18 -0700 <rdar://problem/34728490> 322119 2017-09-28 14:48:58 -0700 2017-09-28 14:50:35 -0700 Patch bug-177624.diff text/plain 3172 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlNTI3NjQwMDRlMC4uYmU2NzAxYzgwYTcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wOS0yOCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnku Y29tPgorCisgICAgICAgIFNpbXBsaWZ5IFBMQVRGT1JNIGlmZGVmcyB3aXRoaW4gRWRpdG9yIGFy b3VuZCB3cml0aW5nIHNlbGVjdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3NzYyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoT09QUyEpLgorCisgICAgICAgICogZWRpdGlu Zy9FZGl0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjpwZXJmb3JtQ3V0T3JDb3B5 KToKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6Y29weUltYWdlKToKKyAgICAgICAgKiBlZGl0 aW5nL0VkaXRvci5oOgorCiAyMDE3LTA5LTI4ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25A YXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBjb25zdGFudCgpIGluIGZhdm9yIG9mIGVudigp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKaW5kZXggMzY4YzI0NGMzYjcuLjE2NTUyNTQ1YzM1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCkBAIC0xMzAyLDE2ICsxMzAyLDE3IEBAIHZv aWQgRWRpdG9yOjpwZXJmb3JtQ3V0T3JDb3B5KEVkaXRvckFjdGlvblNwZWNpZmllciBhY3Rpb24p CiAgICAgICAgICAgICBpbWFnZUVsZW1lbnQgPSBpbWFnZUVsZW1lbnRGcm9tSW1hZ2VEb2N1bWVu dChkb2N1bWVudCgpKTsKIAogICAgICAgICBpZiAoaW1hZ2VFbGVtZW50KSB7Ci0jaWYgUExBVEZP Uk0oQ09DT0EpIHx8IFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKQorI2lmICFQTEFURk9S TShXSU4pCiAgICAgICAgICAgICB3cml0ZUltYWdlVG9QYXN0ZWJvYXJkKCpQYXN0ZWJvYXJkOjpj cmVhdGVGb3JDb3B5QW5kUGFzdGUoKSwgKmltYWdlRWxlbWVudCwgZG9jdW1lbnQoKS51cmwoKSwg ZG9jdW1lbnQoKS50aXRsZSgpKTsKICNlbHNlCisgICAgICAgICAgICAvLyBGSVhNRTogRGVsZXRl IGFmdGVyIDxodHRwOi8vd2Via2l0Lm9yZy9iLzE3NzYxOD4gbGFuZHMuCiAgICAgICAgICAgICBQ YXN0ZWJvYXJkOjpjcmVhdGVGb3JDb3B5QW5kUGFzdGUoKS0+d3JpdGVJbWFnZSgqaW1hZ2VFbGVt ZW50LCBkb2N1bWVudCgpLnVybCgpLCBkb2N1bWVudCgpLnRpdGxlKCkpOwogI2VuZGlmCiAgICAg ICAgIH0gZWxzZSB7Ci0jaWYgUExBVEZPUk0oQ09DT0EpIHx8IFBMQVRGT1JNKEdUSykgfHwgUExB VEZPUk0oV1BFKQorI2lmICFQTEFURk9STShXSU4pCiAgICAgICAgICAgICB3cml0ZVNlbGVjdGlv blRvUGFzdGVib2FyZCgqUGFzdGVib2FyZDo6Y3JlYXRlRm9yQ29weUFuZFBhc3RlKCkpOwogI2Vs c2UKLSAgICAgICAgICAgIC8vIEZJWE1FOiBDb252ZXJ0IGFsbCBvdGhlciBwbGF0Zm9ybXMgdG8g bWF0Y2ggTWFjIGFuZCBkZWxldGUgdGhpcy4KKyAgICAgICAgICAgIC8vIEZJWE1FOiBEZWxldGUg YWZ0ZXIgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTc3NjE4PiBsYW5kcy4KICAgICAgICAgICAgIFBh c3RlYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZSgpLT53cml0ZVNlbGVjdGlvbigqc2VsZWN0 aW9uLCBjYW5TbWFydENvcHlPckRlbGV0ZSgpLCBtX2ZyYW1lLCBJbmNsdWRlSW1hZ2VBbHRUZXh0 Rm9yRGF0YVRyYW5zZmVyKTsKICNlbmRpZgogICAgICAgICB9CkBAIC0xNDMzLDkgKzE0MzQsMTAg QEAgdm9pZCBFZGl0b3I6OmNvcHlJbWFnZShjb25zdCBIaXRUZXN0UmVzdWx0JiByZXN1bHQpCiAg ICAgaWYgKHVybC5pc0VtcHR5KCkpCiAgICAgICAgIHVybCA9IHJlc3VsdC5hYnNvbHV0ZUltYWdl VVJMKCk7CiAKLSNpZiBQTEFURk9STShDT0NPQSkgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9S TShXUEUpCisjaWYgIVBMQVRGT1JNKFdJTikKICAgICB3cml0ZUltYWdlVG9QYXN0ZWJvYXJkKCpQ YXN0ZWJvYXJkOjpjcmVhdGVGb3JDb3B5QW5kUGFzdGUoKSwgKmVsZW1lbnQsIHVybCwgcmVzdWx0 LmFsdERpc3BsYXlTdHJpbmcoKSk7CiAjZWxzZQorICAgIC8vIEZJWE1FOiBEZWxldGUgYWZ0ZXIg PGh0dHA6Ly93ZWJraXQub3JnL2IvMTc3NjE4PiBsYW5kcy4KICAgICBQYXN0ZWJvYXJkOjpjcmVh dGVGb3JDb3B5QW5kUGFzdGUoKS0+d3JpdGVJbWFnZSgqZWxlbWVudCwgdXJsLCByZXN1bHQuYWx0 RGlzcGxheVN0cmluZygpKTsKICNlbmRpZgogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZWRpdGluZy9FZGl0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmgKaW5kZXgg M2MwZmVlYTY3MzguLjg0NDA1Y2I5YjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0 aW5nL0VkaXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmgKQEAgLTQ3 OSw3ICs0NzksNyBAQCBwdWJsaWM6CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCByZXBsYWNlU2Vs ZWN0aW9uV2l0aEF0dHJpYnV0ZWRTdHJpbmcoTlNBdHRyaWJ1dGVkU3RyaW5nICosIE1haWxCbG9j a3F1b3RlSGFuZGxpbmcgPSBNYWlsQmxvY2txdW90ZUhhbmRsaW5nOjpSZXNwZWN0QmxvY2txdW90 ZSk7CiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKENPQ09BKSB8fCBQTEFURk9STShHVEspIHx8IFBM QVRGT1JNKFdQRSkKKyNpZiAhUExBVEZPUk0oV0lOKQogICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQg d3JpdGVTZWxlY3Rpb25Ub1Bhc3RlYm9hcmQoUGFzdGVib2FyZCYpOwogICAgIFdFQkNPUkVfRVhQ T1JUIHZvaWQgd3JpdGVJbWFnZVRvUGFzdGVib2FyZChQYXN0ZWJvYXJkJiwgRWxlbWVudCYgaW1h Z2VFbGVtZW50LCBjb25zdCBVUkwmLCBjb25zdCBTdHJpbmcmIHRpdGxlKTsKICAgICB2b2lkIHdy aXRlU2VsZWN0aW9uKFBhc3RlYm9hcmRXcml0ZXJEYXRhJik7Cg== 322120 2017-09-28 14:50:35 -0700 2017-09-28 17:15:37 -0700 Patch bug-177624.diff text/plain 3187 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlNTI3NjQwMDRlMC4uYmU2NzAxYzgwYTcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wOS0yOCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnku Y29tPgorCisgICAgICAgIFNpbXBsaWZ5IFBMQVRGT1JNIGlmZGVmcyB3aXRoaW4gRWRpdG9yIGFy b3VuZCB3cml0aW5nIHNlbGVjdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3NzYyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisg ICAgICAgICogZWRpdGluZy9FZGl0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjpw ZXJmb3JtQ3V0T3JDb3B5KToKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6Y29weUltYWdlKToK KyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5oOgorCiAyMDE3LTA5LTI4ICBUaW0gSG9ydG9uICA8 dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBjb25zdGFudCgpIGlu IGZhdm9yIG9mIGVudigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRv ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKaW5kZXggMzY4YzI0NGMz YjcuLjE2NTUyNTQ1YzM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRv ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCkBAIC0xMzAyLDE2 ICsxMzAyLDE3IEBAIHZvaWQgRWRpdG9yOjpwZXJmb3JtQ3V0T3JDb3B5KEVkaXRvckFjdGlvblNw ZWNpZmllciBhY3Rpb24pCiAgICAgICAgICAgICBpbWFnZUVsZW1lbnQgPSBpbWFnZUVsZW1lbnRG cm9tSW1hZ2VEb2N1bWVudChkb2N1bWVudCgpKTsKIAogICAgICAgICBpZiAoaW1hZ2VFbGVtZW50 KSB7Ci0jaWYgUExBVEZPUk0oQ09DT0EpIHx8IFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BF KQorI2lmICFQTEFURk9STShXSU4pCiAgICAgICAgICAgICB3cml0ZUltYWdlVG9QYXN0ZWJvYXJk KCpQYXN0ZWJvYXJkOjpjcmVhdGVGb3JDb3B5QW5kUGFzdGUoKSwgKmltYWdlRWxlbWVudCwgZG9j dW1lbnQoKS51cmwoKSwgZG9jdW1lbnQoKS50aXRsZSgpKTsKICNlbHNlCisgICAgICAgICAgICAv LyBGSVhNRTogRGVsZXRlIGFmdGVyIDxodHRwOi8vd2Via2l0Lm9yZy9iLzE3NzYxOD4gbGFuZHMu CiAgICAgICAgICAgICBQYXN0ZWJvYXJkOjpjcmVhdGVGb3JDb3B5QW5kUGFzdGUoKS0+d3JpdGVJ bWFnZSgqaW1hZ2VFbGVtZW50LCBkb2N1bWVudCgpLnVybCgpLCBkb2N1bWVudCgpLnRpdGxlKCkp OwogI2VuZGlmCiAgICAgICAgIH0gZWxzZSB7Ci0jaWYgUExBVEZPUk0oQ09DT0EpIHx8IFBMQVRG T1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKQorI2lmICFQTEFURk9STShXSU4pCiAgICAgICAgICAg ICB3cml0ZVNlbGVjdGlvblRvUGFzdGVib2FyZCgqUGFzdGVib2FyZDo6Y3JlYXRlRm9yQ29weUFu ZFBhc3RlKCkpOwogI2Vsc2UKLSAgICAgICAgICAgIC8vIEZJWE1FOiBDb252ZXJ0IGFsbCBvdGhl ciBwbGF0Zm9ybXMgdG8gbWF0Y2ggTWFjIGFuZCBkZWxldGUgdGhpcy4KKyAgICAgICAgICAgIC8v IEZJWE1FOiBEZWxldGUgYWZ0ZXIgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTc3NjE4PiBsYW5kcy4K ICAgICAgICAgICAgIFBhc3RlYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZSgpLT53cml0ZVNl bGVjdGlvbigqc2VsZWN0aW9uLCBjYW5TbWFydENvcHlPckRlbGV0ZSgpLCBtX2ZyYW1lLCBJbmNs dWRlSW1hZ2VBbHRUZXh0Rm9yRGF0YVRyYW5zZmVyKTsKICNlbmRpZgogICAgICAgICB9CkBAIC0x NDMzLDkgKzE0MzQsMTAgQEAgdm9pZCBFZGl0b3I6OmNvcHlJbWFnZShjb25zdCBIaXRUZXN0UmVz dWx0JiByZXN1bHQpCiAgICAgaWYgKHVybC5pc0VtcHR5KCkpCiAgICAgICAgIHVybCA9IHJlc3Vs dC5hYnNvbHV0ZUltYWdlVVJMKCk7CiAKLSNpZiBQTEFURk9STShDT0NPQSkgfHwgUExBVEZPUk0o R1RLKSB8fCBQTEFURk9STShXUEUpCisjaWYgIVBMQVRGT1JNKFdJTikKICAgICB3cml0ZUltYWdl VG9QYXN0ZWJvYXJkKCpQYXN0ZWJvYXJkOjpjcmVhdGVGb3JDb3B5QW5kUGFzdGUoKSwgKmVsZW1l bnQsIHVybCwgcmVzdWx0LmFsdERpc3BsYXlTdHJpbmcoKSk7CiAjZWxzZQorICAgIC8vIEZJWE1F OiBEZWxldGUgYWZ0ZXIgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTc3NjE4PiBsYW5kcy4KICAgICBQ YXN0ZWJvYXJkOjpjcmVhdGVGb3JDb3B5QW5kUGFzdGUoKS0+d3JpdGVJbWFnZSgqZWxlbWVudCwg dXJsLCByZXN1bHQuYWx0RGlzcGxheVN0cmluZygpKTsKICNlbmRpZgogfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv RWRpdG9yLmgKaW5kZXggM2MwZmVlYTY3MzguLjg0NDA1Y2I5YjdmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv RWRpdG9yLmgKQEAgLTQ3OSw3ICs0NzksNyBAQCBwdWJsaWM6CiAgICAgV0VCQ09SRV9FWFBPUlQg dm9pZCByZXBsYWNlU2VsZWN0aW9uV2l0aEF0dHJpYnV0ZWRTdHJpbmcoTlNBdHRyaWJ1dGVkU3Ry aW5nICosIE1haWxCbG9ja3F1b3RlSGFuZGxpbmcgPSBNYWlsQmxvY2txdW90ZUhhbmRsaW5nOjpS ZXNwZWN0QmxvY2txdW90ZSk7CiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKENPQ09BKSB8fCBQTEFU Rk9STShHVEspIHx8IFBMQVRGT1JNKFdQRSkKKyNpZiAhUExBVEZPUk0oV0lOKQogICAgIFdFQkNP UkVfRVhQT1JUIHZvaWQgd3JpdGVTZWxlY3Rpb25Ub1Bhc3RlYm9hcmQoUGFzdGVib2FyZCYpOwog ICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgd3JpdGVJbWFnZVRvUGFzdGVib2FyZChQYXN0ZWJvYXJk JiwgRWxlbWVudCYgaW1hZ2VFbGVtZW50LCBjb25zdCBVUkwmLCBjb25zdCBTdHJpbmcmIHRpdGxl KTsKICAgICB2b2lkIHdyaXRlU2VsZWN0aW9uKFBhc3RlYm9hcmRXcml0ZXJEYXRhJik7Cg==