177610 2017-09-28 10:56:54 -0700 Small cleanup in RenderMenuList::didUpdateActiveOption 2017-10-02 12:34:46 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue darin dino simon.fraser webkit-bug-importer zalan oldest_to_newest 1354195 0 zalan 2017-09-28 10:56:54 -0700 m_lastActiveIndex should be optional. 1354197 1 322100 zalan 2017-09-28 10:58:15 -0700 Created attachment 322100 Patch 1354202 2 322100 dino 2017-09-28 11:09:12 -0700 Comment on attachment 322100 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322100&action=review > Source/WebCore/rendering/RenderMenuList.cpp:431 > + if (m_lastActiveIndex && m_lastActiveIndex == optionIndex) You learn something every day! I didn't know you could auto cast optional<int> if you used ==. 1354206 3 322102 zalan 2017-09-28 11:21:32 -0700 Created attachment 322102 Patch 1354224 4 322102 commit-queue 2017-09-28 11:50:08 -0700 Comment on attachment 322102 Patch Clearing flags on attachment: 322102 Committed r222621: <http://trac.webkit.org/changeset/222621> 1354225 5 commit-queue 2017-09-28 11:50:10 -0700 All reviewed patches have been landed. Closing bug. 1354227 6 webkit-bug-importer 2017-09-28 11:51:23 -0700 <rdar://problem/34720479> 1354926 7 322102 darin 2017-09-30 15:12:21 -0700 Comment on attachment 322102 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322102&action=review > Source/WebCore/rendering/RenderMenuList.cpp:425 > + if (!AXObjectCache::accessibilityEnabled()) > return; I don’t think we need this. existingAXObjectCache will return nullptr if accessibility is not enabled. 1354928 8 322100 darin 2017-09-30 15:14:40 -0700 Comment on attachment 322100 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322100&action=review >> Source/WebCore/rendering/RenderMenuList.cpp:431 >> + if (m_lastActiveIndex && m_lastActiveIndex == optionIndex) > > You learn something every day! I didn't know you could auto cast optional<int> if you used ==. There’s no need for the first half of the predicate here. A missing value will always compare as not equal, so this can just be: if (m_lastActiveIndex == optionIndex) return; > Source/WebCore/rendering/RenderMenuList.cpp:439 > + if (AccessibilityMenuList* menuList = downcast<AccessibilityMenuList>(axCache->get(this))) Seems like a good place to use auto. 1355404 9 zalan 2017-10-02 12:34:46 -0700 Committed r222733: <http://trac.webkit.org/changeset/222733> 322100 2017-09-28 10:58:15 -0700 2017-09-28 11:21:31 -0700 Patch bug-177610-20170928105814.patch text/plain 3107 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWNkYzE5NzgwZDhlODk1 NDcyYjhmZjFlMDBmMTRhZjA3YTAxNzRjNi4uY2M1NGM5MzUyYWE5MGVhZWFkMGU1ZTVlYmRiYTA0 MWQzOGYzM2I3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA5LTI4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU21hbGwgY2xlYW51cCBpbiBS ZW5kZXJNZW51TGlzdDo6ZGlkVXBkYXRlQWN0aXZlT3B0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc2MTAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4K KworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJNZW51TGlzdC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJNZW51TGlzdDo6UmVuZGVyTWVudUxpc3QpOgorICAgICAgICAoUmVuZGVyTWVu dUxpc3Q6OmRpZFVwZGF0ZUFjdGl2ZU9wdGlvbik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ck1lbnVMaXN0Lmg6CisKIDIwMTctMDktMjcgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBEZWZlcnJlZCBpbWFnZSBzaXplIGNoYW5nZSBtYWtlcyBpbWFnZS1sb2Fk LW9uLWRlbGF5Lmh0bWwgZmxha3kuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTWVudUxpc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1l bnVMaXN0LmNwcAppbmRleCBmMjkyYjU3OTdhYzc5MWM0MDU2ZjZmZGY5YWQ5NzYzMTdjMmM3NzNi Li4xYmQ1YjAxN2E0OWE5OWIwNzk3MzQwNjg3ZjBkMTYxZjg1NWEwZjg4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWVudUxpc3QuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZW51TGlzdC5jcHAKQEAgLTc1LDcgKzc1LDYgQEAgUmVu ZGVyTWVudUxpc3Q6OlJlbmRlck1lbnVMaXN0KEhUTUxTZWxlY3RFbGVtZW50JiBlbGVtZW50LCBS ZW5kZXJTdHlsZSYmIHN0eWxlKQogICAgICwgbV9pbm5lckJsb2NrKG51bGxwdHIpCiAgICAgLCBt X25lZWRzT3B0aW9uc1dpZHRoVXBkYXRlKHRydWUpCiAgICAgLCBtX29wdGlvbnNXaWR0aCgwKQot ICAgICwgbV9sYXN0QWN0aXZlSW5kZXgoLTEpCiAjaWYgIVBMQVRGT1JNKElPUykKICAgICAsIG1f cG9wdXBJc1Zpc2libGUoZmFsc2UpCiAjZW5kaWYKQEAgLTQyMiwxMCArNDIxLDE0IEBAIHZvaWQg UmVuZGVyTWVudUxpc3Q6OmRpZFNldFNlbGVjdGVkSW5kZXgoaW50IGxpc3RJbmRleCkKIAogdm9p ZCBSZW5kZXJNZW51TGlzdDo6ZGlkVXBkYXRlQWN0aXZlT3B0aW9uKGludCBvcHRpb25JbmRleCkK IHsKLSAgICBpZiAoIUFYT2JqZWN0Q2FjaGU6OmFjY2Vzc2liaWxpdHlFbmFibGVkKCkgfHwgIWRv Y3VtZW50KCkuZXhpc3RpbmdBWE9iamVjdENhY2hlKCkpCisgICAgaWYgKCFBWE9iamVjdENhY2hl OjphY2Nlc3NpYmlsaXR5RW5hYmxlZCgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAobV9s YXN0QWN0aXZlSW5kZXggPT0gb3B0aW9uSW5kZXgpCisgICAgYXV0byogYXhDYWNoZSA9IGRvY3Vt ZW50KCkuZXhpc3RpbmdBWE9iamVjdENhY2hlKCk7CisgICAgaWYgKCFheENhY2hlKQorICAgICAg ICByZXR1cm47CisKKyAgICBpZiAobV9sYXN0QWN0aXZlSW5kZXggJiYgbV9sYXN0QWN0aXZlSW5k ZXggPT0gb3B0aW9uSW5kZXgpCiAgICAgICAgIHJldHVybjsKICAgICBtX2xhc3RBY3RpdmVJbmRl eCA9IG9wdGlvbkluZGV4OwogCkBAIC00MzMsMTAgKzQzNiw4IEBAIHZvaWQgUmVuZGVyTWVudUxp c3Q6OmRpZFVwZGF0ZUFjdGl2ZU9wdGlvbihpbnQgb3B0aW9uSW5kZXgpCiAgICAgaWYgKGxpc3RJ bmRleCA8IDAgfHwgbGlzdEluZGV4ID49IHN0YXRpY19jYXN0PGludD4oc2VsZWN0RWxlbWVudCgp Lmxpc3RJdGVtcygpLnNpemUoKSkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmIChBWE9iamVj dENhY2hlKiBjYWNoZSA9IGRvY3VtZW50KCkuZXhpc3RpbmdBWE9iamVjdENhY2hlKCkpIHsKLSAg ICAgICAgaWYgKEFjY2Vzc2liaWxpdHlNZW51TGlzdCogbWVudUxpc3QgPSBkb3duY2FzdDxBY2Nl c3NpYmlsaXR5TWVudUxpc3Q+KGNhY2hlLT5nZXQodGhpcykpKQotICAgICAgICAgICAgbWVudUxp c3QtPmRpZFVwZGF0ZUFjdGl2ZU9wdGlvbihvcHRpb25JbmRleCk7Ci0gICAgfQorICAgIGlmIChB Y2Nlc3NpYmlsaXR5TWVudUxpc3QqIG1lbnVMaXN0ID0gZG93bmNhc3Q8QWNjZXNzaWJpbGl0eU1l bnVMaXN0PihheENhY2hlLT5nZXQodGhpcykpKQorICAgICAgICBtZW51TGlzdC0+ZGlkVXBkYXRl QWN0aXZlT3B0aW9uKG9wdGlvbkluZGV4KTsKIH0KIAogU3RyaW5nIFJlbmRlck1lbnVMaXN0Ojpp dGVtVGV4dCh1bnNpZ25lZCBsaXN0SW5kZXgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTWVudUxpc3QuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJNZW51TGlzdC5oCmluZGV4IGVjNDZiYWJhYWQxYzM5MzRjM2IxMTQxODI3MWUyOTlh YzZlMTkyZDUuLmVlYTAxNWZlYmE4MTZmMTE4NDY5NTU5YjY1MGY4NTFiZGYyZGYwYjggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZW51TGlzdC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZW51TGlzdC5oCkBAIC0xNDMsNyArMTQzLDcg QEAgcHJpdmF0ZToKICAgICBib29sIG1fbmVlZHNPcHRpb25zV2lkdGhVcGRhdGU7CiAgICAgaW50 IG1fb3B0aW9uc1dpZHRoOwogCi0gICAgaW50IG1fbGFzdEFjdGl2ZUluZGV4OworICAgIHN0ZDo6 b3B0aW9uYWw8aW50PiBtX2xhc3RBY3RpdmVJbmRleDsKIAogICAgIHN0ZDo6dW5pcXVlX3B0cjxS ZW5kZXJTdHlsZT4gbV9vcHRpb25TdHlsZTsKIAo= 322102 2017-09-28 11:21:32 -0700 2017-09-28 11:50:08 -0700 Patch bug-177610-20170928112131.patch text/plain 3106 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWNkYzE5NzgwZDhlODk1 NDcyYjhmZjFlMDBmMTRhZjA3YTAxNzRjNi4uZTNkYWZjZjg1ODJkMzJiZTZjYjM1YTM0MWFiYzlk MGUzNzViMjRjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA5LTI4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU21hbGwgY2xlYW51cCBpbiBS ZW5kZXJNZW51TGlzdDo6ZGlkVXBkYXRlQWN0aXZlT3B0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc2MTAKKworICAgICAgICBSZXZpZXdlZCBi eSBEZWFuIEphY2tzb24uCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkuCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTWVudUxpc3QuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyTWVudUxpc3Q6OlJlbmRlck1lbnVMaXN0KToKKyAgICAgICAgKFJlbmRlck1lbnVM aXN0OjpkaWRVcGRhdGVBY3RpdmVPcHRpb24pOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJN ZW51TGlzdC5oOgorCiAyMDE3LTA5LTI3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+ CiAKICAgICAgICAgRGVmZXJyZWQgaW1hZ2Ugc2l6ZSBjaGFuZ2UgbWFrZXMgaW1hZ2UtbG9hZC1v bi1kZWxheS5odG1sIGZsYWt5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck1lbnVMaXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZW51 TGlzdC5jcHAKaW5kZXggZjI5MmI1Nzk3YWM3OTFjNDA1NmY2ZmRmOWFkOTc2MzE3YzJjNzczYi4u YmJjZmNlNDBmMGVhN2FjNWU4NmYzOTU0YjMxYmZkNTlhYzFlZWI4NSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTWVudUxpc3QuY3BwCkBAIC03NSw3ICs3NSw2IEBAIFJlbmRl ck1lbnVMaXN0OjpSZW5kZXJNZW51TGlzdChIVE1MU2VsZWN0RWxlbWVudCYgZWxlbWVudCwgUmVu ZGVyU3R5bGUmJiBzdHlsZSkKICAgICAsIG1faW5uZXJCbG9jayhudWxscHRyKQogICAgICwgbV9u ZWVkc09wdGlvbnNXaWR0aFVwZGF0ZSh0cnVlKQogICAgICwgbV9vcHRpb25zV2lkdGgoMCkKLSAg ICAsIG1fbGFzdEFjdGl2ZUluZGV4KC0xKQogI2lmICFQTEFURk9STShJT1MpCiAgICAgLCBtX3Bv cHVwSXNWaXNpYmxlKGZhbHNlKQogI2VuZGlmCkBAIC00MjIsMTAgKzQyMSwxNCBAQCB2b2lkIFJl bmRlck1lbnVMaXN0OjpkaWRTZXRTZWxlY3RlZEluZGV4KGludCBsaXN0SW5kZXgpCiAKIHZvaWQg UmVuZGVyTWVudUxpc3Q6OmRpZFVwZGF0ZUFjdGl2ZU9wdGlvbihpbnQgb3B0aW9uSW5kZXgpCiB7 Ci0gICAgaWYgKCFBWE9iamVjdENhY2hlOjphY2Nlc3NpYmlsaXR5RW5hYmxlZCgpIHx8ICFkb2N1 bWVudCgpLmV4aXN0aW5nQVhPYmplY3RDYWNoZSgpKQorICAgIGlmICghQVhPYmplY3RDYWNoZTo6 YWNjZXNzaWJpbGl0eUVuYWJsZWQoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKG1fbGFz dEFjdGl2ZUluZGV4ID09IG9wdGlvbkluZGV4KQorICAgIGF1dG8qIGF4Q2FjaGUgPSBkb2N1bWVu dCgpLmV4aXN0aW5nQVhPYmplY3RDYWNoZSgpOworICAgIGlmICghYXhDYWNoZSkKKyAgICAgICAg cmV0dXJuOworCisgICAgaWYgKG1fbGFzdEFjdGl2ZUluZGV4ICYmICptX2xhc3RBY3RpdmVJbmRl eCA9PSBvcHRpb25JbmRleCkKICAgICAgICAgcmV0dXJuOwogICAgIG1fbGFzdEFjdGl2ZUluZGV4 ID0gb3B0aW9uSW5kZXg7CiAKQEAgLTQzMywxMCArNDM2LDggQEAgdm9pZCBSZW5kZXJNZW51TGlz dDo6ZGlkVXBkYXRlQWN0aXZlT3B0aW9uKGludCBvcHRpb25JbmRleCkKICAgICBpZiAobGlzdElu ZGV4IDwgMCB8fCBsaXN0SW5kZXggPj0gc3RhdGljX2Nhc3Q8aW50PihzZWxlY3RFbGVtZW50KCku bGlzdEl0ZW1zKCkuc2l6ZSgpKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKEFYT2JqZWN0 Q2FjaGUqIGNhY2hlID0gZG9jdW1lbnQoKS5leGlzdGluZ0FYT2JqZWN0Q2FjaGUoKSkgewotICAg ICAgICBpZiAoQWNjZXNzaWJpbGl0eU1lbnVMaXN0KiBtZW51TGlzdCA9IGRvd25jYXN0PEFjY2Vz c2liaWxpdHlNZW51TGlzdD4oY2FjaGUtPmdldCh0aGlzKSkpCi0gICAgICAgICAgICBtZW51TGlz dC0+ZGlkVXBkYXRlQWN0aXZlT3B0aW9uKG9wdGlvbkluZGV4KTsKLSAgICB9CisgICAgaWYgKEFj Y2Vzc2liaWxpdHlNZW51TGlzdCogbWVudUxpc3QgPSBkb3duY2FzdDxBY2Nlc3NpYmlsaXR5TWVu dUxpc3Q+KGF4Q2FjaGUtPmdldCh0aGlzKSkpCisgICAgICAgIG1lbnVMaXN0LT5kaWRVcGRhdGVB Y3RpdmVPcHRpb24ob3B0aW9uSW5kZXgpOwogfQogCiBTdHJpbmcgUmVuZGVyTWVudUxpc3Q6Oml0 ZW1UZXh0KHVuc2lnbmVkIGxpc3RJbmRleCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJNZW51TGlzdC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck1lbnVMaXN0LmgKaW5kZXggZWM0NmJhYmFhZDFjMzkzNGMzYjExNDE4MjcxZTI5OWFj NmUxOTJkNS4uZWVhMDE1ZmViYTgxNmYxMTg0Njk1NTliNjUwZjg1MWJkZjJkZjBiOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmgKQEAgLTE0Myw3ICsxNDMsNyBA QCBwcml2YXRlOgogICAgIGJvb2wgbV9uZWVkc09wdGlvbnNXaWR0aFVwZGF0ZTsKICAgICBpbnQg bV9vcHRpb25zV2lkdGg7CiAKLSAgICBpbnQgbV9sYXN0QWN0aXZlSW5kZXg7CisgICAgc3RkOjpv cHRpb25hbDxpbnQ+IG1fbGFzdEFjdGl2ZUluZGV4OwogCiAgICAgc3RkOjp1bmlxdWVfcHRyPFJl bmRlclN0eWxlPiBtX29wdGlvblN0eWxlOwogCg==