177597 2017-09-28 01:34:59 -0700 Speedometer 2.0: Listen for changes to individual attributes in Backbone suite 2017-09-28 18:10:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 167652 1 shiyu.zhang webkit-unassigned addyo lforschler mathias rniwa oldest_to_newest 1354062 0 322072 shiyu.zhang 2017-09-28 01:34:59 -0700 Created attachment 322072 Patch for backbone model change binding Backbone implementation used to trigger render function twice if a new item is created as reported in https://github.com/tastejs/todomvc/issues/469. A workaround is to filter out the render invocation caused by 'id' change as https://github.com/tastejs/todomvc/pull/755 did. I think there is a more decent way to fix this issure by binding listeners to specific attributes change of the model. In this way, we only listen to the model attributes that we really care and ignore the 'id' change. It's also more efficient to write specific listeners for different model attributes ('completed' and 'title') change instead of re-rendering the whole todo item once the mode changes. The performance of backbone suite improved 8% after applying this patch. 1354394 1 rniwa 2017-09-28 18:10:46 -0700 No. Please stop making optimizations to the benchmark. We shouldn't be making the benchmark faster. We should be making the browser engines faster. 322072 2017-09-28 01:34:59 -0700 2017-09-28 01:34:59 -0700 Patch for backbone model change binding backbone-svn.pat text/plain 2248 shiyu.zhang SW5kZXg6IHJlc291cmNlcy90b2RvbXZjL2FyY2hpdGVjdHVyZS1leGFtcGxlcy9iYWNrYm9uZS9q cy92aWV3cy90b2RvLXZpZXcuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcmVzb3VyY2VzL3RvZG9tdmMvYXJj aGl0ZWN0dXJlLWV4YW1wbGVzL2JhY2tib25lL2pzL3ZpZXdzL3RvZG8tdmlldy5qcwkocmV2aXNp b24gMjIyNjA1KQorKysgcmVzb3VyY2VzL3RvZG9tdmMvYXJjaGl0ZWN0dXJlLWV4YW1wbGVzL2Jh Y2tib25lL2pzL3ZpZXdzL3RvZG8tdmlldy5qcwkod29ya2luZyBjb3B5KQpAQCAtMzAsMzEgKzMw LDI5IEBACiAgICAgICAgIC8vICoqVG9kb1ZpZXcqKiBpbiB0aGlzIGFwcCwgd2Ugc2V0IGEgZGly ZWN0IHJlZmVyZW5jZSBvbiB0aGUgbW9kZWwgZm9yCiAgICAgICAgIC8vIGNvbnZlbmllbmNlLgog ICAgICAgICBpbml0aWFsaXplOiBmdW5jdGlvbiAoKSB7Ci0gICAgICAgICAgICB0aGlzLmxpc3Rl blRvKHRoaXMubW9kZWwsICdjaGFuZ2UnLCB0aGlzLnJlbmRlcik7CisgICAgICAgICAgICB0aGlz Lmxpc3RlblRvKHRoaXMubW9kZWwsICdjaGFuZ2U6Y29tcGxldGVkJywgdGhpcy5yZW5kZXJUb2dn bGUpOworICAgICAgICAgICAgdGhpcy5saXN0ZW5Ubyh0aGlzLm1vZGVsLCAnY2hhbmdlOnRpdGxl JywgdGhpcy5yZW5kZXJUaXRsZSk7CiAgICAgICAgICAgICB0aGlzLmxpc3RlblRvKHRoaXMubW9k ZWwsICdkZXN0cm95JywgdGhpcy5yZW1vdmUpOwogICAgICAgICAgICAgdGhpcy5saXN0ZW5Ubyh0 aGlzLm1vZGVsLCAndmlzaWJsZScsIHRoaXMudG9nZ2xlVmlzaWJsZSk7CiAgICAgICAgIH0sCiAK LSAgICAgICAgLy8gUmUtcmVuZGVyIHRoZSB0aXRsZXMgb2YgdGhlIHRvZG8gaXRlbS4KICAgICAg ICAgcmVuZGVyOiBmdW5jdGlvbiAoKSB7Ci0gICAgICAgICAgICAvLyBCYWNrYm9uZSBMb2NhbFN0 b3JhZ2UgaXMgYWRkaW5nIGBpZGAgYXR0cmlidXRlIGluc3RhbnRseSBhZnRlcgotICAgICAgICAg ICAgLy8gY3JlYXRpbmcgYSBtb2RlbC4gIFRoaXMgY2F1c2VzIG91ciBUb2RvVmlldyB0byByZW5k ZXIgdHdpY2UuIE9uY2UKLSAgICAgICAgICAgIC8vIGFmdGVyIGNyZWF0aW5nIGEgbW9kZWwgYW5k IG9uY2Ugb24gYGlkYCBjaGFuZ2UuICBXZSB3YW50IHRvCi0gICAgICAgICAgICAvLyBmaWx0ZXIg b3V0IHRoZSBzZWNvbmQgcmVkdW5kYW50IHJlbmRlciwgd2hpY2ggaXMgY2F1c2VkIGJ5IHRoaXMK LSAgICAgICAgICAgIC8vIGBpZGAgY2hhbmdlLiAgSXQncyBrbm93biBCYWNrYm9uZSBMb2NhbFN0 b3JhZ2UgYnVnLCB0aGVyZWZvcmUKLSAgICAgICAgICAgIC8vIHdlJ3ZlIHRvIGNyZWF0ZSBhIHdv cmthcm91bmQuCi0gICAgICAgICAgICAvLyBodHRwczovL2dpdGh1Yi5jb20vdGFzdGVqcy90b2Rv bXZjL2lzc3Vlcy80NjkKLSAgICAgICAgICAgIGlmICh0aGlzLm1vZGVsLmNoYW5nZWQuaWQgIT09 IHVuZGVmaW5lZCkgewotICAgICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgICAgIH0KLQog ICAgICAgICAgICAgdGhpcy4kZWwuaHRtbCh0aGlzLnRlbXBsYXRlKHRoaXMubW9kZWwudG9KU09O KCkpKTsKLSAgICAgICAgICAgIHRoaXMuJGVsLnRvZ2dsZUNsYXNzKCdjb21wbGV0ZWQnLCB0aGlz Lm1vZGVsLmdldCgnY29tcGxldGVkJykpOwotICAgICAgICAgICAgdGhpcy50b2dnbGVWaXNpYmxl KCk7CiAgICAgICAgICAgICB0aGlzLiRpbnB1dCA9IHRoaXMuJCgnLmVkaXQnKTsKICAgICAgICAg ICAgIHJldHVybiB0aGlzOwogICAgICAgICB9LAogCisgICAgICAgcmVuZGVyVG9nZ2xlOiBmdW5j dGlvbiAoKSB7CisgICAgICAgICAgICAgICB0aGlzLiRlbC50b2dnbGVDbGFzcygnY29tcGxldGVk JywgdGhpcy5tb2RlbC5nZXQoJ2NvbXBsZXRlZCcpKTsKKyAgICAgICAgICAgICAgIHRoaXMudG9n Z2xlVmlzaWJsZSgpOworICAgICAgICAgICAgICAgcmV0dXJuIHRoaXM7CisgICAgICAgIH0sCisK KyAgICAgICByZW5kZXJUaXRsZTogZnVuY3Rpb24gKCkgeworICAgICAgICAgICAgICAgdGhpcy4k KCdsYWJlbCcpLmh0bWwodGhpcy5tb2RlbC5nZXQoJ3RpdGxlJykpOworICAgICAgICAgICAgICAg cmV0dXJuIHRoaXM7CisgICAgICAgIH0sCisKICAgICAgICAgdG9nZ2xlVmlzaWJsZTogZnVuY3Rp b24gKCkgewogICAgICAgICAgICAgdGhpcy4kZWwudG9nZ2xlQ2xhc3MoJ2hpZGRlbicsIHRoaXMu aXNIaWRkZW4oKSk7CiAgICAgICAgIH0sCg==