177587 2017-09-27 20:05:14 -0700 Uncaught Exception: Attempted to assign to readonly property (at ContentView.js:​206:​34)​ 2017-09-27 21:21:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1354001 0 joepeck 2017-09-27 20:05:14 -0700 Uncaught Exception: Attempted to assign to readonly property (at ContentView.js:​206:​34)​ Backtrace: Attempted to assign to readonly property. (at ContentView.js:​206:​34)​ closedContentViewForRepresentedObject @ ContentView.js:​206:​34 _disassociateFromContentView @ ContentViewContainer.js:​432:​65 closeAllContentViews @ ContentViewContainer.js:​291:​46 closed @ ClusterContentView.js:​82:​56 closed @ ResourceClusterContentView.js:​146:​21 _disassociateFromContentView @ ContentViewContainer.js:​429:​27 closeAllContentViews @ ContentViewContainer.js:​291:​46 dispose @ NetworkResourceDetailView.js:​71:​71 reset @ NetworkTableContentView.js:​183:​31 _mainResourceDidChange @ NetworkTableContentView.js:​698:​19 ... It when we close any ContentView with Post Data we can get this exception since the representedObject is a string, and you can't do: str[prop] = value; in strict mode on a string... it throws this exception. 1354002 1 322059 joepeck 2017-09-27 20:08:03 -0700 Created attachment 322059 [PATCH] Proposed Fix 1354008 2 322059 mattbaker 2017-09-27 20:34:40 -0700 Comment on attachment 322059 [PATCH] Proposed Fix r=me 1354019 3 322059 commit-queue 2017-09-27 21:20:08 -0700 Comment on attachment 322059 [PATCH] Proposed Fix Clearing flags on attachment: 322059 Committed r222599: <http://trac.webkit.org/changeset/222599> 1354020 4 commit-queue 2017-09-27 21:20:10 -0700 All reviewed patches have been landed. Closing bug. 1354021 5 webkit-bug-importer 2017-09-27 21:21:17 -0700 <rdar://problem/34706004> 322059 2017-09-27 20:08:03 -0700 2017-09-27 21:20:08 -0700 [PATCH] Proposed Fix avoid-exception-1.patch text/plain 2836 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDE5ZDMzMjFhYzc5Li40ZGY2NzYyYzBiOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMgQEAKIDIwMTctMDktMjcgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBVbmNhdWdodCBFeGNl cHRpb246IEF0dGVtcHRlZCB0byBhc3NpZ24gdG8gcmVhZG9ubHkgcHJvcGVydHkgKGF0IENvbnRl bnRWaWV3LmpzOuKAizIwNjrigIszNCnigIsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NzU4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlIGFsbG93IGEgcmVwcmVzZW50ZWRPYmplY3QgdG8gYmUgYSBz dHJpbmcuIEluIHN0cmljdCBtb2RlIGF0dGVtcHRpbmcgdG8gc2V0CisgICAgICAgIGEgcHJvcGVy dHkgb24gYSBzdHJpbmcgcmVzdWx0cyBpbiBhIFR5cGVFcnJvci4gU28gd2Ugc2hvdWxkIGJlIGNh cmVmdWwgbm90IHRvCisgICAgICAgIGRvIHRoaXMgaW4gdGhlIHJhcmUgY2FzZXMgd2hlcmUgb3Vy IHJlcHJlc2VudGVkT2JqZWN0IGlzIHRoZSBhIHN0cmluZy4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvVmlld3MvQ29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5Db250ZW50Vmlldy5jb250 ZW50Vmlld0ZvclJlcHJlc2VudGVkT2JqZWN0KToKKyAgICAgICAgKFdJLkNvbnRlbnRWaWV3LmNs b3NlZENvbnRlbnRWaWV3Rm9yUmVwcmVzZW50ZWRPYmplY3QpOgorICAgICAgICBBdm9pZCBzZXR0 aW5nIGEgcHJvcGVydHkgb24gc3RyaW5ncy4gQ29udGVudFZpZXdzIGJhY2tlZCBieSBhIFN0cmlu ZyBhcmVuJ3QgdHlwaWNhbGx5CisgICAgICAgIHNoYXJlZCBhbnl3YXlzLCBzbyB0aGUgcHJvcGVy dHkgY2FzZSB3b3VsZCBub3QgYmUgdXNlZnVsLiBJZiBhIGNsaWVudCByZWFsbHkgd2FudHMKKyAg ICAgICAgdG8gc2hhcmUgdGhleSBjb3VsZCB1c2UgYG5ldyBTdHJpbmcoLi4uKWAgYXMgdGhlIHJl cHJlc2VudGVkT2JqZWN0LgorCisyMDE3LTA5LTI3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogRGV0YWlsIFZpZXdzIGZvciBy ZXNvdXJjZXMgaW4gTmV0d29yayBUYWIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3NzU1MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRWaWV3LmpzCmluZGV4IDUwMjczODRiZmMw Li45Y2E5NWEwNjVhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvQ29udGVudFZpZXcuanMKQEAgLTE5NiwxNCArMTk2LDE2IEBAIFdJ LkNvbnRlbnRWaWV3ID0gY2xhc3MgQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5WaWV3CiAgICAgICAg ICAgICByZXR1cm4gbnVsbDsKIAogICAgICAgICBjb25zb2xlLmFzc2VydChuZXdDb250ZW50Vmll dy5yZXByZXNlbnRlZE9iamVjdCA9PT0gcmVzb2x2ZWRSZXByZXNlbnRlZE9iamVjdCwgImNyZWF0 ZUZyb21SZXByZXNlbnRlZE9iamVjdCBhbmQgcmVzb2x2ZWRSZXByZXNlbnRlZE9iamVjdEZvclJl cHJlc2VudGVkT2JqZWN0IGFyZSBvdXQgb2Ygc3luYyBmb3IgdHlwZSIsIHJlcHJlc2VudGVkT2Jq ZWN0LmNvbnN0cnVjdG9yLm5hbWUpOwotICAgICAgICBuZXdDb250ZW50Vmlldy5yZXByZXNlbnRl ZE9iamVjdFtXSS5Db250ZW50Vmlldy5Db250ZW50Vmlld0ZvclJlcHJlc2VudGVkT2JqZWN0U3lt Ym9sXSA9IG5ld0NvbnRlbnRWaWV3OworICAgICAgICBpZiAodHlwZW9mIHJlc29sdmVkUmVwcmVz ZW50ZWRPYmplY3QgPT09ICJvYmplY3QiKQorICAgICAgICAgICAgbmV3Q29udGVudFZpZXcucmVw cmVzZW50ZWRPYmplY3RbV0kuQ29udGVudFZpZXcuQ29udGVudFZpZXdGb3JSZXByZXNlbnRlZE9i amVjdFN5bWJvbF0gPSBuZXdDb250ZW50VmlldzsKICAgICAgICAgcmV0dXJuIG5ld0NvbnRlbnRW aWV3OwogICAgIH0KIAogICAgIHN0YXRpYyBjbG9zZWRDb250ZW50Vmlld0ZvclJlcHJlc2VudGVk T2JqZWN0KHJlcHJlc2VudGVkT2JqZWN0KQogICAgIHsKICAgICAgICAgbGV0IHJlc29sdmVkUmVw cmVzZW50ZWRPYmplY3QgPSBXSS5Db250ZW50Vmlldy5yZXNvbHZlZFJlcHJlc2VudGVkT2JqZWN0 Rm9yUmVwcmVzZW50ZWRPYmplY3QocmVwcmVzZW50ZWRPYmplY3QpOwotICAgICAgICByZXNvbHZl ZFJlcHJlc2VudGVkT2JqZWN0W1dJLkNvbnRlbnRWaWV3LkNvbnRlbnRWaWV3Rm9yUmVwcmVzZW50 ZWRPYmplY3RTeW1ib2xdID0gbnVsbDsKKyAgICAgICAgaWYgKHR5cGVvZiByZXNvbHZlZFJlcHJl c2VudGVkT2JqZWN0ID09PSAib2JqZWN0IikKKyAgICAgICAgICAgIHJlc29sdmVkUmVwcmVzZW50 ZWRPYmplY3RbV0kuQ29udGVudFZpZXcuQ29udGVudFZpZXdGb3JSZXByZXNlbnRlZE9iamVjdFN5 bWJvbF0gPSBudWxsOwogICAgIH0KIAogICAgIHN0YXRpYyByZXNvbHZlZFJlcHJlc2VudGVkT2Jq ZWN0Rm9yUmVwcmVzZW50ZWRPYmplY3QocmVwcmVzZW50ZWRPYmplY3QpCg==