177574 2017-09-27 15:40:02 -0700 Web Inspector: Missing checks in DebuggerSidebarPanel for DOM debugging support 2017-09-27 16:55:45 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1353883 0 mattbaker 2017-09-27 15:40:02 -0700 Summary: Missing checks in DebuggerSidebarPanel for DOM debugging support. Check before using member variables that are conditionally constructed based on DOM debugging support (WI.domDebuggerManager.supported). 1353885 1 322030 mattbaker 2017-09-27 15:42:22 -0700 Created attachment 322030 Patch 1353921 2 322030 joepeck 2017-09-27 16:27:26 -0700 Comment on attachment 322030 Patch r=me 1353935 3 322030 commit-queue 2017-09-27 16:54:44 -0700 Comment on attachment 322030 Patch Clearing flags on attachment: 322030 Committed r222585: <http://trac.webkit.org/changeset/222585> 1353936 4 commit-queue 2017-09-27 16:54:46 -0700 All reviewed patches have been landed. Closing bug. 1353937 5 webkit-bug-importer 2017-09-27 16:55:45 -0700 <rdar://problem/34701913> 322030 2017-09-27 15:42:22 -0700 2017-09-27 16:54:44 -0700 Patch bug-177574-20170927154221.patch text/plain 2676 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw ZTdlMWI2Mjc2N2MxM2VjYTI5Nzg0OGQyMzcxZDU0YTA2MGViODVmLi5jZDBhZjVmNjg0YjhmMGQ1 NDZiZjNkZjcyN2ZhMmU3NjUxYTNhMjU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOSBAQAogMjAxNy0wOS0yNyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTWlzc2luZyBjaGVja3MgaW4gRGVidWdnZXJTaWRl YmFyUGFuZWwgZm9yIERPTSBkZWJ1Z2dpbmcgc3VwcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3NTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgYmVmb3JlIHVzaW5nIGNsYXNzIG1lbWJl cnMgdGhhdCBhcmUgY29uZGl0aW9uYWxseSBjb25zdHJ1Y3RlZCBiYXNlZAorICAgICAgICBvbiBE T00gZGVidWdnaW5nIHN1cHBvcnQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0Rl YnVnZ2VyU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV0kuRGVidWdnZXJTaWRlYmFyUGFuZWwu cHJvdG90eXBlLmNsb3NlZCk6CisgICAgICAgIChXSS5EZWJ1Z2dlclNpZGViYXJQYW5lbC5wcm90 b3R5cGUucmVzdG9yZVN0YXRlRnJvbUNvb2tpZSk6CisKKzIwMTctMDktMjcgIE1hdHQgQmFrZXIg IDxtYXR0YmFrZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENyZWF0ZSBS ZXNvdXJjZUNvbGxlY3Rpb25Db250ZW50VmlldyBhbmQgbWFrZSBDb2xsZWN0aW9uQ29udGVudFZp ZXcgZWFzaWVyIHRvIGV4dGVuZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc3NDE5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanMKaW5k ZXggYWIyNmMyYTcxOWE3MmM5M2EzZTY0YTVmYWE1MzFkNjVhZGM0NWNkYi4uYzc4YzMzZTI0ODgx MDcyOGI0ZGE0OGY3ZjZlNjJjMzA4ZjkwOTMyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGVidWdnZXJTaWRlYmFy UGFuZWwuanMKQEAgLTI2Nyw4ICsyNjcsMTAgQEAgV0kuRGVidWdnZXJTaWRlYmFyUGFuZWwgPSBj bGFzcyBEZWJ1Z2dlclNpZGViYXJQYW5lbCBleHRlbmRzIFdJLk5hdmlnYXRpb25TaWRlYmEKICAg ICB7CiAgICAgICAgIHN1cGVyLmNsb3NlZCgpOwogCi0gICAgICAgIHRoaXMuX2RvbUJyZWFrcG9p bnRUcmVlQ29udHJvbGxlci5kaXNjb25uZWN0KCk7Ci0gICAgICAgIHRoaXMuX2RvbUJyZWFrcG9p bnRUcmVlQ29udHJvbGxlciA9IG51bGw7CisgICAgICAgIGlmICh0aGlzLl9kb21CcmVha3BvaW50 VHJlZUNvbnRyb2xsZXIpIHsKKyAgICAgICAgICAgIHRoaXMuX2RvbUJyZWFrcG9pbnRUcmVlQ29u dHJvbGxlci5kaXNjb25uZWN0KCk7CisgICAgICAgICAgICB0aGlzLl9kb21CcmVha3BvaW50VHJl ZUNvbnRyb2xsZXIgPSBudWxsOworICAgICAgICB9CiAKICAgICAgICAgV0kuRnJhbWUucmVtb3Zl RXZlbnRMaXN0ZW5lcihudWxsLCBudWxsLCB0aGlzKTsKICAgICAgICAgV0kuZGVidWdnZXJNYW5h Z2VyLnJlbW92ZUV2ZW50TGlzdGVuZXIobnVsbCwgbnVsbCwgdGhpcyk7CkBAIC0zNzYsNyArMzc4 LDggQEAgV0kuRGVidWdnZXJTaWRlYmFyUGFuZWwgPSBjbGFzcyBEZWJ1Z2dlclNpZGViYXJQYW5l bCBleHRlbmRzIFdJLk5hdmlnYXRpb25TaWRlYmEKICAgICAgICAgZWxzZSBpZiAoY29va2llW1dJ LkRlYnVnZ2VyU2lkZWJhclBhbmVsLlNlbGVjdGVkQXNzZXJ0aW9uc0Nvb2tpZUtleV0pCiAgICAg ICAgICAgICB0aGlzLl9hc3NlcnRpb25zQnJlYWtwb2ludFRyZWVFbGVtZW50LnJldmVhbEFuZFNl bGVjdCgpOwogICAgICAgICBlbHNlIGlmIChjb29raWVbV0kuRGVidWdnZXJTaWRlYmFyUGFuZWwu U2VsZWN0ZWRBbGxSZXF1ZXN0c0Nvb2tpZUtleV0pCi0gICAgICAgICAgICB0aGlzLl94aHJCcmVh a3BvaW50VHJlZUNvbnRyb2xsZXIucmV2ZWFsQW5kU2VsZWN0KFdJLmRvbURlYnVnZ2VyTWFuYWdl ci5hbGxSZXF1ZXN0c0JyZWFrcG9pbnQpOworICAgICAgICAgICAgaWYgKHRoaXMuX3hockJyZWFr cG9pbnRUcmVlQ29udHJvbGxlcikKKyAgICAgICAgICAgICAgICB0aGlzLl94aHJCcmVha3BvaW50 VHJlZUNvbnRyb2xsZXIucmV2ZWFsQW5kU2VsZWN0KFdJLmRvbURlYnVnZ2VyTWFuYWdlci5hbGxS ZXF1ZXN0c0JyZWFrcG9pbnQpOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBzdXBlci5yZXN0 b3JlU3RhdGVGcm9tQ29va2llKGNvb2tpZSwgcmVsYXhlZE1hdGNoRGVsYXkpOwogICAgIH0K