177569 2017-09-27 14:45:05 -0700 Sync SYSTEM_MALLOC implementation of Gigacage 2017-09-28 10:37:40 -0700 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead benjamin buildbot cdumez cmarcelo commit-queue dbates fpizlo ggaren mark.lam msaboff pvollan webkit-bug-importer oldest_to_newest 1353851 0 don.olmstead 2017-09-27 14:45:05 -0700 The interface of Gigacage was changed in https://bugs.webkit.org/show_bug.cgi?id=174972 but the SYSTEM_MALLOC implementation in WTF was not updated. 1353852 1 322018 don.olmstead 2017-09-27 14:47:08 -0700 Created attachment 322018 Patch Putting up for review to make sure this is the correct fix 1353856 2 don.olmstead 2017-09-27 14:49:45 -0700 This should fix the WinCairo build which is x64 https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/6661/steps/compile-webkit/logs/stdio 1353981 3 322052 don.olmstead 2017-09-27 18:41:21 -0700 Created attachment 322052 Patch Rebasing after https://bugs.webkit.org/show_bug.cgi?id=177565 1354105 4 webkit-bug-importer 2017-09-28 07:58:07 -0700 <rdar://problem/34713975> 1354149 5 322052 mark.lam 2017-09-28 10:02:17 -0700 Comment on attachment 322052 Patch r=me if this has been tested to work. Is it tested? 1354158 6 322052 don.olmstead 2017-09-28 10:10:07 -0700 Comment on attachment 322052 Patch It was building and running locally for me. 1354180 7 322052 commit-queue 2017-09-28 10:37:37 -0700 Comment on attachment 322052 Patch Clearing flags on attachment: 322052 Committed r222615: <http://trac.webkit.org/changeset/222615> 1354181 8 commit-queue 2017-09-28 10:37:40 -0700 All reviewed patches have been landed. Closing bug. 322018 2017-09-27 14:47:08 -0700 2017-09-27 18:41:21 -0700 Patch bug-177569.diff text/plain 1859 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNjNlYWY4MTQzYjYuLmZmODUwZDc5ZDhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3 LTA5LTI3ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAg U3luYyBTWVNURU1fTUFMTE9DIGltcGxlbWVudGF0aW9uIG9mIEdpZ2FjYWdlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc1NjkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9HaWdhY2FnZS5oOgor ICAgICAgICAoR2lnYWNhZ2U6OmJhc2VQdHIpOgorICAgICAgICAoR2lnYWNhZ2U6OmJhc2VQdHJz KToKKwogMjAxNy0wOS0yNiAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUu Y29tPgogCiAgICAgICAgIEZvbGxvd3VwIChyMjIyNDI3KTogU3luY2hyb25pemVkRml4ZWRRdWV1 ZSBzaG91bGQgbm90IGhhdmUgYSBwdWJsaWMgY29uc3RydWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvd3RmL0dpZ2FjYWdlLmggYi9Tb3VyY2UvV1RGL3d0Zi9HaWdhY2FnZS5oCmluZGV4IDcx MTE4MzBhY2RmLi5jZTg0ZTMyZmIzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvR2lnYWNh Z2UuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9HaWdhY2FnZS5oCkBAIC0zMSwxMyArMzEsMjAgQEAK ICNkZWZpbmUgR0lHQUNBR0VfRU5BQkxFRCAwCiAjZGVmaW5lIFBSSU1JVElWRV9HSUdBQ0FHRV9N QVNLIDAKICNkZWZpbmUgSlNWQUxVRV9HSUdBQ0FHRV9NQVNLIDAKKyNkZWZpbmUgR0lHQUNBR0Vf QkFTRV9QVFJTX1NJWkUgODE5MgogCiBleHRlcm4gIkMiIHsKLWV4dGVybiBXVEZfRVhQT1JUREFU QSB2b2lkKiBnX2dpZ2FjYWdlQmFzZVB0cjsKK2V4dGVybiBXVEZfRVhQT1JUREFUQSBjaGFyIGdf Z2lnYWNhZ2VCYXNlUHRyc1tHSUdBQ0FHRV9CQVNFX1BUUlNfU0laRV07CiB9CiAKIG5hbWVzcGFj ZSBHaWdhY2FnZSB7CiAKK3N0cnVjdCBCYXNlUHRycyB7CisgICAgdm9pZCogcHJpbWl0aXZlOwor ICAgIHZvaWQqIGpzVmFsdWU7CisgICAgdm9pZCogc3RyaW5nOworfTsKKwogZW51bSBLaW5kIHsK ICAgICBQcmltaXRpdmUsCiAgICAgSlNWYWx1ZSwKQEAgLTcxLDkgKzc4LDIzIEBAIEFMV0FZU19J TkxJTkUgY29uc3QgY2hhciogbmFtZShLaW5kIGtpbmQpCiAgICAgcmV0dXJuIG51bGxwdHI7CiB9 CiAKLUFMV0FZU19JTkxJTkUgdm9pZComIGJhc2VQdHIoS2luZCkKK0FMV0FZU19JTkxJTkUgdm9p ZComIGJhc2VQdHIoQmFzZVB0cnMmIGJhc2VQdHJzLCBLaW5kIGtpbmQpCit7CisgICAgc3dpdGNo IChraW5kKSB7CisgICAgY2FzZSBQcmltaXRpdmU6CisgICAgICAgIHJldHVybiBiYXNlUHRycy5w cmltaXRpdmU7CisgICAgY2FzZSBKU1ZhbHVlOgorICAgICAgICByZXR1cm4gYmFzZVB0cnMuanNW YWx1ZTsKKyAgICBjYXNlIFN0cmluZzoKKyAgICAgICAgcmV0dXJuIGJhc2VQdHJzLnN0cmluZzsK KyAgICB9CisgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gYmFz ZVB0cnMucHJpbWl0aXZlOworfQorCitBTFdBWVNfSU5MSU5FIEJhc2VQdHJzJiBiYXNlUHRycygp CiB7Ci0gICAgcmV0dXJuIGdfZ2lnYWNhZ2VCYXNlUHRyOworICAgIHJldHVybiAqcmVpbnRlcnBy ZXRfY2FzdDxCYXNlUHRycyo+KGdfZ2lnYWNhZ2VCYXNlUHRycyk7CiB9CiAKIEFMV0FZU19JTkxJ TkUgc2l6ZV90IG1hc2soS2luZCkgeyByZXR1cm4gMDsgfQo= 322052 2017-09-27 18:41:21 -0700 2017-09-28 10:37:37 -0700 Patch bug-177569.diff text/plain 1688 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNGM0OGEzMDhkZWIuLjMzNGQzMjI4ZmMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3 LTA5LTI3ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAg U3luYyBTWVNURU1fTUFMTE9DIGltcGxlbWVudGF0aW9uIG9mIEdpZ2FjYWdlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc1NjkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9HaWdhY2FnZS5oOgor ICAgICAgICAoR2lnYWNhZ2U6OmJhc2VQdHIpOgorICAgICAgICAoR2lnYWNhZ2U6OmJhc2VQdHJz KToKKwogMjAxNy0wOS0yNyAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgW1dpbjY0XSBDb21waWxlIGVycm9yLCAnQmFzZVB0cnMnIGlzIHVuZGVmaW5lZC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0dpZ2FjYWdlLmggYi9Tb3VyY2UvV1RGL3d0Zi9H aWdhY2FnZS5oCmluZGV4IGQ1ZTA5NGMzMDBiLi5jZTg0ZTMyZmIzNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvR2lnYWNhZ2UuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9HaWdhY2FnZS5oCkBA IC0zMSw5ICszMSwxMCBAQAogI2RlZmluZSBHSUdBQ0FHRV9FTkFCTEVEIDAKICNkZWZpbmUgUFJJ TUlUSVZFX0dJR0FDQUdFX01BU0sgMAogI2RlZmluZSBKU1ZBTFVFX0dJR0FDQUdFX01BU0sgMAor I2RlZmluZSBHSUdBQ0FHRV9CQVNFX1BUUlNfU0laRSA4MTkyCiAKIGV4dGVybiAiQyIgewotZXh0 ZXJuIFdURl9FWFBPUlREQVRBIHZvaWQqIGdfZ2lnYWNhZ2VCYXNlUHRyOworZXh0ZXJuIFdURl9F WFBPUlREQVRBIGNoYXIgZ19naWdhY2FnZUJhc2VQdHJzW0dJR0FDQUdFX0JBU0VfUFRSU19TSVpF XTsKIH0KIAogbmFtZXNwYWNlIEdpZ2FjYWdlIHsKQEAgLTc3LDkgKzc4LDIzIEBAIEFMV0FZU19J TkxJTkUgY29uc3QgY2hhciogbmFtZShLaW5kIGtpbmQpCiAgICAgcmV0dXJuIG51bGxwdHI7CiB9 CiAKLUFMV0FZU19JTkxJTkUgdm9pZComIGJhc2VQdHIoS2luZCkKK0FMV0FZU19JTkxJTkUgdm9p ZComIGJhc2VQdHIoQmFzZVB0cnMmIGJhc2VQdHJzLCBLaW5kIGtpbmQpCiB7Ci0gICAgcmV0dXJu IGdfZ2lnYWNhZ2VCYXNlUHRyOworICAgIHN3aXRjaCAoa2luZCkgeworICAgIGNhc2UgUHJpbWl0 aXZlOgorICAgICAgICByZXR1cm4gYmFzZVB0cnMucHJpbWl0aXZlOworICAgIGNhc2UgSlNWYWx1 ZToKKyAgICAgICAgcmV0dXJuIGJhc2VQdHJzLmpzVmFsdWU7CisgICAgY2FzZSBTdHJpbmc6Cisg ICAgICAgIHJldHVybiBiYXNlUHRycy5zdHJpbmc7CisgICAgfQorICAgIFJFTEVBU0VfQVNTRVJU X05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIGJhc2VQdHJzLnByaW1pdGl2ZTsKK30KKworQUxX QVlTX0lOTElORSBCYXNlUHRycyYgYmFzZVB0cnMoKQoreworICAgIHJldHVybiAqcmVpbnRlcnBy ZXRfY2FzdDxCYXNlUHRycyo+KGdfZ2lnYWNhZ2VCYXNlUHRycyk7CiB9CiAKIEFMV0FZU19JTkxJ TkUgc2l6ZV90IG1hc2soS2luZCkgeyByZXR1cm4gMDsgfQo=