177568 2017-09-27 14:08:13 -0700 default_construct_at 2017-11-27 10:03:32 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 177473 https://bugs.webkit.org/show_bug.cgi?id=177473 P2 Normal --- 1 jfbastien jfbastien benjamin buildbot cdumez cmarcelo darin dbates jfbastien jyasskin sam oldest_to_newest 1353831 0 jfbastien 2017-09-27 14:08:13 -0700 https://bugs.webkit.org/show_bug.cgi?id=177473 has so pretty ugly code to default construct a generic ArrayPtr<T>: new (&container.get()[i]) std::remove_reference_t<decltype(*container.get())>(); Let's add default_construct_at, which jyasskin suggested I do. 1353843 1 322015 jfbastien 2017-09-27 14:10:33 -0700 Created attachment 322015 patch 1353844 2 buildbot 2017-09-27 14:12:08 -0700 Attachment 322015 did not pass style-queue: ERROR: Source/WTF/wtf/StdLibExtras.h:164: default_construct_at is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1354210 3 jfbastien 2017-09-28 11:34:43 -0700 cdumez suggested I do this change straight in #177473 and use it there. Closing to do that instead. *** This bug has been marked as a duplicate of bug 177473 *** 1374248 4 322015 darin 2017-11-22 11:30:00 -0800 Comment on attachment 322015 patch Unlike the others who commented on this, I do think this might possibly make some call sites a little easier to read, and why not get on board now if it’s the future of C++ anyway. But I don’t think we should land the change without using it anywhere. 1374249 5 darin 2017-11-22 11:30:20 -0800 Oh, this bug is obsolete. Clearing the flags. 1374976 6 jfbastien 2017-11-27 10:03:32 -0800 (In reply to Darin Adler from comment #4) > Comment on attachment 322015 [details] > patch > > Unlike the others who commented on this, I do think this might possibly make > some call sites a little easier to read, and why not get on board now if > it’s the future of C++ anyway. But I don’t think we should land the change > without using it anywhere. I liked it too, it made the sample code way more readable, but it's admittedly a rare thing so I'm happy not pushing it and leaving the obscure placement new code as-is. 322015 2017-09-27 14:10:33 -0700 2017-11-22 11:30:35 -0800 patch 0001-Add-default_construct_at.patch text/plain 1640 jfbastien RnJvbSBkMjk3YWJjYjVmNzlkMzJlOTgzNzdiNzYxZTMxOWM2ZGI2ZWZkZGM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBXZWQsIDI3IFNlcCAyMDE3IDE0OjEwOjA0IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIGRl ZmF1bHRfY29uc3RydWN0X2F0CgotLS0KIFNvdXJjZS9XVEYvQ2hhbmdlTG9nICAgICAgICAgIHwg MTAgKysrKysrKysrKwogU291cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmggfCAgNyArKysrKysr CiAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDYzZWFmODEuLmU1OTNi NTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDktMjcgIEpGIEJhc3RpZW4gIDxqZmJhc3Rp ZW5AYXBwbGUuY29tPgorCisgICAgICAgIGRlZmF1bHRfY29uc3RydWN0X2F0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc1NjgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9TdGRMaWJFeHRyYXMu aDoKKyAgICAgICAgKFdURjo6ZGVmYXVsdF9jb25zdHJ1Y3RfYXQpOiB0aGlzIG1ha2VzIGNvZGUg bW9yZSByZWFkYWJsZQorCiAyMDE3LTA5LTI2ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFs bGF3YUBhcHBsZS5jb20+CiAKICAgICAgICAgRm9sbG93dXAgKHIyMjI0MjcpOiBTeW5jaHJvbml6 ZWRGaXhlZFF1ZXVlIHNob3VsZCBub3QgaGF2ZSBhIHB1YmxpYyBjb25zdHJ1Y3RvcgpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmggYi9Tb3VyY2UvV1RGL3d0Zi9TdGRM aWJFeHRyYXMuaAppbmRleCAxMmUzOTNhLi5kN2VmYWJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9TdGRMaWJFeHRyYXMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaApA QCAtMTYwLDYgKzE2MCwxMiBAQCBpbmxpbmUgVG9UeXBlIHNhZmVDYXN0KEZyb21UeXBlIHZhbHVl KQogICAgIHJldHVybiBzdGF0aWNfY2FzdDxUb1R5cGU+KHZhbHVlKTsKIH0KIAordGVtcGxhdGU8 dHlwZW5hbWUgVD4KK2lubGluZSBUJiBkZWZhdWx0X2NvbnN0cnVjdF9hdChUKiBhZGRyKQorewor ICAgIHJldHVybiAqbmV3IChhZGRyKSBUKCk7Cit9CisKIC8vIFJldHVybnMgYSBjb3VudCBvZiB0 aGUgbnVtYmVyIG9mIGJpdHMgc2V0IGluICdiaXRzJy4KIGlubGluZSBzaXplX3QgYml0Q291bnQo dW5zaWduZWQgYml0cykKIHsKQEAgLTUzNSw2ICs1NDEsNyBAQCB1c2luZyBXVEY6OkdCOwogdXNp bmcgV1RGOjphcHByb3hpbWF0ZUJpbmFyeVNlYXJjaDsKIHVzaW5nIFdURjo6YmluYXJ5U2VhcmNo OwogdXNpbmcgV1RGOjpiaXR3aXNlX2Nhc3Q7Cit1c2luZyBXVEY6OmRlZmF1bHRfY29uc3RydWN0 X2F0OwogdXNpbmcgV1RGOjpjYWxsU3RhdGVsZXNzTGFtYmRhOwogdXNpbmcgV1RGOjpjaGVja0Fu ZFNldDsKIHVzaW5nIFdURjo6ZmluZEJpdEluV29yZDsKLS0gCjIuOS4zCgo=