177565 2017-09-27 13:34:18 -0700 [Win64] Compile error, 'BasePtrs' is undefined. 2017-09-27 18:29:19 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen benjamin bfulgham buildbot cdumez cmarcelo commit-queue dbates don.olmstead fpizlo mark.lam webkit-bug-importer oldest_to_newest 1353809 0 pvollan 2017-09-27 13:34:18 -0700 DerivedSources\WebCore\JSBasicCredential.cpp(80): error C3083: 'PropertyAttribute': the symbol to the left of a '::' must be a type 1353811 1 webkit-bug-importer 2017-09-27 13:35:11 -0700 <rdar://problem/34695516> 1353940 2 pvollan 2017-09-27 16:59:02 -0700 (In reply to Per Arne Vollan from comment #0) > DerivedSources\WebCore\JSBasicCredential.cpp(80): error C3083: > 'PropertyAttribute': the symbol to the left of a '::' must be a type This error message is a bit misleading, since it is a consequence of a Win64 JSC build failure, where 'BasePtrs' is undefined. 1353944 3 322044 pvollan 2017-09-27 17:02:13 -0700 Created attachment 322044 Patch 1353946 4 322044 mark.lam 2017-09-27 17:05:58 -0700 Comment on attachment 322044 Patch r=me 1353950 5 322044 pvollan 2017-09-27 17:08:46 -0700 Comment on attachment 322044 Patch Thanks for reviewing! 1353969 6 don.olmstead 2017-09-27 18:09:55 -0700 Looks like we both were trying to get this sorted https://bugs.webkit.org/show_bug.cgi?id=177569 1353977 7 322044 commit-queue 2017-09-27 18:29:17 -0700 Comment on attachment 322044 Patch Clearing flags on attachment: 322044 Committed r222593: <http://trac.webkit.org/changeset/222593> 1353978 8 commit-queue 2017-09-27 18:29:19 -0700 All reviewed patches have been landed. Closing bug. 322044 2017-09-27 17:02:13 -0700 2017-09-27 18:29:17 -0700 Patch bug-177565-20170928020213.patch text/plain 1054 pvollan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjI1ODYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA5LTI3ICBQZXIgQXJuZSBWb2xsYW4gIDxw dm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luNjRdIENvbXBpbGUgZXJyb3IsICdCYXNl UHRycycgaXMgdW5kZWZpbmVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc3NTY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ29weSBkZWZpbml0aW9uIG9mICdCYXNlUHRycycgZnJvbSBibWFsbG9jL0dp Z2FDYWdlLmguCisKKyAgICAgICAgKiB3dGYvR2lnYWNhZ2UuaDoKKwogMjAxNy0wOS0yNiAgU2Fp ZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAgICAgIEZvbGxv d3VwIChyMjIyNDI3KTogU3luY2hyb25pemVkRml4ZWRRdWV1ZSBzaG91bGQgbm90IGhhdmUgYSBw dWJsaWMgY29uc3RydWN0b3IKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0dpZ2FjYWdlLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dURi93dGYvR2lnYWNhZ2UuaAkocmV2aXNpb24gMjIyNTc4KQorKysg U291cmNlL1dURi93dGYvR2lnYWNhZ2UuaAkod29ya2luZyBjb3B5KQpAQCAtMzgsNiArMzgsMTIg QEAgZXh0ZXJuIFdURl9FWFBPUlREQVRBIHZvaWQqIGdfZ2lnYWNhZ2VCYQogCiBuYW1lc3BhY2Ug R2lnYWNhZ2UgewogCitzdHJ1Y3QgQmFzZVB0cnMgeworICAgIHZvaWQqIHByaW1pdGl2ZTsKKyAg ICB2b2lkKiBqc1ZhbHVlOworICAgIHZvaWQqIHN0cmluZzsKK307CisKIGVudW0gS2luZCB7CiAg ICAgUHJpbWl0aXZlLAogICAgIEpTVmFsdWUsCg==