177561 2017-09-27 12:32:05 -0700 Web Inspector: Remove unused `representedObject` parameter from GeneralTreeElementPathComponent constructor 2017-10-04 11:33:51 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1353454 0 mattbaker 2017-09-27 12:32:05 -0700 It isn't used anywhere. There also isn't a good reason for the path component to have a different represented object than the source tree element. 1353466 1 321998 mattbaker 2017-09-27 12:33:11 -0700 Created attachment 321998 Patch 1356530 2 321998 joepeck 2017-10-04 11:30:00 -0700 Comment on attachment 321998 Patch r=me 1356534 3 321998 commit-queue 2017-10-04 11:32:32 -0700 Comment on attachment 321998 Patch Clearing flags on attachment: 321998 Committed r222861: <http://trac.webkit.org/changeset/222861> 1356535 4 commit-queue 2017-10-04 11:32:33 -0700 All reviewed patches have been landed. Closing bug. 1356538 5 webkit-bug-importer 2017-10-04 11:33:51 -0700 <rdar://problem/34816375> 321998 2017-09-27 12:33:11 -0700 2017-10-04 11:32:32 -0700 Patch bug-177561-20170927123310.patch text/plain 3114 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz Y2Y5ODU4YzEwZjMwMTYxYTkyZTAyOTk4N2MyMzhkZDBiMWQ2ZDUwLi41NGQ0MzlmZDg4NGQ0ZmFi Njc5YjJkM2Y3YmI5YjVlMzk5NDQ4NTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNy0wOS0yNyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIHVudXNlZCBgcmVwcmVzZW50ZWRPYmpl Y3RgIHBhcmFtZXRlciBmcm9tIEdlbmVyYWxUcmVlRWxlbWVudFBhdGhDb21wb25lbnQgY29uc3Ry dWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NzU2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsVHJlZUVsZW1lbnRQYXRoQ29tcG9uZW50LmpzOgor ICAgICAgICAoV0kuR2VuZXJhbFRyZWVFbGVtZW50UGF0aENvbXBvbmVudCk6CisgICAgICAgIChX SS5HZW5lcmFsVHJlZUVsZW1lbnRQYXRoQ29tcG9uZW50LnByb3RvdHlwZS5nZXQgZ2VuZXJhbFRy ZWVFbGVtZW50KToKKyAgICAgICAgKFdJLkdlbmVyYWxUcmVlRWxlbWVudFBhdGhDb21wb25lbnQu cHJvdG90eXBlLmdldCBwcmV2aW91c1NpYmxpbmcpOgorICAgICAgICAoV0kuR2VuZXJhbFRyZWVF bGVtZW50UGF0aENvbXBvbmVudC5wcm90b3R5cGUuZ2V0IG5leHRTaWJsaW5nKToKKwogMjAxNy0w OS0yNyAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAg ICBbR1RLXSBXZWIgSW5zcGVjdG9yOiBBZGQgQ2FudmFzMkQuc3ZnIGFuZCBDYW52YXMzRC5zdmcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0dl bmVyYWxUcmVlRWxlbWVudFBhdGhDb21wb25lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsVHJlZUVsZW1lbnRQYXRoQ29tcG9uZW50LmpzCmlu ZGV4IDhhNTdlMzIyYjM4MzE5OGIyNTFiN2VmN2IwNzQ3YmQ2ODAxOTViN2YuLjkyMGQxMGNiZGM1 NTgyNGQwY2IyODc5NjFjZjkyM2EyYzZiZTAwZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0dlbmVyYWxUcmVlRWxlbWVudFBhdGhDb21wb25l bnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvR2Vu ZXJhbFRyZWVFbGVtZW50UGF0aENvbXBvbmVudC5qcwpAQCAtMjUsMjQgKzI1LDIxIEBACiAKIFdJ LkdlbmVyYWxUcmVlRWxlbWVudFBhdGhDb21wb25lbnQgPSBjbGFzcyBHZW5lcmFsVHJlZUVsZW1l bnRQYXRoQ29tcG9uZW50IGV4dGVuZHMgV0kuSGllcmFyY2hpY2FsUGF0aENvbXBvbmVudAogewot ICAgIGNvbnN0cnVjdG9yKGdlbmVyYWxUcmVlRWxlbWVudCwgcmVwcmVzZW50ZWRPYmplY3QpCisg ICAgY29uc3RydWN0b3IoZ2VuZXJhbFRyZWVFbGVtZW50KQogICAgIHsKLSAgICAgICAgc3VwZXIo Z2VuZXJhbFRyZWVFbGVtZW50Lm1haW5UaXRsZSwgZ2VuZXJhbFRyZWVFbGVtZW50LmNsYXNzTmFt ZXMsIHJlcHJlc2VudGVkT2JqZWN0IHx8IGdlbmVyYWxUcmVlRWxlbWVudC5yZXByZXNlbnRlZE9i amVjdCk7CisgICAgICAgIHN1cGVyKGdlbmVyYWxUcmVlRWxlbWVudC5tYWluVGl0bGUsIGdlbmVy YWxUcmVlRWxlbWVudC5jbGFzc05hbWVzLCBnZW5lcmFsVHJlZUVsZW1lbnQucmVwcmVzZW50ZWRP YmplY3QpOwogCiAgICAgICAgIHRoaXMuX2dlbmVyYWxUcmVlRWxlbWVudCA9IGdlbmVyYWxUcmVl RWxlbWVudDsKLSAgICAgICAgZ2VuZXJhbFRyZWVFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoV0ku R2VuZXJhbFRyZWVFbGVtZW50LkV2ZW50Lk1haW5UaXRsZURpZENoYW5nZSwgdGhpcy5fbWFpblRp dGxlRGlkQ2hhbmdlLCB0aGlzKTsKKyAgICAgICAgdGhpcy5fZ2VuZXJhbFRyZWVFbGVtZW50LmFk ZEV2ZW50TGlzdGVuZXIoV0kuR2VuZXJhbFRyZWVFbGVtZW50LkV2ZW50Lk1haW5UaXRsZURpZENo YW5nZSwgdGhpcy5fbWFpblRpdGxlRGlkQ2hhbmdlLCB0aGlzKTsKICAgICB9CiAKICAgICAvLyBQ dWJsaWMKIAotICAgIGdldCBnZW5lcmFsVHJlZUVsZW1lbnQoKQotICAgIHsKLSAgICAgICAgcmV0 dXJuIHRoaXMuX2dlbmVyYWxUcmVlRWxlbWVudDsKLSAgICB9CisgICAgZ2V0IGdlbmVyYWxUcmVl RWxlbWVudCgpIHsgcmV0dXJuIHRoaXMuX2dlbmVyYWxUcmVlRWxlbWVudDsgfQogCiAgICAgZ2V0 IHByZXZpb3VzU2libGluZygpCiAgICAgewotICAgICAgICB2YXIgcHJldmlvdXNTaWJsaW5nID0g dGhpcy5fZ2VuZXJhbFRyZWVFbGVtZW50LnByZXZpb3VzU2libGluZzsKKyAgICAgICAgbGV0IHBy ZXZpb3VzU2libGluZyA9IHRoaXMuX2dlbmVyYWxUcmVlRWxlbWVudC5wcmV2aW91c1NpYmxpbmc7 CiAgICAgICAgIHdoaWxlIChwcmV2aW91c1NpYmxpbmcgJiYgcHJldmlvdXNTaWJsaW5nLmhpZGRl bikKICAgICAgICAgICAgIHByZXZpb3VzU2libGluZyA9IHByZXZpb3VzU2libGluZy5wcmV2aW91 c1NpYmxpbmc7CiAKQEAgLTU0LDcgKzUxLDcgQEAgV0kuR2VuZXJhbFRyZWVFbGVtZW50UGF0aENv bXBvbmVudCA9IGNsYXNzIEdlbmVyYWxUcmVlRWxlbWVudFBhdGhDb21wb25lbnQgZXh0ZW4KIAog ICAgIGdldCBuZXh0U2libGluZygpCiAgICAgewotICAgICAgICB2YXIgbmV4dFNpYmxpbmcgPSB0 aGlzLl9nZW5lcmFsVHJlZUVsZW1lbnQubmV4dFNpYmxpbmc7CisgICAgICAgIGxldCBuZXh0U2li bGluZyA9IHRoaXMuX2dlbmVyYWxUcmVlRWxlbWVudC5uZXh0U2libGluZzsKICAgICAgICAgd2hp bGUgKG5leHRTaWJsaW5nICYmIG5leHRTaWJsaW5nLmhpZGRlbikKICAgICAgICAgICAgIG5leHRT aWJsaW5nID0gbmV4dFNpYmxpbmcubmV4dFNpYmxpbmc7CiAK