177560 2017-09-27 12:23:58 -0700 Blurry captions on retina screens. 2017-11-02 11:26:56 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jeremyj-wk jeremyj-wk commit-queue eric.carlson jer.noble webkit-bug-importer oldest_to_newest 1353348 0 jeremyj-wk 2017-09-27 12:23:58 -0700 Blurry captions on retina screens. 1353355 1 jeremyj-wk 2017-09-27 12:24:54 -0700 rdar://problem/17913388 1353420 2 321997 jeremyj-wk 2017-09-27 12:29:14 -0700 Created attachment 321997 Patch 1355944 3 321997 jer.noble 2017-10-03 12:09:03 -0700 Comment on attachment 321997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321997&action=review > Source/WebCore/html/shadow/MediaControlElements.cpp:1369 > + videoBox.setWidth(videoBox.width()*deviceScaleFactor); > + videoBox.setHeight(videoBox.height()*deviceScaleFactor); Nit: spaces around the "*". 1355946 4 322559 jeremyj-wk 2017-10-03 12:14:47 -0700 Created attachment 322559 Patch for landing 1355968 5 jeremyj-wk 2017-10-03 12:24:42 -0700 (In reply to Jer Noble from comment #3) > Comment on attachment 321997 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321997&action=review > > > Source/WebCore/html/shadow/MediaControlElements.cpp:1369 > > + videoBox.setWidth(videoBox.width()*deviceScaleFactor); > > + videoBox.setHeight(videoBox.height()*deviceScaleFactor); > > Nit: spaces around the "*". Done. 1358294 6 322559 commit-queue 2017-10-09 10:56:38 -0700 Comment on attachment 322559 Patch for landing Clearing flags on attachment: 322559 Committed r223052: <http://trac.webkit.org/changeset/223052> 321997 2017-09-27 12:29:14 -0700 2017-10-03 12:09:03 -0700 Patch bug-177560-20170927122913.patch text/plain 2578 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTlhYTc4MGQ4OGNiMzc2 YTQ1ZWVmOTQ5ODI5OTQyNmIxODE5MWQ5Ny4uZjcyZTFlNWIyMzA2YWQ4NGZjYWFmY2FkMTIyMDMw NWUxYjE3MmRmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA5LTI3ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBCbHVycnkgY2FwdGlvbnMg b24gcmV0aW5hIHNjcmVlbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzc1NjAKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTc5MTMzODgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMg YmVjYXVzZSB0aGUgY29udGVudHMgc2NhbGUgb2YgdGhlIGNhcHRpb25zIGxheWVyIGlzIG5vdCBl eHBvc2VkIHRvIHRoZSBET00uCisKKyAgICAgICAgVGhlIGNhcHRpb25zIGxheWVyIGNvbnRlbnRz IHNjYWxlIG5lZWRzIHRvIHRha2UgaW50byBhY2NvdW50IHRoZSBkZXZpY2Ugc2NyZWVuIHNjYWxl IHRvIGdldCB0aGUgY29ycmVjdCByZXNvbHV0aW9uIGZvciBjYXB0aW9ucy4KKworICAgICAgICAq IGh0bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Ok1lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ6OnVwZGF0ZVRleHRUcmFja1Jl cHJlc2VudGF0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbFRleHRUcmFja0Nv bnRhaW5lckVsZW1lbnQ6OnVwZGF0ZVNpemVzKToKKwogMjAxNy0wOC0yOCAgQ2FybG9zIEFsYmVy dG8gTG9wZXogUGVyZXogIDxjbG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBbV1BF XSBSZW5hbWUgRXZlbnRIYW5kbGVyR2xpYiB0byBFdmVudEhhbmRsZXJHTGliCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKaW5kZXgg NTQzZjYxZjllODczNTBkNTc4NmRkZDY2ZTQ3NzRlNzUzNTRiZTYxNi4uMGNkYzk0M2IxMGQ5YWY2 MGFlMzk3N2Q5MTIwNmZjZjk1YmNkN2JmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcApAQCAtMTI5Miw2ICsxMjkyLDggQEAg dm9pZCBNZWRpYUNvbnRyb2xUZXh0VHJhY2tDb250YWluZXJFbGVtZW50Ojp1cGRhdGVUZXh0VHJh Y2tSZXByZXNlbnRhdGlvbigpCiAKICAgICBpZiAoIW1fdGV4dFRyYWNrUmVwcmVzZW50YXRpb24p IHsKICAgICAgICAgbV90ZXh0VHJhY2tSZXByZXNlbnRhdGlvbiA9IFRleHRUcmFja1JlcHJlc2Vu dGF0aW9uOjpjcmVhdGUoKnRoaXMpOworICAgICAgICBpZiAoZG9jdW1lbnQoKS5wYWdlKCkpCisg ICAgICAgICAgICBtX3RleHRUcmFja1JlcHJlc2VudGF0aW9uLT5zZXRDb250ZW50U2NhbGUoZG9j dW1lbnQoKS5wYWdlKCktPmRldmljZVNjYWxlRmFjdG9yKCkpOwogICAgICAgICBtX3VwZGF0ZVRl eHRUcmFja1JlcHJlc2VudGF0aW9uU3R5bGUgPSB0cnVlOwogICAgICAgICBtZWRpYUVsZW1lbnQt PnNldFRleHRUcmFja1JlcHJlc2VudGF0aW9uKG1fdGV4dFRyYWNrUmVwcmVzZW50YXRpb24uZ2V0 KCkpOwogICAgIH0KQEAgLTEzNjAsOSArMTM2MiwxMiBAQCB2b2lkIE1lZGlhQ29udHJvbFRleHRU cmFja0NvbnRhaW5lckVsZW1lbnQ6OnVwZGF0ZVNpemVzKGJvb2wgZm9yY2VVcGRhdGUpCiAgICAg bWVkaWFFbGVtZW50LT5zeW5jVGV4dFRyYWNrQm91bmRzKCk7CiAKICAgICBJbnRSZWN0IHZpZGVv Qm94OwotICAgIGlmIChtX3RleHRUcmFja1JlcHJlc2VudGF0aW9uKQorICAgIGlmIChtX3RleHRU cmFja1JlcHJlc2VudGF0aW9uKSB7CiAgICAgICAgIHZpZGVvQm94ID0gbV90ZXh0VHJhY2tSZXBy ZXNlbnRhdGlvbi0+Ym91bmRzKCk7Ci0gICAgZWxzZSB7CisgICAgICAgIGZsb2F0IGRldmljZVNj YWxlRmFjdG9yID0gZG9jdW1lbnQoKS5wYWdlKCktPmRldmljZVNjYWxlRmFjdG9yKCk7CisgICAg ICAgIHZpZGVvQm94LnNldFdpZHRoKHZpZGVvQm94LndpZHRoKCkqZGV2aWNlU2NhbGVGYWN0b3Ip OworICAgICAgICB2aWRlb0JveC5zZXRIZWlnaHQodmlkZW9Cb3guaGVpZ2h0KCkqZGV2aWNlU2Nh bGVGYWN0b3IpOworICAgIH0gZWxzZSB7CiAgICAgICAgIGlmICghaXM8UmVuZGVyVmlkZW8+KG1l ZGlhRWxlbWVudC0+cmVuZGVyZXIoKSkpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIHZp ZGVvQm94ID0gZG93bmNhc3Q8UmVuZGVyVmlkZW8+KCptZWRpYUVsZW1lbnQtPnJlbmRlcmVyKCkp LnZpZGVvQm94KCk7Cg== 322559 2017-10-03 12:14:47 -0700 2017-10-09 10:56:38 -0700 Patch for landing bug-177560-20171003121446.patch text/plain 2577 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTlhYTc4MGQ4OGNiMzc2 YTQ1ZWVmOTQ5ODI5OTQyNmIxODE5MWQ5Ny4uMTIwNWI2M2Y1YjY1YmNkNTcyYWE1YmRmNjdkNTg1 YmIxNTFkZGY2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA5LTI3ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBCbHVycnkgY2FwdGlvbnMg b24gcmV0aW5hIHNjcmVlbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzc1NjAKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTc5MTMzODgKKworICAg ICAgICBSZXZpZXdlZCBieSBKZXIgTm9ibGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1 c2UgdGhlIGNvbnRlbnRzIHNjYWxlIG9mIHRoZSBjYXB0aW9ucyBsYXllciBpcyBub3QgZXhwb3Nl ZCB0byB0aGUgRE9NLgorCisgICAgICAgIFRoZSBjYXB0aW9ucyBsYXllciBjb250ZW50cyBzY2Fs ZSBuZWVkcyB0byB0YWtlIGludG8gYWNjb3VudCB0aGUgZGV2aWNlIHNjcmVlbiBzY2FsZSB0byBn ZXQgdGhlIGNvcnJlY3QgcmVzb2x1dGlvbiBmb3IgY2FwdGlvbnMuCisKKyAgICAgICAgKiBodG1s L3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRp YUNvbnRyb2xUZXh0VHJhY2tDb250YWluZXJFbGVtZW50Ojp1cGRhdGVUZXh0VHJhY2tSZXByZXNl bnRhdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xUZXh0VHJhY2tDb250YWlu ZXJFbGVtZW50Ojp1cGRhdGVTaXplcyk6CisKIDIwMTctMDgtMjggIENhcmxvcyBBbGJlcnRvIExv cGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gW1dQRV0gUmVu YW1lIEV2ZW50SGFuZGxlckdsaWIgdG8gRXZlbnRIYW5kbGVyR0xpYgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCmluZGV4IDU0M2Y2 MWY5ZTg3MzUwZDU3ODZkZGQ2NmU0Nzc0ZTc1MzU0YmU2MTYuLjI4Mjk4ZGYzM2JjYWJjMTVkMTUy YWIyY2JhODkyODRiN2MwMTA2N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hh ZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3No YWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKQEAgLTEyOTIsNiArMTI5Miw4IEBAIHZvaWQg TWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6dXBkYXRlVGV4dFRyYWNrUmVw cmVzZW50YXRpb24oKQogCiAgICAgaWYgKCFtX3RleHRUcmFja1JlcHJlc2VudGF0aW9uKSB7CiAg ICAgICAgIG1fdGV4dFRyYWNrUmVwcmVzZW50YXRpb24gPSBUZXh0VHJhY2tSZXByZXNlbnRhdGlv bjo6Y3JlYXRlKCp0aGlzKTsKKyAgICAgICAgaWYgKGRvY3VtZW50KCkucGFnZSgpKQorICAgICAg ICAgICAgbV90ZXh0VHJhY2tSZXByZXNlbnRhdGlvbi0+c2V0Q29udGVudFNjYWxlKGRvY3VtZW50 KCkucGFnZSgpLT5kZXZpY2VTY2FsZUZhY3RvcigpKTsKICAgICAgICAgbV91cGRhdGVUZXh0VHJh Y2tSZXByZXNlbnRhdGlvblN0eWxlID0gdHJ1ZTsKICAgICAgICAgbWVkaWFFbGVtZW50LT5zZXRU ZXh0VHJhY2tSZXByZXNlbnRhdGlvbihtX3RleHRUcmFja1JlcHJlc2VudGF0aW9uLmdldCgpKTsK ICAgICB9CkBAIC0xMzYwLDkgKzEzNjIsMTIgQEAgdm9pZCBNZWRpYUNvbnRyb2xUZXh0VHJhY2tD b250YWluZXJFbGVtZW50Ojp1cGRhdGVTaXplcyhib29sIGZvcmNlVXBkYXRlKQogICAgIG1lZGlh RWxlbWVudC0+c3luY1RleHRUcmFja0JvdW5kcygpOwogCiAgICAgSW50UmVjdCB2aWRlb0JveDsK LSAgICBpZiAobV90ZXh0VHJhY2tSZXByZXNlbnRhdGlvbikKKyAgICBpZiAobV90ZXh0VHJhY2tS ZXByZXNlbnRhdGlvbikgewogICAgICAgICB2aWRlb0JveCA9IG1fdGV4dFRyYWNrUmVwcmVzZW50 YXRpb24tPmJvdW5kcygpOwotICAgIGVsc2UgeworICAgICAgICBmbG9hdCBkZXZpY2VTY2FsZUZh Y3RvciA9IGRvY3VtZW50KCkucGFnZSgpLT5kZXZpY2VTY2FsZUZhY3RvcigpOworICAgICAgICB2 aWRlb0JveC5zZXRXaWR0aCh2aWRlb0JveC53aWR0aCgpICogZGV2aWNlU2NhbGVGYWN0b3IpOwor ICAgICAgICB2aWRlb0JveC5zZXRIZWlnaHQodmlkZW9Cb3guaGVpZ2h0KCkgKiBkZXZpY2VTY2Fs ZUZhY3Rvcik7CisgICAgfSBlbHNlIHsKICAgICAgICAgaWYgKCFpczxSZW5kZXJWaWRlbz4obWVk aWFFbGVtZW50LT5yZW5kZXJlcigpKSkKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgdmlk ZW9Cb3ggPSBkb3duY2FzdDxSZW5kZXJWaWRlbz4oKm1lZGlhRWxlbWVudC0+cmVuZGVyZXIoKSku dmlkZW9Cb3goKTsK