177520 2017-09-26 19:20:48 -0700 Deferred image size change makes image-load-on-delay.html flaky. 2017-09-27 18:38:23 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan ap bfulgham cfleizach commit-queue dino simon.fraser webkit-bug-importer zalan oldest_to_newest 1352990 0 zalan 2017-09-26 19:20:48 -0700 Related to bug 177446 1352993 1 webkit-bug-importer 2017-09-26 19:21:28 -0700 <rdar://problem/34674299> 1353908 2 322036 zalan 2017-09-27 16:05:40 -0700 Created attachment 322036 Patch 1353909 3 322036 cfleizach 2017-09-27 16:16:11 -0700 Comment on attachment 322036 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322036&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:2803 > + m_deferredRecomputeIsIgnoredList.add(element); is this a set or array? do we need to worry about duplicates being added? > Source/WebCore/accessibility/AXObjectCache.cpp:2805 > + } we could save some code if we did if (rendererNeedsDeferredUpdate(*renderer)) { m_deferredRecomputeIsIgnoredList.add(element); else recomputeIsIgnored(renderer); > Source/WebCore/rendering/RenderImage.cpp:269 > + if (AXObjectCache* cache = document().existingAXObjectCache()) are you sure you want to lose the accessibilityEnabled() check? 1353916 4 zalan 2017-09-27 16:23:21 -0700 (In reply to chris fleizach from comment #3) > Comment on attachment 322036 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322036&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:2803 > > + m_deferredRecomputeIsIgnoredList.add(element); > > is this a set or array? do we need to worry about duplicates being added? It's a set. Dupes are fine. > > > Source/WebCore/accessibility/AXObjectCache.cpp:2805 > > + } > > we could save some code if we did > > if (rendererNeedsDeferredUpdate(*renderer)) { > m_deferredRecomputeIsIgnoredList.add(element); > else > recomputeIsIgnored(renderer); > I don't mind doing that but in WebCore we prefer early returns (unless it has changed). > > Source/WebCore/rendering/RenderImage.cpp:269 > > + if (AXObjectCache* cache = document().existingAXObjectCache()) > > are you sure you want to lose the accessibilityEnabled() check? Not sure how much that helps and if you look at all the call sites, they don't really check for that (not even the hot ones). 1353919 5 322039 zalan 2017-09-27 16:25:47 -0700 Created attachment 322039 Patch 1353979 6 322039 commit-queue 2017-09-27 18:38:21 -0700 Comment on attachment 322039 Patch Clearing flags on attachment: 322039 Committed r222594: <http://trac.webkit.org/changeset/222594> 1353980 7 commit-queue 2017-09-27 18:38:23 -0700 All reviewed patches have been landed. Closing bug. 322036 2017-09-27 16:05:40 -0700 2017-09-27 16:25:45 -0700 Patch bug-177520-20170927160539.patch text/plain 6584 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTZlNDY5MzBlODM5Yjll NTU4ZGNjZTc3YTY2N2I0MTJiNTIzMGY5MS4uMjJmMDIyNjMzNWFmODRjMDZlMGUzY2FlMzJmZjY1 MGE2NDU4YmMxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA5LTI3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgRGVmZXJyZWQgaW1hZ2Ugc2l6 ZSBjaGFuZ2UgbWFrZXMgaW1hZ2UtbG9hZC1vbi1kZWxheS5odG1sIGZsYWt5LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3NTIwCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zNDY3NDI5OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBPbmx5IGRlZmVyIHJlY29tcHV0ZUlzSWdub3JlZCB3aGVuIHRoZSBp bWFnZSBjaGFuZ2UgYWN0dWFsbHkgdHJpZ2dlcnMgbGF5b3V0LiAKKworICAgICAgICAqIGFjY2Vz c2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZW5kZXJlck5l ZWRzRGVmZXJyZWRVcGRhdGUpOgorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6ZGVm ZXJSZWNvbXB1dGVJc0lnbm9yZWRJZk5lZWRlZCk6CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVj dENhY2hlOjpkZWZlclRleHRDaGFuZ2VkSWZOZWVkZWQpOgorICAgICAgICAqIGFjY2Vzc2liaWxp dHkvQVhPYmplY3RDYWNoZS5oOgorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6ZGVm ZXJSZWNvbXB1dGVJc0lnbm9yZWRJZk5lZWRlZCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckltYWdlOjppbWFnZUNoYW5nZWQp OgorCiAyMDE3LTA5LTI3ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZWYgZWxlbWVudCBrZXlzIGluIENTU0FuaW1hdGlvbkNvbnRyb2xsZXJQcml2YXRlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3Bw IGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcAppbmRleCBj MjE3MWFkZjEyMjhhOTliZDNlMTdkODQyMzIzOWEwOTdiNzgzYTNiLi41ZWQ4NjJlNDVlNzA2MDRh MjJjMmJlYWY5NjdkMDFkZDg0ODY3MThhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQVhPYmplY3RDYWNoZS5jcHAKQEAgLTI3ODMsNiArMjc4MywyOSBAQCB2b2lkIEFYT2Jq ZWN0Q2FjaGU6OnBlcmZvcm1EZWZlcnJlZENhY2hlVXBkYXRlKCkKICAgICBtX2RlZmVycmVkUmVj b21wdXRlSXNJZ25vcmVkTGlzdC5jbGVhcigpOwogfQogCitzdGF0aWMgYm9vbCByZW5kZXJlck5l ZWRzRGVmZXJyZWRVcGRhdGUoUmVuZGVyT2JqZWN0JiByZW5kZXJlcikKK3sKKyAgICBBU1NFUlQo IXJlbmRlcmVyLmJlaW5nRGVzdHJveWVkKCkpOworICAgIGF1dG8mIGRvY3VtZW50ID0gcmVuZGVy ZXIuZG9jdW1lbnQoKTsKKyAgICByZXR1cm4gcmVuZGVyZXIubmVlZHNMYXlvdXQoKSB8fCBkb2N1 bWVudC5uZWVkc1N0eWxlUmVjYWxjKCkgfHwgZG9jdW1lbnQuaW5SZW5kZXJUcmVlVXBkYXRlKCkg fHwgKGRvY3VtZW50LnZpZXcoKSAmJiBkb2N1bWVudC52aWV3KCktPmlzSW5SZW5kZXJUcmVlTGF5 b3V0KCkpOworfQorCit2b2lkIEFYT2JqZWN0Q2FjaGU6OmRlZmVyUmVjb21wdXRlSXNJZ25vcmVk SWZOZWVkZWQoRWxlbWVudCogZWxlbWVudCkKK3sKKyAgICBpZiAoIWVsZW1lbnQpCisgICAgICAg IHJldHVybjsKKworICAgIGF1dG8qIHJlbmRlcmVyID0gZWxlbWVudC0+cmVuZGVyZXIoKTsKKyAg ICBpZiAoIXJlbmRlcmVyIHx8IHJlbmRlcmVyLT5iZWluZ0Rlc3Ryb3llZCgpKQorICAgICAgICBy ZXR1cm47CisKKyAgICBpZiAocmVuZGVyZXJOZWVkc0RlZmVycmVkVXBkYXRlKCpyZW5kZXJlcikp IHsKKyAgICAgICAgbV9kZWZlcnJlZFJlY29tcHV0ZUlzSWdub3JlZExpc3QuYWRkKGVsZW1lbnQp OworICAgICAgICByZXR1cm47CisgICAgfQorICAgIHJlY29tcHV0ZUlzSWdub3JlZChyZW5kZXJl cik7Cit9CisKIHZvaWQgQVhPYmplY3RDYWNoZTo6ZGVmZXJSZWNvbXB1dGVJc0lnbm9yZWQoRWxl bWVudCogZWxlbWVudCkKIHsKICAgICBpZiAoIWVsZW1lbnQpCkBAIC0yNzk5LDEyICsyODIyLDEx IEBAIHZvaWQgQVhPYmplY3RDYWNoZTo6ZGVmZXJUZXh0Q2hhbmdlZElmTmVlZGVkKE5vZGUqIG5v ZGUpCiAgICAgaWYgKCFub2RlKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAobm9kZS0+cmVu ZGVyZXIoKSAmJiBub2RlLT5yZW5kZXJlcigpLT5iZWluZ0Rlc3Ryb3llZCgpKQorICAgIGF1dG8q IHJlbmRlcmVyID0gbm9kZS0+cmVuZGVyZXIoKTsKKyAgICBpZiAocmVuZGVyZXIgJiYgcmVuZGVy ZXItPmJlaW5nRGVzdHJveWVkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGF1dG8mIGRvY3Vt ZW50ID0gbm9kZS0+ZG9jdW1lbnQoKTsKLSAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGp1c3QgZGVm ZXIgYWxsIHRleHQgY2hhbmdlcy4KLSAgICBpZiAoZG9jdW1lbnQubmVlZHNTdHlsZVJlY2FsYygp IHx8IGRvY3VtZW50LmluUmVuZGVyVHJlZVVwZGF0ZSgpIHx8IChkb2N1bWVudC52aWV3KCkgJiYg ZG9jdW1lbnQudmlldygpLT5pc0luUmVuZGVyVHJlZUxheW91dCgpKSkgeworICAgIGlmIChyZW5k ZXJlciAmJiByZW5kZXJlck5lZWRzRGVmZXJyZWRVcGRhdGUoKnJlbmRlcmVyKSkgewogICAgICAg ICBtX2RlZmVycmVkVGV4dENoYW5nZWRMaXN0LmFkZChub2RlKTsKICAgICAgICAgcmV0dXJuOwog ICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RD YWNoZS5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmgKaW5k ZXggN2VkZjY0OWU0N2RlYjZlYzdhY2Y2YmEwMmIwOGUxMDMyYTE0MTdiZi4uNzg4ZmI3NDY0NDE2 MmViMTM2MTQwNzc2ZmJhMGZlMDNkN2NmOWUxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BWE9iamVjdENhY2hlLmgKQEAgLTMyOSw2ICszMjksNyBAQCBwdWJsaWM6CiAjaWYg UExBVEZPUk0oTUFDKQogICAgIHN0YXRpYyB2b2lkIHNldFNob3VsZFJlcG9zdE5vdGlmaWNhdGlv bnNGb3JUZXN0cyhib29sIHZhbHVlKTsKICNlbmRpZgorICAgIHZvaWQgZGVmZXJSZWNvbXB1dGVJ c0lnbm9yZWRJZk5lZWRlZChFbGVtZW50Kik7CiAgICAgdm9pZCBkZWZlclJlY29tcHV0ZUlzSWdu b3JlZChFbGVtZW50Kik7CiAgICAgdm9pZCBkZWZlclRleHRDaGFuZ2VkSWZOZWVkZWQoTm9kZSop OwogICAgIHZvaWQgcGVyZm9ybURlZmVycmVkQ2FjaGVVcGRhdGUoKTsKQEAgLTQ4Niw2ICs0ODcs NyBAQCBpbmxpbmUgdm9pZCBBWE9iamVjdENhY2hlOjpjaGVja2VkU3RhdGVDaGFuZ2VkKE5vZGUq KSB7IH0KIGlubGluZSB2b2lkIEFYT2JqZWN0Q2FjaGU6OmNoaWxkcmVuQ2hhbmdlZChBY2Nlc3Np YmlsaXR5T2JqZWN0KikgeyB9CiBpbmxpbmUgdm9pZCBBWE9iamVjdENhY2hlOjpjaGlsZHJlbkNo YW5nZWQoTm9kZSosIE5vZGUqKSB7IH0KIGlubGluZSB2b2lkIEFYT2JqZWN0Q2FjaGU6OmNoaWxk cmVuQ2hhbmdlZChSZW5kZXJPYmplY3QqLCBSZW5kZXJPYmplY3QqKSB7IH0KK2lubGluZSB2b2lk IEFYT2JqZWN0Q2FjaGU6OmRlZmVyUmVjb21wdXRlSXNJZ25vcmVkSWZOZWVkZWQoRWxlbWVudCop IHsgfQogaW5saW5lIHZvaWQgQVhPYmplY3RDYWNoZTo6ZGVmZXJSZWNvbXB1dGVJc0lnbm9yZWQo RWxlbWVudCopIHsgfQogaW5saW5lIHZvaWQgQVhPYmplY3RDYWNoZTo6ZGVmZXJUZXh0Q2hhbmdl ZElmTmVlZGVkKE5vZGUqKSB7IH0KIGlubGluZSB2b2lkIEFYT2JqZWN0Q2FjaGU6OmRldGFjaFdy YXBwZXIoQWNjZXNzaWJpbGl0eU9iamVjdCosIEFjY2Vzc2liaWxpdHlEZXRhY2htZW50VHlwZSkg eyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckltYWdlLmNwcAppbmRleCAxODY2YmZk MWY1ZDg3MDFmNjExNjhhNGVhZmRhNzg4ZjY1MzBjMDQ1Li5mNzM1MzY5NTE1NzUzOWFlNzJjMDNm NDU0MTM3N2FkYWI1MTc4ZWVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVySW1hZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFn ZS5jcHAKQEAgLTI2NSwxMyArMjY1LDkgQEAgdm9pZCBSZW5kZXJJbWFnZTo6aW1hZ2VDaGFuZ2Vk KFdyYXBwZWRJbWFnZVB0ciBuZXdJbWFnZSwgY29uc3QgSW50UmVjdCogcmVjdCkKICAgICAgICAg fQogICAgICAgICBpbWFnZVNpemVDaGFuZ2UgPSBzZXRJbWFnZVNpemVGb3JBbHRUZXh0KGNhY2hl ZEltYWdlKCkpOwogICAgIH0KLQotICAgIGlmIChVTkxJS0VMWShBWE9iamVjdENhY2hlOjphY2Nl c3NpYmlsaXR5RW5hYmxlZCgpKSkgewotICAgICAgICBpZiAoQVhPYmplY3RDYWNoZSogY2FjaGUg PSBkb2N1bWVudCgpLmV4aXN0aW5nQVhPYmplY3RDYWNoZSgpKQotICAgICAgICAgICAgY2FjaGUt PmRlZmVyUmVjb21wdXRlSXNJZ25vcmVkKGVsZW1lbnQoKSk7Ci0gICAgfQotCiAgICAgcmVwYWlu dE9yTWFya0ZvckxheW91dChpbWFnZVNpemVDaGFuZ2UsIHJlY3QpOworICAgIGlmIChBWE9iamVj dENhY2hlKiBjYWNoZSA9IGRvY3VtZW50KCkuZXhpc3RpbmdBWE9iamVjdENhY2hlKCkpCisgICAg ICAgIGNhY2hlLT5kZWZlclJlY29tcHV0ZUlzSWdub3JlZElmTmVlZGVkKGVsZW1lbnQoKSk7CiB9 CiAKIHZvaWQgUmVuZGVySW1hZ2U6OnVwZGF0ZUludHJpbnNpY1NpemVJZk5lZWRlZChjb25zdCBM YXlvdXRTaXplJiBuZXdTaXplKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg4NzZlNjc2NzVkNmU5NmEzNDk0YjY0ZTMzY2Jj NWE0YjI1ZTJhNDcuLmQzMTc3MDg2OWY4Y2UwOTM0NTI4ZjhiNTk5NjUzNzViMTdiZTUxNmEgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wOS0yNyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBw bGUuY29tPgorCisgICAgICAgIERlZmVycmVkIGltYWdlIHNpemUgY2hhbmdlIG1ha2VzIGltYWdl LWxvYWQtb24tZGVsYXkuaHRtbCBmbGFreS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NzUyMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzQ2NzQy OTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNy0wOS0yNyAgQW50dGkgS29pdmlz dG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIyMjA0MCk6IENy YXNoIG5hdmlnYXRpbmcgb3V0IG9mIGdmeWNhdC5jb20gdXJsCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDM2NDQzZTgzNTA5Y2RmYmVlMjdhNzU0ZjAwMGFl YmY5ZjEzNmFhMDEuLmQwYzg5OTI4MTNlYmU2YjBmYTk0MWRhNDY3ZTVjMDg3ZDY4ZDA3YzEgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xNzcwLDUgKzE3 NzAsMyBAQCB3ZWJraXQub3JnL2IvMTc3MzE5IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvaHRtbC9zZW1hbnRpY3MvZm9ybXMvdGhlLWZvcgogd2Via2l0Lm9yZy9iLzE3NzMyMiBbIERl YnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9kb2N1 bWVudC1tZXRhZGF0YS90aGUtbWV0YS1lbGVtZW50L3ByYWdtYS1kaXJlY3RpdmVzL2F0dHItbWV0 YS1odHRwLWVxdWl2LXJlZnJlc2gvcGFyc2luZy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAogd2Vi a2l0Lm9yZy9iLzE3NzMyMyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL3Nl Y3VyaXR5L2VtYmVkZGVkLWNyZWRlbnRpYWxzLnRlbnRhdGl2ZS5zdWIuaHRtbCBbIFBhc3MgRmFp bHVyZSBdCi0KLXdlYmtpdC5vcmcvYi8xNzc1MjAgYWNjZXNzaWJpbGl0eS9pbWFnZS1sb2FkLW9u LWRlbGF5Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQo= 322039 2017-09-27 16:25:47 -0700 2017-09-27 18:38:21 -0700 Patch bug-177520-20170927162546.patch text/plain 6584 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGRlMTMwYmIzMjgxMWY2 NzFmNzQxNzI2YTZlZTcyOWEwODA2YjlkNS4uYzE0OGM4ZDcyZDlkY2RlOWRiZjIxNmZkMjk0MTQy NTMxYjJjODZmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA5LTI3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgRGVmZXJyZWQgaW1hZ2Ugc2l6 ZSBjaGFuZ2UgbWFrZXMgaW1hZ2UtbG9hZC1vbi1kZWxheS5odG1sIGZsYWt5LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3NTIwCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zNDY3NDI5OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBPbmx5IGRlZmVyIHJlY29tcHV0ZUlzSWdub3JlZCB3aGVuIHRoZSBp bWFnZSBjaGFuZ2UgYWN0dWFsbHkgdHJpZ2dlcnMgbGF5b3V0LiAKKworICAgICAgICAqIGFjY2Vz c2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZW5kZXJlck5l ZWRzRGVmZXJyZWRVcGRhdGUpOgorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6ZGVm ZXJSZWNvbXB1dGVJc0lnbm9yZWRJZk5lZWRlZCk6CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVj dENhY2hlOjpkZWZlclRleHRDaGFuZ2VkSWZOZWVkZWQpOgorICAgICAgICAqIGFjY2Vzc2liaWxp dHkvQVhPYmplY3RDYWNoZS5oOgorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6ZGVm ZXJSZWNvbXB1dGVJc0lnbm9yZWRJZk5lZWRlZCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckltYWdlOjppbWFnZUNoYW5nZWQp OgorCiAyMDE3LTA5LTI3ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CiAKICAgICAgICAgIlRhZyIgY29kZXBvaW50cyByZXF1aXJlIHRoZSBjb21wbGV4IHRleHQgY29k ZXBhdGgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RD YWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3Bw CmluZGV4IGMyMTcxYWRmMTIyOGE5OWJkM2UxN2Q4NDIzMjM5YTA5N2I3ODNhM2IuLjVlZDg2MmU0 NWU3MDYwNGEyMmMyYmVhZjk2N2QwMWRkODQ4NjcxOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcApAQCAtMjc4Myw2ICsyNzgzLDI5IEBAIHZv aWQgQVhPYmplY3RDYWNoZTo6cGVyZm9ybURlZmVycmVkQ2FjaGVVcGRhdGUoKQogICAgIG1fZGVm ZXJyZWRSZWNvbXB1dGVJc0lnbm9yZWRMaXN0LmNsZWFyKCk7CiB9CiAKK3N0YXRpYyBib29sIHJl bmRlcmVyTmVlZHNEZWZlcnJlZFVwZGF0ZShSZW5kZXJPYmplY3QmIHJlbmRlcmVyKQoreworICAg IEFTU0VSVCghcmVuZGVyZXIuYmVpbmdEZXN0cm95ZWQoKSk7CisgICAgYXV0byYgZG9jdW1lbnQg PSByZW5kZXJlci5kb2N1bWVudCgpOworICAgIHJldHVybiByZW5kZXJlci5uZWVkc0xheW91dCgp IHx8IGRvY3VtZW50Lm5lZWRzU3R5bGVSZWNhbGMoKSB8fCBkb2N1bWVudC5pblJlbmRlclRyZWVV cGRhdGUoKSB8fCAoZG9jdW1lbnQudmlldygpICYmIGRvY3VtZW50LnZpZXcoKS0+aXNJblJlbmRl clRyZWVMYXlvdXQoKSk7Cit9CisKK3ZvaWQgQVhPYmplY3RDYWNoZTo6ZGVmZXJSZWNvbXB1dGVJ c0lnbm9yZWRJZk5lZWRlZChFbGVtZW50KiBlbGVtZW50KQoreworICAgIGlmICghZWxlbWVudCkK KyAgICAgICAgcmV0dXJuOworCisgICAgYXV0byogcmVuZGVyZXIgPSBlbGVtZW50LT5yZW5kZXJl cigpOworICAgIGlmICghcmVuZGVyZXIgfHwgcmVuZGVyZXItPmJlaW5nRGVzdHJveWVkKCkpCisg ICAgICAgIHJldHVybjsKKworICAgIGlmIChyZW5kZXJlck5lZWRzRGVmZXJyZWRVcGRhdGUoKnJl bmRlcmVyKSkgeworICAgICAgICBtX2RlZmVycmVkUmVjb21wdXRlSXNJZ25vcmVkTGlzdC5hZGQo ZWxlbWVudCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisgICAgcmVjb21wdXRlSXNJZ25vcmVk KHJlbmRlcmVyKTsKK30KKwogdm9pZCBBWE9iamVjdENhY2hlOjpkZWZlclJlY29tcHV0ZUlzSWdu b3JlZChFbGVtZW50KiBlbGVtZW50KQogewogICAgIGlmICghZWxlbWVudCkKQEAgLTI3OTksMTIg KzI4MjIsMTEgQEAgdm9pZCBBWE9iamVjdENhY2hlOjpkZWZlclRleHRDaGFuZ2VkSWZOZWVkZWQo Tm9kZSogbm9kZSkKICAgICBpZiAoIW5vZGUpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmIChu b2RlLT5yZW5kZXJlcigpICYmIG5vZGUtPnJlbmRlcmVyKCktPmJlaW5nRGVzdHJveWVkKCkpCisg ICAgYXV0byogcmVuZGVyZXIgPSBub2RlLT5yZW5kZXJlcigpOworICAgIGlmIChyZW5kZXJlciAm JiByZW5kZXJlci0+YmVpbmdEZXN0cm95ZWQoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgYXV0 byYgZG9jdW1lbnQgPSBub2RlLT5kb2N1bWVudCgpOwotICAgIC8vIEZJWE1FOiBXZSBzaG91bGQg anVzdCBkZWZlciBhbGwgdGV4dCBjaGFuZ2VzLgotICAgIGlmIChkb2N1bWVudC5uZWVkc1N0eWxl UmVjYWxjKCkgfHwgZG9jdW1lbnQuaW5SZW5kZXJUcmVlVXBkYXRlKCkgfHwgKGRvY3VtZW50LnZp ZXcoKSAmJiBkb2N1bWVudC52aWV3KCktPmlzSW5SZW5kZXJUcmVlTGF5b3V0KCkpKSB7CisgICAg aWYgKHJlbmRlcmVyICYmIHJlbmRlcmVyTmVlZHNEZWZlcnJlZFVwZGF0ZSgqcmVuZGVyZXIpKSB7 CiAgICAgICAgIG1fZGVmZXJyZWRUZXh0Q2hhbmdlZExpc3QuYWRkKG5vZGUpOwogICAgICAgICBy ZXR1cm47CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B WE9iamVjdENhY2hlLmggYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2Fj aGUuaAppbmRleCA3ZWRmNjQ5ZTQ3ZGViNmVjN2FjZjZiYTAyYjA4ZTEwMzJhMTQxN2JmLi43ODhm Yjc0NjQ0MTYyZWIxMzYxNDA3NzZmYmEwZmUwM2Q3Y2Y5ZTFkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaApAQCAtMzI5LDYgKzMyOSw3IEBAIHB1Ymxp YzoKICNpZiBQTEFURk9STShNQUMpCiAgICAgc3RhdGljIHZvaWQgc2V0U2hvdWxkUmVwb3N0Tm90 aWZpY2F0aW9uc0ZvclRlc3RzKGJvb2wgdmFsdWUpOwogI2VuZGlmCisgICAgdm9pZCBkZWZlclJl Y29tcHV0ZUlzSWdub3JlZElmTmVlZGVkKEVsZW1lbnQqKTsKICAgICB2b2lkIGRlZmVyUmVjb21w dXRlSXNJZ25vcmVkKEVsZW1lbnQqKTsKICAgICB2b2lkIGRlZmVyVGV4dENoYW5nZWRJZk5lZWRl ZChOb2RlKik7CiAgICAgdm9pZCBwZXJmb3JtRGVmZXJyZWRDYWNoZVVwZGF0ZSgpOwpAQCAtNDg2 LDYgKzQ4Nyw3IEBAIGlubGluZSB2b2lkIEFYT2JqZWN0Q2FjaGU6OmNoZWNrZWRTdGF0ZUNoYW5n ZWQoTm9kZSopIHsgfQogaW5saW5lIHZvaWQgQVhPYmplY3RDYWNoZTo6Y2hpbGRyZW5DaGFuZ2Vk KEFjY2Vzc2liaWxpdHlPYmplY3QqKSB7IH0KIGlubGluZSB2b2lkIEFYT2JqZWN0Q2FjaGU6OmNo aWxkcmVuQ2hhbmdlZChOb2RlKiwgTm9kZSopIHsgfQogaW5saW5lIHZvaWQgQVhPYmplY3RDYWNo ZTo6Y2hpbGRyZW5DaGFuZ2VkKFJlbmRlck9iamVjdCosIFJlbmRlck9iamVjdCopIHsgfQoraW5s aW5lIHZvaWQgQVhPYmplY3RDYWNoZTo6ZGVmZXJSZWNvbXB1dGVJc0lnbm9yZWRJZk5lZWRlZChF bGVtZW50KikgeyB9CiBpbmxpbmUgdm9pZCBBWE9iamVjdENhY2hlOjpkZWZlclJlY29tcHV0ZUlz SWdub3JlZChFbGVtZW50KikgeyB9CiBpbmxpbmUgdm9pZCBBWE9iamVjdENhY2hlOjpkZWZlclRl eHRDaGFuZ2VkSWZOZWVkZWQoTm9kZSopIHsgfQogaW5saW5lIHZvaWQgQVhPYmplY3RDYWNoZTo6 ZGV0YWNoV3JhcHBlcihBY2Nlc3NpYmlsaXR5T2JqZWN0KiwgQWNjZXNzaWJpbGl0eURldGFjaG1l bnRUeXBlKSB7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJ bWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCmluZGV4 IDRjYWE2NmVlMDllMDljN2MzZGMyNzhkNjhhZjg1MTc1MGIzMmQxOTIuLmNiZTMxNTI5MzM0MDcx MDJmNDk2OWRjMDZjZmYxNGE5ZGEzOWMwZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJJbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckltYWdlLmNwcApAQCAtMjY1LDEzICsyNjUsOSBAQCB2b2lkIFJlbmRlckltYWdlOjppbWFn ZUNoYW5nZWQoV3JhcHBlZEltYWdlUHRyIG5ld0ltYWdlLCBjb25zdCBJbnRSZWN0KiByZWN0KQog ICAgICAgICB9CiAgICAgICAgIGltYWdlU2l6ZUNoYW5nZSA9IHNldEltYWdlU2l6ZUZvckFsdFRl eHQoY2FjaGVkSW1hZ2UoKSk7CiAgICAgfQotCi0gICAgaWYgKFVOTElLRUxZKEFYT2JqZWN0Q2Fj aGU6OmFjY2Vzc2liaWxpdHlFbmFibGVkKCkpKSB7Ci0gICAgICAgIGlmIChBWE9iamVjdENhY2hl KiBjYWNoZSA9IGRvY3VtZW50KCkuZXhpc3RpbmdBWE9iamVjdENhY2hlKCkpCi0gICAgICAgICAg ICBjYWNoZS0+ZGVmZXJSZWNvbXB1dGVJc0lnbm9yZWQoZWxlbWVudCgpKTsKLSAgICB9Ci0KICAg ICByZXBhaW50T3JNYXJrRm9yTGF5b3V0KGltYWdlU2l6ZUNoYW5nZSwgcmVjdCk7CisgICAgaWYg KEFYT2JqZWN0Q2FjaGUqIGNhY2hlID0gZG9jdW1lbnQoKS5leGlzdGluZ0FYT2JqZWN0Q2FjaGUo KSkKKyAgICAgICAgY2FjaGUtPmRlZmVyUmVjb21wdXRlSXNJZ25vcmVkSWZOZWVkZWQoZWxlbWVu dCgpKTsKIH0KIAogdm9pZCBSZW5kZXJJbWFnZTo6dXBkYXRlSW50cmluc2ljU2l6ZUlmTmVlZGVk KGNvbnN0IExheW91dFNpemUmIG5ld1NpemUpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTRhMjY3ZmJmMDNkMTk1MWQyNTEy MGE2OTRiZTUxODYwN2Y0NDNiMC4uOGVkZDIyZDgyOTM4NDI0YWFiN2ZlZDdlNmEwMThkYjkwNzIx ODZmMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA5LTI3ICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgRGVmZXJyZWQgaW1hZ2Ugc2l6ZSBjaGFuZ2UgbWFr ZXMgaW1hZ2UtbG9hZC1vbi1kZWxheS5odG1sIGZsYWt5LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3NTIwCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8zNDY3NDI5OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE3LTA5LTI3ICBNYXR0 IExld2lzICA8amxld2lzM0BhcHBsZS5jb20+CiAKICAgICAgICAgTWFya2VkIGltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9icm93c2Vycy9vcmlnaW4vcmVsYXhpbmctdGhlLXNh bWUtb3JpZ2luLXJlc3RyaWN0aW9uL2RvY3VtZW50X2RvbWFpbl9zZXR0ZXJfbnVsbC50ZW50YXRp dmUuaHRtbCBhcyBmbGFreS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9U ZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlv bnMKaW5kZXggMDUyMzk1MmFmOTc0NWZmZWM2Nzc1NGY4NjhjM2VmZTQzMjI1ZjZhNS4uNjRmOTYz OTQyNGMzYjkxNTc1NmE0YzU0MGY0MjQyMGJhNmIxODQyNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE3NzEsNyArMTc3MSw1IEBAIHdlYmtpdC5vcmcv Yi8xNzczMjIgWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9z ZW1hbnRpY3MvZG9jCiAKIHdlYmtpdC5vcmcvYi8xNzczMjMgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy9mZXRjaC9zZWN1cml0eS9lbWJlZGRlZC1jcmVkZW50aWFscy50ZW50YXRpdmUu c3ViLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTc3NTIwIGFjY2Vzc2li aWxpdHkvaW1hZ2UtbG9hZC1vbi1kZWxheS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQogd2Via2l0 Lm9yZy9iLzE3NzM4OCBpbnNwZWN0b3IvY2FudmFzL3NoYWRlclByb2dyYW0tYWRkLXJlbW92ZS13 ZWJnbC5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAo=