177514 2017-09-26 16:01:02 -0700 Web Automation: overflow:hidden elements with no children are mistakenly reported as not visible 2017-09-26 17:02:06 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg cgarcia joepeck webkit-bug-importer oldest_to_newest 1352893 0 bburg 2017-09-26 16:01:02 -0700 .............. 1352894 1 bburg 2017-09-26 16:01:13 -0700 <rdar://problem/31936291> 1352896 2 321883 bburg 2017-09-26 16:03:35 -0700 Created attachment 321883 Patch 1352900 3 321883 joepeck 2017-09-26 16:14:27 -0700 Comment on attachment 321883 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321883&action=review r=me > Source/WebKit/ChangeLog:12 > + to check for the case where the element has no children and return 'false'. I'd use backticks `false` to avoid string confusion, but this is a ChangeLog after all, so whatever. 1352925 4 bburg 2017-09-26 17:02:06 -0700 Committed r222536: <http://trac.webkit.org/changeset/222536> 321883 2017-09-26 16:03:35 -0700 2017-09-26 16:59:46 -0700 Patch bug-177514-20170926160335.patch text/plain 1786 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdjNWE5ZmU5ZjdjNTZhZTY5 YjdjYzJkOGYyNWU0YmU3YTM4Y2JhMjcuLmFmOWMwZTA2NTRiZTc1YzA3ZjEyMzk0MmZlMjliMjQ3 YTkyYzJmYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDktMjYgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEF1dG9tYXRpb246IG92ZXJmbG93 OmhpZGRlbiBlbGVtZW50cyB3aXRoIG5vIGNoaWxkcmVuIGFyZSBtaXN0YWtlbmx5IHJlcG9ydGVk IGFzIG5vdCB2aXNpYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzc1MTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMxOTM2MjkxPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0F1 dG9tYXRpb24vYXRvbXMvRWxlbWVudERpc3BsYXllZC5qczoKKyAgICAgICAgKGlzU2hvd24uaXNF bGVtZW50U3VidHJlZUhpZGRlbkJ5T3ZlcmZsb3cpOgorICAgICAgICBBcnJheS5wcm90b3R5cGUu ZXZlcnkgcmV0dXJucyB0cnVlIHdoZW4gcGFzc2VkIGFuIGVtcHR5IGxpc3QsIHNvIHdlIG5lZWQK KyAgICAgICAgdG8gY2hlY2sgZm9yIHRoZSBjYXNlIHdoZXJlIHRoZSBlbGVtZW50IGhhcyBubyBj aGlsZHJlbiBhbmQgcmV0dXJuICdmYWxzZScuCisKIDIwMTctMDktMjIgIEJyaWFuIEJ1cmcgIDxi YnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEF1dG9tYXRpb246IGFkZCBjb21tYW5kcyB0 byBnZXQgYW5kIHNldCB1c2VyIHBlcm1pc3Npb25zIGZvciBwYWdlcyBpbiBhbiBhdXRvbWF0aW9u IHNlc3Npb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0F1dG9tYXRpb24v YXRvbXMvRWxlbWVudERpc3BsYXllZC5qcyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0F1dG9t YXRpb24vYXRvbXMvRWxlbWVudERpc3BsYXllZC5qcwppbmRleCAyYWY0OWJhMWNjNDQxMTY5NTE1 ZDY5ZTdiMzBjNDU5N2UxOWIwNmRmLi5hNmVjOWYzYjVkYjdiNWVkMTExNjY5MmJlY2RiYmNjNjgy YmMyZmRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXRvbWF0aW9uL2F0 b21zL0VsZW1lbnREaXNwbGF5ZWQuanMKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0 b21hdGlvbi9hdG9tcy9FbGVtZW50RGlzcGxheWVkLmpzCkBAIC0xMzIsNiArMTMyLDkgQEAgZnVu Y3Rpb24gaXNTaG93bihlbGVtZW50KSB7CiAgICAgICAgIGlmICghZWxlbWVudE92ZXJmbG93c0Nv bnRhaW5lcihlbGVtZW50KSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgICAgICBp ZiAoIWVsZW1lbnQuY2hpbGROb2Rlcy5sZW5ndGgpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CisKICAgICAgICAgLy8gVGhpcyBlbGVtZW50J3Mgc3VidHJlZSBpcyBoaWRkZW4gYnkgb3ZlcmZs b3cgaWYgYWxsIGNoaWxkIHN1YnRyZWVzIGFyZSBhcyB3ZWxsLgogICAgICAgICByZXR1cm4gQXJy YXkuZnJvbShlbGVtZW50LmNoaWxkTm9kZXMpLmV2ZXJ5KChjaGlsZE5vZGUpID0+IHsKICAgICAg ICAgICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB0aGUgY2hpbGQgbm9kZSBpcyBvdmVyZmxvd2VkIG9y IG90aGVyd2lzZSBoaWRkZW4uCg==