177511 2017-09-26 15:33:35 -0700 Make it possible to easily get verbose ninja output from build-webkit 2017-09-27 12:14:43 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 177512 1 thorton thorton achristensen buildbot dbates keith_miller sam webkit-bug-importer oldest_to_newest 1352880 0 thorton 2017-09-26 15:33:35 -0700 Make it possible to easily get verbose ninja output from build-webkit 1352881 1 321880 thorton 2017-09-26 15:33:49 -0700 Created attachment 321880 Patch 1352926 2 321880 sam 2017-09-26 17:03:56 -0700 Comment on attachment 321880 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321880&action=review Seems fine. Kind of weird using ENV to communicate to buildCMakeGeneratedProject. Seems like passing an argument would be clearer. > Tools/ChangeLog:15 > + Add Ninja verbosity arguments to @makeArgs, which are appended > + after the -- and thus handed to ninja; the previous implementation Inconsistent on capitalization of Ninja. 1352957 3 thorton 2017-09-26 18:00:47 -0700 https://trac.webkit.org/changeset/222538/webkit 1353227 4 webkit-bug-importer 2017-09-27 12:14:43 -0700 <rdar://problem/34692854> 321880 2017-09-26 15:33:49 -0700 2017-09-26 17:03:56 -0700 Patch bug-177511-20170926153348.patch text/plain 4257 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNDg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGFkNzlkMzEwZTMzNDIyMmYxMzUyZmNjNTcxNzM4MWFm OWUxMjZjOC4uYzA2Y2RlOGM3ODczMWM2NzdiYmJjNzVkNjgwOWFhMzA4ZTlkOTk2ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE3LTA5LTI2ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgor CisgICAgICAgIE1ha2UgaXQgcG9zc2libGUgdG8gZWFzaWx5IGdldCB2ZXJib3NlIG5pbmphIG91 dHB1dCBmcm9tIGJ1aWxkLXdlYmtpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc3NTExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKyAgICAgICAgQWRkIGEgLXYv LS12ZXJib3NlIGFyZ3VtZW50IHRvIGJ1aWxkLXdlYmtpdCwgd2hpY2ggc2V0cyB0aGUgZW52aXJv bm1lbnQKKyAgICAgICAgdmFyaWFibGUgVkVSQk9TRT0xLCB3aGljaCBidWlsZENNYWtlR2VuZXJh dGVkUHJvamVjdCBhbHJlYWR5IGNoZWNrcy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGly cy5wbToKKyAgICAgICAgKGJ1aWxkQ01ha2VHZW5lcmF0ZWRQcm9qZWN0KToKKyAgICAgICAgQWRk IE5pbmphIHZlcmJvc2l0eSBhcmd1bWVudHMgdG8gQG1ha2VBcmdzLCB3aGljaCBhcmUgYXBwZW5k ZWQKKyAgICAgICAgYWZ0ZXIgdGhlIC0tIGFuZCB0aHVzIGhhbmRlZCB0byBuaW5qYTsgdGhlIHBy ZXZpb3VzIGltcGxlbWVudGF0aW9uCisgICAgICAgIChhcHBlbmRpbmcgdG8gQGFyZ3MpIHdvdWxk IG9ubHkgd29yayBpZiBAbWFrZUFyZ3Mgd2FzIG5vbi1lbXB0eSBhbmQgdGh1cworICAgICAgICB0 aGUgLS0gd2FzIGluY2x1ZGVkLgorCiAyMDE3LTA5LTI1ICBGcmVkZXJpayBSaWVkZWwgIDxyaWVk ZWxAYXBwbGUuY29tPgogCiAgICAgICAgIEV4cG9zZSB3YXkgdG8gc2V0IHZhbHVlcyBvZiBjbGFz c2lmaWVkIGZvcm0gY29udHJvbHMgYXMge0xlZ2FjeSBXZWJLaXQsIFdlYktpdH0gU1BJCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQt d2Via2l0CmluZGV4IDk5MjViMDJhZTVhNGMzODY5NTMzNjg3NWRiMzdlYWU5MTc2ZmNiNzcuLmQ3 YmE4NjA0NDZhNjRiYzg2MTQ1NjQwNjhlODM5MjhhODdjZjRmYzcgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CkBA IC01MSw2ICs1MSw3IEBAIG15ICRvcmlnaW5hbFdvcmtpbmdEaXJlY3RvcnkgPSBnZXRjd2QoKTsK IGNoZGlyV2ViS2l0KCk7CiAKIG15ICRzaG93SGVscCA9IDA7CitteSAkdmVyYm9zZSA9IDA7CiBt eSAkY2xlYW4gPSAwOwogbXkgJGRlZmF1bHRDTWFrZUZlYXR1cmVzID0gMDsKIG15ICRtaW5pbWFs ID0gMDsKQEAgLTg4LDYgKzg5LDcgQEAgbXkgJHByb2dyYW1OYW1lID0gYmFzZW5hbWUoJDApOwog bXkgJHVzYWdlID0gPDxFT0Y7CiBVc2FnZTogJHByb2dyYW1OYW1lIFtvcHRpb25zXSBbb3B0aW9u cyB0byBwYXNzIHRvIGJ1aWxkIHN5c3RlbV0KICAgLS1oZWxwICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFNob3cgdGhpcyBoZWxwIG1lc3NhZ2UKKyAgLS12ZXJib3NlICAgICAgICAgICAgICAg ICAgICAgICAgIFNob3cgdmVyYm9zZSBidWlsZCBvdXRwdXQKICAgLS1jbGVhbiAgICAgICAgICAg ICAgICAgICAgICAgICAgIENsZWFudXAgdGhlIGJ1aWxkIGRpcmVjdG9yeQogICAtLWdlbmVyYXRl LXByb2plY3Qtb25seSAgICAgICAgICAgT25seSBnZW5lcmF0ZSBwcm9qZWN0IGZpbGVzCiAgIC0t ZGVidWcgICAgICAgICAgICAgICAgICAgICAgICAgICBDb21waWxlIHdpdGggRGVidWcgY29uZmln dXJhdGlvbgpAQCAtMTE5LDYgKzEyMSw3IEBAIEVPRgogCiBteSAlb3B0aW9ucyA9ICgKICAgICAn aGVscCcgPT4gXCRzaG93SGVscCwKKyAgICAndnx2ZXJib3NlJyA9PiBcJHZlcmJvc2UsCiAgICAg J2NsZWFuJyA9PiBcJGNsZWFuLAogICAgICdpbnN0YWxsLWhlYWRlcnM9cycgPT4gXCRpbnN0YWxs SGVhZGVycywKICAgICAnaW5zdGFsbC1saWJzPXMnID0+IFwkaW5zdGFsbExpYnMsCkBAIC0xNDYs NiArMTQ5LDggQEAgaWYgKCRzaG93SGVscCkgewogICAgZXhpdCAxOwogfQogCiskRU5WeydWRVJC T1NFJ30gPSAxIGlmICR2ZXJib3NlOworCiBjaGVja1JlcXVpcmVkU3lzdGVtQ29uZmlnKCk7CiBz ZXRDb25maWd1cmF0aW9uKCk7CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBjMjUxZmQ4MjAxMDlhZmE4 ODk5NTliZThjMWFkODM5ZWE5YzczYmMwLi40ZDdiYzZlNWQ2NmZlZjc5NTIyZGVjMGZhMjg3YmNh MmQwODc3YmEzIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0yMTA0LDMxICsyMTA0LDMxIEBAIHN1YiBn ZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdAogCiBzdWIgYnVpbGRDTWFrZUdlbmVy YXRlZFByb2plY3QoJCkKIHsKLSAgICBteSAoJG1ha2VBcmdzKSA9IEBfOworICAgIG15IChAbWFr ZUFyZ3MpID0gQF87CiAgICAgbXkgJGNvbmZpZyA9IGNvbmZpZ3VyYXRpb24oKTsKICAgICBteSAk YnVpbGRQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKGJhc2VQcm9kdWN0RGlyKCksICRjb25maWcp OwogICAgIGlmICghIC1kICRidWlsZFBhdGgpIHsKICAgICAgICAgZGllICJNdXN0IGNhbGwgZ2Vu ZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QoKSBiZWZvcmUgYnVpbGRpbmcgQ01ha2Ug cHJvamVjdC4iOwogICAgIH0KIAorICAgIGlmICgkRU5We1ZFUkJPU0V9ICYmIGNhblVzZU5pbmph KCkpIHsKKyAgICAgICAgcHVzaCBAbWFrZUFyZ3MsICItdiI7CisgICAgICAgIHB1c2ggQG1ha2VB cmdzLCAiLWQga2VlcHJzcCIgaWYgKHZlcnNpb24tPnBhcnNlKGRldGVybWluZU5pbmphVmVyc2lv bigpKSA+PSB2ZXJzaW9uLT5wYXJzZSgiMS40LjAiKSk7CisgICAgfQorCiAgICAgbXkgJGNvbW1h bmQgPSAiY21ha2UiOwogICAgIG15IEBhcmdzID0gKCItLWJ1aWxkIiwgJGJ1aWxkUGF0aCwgIi0t Y29uZmlnIiwgJGNvbmZpZyk7Ci0gICAgcHVzaCBAYXJncywgKCItLSIsICRtYWtlQXJncykgaWYg JG1ha2VBcmdzOworICAgIHB1c2ggQGFyZ3MsICgiLS0iLCBAbWFrZUFyZ3MpIGlmIEBtYWtlQXJn czsKIAogICAgICMgR1RLIGFuZCBKU0NPbmx5IGNhbiB1c2UgYSBidWlsZCBzY3JpcHQgdG8gcHJl c2VydmUgY29sb3JzIGFuZCBwcmV0dHktcHJpbnRpbmcuCiAgICAgaWYgKChpc0d0aygpIHx8IGlz SlNDT25seSgpKSAmJiAtZSAiJGJ1aWxkUGF0aC9idWlsZC5zaCIpIHsKICAgICAgICAgY2hkaXIg IiRidWlsZFBhdGgiIG9yIGRpZTsKICAgICAgICAgJGNvbW1hbmQgPSAiJGJ1aWxkUGF0aC9idWls ZC5zaCI7Ci0gICAgICAgIEBhcmdzID0gKCRtYWtlQXJncyk7Ci0gICAgfQotCi0gICAgaWYgKCRF TlZ7VkVSQk9TRX0gJiYgY2FuVXNlTmluamEoKSkgewotICAgICAgICBwdXNoIEBhcmdzLCAiLXYi OwotICAgICAgICBwdXNoIEBhcmdzLCAiLWQga2VlcHJzcCIgaWYgKHZlcnNpb24tPnBhcnNlKGRl dGVybWluZU5pbmphVmVyc2lvbigpKSA+PSB2ZXJzaW9uLT5wYXJzZSgiMS40LjAiKSk7CisgICAg ICAgIEBhcmdzID0gKEBtYWtlQXJncyk7CiAgICAgfQogCiAgICAgIyBXZSBjYWxsIHN5c3RlbSgi Y21ha2UgQGFyZ3MiKSBpbnN0ZWFkIG9mIHN5c3RlbSgiY21ha2UiLCBAYXJncykgc28gdGhhdCBA YXJncyBpcwotICAgICMgcGFyc2VkIGZvciBzaGVsbCBtZXRhY2hhcmFjdGVycy4gSW4gcGFydGlj dWxhciwgJG1ha2VBcmdzIG1heSBjb250YWluIHN1Y2ggbWV0YWNoYXJhY3RlcnMuCisgICAgIyBw YXJzZWQgZm9yIHNoZWxsIG1ldGFjaGFyYWN0ZXJzLiBJbiBwYXJ0aWN1bGFyLCBAbWFrZUFyZ3Mg bWF5IGNvbnRhaW4gc3VjaCBtZXRhY2hhcmFjdGVycy4KICAgICBteSAkd3JhcHBlciA9IGpvaW4o IiAiLCB3cmFwcGVyUHJlZml4SWZOZWVkZWQoKSkgLiAiICI7CiAgICAgcmV0dXJuIHN5c3RlbVZl cmJvc2UoJHdyYXBwZXIgLiAiJGNvbW1hbmQgQGFyZ3MiKTsKIH0K