177479 2017-09-25 18:59:43 -0700 [WinCairo] Share default value of font family preferences among non-cocoa builds 2017-09-27 12:16:03 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yoshiaki.jitsukawa webkit-unassigned achristensen bfulgham commit-queue don.olmstead stephan.szabo webkit-bug-importer yoshiaki.jitsukawa Yousuke.Kimoto ysuzuki oldest_to_newest 1352553 0 yoshiaki.jitsukawa 2017-09-25 18:59:43 -0700 Currently the default font family preferences are defined for PLATFORM(COCOA) and (PLATFORM(GTK) || PLATFORM(WPE)) and there's no definitions for the other ports. It seems like we can use (PLATFORM(GTK) || PLATFORM(WPE))'s one as a default case. #if PLATFORM(COCOA) #define FOR_EACH_WEBKIT_FONT_FAMILY_PREFERENCE(macro) \ macro(StandardFontFamily, standardFontFamily, String, String, "Times", "", "") \ macro(CursiveFontFamily, cursiveFontFamily, String, String, DEFAULT_CURSIVE_FONT_FAMILY, "", "") \ macro(FantasyFontFamily, fantasyFontFamily, String, String, "Papyrus", "", "") \ macro(FixedFontFamily, fixedFontFamily, String, String, "Courier", "", "") \ macro(SansSerifFontFamily, sansSerifFontFamily, String, String, "Helvetica", "", "") \ macro(SerifFontFamily, serifFontFamily, String, String, "Times", "", "") \ macro(PictographFontFamily, pictographFontFamily, String, String, "Apple Color Emoji", "", "") \ \ #elif PLATFORM(GTK) || PLATFORM(WPE) #define FOR_EACH_WEBKIT_FONT_FAMILY_PREFERENCE(macro) \ macro(StandardFontFamily, standardFontFamily, String, String, "Times", "", "") \ macro(CursiveFontFamily, cursiveFontFamily, String, String, "Comic Sans MS", "", "") \ macro(FantasyFontFamily, fantasyFontFamily, String, String, "Impact", "", "") \ macro(FixedFontFamily, fixedFontFamily, String, String, "Courier New", "", "") \ macro(SansSerifFontFamily, sansSerifFontFamily, String, String, "Helvetica", "", "") \ macro(SerifFontFamily, serifFontFamily, String, String, "Times", "", "") \ macro(PictographFontFamily, pictographFontFamily, String, String, "Times", "", "") \ \ #endif 1352561 1 321786 yoshiaki.jitsukawa 2017-09-25 19:39:42 -0700 Created attachment 321786 Patch 1352571 2 321786 ysuzuki 2017-09-25 21:18:10 -0700 Comment on attachment 321786 Patch r=me 1352573 3 321786 commit-queue 2017-09-25 21:56:14 -0700 Comment on attachment 321786 Patch Clearing flags on attachment: 321786 Committed r222490: <http://trac.webkit.org/changeset/222490> 1352574 4 commit-queue 2017-09-25 21:56:16 -0700 All reviewed patches have been landed. Closing bug. 1353243 5 webkit-bug-importer 2017-09-27 12:16:03 -0700 <rdar://problem/34692895> 321786 2017-09-25 19:39:42 -0700 2017-09-25 21:56:14 -0700 Patch bug-177479-20170926114030.patch text/plain 1342 yoshiaki.jitsukawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDExYTdiMzJmMmU0ZTVkZDk2 MjNhYzA2NjQyYTdmODNlOTNmMjNiZTQuLjdiMDJiNGM5NmY2YWYwNzIzMDU5MmJjYzkxNDY3ZDAw ZGJlYjc3NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMDktMjUgIFlvc2hpYWtp IEppdHN1a2F3YSAgPFlvc2hpYWtpLkppdHN1a2F3YUBzb255LmNvbT4KKworICAgICAgICBbV2lu Q2Fpcm9dIFNoYXJlIGRlZmF1bHQgdmFsdWUgb2YgZm9udCBmYW1pbHkgcHJlZmVyZW5jZXMgYW1v bmcgbm9uLWNvY29hIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc3NDc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oOgorCiAyMDE3 LTA5LTI1ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJS VEMgdmlkZW8gZG9lcyBub3QgcmVzdW1lIHJlY2VpdmluZyB3aGVuIHN3aXRjaGluZyBiYWNrIHRv IFNhZmFyaSAxMSBvbiBpT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlBy ZWZlcmVuY2VzRGVmaW5pdGlvbnMuaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVu Y2VzRGVmaW5pdGlvbnMuaAppbmRleCA1N2RkZDFiMzAyY2EwYzUwZTk1NzRhZTg4N2FlMDFlYmM3 NjVhMTMwLi5jNjgyMGQ4MTU2ZGIyYjVmMjg1ODExMDIxYzgyMjcyMjY5NDg1NzBkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgKKysr IGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oCkBAIC00 MDksNyArNDA5LDcgQEAKICAgICBtYWNybyhQaWN0b2dyYXBoRm9udEZhbWlseSwgcGljdG9ncmFw aEZvbnRGYW1pbHksIFN0cmluZywgU3RyaW5nLCAiQXBwbGUgQ29sb3IgRW1vamkiLCAiIiwgIiIp IFwKICAgICBcCiAKLSNlbGlmIFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKQorI2Vsc2UK IAogI2RlZmluZSBGT1JfRUFDSF9XRUJLSVRfRk9OVF9GQU1JTFlfUFJFRkVSRU5DRShtYWNybykg XAogICAgIG1hY3JvKFN0YW5kYXJkRm9udEZhbWlseSwgc3RhbmRhcmRGb250RmFtaWx5LCBTdHJp bmcsIFN0cmluZywgIlRpbWVzIiwgIiIsICIiKSBcCg==