177441 2017-09-25 11:03:12 -0700 Building release with -DLOG_DISABLED=0 fails 2017-09-27 12:18:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=177459 InRadar P2 Normal --- 1 clopez clopez achristensen alecflett beidson bugs-noreply buildbot commit-queue darin jsbell mcatanzaro saam webkit-bug-importer ysuzuki oldest_to_newest 1352264 0 clopez 2017-09-25 11:03:12 -0700 Building WebKitGTK+ release with CXXFLAGS='-DLOG_DISABLED=0' to enable logs results in this build failure: FAILED: Source/WebCore/CMakeFiles/WebCore.dir/Modules/indexeddb/IDBObjectStore.cpp.o /usr/lib/ccache/clang++ -DBUILDING_GTK__=1 [....] Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:427:116: error: use of undeclared identifier 'loggingString' LOG(IndexedDB, "IDBObjectStore::createIndex %s (keyPath: %s, unique: %i, multiEntry: %i)", name.utf8().data(), loggingString(keyPath).utf8().data(), parameters.unique, parameters.multiEntry); ^ 1 error generated. 1352265 1 321703 clopez 2017-09-25 11:07:44 -0700 Created attachment 321703 Patch 1352338 2 321703 mcatanzaro 2017-09-25 12:39:59 -0700 Comment on attachment 321703 Patch Not sure if I'm more surprised that you tried to do this, or that it's the only problem. 1352363 3 321703 commit-queue 2017-09-25 13:06:15 -0700 Comment on attachment 321703 Patch Clearing flags on attachment: 321703 Committed r222459: <http://trac.webkit.org/changeset/222459> 1352364 4 commit-queue 2017-09-25 13:06:17 -0700 All reviewed patches have been landed. Closing bug. 1353272 5 webkit-bug-importer 2017-09-27 12:18:05 -0700 <rdar://problem/34692985> 321703 2017-09-25 11:07:44 -0700 2017-09-25 13:06:15 -0700 Patch bug-177441-20170925200743.patch text/plain 1863 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTUxZTgyNmE3YTIzMmVm NjJmNTNiZmYzNTQwNDg3NWM4YWUzZWYwZC4uY2U3OGYwY2Q3NzVhZGM5MTc1Nzk0MmZkNTU3NmQy NWJiM2RmYjRlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA5LTI1ICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIEJ1 aWxkaW5nIHJlbGVhc2Ugd2l0aCAtRExPR19ESVNBQkxFRD0wIGZhaWxzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc0NDEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGl0IGlzIGEg YnVpbGQgZml4LgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCS2V5UGF0aC5jcHA6 CisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCS2V5UGF0aC5oOgorCiAyMDE3LTA5LTI1 ICBNczJnZXIgIDxNczJnZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBVcGRhdGUgd2FpdFN5bmMg YW5kIHRoZSBUSU1FT1VUX0lHTk9SRUQgY29uc3RhbnQgdG8gdXNlIHNpZ25lZCBpbnRlZ2Vycy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQktleVBhdGgu Y3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCS2V5UGF0aC5jcHAKaW5k ZXggZTc2ZDRmOWNlN2U5ZjBiMjIyODgzZjY3MWI3MzgxY2ZiZmE0MTE3YS4uNzZlYmViM2MyNmMx YzAzZjEyZmRhNDcyNGMxYzljMTFhZDQ5OWMwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvSURCS2V5UGF0aC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9pbmRleGVkZGIvSURCS2V5UGF0aC5jcHAKQEAgLTIyMyw3ICsyMjMsNyBAQCBJREJLZXlQ YXRoIGlzb2xhdGVkQ29weShjb25zdCBJREJLZXlQYXRoJiBrZXlQYXRoKQogICAgIHJldHVybiBX VEY6OnZpc2l0KHZpc2l0b3IsIGtleVBhdGgpOwogfQogCi0jaWZuZGVmIE5ERUJVRworI2lmICFM T0dfRElTQUJMRUQKIFN0cmluZyBsb2dnaW5nU3RyaW5nKGNvbnN0IElEQktleVBhdGgmIHBhdGgp CiB7CiAgICAgYXV0byB2aXNpdG9yID0gV1RGOjptYWtlVmlzaXRvcihbXShjb25zdCBTdHJpbmcm IHN0cmluZykgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIv SURCS2V5UGF0aC5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCS2V5UGF0 aC5oCmluZGV4IGM1YTA0YjNkMjFkNWY0NjE2Y2Y4OTNjMGIwMDUyNTMwYWQwNjg0MzQuLjBiNzJk MWM5N2Y0ZjVkZmEzYWI1ZmJlZWRhMTcwZGYwYzRlYTMxZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQktleVBhdGguaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJLZXlQYXRoLmgKQEAgLTUzLDcgKzUzLDcgQEAgaW5saW5l IHN0ZDo6b3B0aW9uYWw8SURCS2V5UGF0aD4gaXNvbGF0ZWRDb3B5KGNvbnN0IHN0ZDo6b3B0aW9u YWw8SURCS2V5UGF0aD4mIHYKICAgICByZXR1cm4gaXNvbGF0ZWRDb3B5KHZhcmlhbnQudmFsdWUo KSk7CiB9CiAKLSNpZm5kZWYgTkRFQlVHCisjaWYgIUxPR19ESVNBQkxFRAogU3RyaW5nIGxvZ2dp bmdTdHJpbmcoY29uc3QgSURCS2V5UGF0aCYpOwogI2VuZGlmCiAK