<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>177426</bug_id>
          
          <creation_ts>2017-09-25 00:45:18 -0700</creation_ts>
          <short_desc>[CMake] Use implicit include directories for Clang as well</short_desc>
          <delta_ts>2017-09-27 12:17:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=161697</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zan Dobersek">zan</reporter>
          <assigned_to name="Zan Dobersek">zan</assigned_to>
          <cc>clopez</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1352149</commentid>
    <comment_count>0</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2017-09-25 00:45:18 -0700</bug_when>
    <thetext>[CMake] Use implicit include directories for Clang as well</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1352152</commentid>
    <comment_count>1</comment_count>
      <attachid>321674</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2017-09-25 00:56:39 -0700</bug_when>
    <thetext>Created attachment 321674
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1352601</commentid>
    <comment_count>2</comment_count>
      <attachid>321674</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2017-09-26 00:05:49 -0700</bug_when>
    <thetext>Comment on attachment 321674
Patch

Clearing flags on attachment: 321674

Committed r222494: &lt;http://trac.webkit.org/changeset/222494&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1352602</commentid>
    <comment_count>3</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2017-09-26 00:05:53 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1352634</commentid>
    <comment_count>4</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-09-26 04:44:02 -0700</bug_when>
    <thetext>(In reply to Zan Dobersek from comment #3)
&gt; All reviewed patches have been landed.  Closing bug.

With this is actually possible to use clang for cross-building?
Did you tested that? With Yocto?

Then I think we can close bug 161697</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1352635</commentid>
    <comment_count>5</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2017-09-26 04:47:38 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #4)
&gt; (In reply to Zan Dobersek from comment #3)
&gt; &gt; All reviewed patches have been landed.  Closing bug.
&gt; 
&gt; With this is actually possible to use clang for cross-building?
&gt; Did you tested that? With Yocto?
&gt; 
&gt; Then I think we can close bug 161697

Didn&apos;t test with Yocto, but it fixed build failures with the Clang-based Android NDK toolchain.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1353259</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-09-27 12:17:12 -0700</bug_when>
    <thetext>&lt;rdar://problem/34692944&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>321674</attachid>
            <date>2017-09-25 00:56:39 -0700</date>
            <delta_ts>2017-09-26 00:05:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-177426-20170925095638.patch</filename>
            <type>text/plain</type>
            <size>2061</size>
            <attacher name="Zan Dobersek">zan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi
S2l0Q29tcGlsZXJGbGFncy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21waWxlckZsYWdz
LmNtYWtlCmluZGV4IDUwOTY5NGI5OTJkMTVlOTk2YWMyZWM1ZjM1ODBlNWVmY2FhYTI4OTcuLjg2
NzE1Y2M4ODc1ZmU4MGNiZmVmN2JlNjQxNWRkYTVlNGQzZDRhZGMgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9jbWFrZS9XZWJLaXRDb21waWxlckZsYWdzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJL
aXRDb21waWxlckZsYWdzLmNtYWtlCkBAIC0xOTMsMTIgKzE5Myw5IEBAIG1hY3JvKERFVEVSTUlO
RV9HQ0NfU1lTVEVNX0lOQ0xVREVfRElSUyBfbGFuZyBfY29tcGlsZXIgX2ZsYWdzIF9yZXN1bHQp
CiAgICAgZW5kaWYgKCkKIGVuZG1hY3JvKCkKIAotaWYgKENNQUtFX0NPTVBJTEVSX0lTX0dOVUND
KQoraWYgKENPTVBJTEVSX0lTX0dDQ19PUl9DTEFORykKICAgIERFVEVSTUlORV9HQ0NfU1lTVEVN
X0lOQ0xVREVfRElSUygiYyIgIiR7Q01BS0VfQ19DT01QSUxFUn0iICIke0NNQUtFX0NfRkxBR1N9
IiBTWVNURU1fSU5DTFVERV9ESVJTKQogICAgc2V0KENNQUtFX0NfSU1QTElDSVRfSU5DTFVERV9E
SVJFQ1RPUklFUyAke0NNQUtFX0NfSU1QTElDSVRfSU5DTFVERV9ESVJFQ1RPUklFU30gJHtTWVNU
RU1fSU5DTFVERV9ESVJTfSkKLWVuZGlmICgpCi0KLWlmIChDTUFLRV9DT01QSUxFUl9JU19HTlVD
WFgpCiAgICBERVRFUk1JTkVfR0NDX1NZU1RFTV9JTkNMVURFX0RJUlMoImMrKyIgIiR7Q01BS0Vf
Q1hYX0NPTVBJTEVSfSIgIiR7Q01BS0VfQ1hYX0ZMQUdTfSIgU1lTVEVNX0lOQ0xVREVfRElSUykK
ICAgIHNldChDTUFLRV9DWFhfSU1QTElDSVRfSU5DTFVERV9ESVJFQ1RPUklFUyAke0NNQUtFX0NY
WF9JTVBMSUNJVF9JTkNMVURFX0RJUkVDVE9SSUVTfSAke1NZU1RFTV9JTkNMVURFX0RJUlN9KQog
ZW5kaWYgKCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBjOGRmMmYx
OTFkNzY2MzFmNzQyMTY2NDc5NGIzYzUwYWJhZDkzZjQ1Li42OWY3N2ViOWNiMGVkNjhlYzRmMTg2
ZTNmOTQ4Nzc2NjE0ZmY4ODM5IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9n
CkBAIC0xLDMgKzEsMjIgQEAKKzIwMTctMDktMjUgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0Bp
Z2FsaWEuY29tPgorCisgICAgICAgIFtDTWFrZV0gVXNlIGltcGxpY2l0IGluY2x1ZGUgZGlyZWN0
b3JpZXMgZm9yIENsYW5nIGFzIHdlbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTE3NzQyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgIEluIFdlYktpdENvbXBpbGVyRmxhZ3MuY21ha2UsIGFsc28gZ2F0aGVy
IGFuZCB1c2UgdGhlIHN5c3RlbQorICAgICAgICBpbmNsdWRlIGRpcmVjdG9yaWVzIGZvciBDIGFu
ZCBDKysgYnVpbGQgdGFyZ2V0cyB3aGVuIGNvbXBpbGluZworICAgICAgICB3aXRoIENsYW5nLiBU
aGlzIGZpeGVzIGNvbXBpbGF0aW9uIGVycm9ycyB3aGVuIGNyb3NzLWJ1aWxkaW5nCisgICAgICAg
IFdlYktpdCB3aXRoIGEgQ2xhbmctYmFzZWQgdG9vbGNoYWluLgorCisgICAgICAgIENPTVBJTEVS
X0lTX0dDQ19PUl9DTEFORyBpcyB1c2VkIHRvIGNoZWNrIGZvciBHQ0Mgb3IgQ2xhbmcKKyAgICAg
ICAgY29tcGlsZXJzLiBUaGF0IG9ubHkgY2hlY2tzIGZvciB0aGUgQysrIGNvbXBpbGVyLCBidXQg
aXQncyBub3QKKyAgICAgICAgcmVhc29uYWJsZSB0byBleHBlY3QgdHdvIHdpZGVseSBkaWZmZXJl
bnQgY29tcGlsZXJzIGJlaW5nIHVzZWQKKyAgICAgICAgZm9yIEMgYW5kIEMrKyBjb21waWxhdGlv
bi4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRDb21waWxlckZsYWdzLmNtYWtlOgor
CiAyMDE3LTA5LTIyICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAg
ICAgICBbV2luXSBXZWJLaXQgaXMgYnVpbHQgYXMgYSBzdGF0aWMgbGlicmFyeSwgYW5kIG5vdCBh
cyBhIGRsbC4K
</data>

          </attachment>
      

    </bug>

</bugzilla>