177416 2017-09-24 08:09:19 -0700 CSS constant properties should not be enabled by default 2017-10-10 14:25:36 -0700 1 1 1 Unclassified WebKit WebKit2 Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro commit-queue darin dino mcatanzaro thorton webkit-bug-importer oldest_to_newest 1352070 0 mcatanzaro 2017-09-24 08:09:19 -0700 CSS constant properties is still experimental, so it shouldn't be enabled by default except for Cocoa ports. 1352072 1 mcatanzaro 2017-09-24 08:18:13 -0700 Hm I found r219318. This should probably be reviewed by Dean. Dean, we really do not want any experimental features enabled by default in GTK and WPE releases, only for Safari Tech Preview, which is what the DEFAULT_EXPERIMENTAL_FEATURES_ENABLED setting is trying to accomplish. If CSS constant properties is ready for Safari releases, then it should no longer be in the experimental features list. I know there's been some desire for a runtime-enumerable list of feature toggles, but I don't think we should be abusing the experimental features list for that purpose. 1352073 2 321653 mcatanzaro 2017-09-24 08:18:39 -0700 Created attachment 321653 Patch 1352096 3 321653 darin 2017-09-24 17:03:44 -0700 Comment on attachment 321653 Patch I am not sure this is right for Safari Developer Preview. Does someone at Apple have to do something to turn it on by default for that if we turn it off here? 1352097 4 321653 darin 2017-09-24 17:04:36 -0700 Comment on attachment 321653 Patch Oh, I see. DEFAULT_EXPERIMENTAL_FEATURES_ENABLED does mean "on for developer preview". I wonder if it’s right for actual iOS and macOS releases too. I would say review+ if I was more of an expert on how this works. 1352111 5 mcatanzaro 2017-09-24 19:35:36 -0700 (In reply to Darin Adler from comment #4) > Comment on attachment 321653 [details] > Patch > > Oh, I see. DEFAULT_EXPERIMENTAL_FEATURES_ENABLED does mean "on for developer > preview". I wonder if it’s right for actual iOS and macOS releases too. I > would say review+ if I was more of an expert on how this works. Because Apple doesn't have ENABLE(DEVELOPER_MODE) or ENABLE(EXPERIMENTAL_FEATURES) (which is introduced in bug #177338), currently for macOS and iOS the experimental features are disabled manually after branching. So this change doesn't affect Apple at all, only WPE/GTK and WinCairo. This process seems confusing and non-ideal to me, but if it's what works best for your release managers then I don't see any need to change it. 1352112 6 mcatanzaro 2017-09-24 19:41:10 -0700 DEFAULT_EXPERIMENTAL_FEATURES_ENABLED probably needs to be renamed, by the way. Originally I envisioned that all experimental features would be either enabled or disabled, but I didn't realize that Safari Tech Preview would want to enable some but not all experimental features. So there are actually two valid options for experimental features: always disabled by default (for the really unstable stuff), and enabled only for tech previews and GTK/WPE developer builds (DEFAULT_EXPERIMENTAL_FEATURES_ENABLED). 1356273 7 mcatanzaro 2017-10-04 00:42:22 -0700 Seems this got forgotten. Darin, can you give r+ please? Since this doesn't affect Apple and it would be good to get it into our next GTK release. 1358908 8 321653 commit-queue 2017-10-10 14:24:18 -0700 Comment on attachment 321653 Patch Clearing flags on attachment: 321653 Committed r223143: <http://trac.webkit.org/changeset/223143> 1358909 9 commit-queue 2017-10-10 14:24:19 -0700 All reviewed patches have been landed. Closing bug. 1358910 10 webkit-bug-importer 2017-10-10 14:25:36 -0700 <rdar://problem/34919586> 321653 2017-09-24 08:18:39 -0700 2017-10-10 14:24:18 -0700 Patch bug-177416-20170924101838.patch text/plain 2166 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQyMDhlNGVkMDU0MGEwM2M3 NjZiOTUxNTc2OTkzOTgzNjAzN2NiZGEuLmNlY2NhMjhkMTdhNzNlMDU4OWUzZDVhNzY3ZDhjODY4 NDFjNGMyYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTctMDktMjQgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCisgICAgICAgIENTUyBjb25zdGFu dCBwcm9wZXJ0aWVzIHNob3VsZCBub3QgYmUgZW5hYmxlZCBieSBkZWZhdWx0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc0MTYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9XZWJQcmVmZXJl bmNlc0RlZmluaXRpb25zLmg6CisKKzIwMTctMDktMjQgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNh dGFuemFyb0BpZ2FsaWEuY29tPgorCiAgICAgICAgIEFscGhhYmV0aXplIGV4cGVyaW1lbnRhbCBm ZWF0dXJlcyBsaXN0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzczNzQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVy ZW5jZXNEZWZpbml0aW9ucy5oIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNE ZWZpbml0aW9ucy5oCmluZGV4IDdjNDNjNDY0MmNlMzQxNDU3YzNlYzMzYTRjYTc2MzgxMDI1YTRj NWIuLjVmMDQ2MmQyOTQyYjYzYmUyY2NkMjUxODQ3ODNhYzVkNGEyNDUzOTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmaW5pdGlvbnMuaAorKysgYi9T b3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgKQEAgLTM3Miw3 ICszNzIsNyBAQAogI2RlZmluZSBGT1JfRUFDSF9XRUJLSVRfRVhQRVJJTUVOVEFMX0ZFQVRVUkVf UFJFRkVSRU5DRShtYWNybykgXAogICAgIG1hY3JvKEFzeW5jRnJhbWVTY3JvbGxpbmdFbmFibGVk LCBhc3luY0ZyYW1lU2Nyb2xsaW5nRW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UsICJBc3luYyBG cmFtZSBTY3JvbGxpbmciLCAiUGVyZm9ybSBmcmFtZSBzY3JvbGxpbmcgaW4gYSBkZWRpY2F0ZWQg dGhyZWFkIG9yIHByb2Nlc3MiKSBcCiAgICAgbWFjcm8oQ2FjaGVBUElFbmFibGVkLCBjYWNoZUFQ SUVuYWJsZWQsIEJvb2wsIGJvb2wsIGZhbHNlLCAiQ2FjaGUgQVBJIiwgIkVuYWJsZSBDYWNoZSBB UEkiKSBcCi0gICAgbWFjcm8oQ29uc3RhbnRQcm9wZXJ0aWVzRW5hYmxlZCwgY29uc3RhbnRQcm9w ZXJ0aWVzRW5hYmxlZCwgQm9vbCwgYm9vbCwgdHJ1ZSwgIkNvbnN0YW50IFByb3BlcnRpZXMiLCAi RW5hYmxlIENTUyBjb25zdGFudCgpIHByb3BlcnRpZXMiKSBcCisgICAgbWFjcm8oQ29uc3RhbnRQ cm9wZXJ0aWVzRW5hYmxlZCwgY29uc3RhbnRQcm9wZXJ0aWVzRW5hYmxlZCwgQm9vbCwgYm9vbCwg REVGQVVMVF9FWFBFUklNRU5UQUxfRkVBVFVSRVNfRU5BQkxFRCwgIkNvbnN0YW50IFByb3BlcnRp ZXMiLCAiRW5hYmxlIENTUyBjb25zdGFudCgpIHByb3BlcnRpZXMiKSBcCiAgICAgbWFjcm8oRGlz cGxheUNvbnRlbnRzRW5hYmxlZCwgZGlzcGxheUNvbnRlbnRzRW5hYmxlZCwgQm9vbCwgYm9vbCwg ZmFsc2UsICJDU1MgZGlzcGxheTogY29udGVudHMiLCAiRW5hYmxlIENTUyBkaXNwbGF5OiBjb250 ZW50cyBzdXBwb3J0IikgXAogICAgIG1hY3JvKFNwcmluZ1RpbWluZ0Z1bmN0aW9uRW5hYmxlZCwg c3ByaW5nVGltaW5nRnVuY3Rpb25FbmFibGVkLCBCb29sLCBib29sLCBERUZBVUxUX0VYUEVSSU1F TlRBTF9GRUFUVVJFU19FTkFCTEVELCAiQ1NTIFNwcmluZyBBbmltYXRpb25zIiwgIkNTUyBTcHJp bmcgQW5pbWF0aW9uIHByb3RvdHlwZSIpIFwKICAgICBtYWNybyhMaW5rUHJlbG9hZEVuYWJsZWQs IGxpbmtQcmVsb2FkRW5hYmxlZCwgQm9vbCwgYm9vbCwgREVGQVVMVF9FWFBFUklNRU5UQUxfRkVB VFVSRVNfRU5BQkxFRCwgIkxpbmsgUHJlbG9hZCIsICJMaW5rIHByZWxvYWQgc3VwcG9ydCIpIFwK