177410 2017-09-23 12:33:13 -0700 [GStreamer][MSE] Likely race condition causes WTF::Deque to crash on debug 2017-10-06 02:43:30 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya eocanha bugs-noreply calvaris commit-queue eocanha oldest_to_newest 1351980 0 aboya 2017-09-23 12:33:13 -0700 When running the YouTube 2018 MSE tests, many of them sometimes crash WebKit on this assertion: http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2018.html?tests=73,74,75,85,93,94,101,102&command=run ASSERTION FAILED: m_next->m_previous == this ../../../Source/WTF/wtf/Deque.h(634) : void WTF::DequeIteratorBase<T, inlineCapacity>::removeFromIteratorsList() [with T = _Stream*; long unsigned int inlineCapacity = 0] 1 0x7fc8398e24d4 /webkit/WebKitBuild/webm/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x7fc8398e24d4] 2 0x7fc8441d985b /webkit/WebKitBuild/webm/Debug/lib/libwebkit2gtk-4.0.so.2(WTF::DequeIteratorBase<_Stream*, 0ul>::removeFromIteratorsList()+0xc1) [0x7fc8441d985b] 3 0x7fc8441d8ef6 /webkit/WebKitBuild/webm/Debug/lib/libwebkit2gtk-4.0.so.2(WTF::DequeIteratorBase<_Stream*, 0ul>::~DequeIteratorBase()+0x18) [0x7fc8441d8ef6] 4 0x7fc8441d8e20 /webkit/WebKitBuild/webm/Debug/lib/libwebkit2gtk-4.0.so.2(WTF::DequeIterator<_Stream*, 0ul>::~DequeIterator()+0x18) [0x7fc8441d8e20] 5 0x7fc8441de38a /webkit/WebKitBuild/webm/Debug/lib/libwebkit2gtk-4.0.so.2(+0x7bc638a) [0x7fc8441de38a] 6 0x7fc8441de5c3 /webkit/WebKitBuild/webm/Debug/lib/libwebkit2gtk-4.0.so.2(+0x7bc65c3) [0x7fc8441de5c3] 7 0x7fc829139bde /lib64/libffi.so.6(ffi_call_unix64+0x4c) [0x7fc829139bde] 8 0x7fc82913954f /lib64/libffi.so.6(ffi_call+0x22f) [0x7fc82913954f] 9 0x7fc832affc33 /webkit/WebKitBuild/DependenciesGTK/Root/lib/libgobject-2.0.so.0(g_cclosure_marshal_generic+0x1d3) [0x7fc832affc33] 10 0x7fc832aff46d /webkit/WebKitBuild/DependenciesGTK/Root/lib/libgobject-2.0.so.0(g_closure_invoke+0x19d) [0x7fc832aff46d] 11 0x7fc832b111fe /webkit/WebKitBuild/DependenciesGTK/Root/lib/libgobject-2.0.so.0(+0x211fe) [0x7fc832b111fe] 12 0x7fc832b19895 /webkit/WebKitBuild/DependenciesGTK/Root/lib/libgobject-2.0.so.0(g_signal_emit_valist+0xa45) [0x7fc832b19895] 13 0x7fc832b1a252 /webkit/WebKitBuild/DependenciesGTK/Root/lib/libgobject-2.0.so.0(g_signal_emit+0x82) [0x7fc832b1a252] 14 0x7fc834c34684 /webkit/WebKitBuild/DependenciesGTK/Root/lib/libgstreamer-1.0.so.0(gst_bus_async_signal_func+0x54) [0x7fc834c34684] 15 0x7fc834c3546d /webkit/WebKitBuild/DependenciesGTK/Root/lib/libgstreamer-1.0.so.0(+0x4246d) [0x7fc834c3546d] 16 0x7fc8328274d5 /webkit/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_main_context_dispatch+0x135) [0x7fc8328274d5] 17 0x7fc832827878 /webkit/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(+0x49878) [0x7fc832827878] 18 0x7fc832827b82 /webkit/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_main_loop_run+0xc2) [0x7fc832827b82] 19 0x7fc839950f54 /webkit/WebKitBuild/webm/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTF::RunLoop::run()+0xac) [0x7fc839950f54] 20 0x7fc843086b51 /webkit/WebKitBuild/webm/Debug/lib/libwebkit2gtk-4.0.so.2(int WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMain>(int, char**)+0x82) [0x7fc843086b51] 21 0x7fc843086a03 /webkit/WebKitBuild/webm/Debug/lib/libwebkit2gtk-4.0.so.2(WebProcessMainUnix+0x20) [0x7fc843086a03] 22 0x400d22 /webkit/WebKitBuild/webm/Debug/bin/WebKitWebProcess(main+0x3d) [0x400d22] 23 0x7fc82d9d050a /lib64/libc.so.6(__libc_start_main+0xea) [0x7fc82d9d050a] 24 0x400bfa /webkit/WebKitBuild/webm/Debug/bin/WebKitWebProcess(_start+0x2a) [0x400bfa] Tests that may show the error: 73, 74, 75, 85, 93, 94, 101, 102. It's likely a result of using WTF::Deque's from different threads. Since removeFromIteratorsList() only contains code in debug mode it's possible that this race is hidden on release. 1352157 1 eocanha 2017-09-25 02:16:59 -0700 These crashes come from a suggestion to use a Deque instead of the original GList during the upstreaming of the MSE code. GLists were more robust to multithreading because the links are maintained using pointers, which are atomically swappable. What we've done downstream to mitigate this problem is to use a Vector: https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/44d8a78783b195c1a4d5e7b765e33d654da0e1d2 1357248 2 322916 eocanha 2017-10-05 14:22:38 -0700 Created attachment 322916 Patch 1357535 3 322916 commit-queue 2017-10-06 02:43:29 -0700 Comment on attachment 322916 Patch Clearing flags on attachment: 322916 Committed r222972: <http://trac.webkit.org/changeset/222972> 1357536 4 commit-queue 2017-10-06 02:43:30 -0700 All reviewed patches have been landed. Closing bug. 322916 2017-10-05 14:22:38 -0700 2017-10-06 02:43:29 -0700 Patch bug-177410-20171005212236.patch text/plain 7370 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQwNThhZmE4ODMwNjRj OTAzMjllM2I4YjYzZThiMTRlYTllNmJhMy4uMTBmZGIyODJlMWVmYjFjYmYyYjM5YWE1YmI0ZTkx MDFiMjYxMmUyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDE3LTEwLTA1ICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl1bTVNFXSBMaWtlbHkgcmFjZSBjb25kaXRpb24gY2F1c2VzIFdURjo6RGVxdWUgdG8g Y3Jhc2ggb24gZGVidWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3NzQxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIERlcXVlIGtlZXBzIGEgY2hhaW4gb2YgaXRlcmF0b3JzIHdoaWNoIGlzIHVwZGF0ZWQg YXMgaXRlcmF0b3JzIGFyZQorICAgICAgICBjcmVhdGVkL2Rlc3Ryb3llZC4gVGhpcyBjYW4gY2F1 c2UgcHJvYmxlbXMgd2hlbiBpdGVyYXRvcnMgYXJlIGNyZWF0ZWQKKyAgICAgICAgZnJvbSBtdWx0 aXBsZSB0aHJlYWRzIGFzIHRoZXkgYXJlIG5vdywgc29tZXRpbWVzIHdpdGhvdXQgcHJvcGVyCisg ICAgICAgIGxvY2tpbmcgYmVjYXVzZSBpdCdzIG5vdCBhY3R1YWxseSBuZWVkZWQuCisKKyAgICAg ICAgRm9yIGluc3RhbmNlLCB0aGUgbG9jayBpbiBQbGF5YmFja1BpcGVsaW5lOjplbnF1ZXVlU2Ft cGxlKCkgaXMgbm90CisgICAgICAgIG5lZWRlZCBiZWNhdXNlIG5vbmUgb2YgdGhlIGFjY2Vzc2Vz IGFyZSBhY3R1YWxseSByaXNreS4gTG9ja2luZyB0aGVyZQorICAgICAgICBqdXN0IHRvIG1ha2Ug RGVxdWUgaGFwcHkgd291bGQgb25seSBjYXVzZSBhIHBlcmZvcm1hbmNlIHBlbmFsdHkgb24gdGhl CisgICAgICAgIHJlYWRlcnMgd29ya2luZyBpbiBvdGhlciB0aHJlYWRzLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2Uv UGxheWJhY2tQaXBlbGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbGF5YmFja1BpcGVsaW5l OjphZGRTb3VyY2VCdWZmZXIpOiBVc2UgVmVjdG9yIGluc3RlYWQgb2YKKyAgICAgICAgRGVxdWUu CisgICAgICAgIChXZWJDb3JlOjpQbGF5YmFja1BpcGVsaW5lOjpyZW1vdmVTb3VyY2VCdWZmZXIp OiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OlBsYXliYWNrUGlwZWxpbmU6OmVucXVldWVTYW1w bGUpOiBSZW1vdmUgbG9jayBhbmQgZXhwbGFpbgorICAgICAgICB3aHkgaXQncyBub3QgbmVlZGVk LgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvV2ViS2l0TWVkaWFT b3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAod2ViS2l0TWVkaWFTcmNGaW5hbGl6ZSk6IFVz ZSBWZWN0b3IuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9XZWJL aXRNZWRpYVNvdXJjZUdTdHJlYW1lclByaXZhdGUuaDoKKyAgICAgICAgVXNlIFZlY3Rvci4KKwog MjAxNy0wOS0yNiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0VNRV0gQWRkIENsZWFyS2V5IHN1cHBvcnQgZm9yIHBlcnNpc3RlbnQgc2Vzc2lvbiBkYXRh IGxvYWQgYW5kIHJlbW92YWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9tc2UvUGxheWJhY2tQaXBlbGluZS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL1BsYXliYWNrUGlwZWxpbmUuY3BwCmlu ZGV4IDYwNDllOWQ3MWM4ZDRmM2QxZWZmM2ZhNDAwNGU1MDI1YWFkYTE2MTguLjgyOTg0NTcxYjQ2 YzUxZWNiMWQ2NWVjM2ZkNzA3M2U3MzIxZWU4MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvUGxheWJhY2tQaXBlbGluZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9QbGF5YmFj a1BpcGVsaW5lLmNwcApAQCAtMTM3LDcgKzEzNyw3IEBAIE1lZGlhU291cmNlUHJpdmF0ZTo6QWRk U3RhdHVzIFBsYXliYWNrUGlwZWxpbmU6OmFkZFNvdXJjZUJ1ZmZlcihSZWZQdHI8U291cmNlQnVm CiAgICAgZ19vYmplY3Rfc2V0KEdfT0JKRUNUKHN0cmVhbS0+YXBwc3JjKSwgImJsb2NrIiwgRkFM U0UsICJtaW4tcGVyY2VudCIsIDIwLCAiZm9ybWF0IiwgR1NUX0ZPUk1BVF9USU1FLCBudWxscHRy KTsKIAogICAgIEdTVF9PQkpFQ1RfTE9DSyhtX3dlYktpdE1lZGlhU3JjLmdldCgpKTsKLSAgICBw cml2LT5zdHJlYW1zLnByZXBlbmQoc3RyZWFtKTsKKyAgICBwcml2LT5zdHJlYW1zLmFwcGVuZChz dHJlYW0pOwogICAgIEdTVF9PQkpFQ1RfVU5MT0NLKG1fd2ViS2l0TWVkaWFTcmMuZ2V0KCkpOwog CiAgICAgZ3N0X2Jpbl9hZGQoR1NUX0JJTihtX3dlYktpdE1lZGlhU3JjLmdldCgpKSwgc3RyZWFt LT5hcHBzcmMpOwpAQCAtMTUzLDE3ICsxNTMsOSBAQCB2b2lkIFBsYXliYWNrUGlwZWxpbmU6OnJl bW92ZVNvdXJjZUJ1ZmZlcihSZWZQdHI8U291cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1lcj4gcwog ICAgIEdTVF9ERUJVR19PQkpFQ1QobV93ZWJLaXRNZWRpYVNyYy5nZXQoKSwgIkVsZW1lbnQgcmVt b3ZlZCBmcm9tIE1lZGlhU291cmNlIik7CiAgICAgR1NUX09CSkVDVF9MT0NLKG1fd2ViS2l0TWVk aWFTcmMuZ2V0KCkpOwogICAgIFdlYktpdE1lZGlhU3JjUHJpdmF0ZSogcHJpdiA9IG1fd2ViS2l0 TWVkaWFTcmMtPnByaXY7Ci0gICAgU3RyZWFtKiBzdHJlYW0gPSBudWxscHRyOwotICAgIERlcXVl PFN0cmVhbSo+OjppdGVyYXRvciBzdHJlYW1Qb3NpdGlvbiA9IHByaXYtPnN0cmVhbXMuYmVnaW4o KTsKLQotICAgIGZvciAoOyBzdHJlYW1Qb3NpdGlvbiAhPSBwcml2LT5zdHJlYW1zLmVuZCgpOyAr K3N0cmVhbVBvc2l0aW9uKSB7Ci0gICAgICAgIGlmICgoKnN0cmVhbVBvc2l0aW9uKS0+c291cmNl QnVmZmVyID09IHNvdXJjZUJ1ZmZlclByaXZhdGUuZ2V0KCkpIHsKLSAgICAgICAgICAgIHN0cmVh bSA9ICpzdHJlYW1Qb3NpdGlvbjsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9Ci0gICAg fQorICAgIFN0cmVhbSogc3RyZWFtID0gZ2V0U3RyZWFtQnlTb3VyY2VCdWZmZXJQcml2YXRlKG1f d2ViS2l0TWVkaWFTcmMuZ2V0KCksIHNvdXJjZUJ1ZmZlclByaXZhdGUuZ2V0KCkpOwogICAgIGlm IChzdHJlYW0pCi0gICAgICAgIHByaXYtPnN0cmVhbXMucmVtb3ZlKHN0cmVhbVBvc2l0aW9uKTsK KyAgICAgICAgcHJpdi0+c3RyZWFtcy5yZW1vdmVGaXJzdChzdHJlYW0pOwogICAgIEdTVF9PQkpF Q1RfVU5MT0NLKG1fd2ViS2l0TWVkaWFTcmMuZ2V0KCkpOwogCiAgICAgaWYgKHN0cmVhbSkKQEAg LTQ4NCw3ICs0NzYsMTAgQEAgdm9pZCBQbGF5YmFja1BpcGVsaW5lOjplbnF1ZXVlU2FtcGxlKFJl ZjxNZWRpYVNhbXBsZT4mJiBtZWRpYVNhbXBsZSkKICAgICAgICAgR1NUX1RJTUVfQVJHUyhXZWJD b3JlOjp0b0dzdENsb2NrVGltZShtZWRpYVNhbXBsZS0+cHJlc2VudGF0aW9uVGltZSgpLnRvRG91 YmxlKCkpKSwKICAgICAgICAgR1NUX1RJTUVfQVJHUyhXZWJDb3JlOjp0b0dzdENsb2NrVGltZSht ZWRpYVNhbXBsZS0+ZHVyYXRpb24oKS50b0RvdWJsZSgpKSkpOwogCi0gICAgV1RGOjpHTXV0ZXhM b2NrZXI8R011dGV4PiBsb2NrZXIoKkdTVF9PQkpFQ1RfR0VUX0xPQ0sobV93ZWJLaXRNZWRpYVNy Yy5nZXQoKSkpOworICAgIC8vIE5vIG5lZWQgdG8gbG9jayB0byBhY2Nlc3MgdGhlIFN0cmVhbSBo ZXJlIGJlY2F1c2UgdGhlIG9ubHkgY2hhbmNlIG9mIGNvbmZsaWN0IHdpdGggdGhpcyByZWFkIGFu ZCB3aXRoIHRoZSB1c2FnZQorICAgIC8vIG9mIHRoZSBzYW1wbGUgZmllbGRzIGRvbmUgaW4gdGhp cyBtZXRob2Qgd291bGQgYmUgdGhlIGRlbGV0aW9uIG9mIHRoZSBzdHJlYW0uIEhvd2V2ZXIsIHRo YXQgb3BlcmF0aW9uIGNhbiBvbmx5CisgICAgLy8gaGFwcGVuIGluIHRoZSBtYWluIHRocmVhZCwg YnV0IHdlJ3JlIGFscmVhZHkgdGhlcmUuIFRoZXJlZm9yZSB0aGVyZSdzIG5vIGNvbmZsaWN0IGFu ZCBsb2NraW5nIHdvdWxkIG9ubHkgY2F1c2UKKyAgICAvLyBhIHBlcmZvcm1hbmNlIHBlbmFsdHkg b24gdGhlIHJlYWRlcnMgd29ya2luZyBpbiBvdGhlciB0aHJlYWRzLgogICAgIFN0cmVhbSogc3Ry ZWFtID0gZ2V0U3RyZWFtQnlUcmFja0lkKG1fd2ViS2l0TWVkaWFTcmMuZ2V0KCksIHRyYWNrSWQp OwogCiAgICAgaWYgKCFzdHJlYW0pIHsKQEAgLTQ5Nyw3ICs0OTIsMTAgQEAgdm9pZCBQbGF5YmFj a1BpcGVsaW5lOjplbnF1ZXVlU2FtcGxlKFJlZjxNZWRpYVNhbXBsZT4mJiBtZWRpYVNhbXBsZSkK ICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIC8vIFRoaXMgZmllbGQgZG9lc24ndCBjaGFu Z2UgYWZ0ZXIgY3JlYXRpb24sIG5vIG5lZWQgdG8gbG9jay4KICAgICBHc3RFbGVtZW50KiBhcHBz cmMgPSBzdHJlYW0tPmFwcHNyYzsKKworICAgIC8vIE9ubHkgbW9kaWZpZWQgYnkgdGhlIG1haW4g dGhyZWFkLCBubyBuZWVkIHRvIGxvY2suCiAgICAgTWVkaWFUaW1lIGxhc3RFbnF1ZXVlZFRpbWUg PSBzdHJlYW0tPmxhc3RFbnF1ZXVlZFRpbWU7CiAKICAgICBHU3RyZWFtZXJNZWRpYVNhbXBsZSog c2FtcGxlID0gc3RhdGljX2Nhc3Q8R1N0cmVhbWVyTWVkaWFTYW1wbGUqPihtZWRpYVNhbXBsZS5w dHIoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvbXNlL1dlYktpdE1lZGlhU291cmNlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvV2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFt ZXIuY3BwCmluZGV4IDUyY2E2Njg2NzZiZmQ5ZTA5MDRjNWQ2ZGI5ZTk2NGI0OGRlMmMxZjUuLjZl OTJlNDc2ZDgxMGI4NmY5MDRkZGQ5MDgwMTZmNGYzNjZhOWJmODUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvV2ViS2l0TWVkaWFTb3Vy Y2VHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9tc2UvV2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwCkBAIC0yNjksNyArMjY5 LDcgQEAgdm9pZCB3ZWJLaXRNZWRpYVNyY0ZpbmFsaXplKEdPYmplY3QqIG9iamVjdCkKICAgICBX ZWJLaXRNZWRpYVNyYyogc291cmNlID0gV0VCS0lUX01FRElBX1NSQyhvYmplY3QpOwogICAgIFdl YktpdE1lZGlhU3JjUHJpdmF0ZSogcHJpdiA9IHNvdXJjZS0+cHJpdjsKIAotICAgIERlcXVlPFN0 cmVhbSo+IG9sZFN0cmVhbXM7CisgICAgVmVjdG9yPFN0cmVhbSo+IG9sZFN0cmVhbXM7CiAgICAg c291cmNlLT5wcml2LT5zdHJlYW1zLnN3YXAob2xkU3RyZWFtcyk7CiAKICAgICBmb3IgKFN0cmVh bSogc3RyZWFtIDogb2xkU3RyZWFtcykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvV2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFtZXJQcml2 YXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL1dl YktpdE1lZGlhU291cmNlR1N0cmVhbWVyUHJpdmF0ZS5oCmluZGV4IDgzYjUyM2Y3ZDJhNDQwZWVh Nzg3YzEwOTExODY5YzM0NjhkZmE5YWYuLmE4MTA5MDE3YWFmNGM1YWJkYmI4Yzg1YmQ3MWI3NWZi MDM2MTU5MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9tc2UvV2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFtZXJQcml2YXRlLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9XZWJLaXRNZWRpYVNv dXJjZUdTdHJlYW1lclByaXZhdGUuaApAQCAtNDksOSArNDksMTEgQEAgc3RydWN0IF9TdHJlYW0g ewogICAgIC8vIEZpZWxkcyBmaWxsZWQgd2hlbiB0aGUgU3RyZWFtIGlzIGNyZWF0ZWQuCiAgICAg V2ViS2l0TWVkaWFTcmMqIHBhcmVudDsKIAotICAgIC8vIEFwcFNyYy4KKyAgICAvLyBBcHBTcmMu IE5ldmVyIG1vZGlmaWVkIGFmdGVyIGZpcnN0IGFzc2lnbm1lbnQuCiAgICAgR3N0RWxlbWVudCog YXBwc3JjOwogICAgIEdzdFBhZCogZGVjb2RlYmluU2lua1BhZDsKKworICAgIC8vIE5ldmVyIG1v ZGlmaWVkIGFmdGVyIGZpcnN0IGFzc2lnbm1lbnQuCiAgICAgV2ViQ29yZTo6U291cmNlQnVmZmVy UHJpdmF0ZUdTdHJlYW1lciogc291cmNlQnVmZmVyOwogCiAgICAgLy8gRmllbGRzIGZpbGxlZCB3 aGVuIHRoZSB0cmFjayBpcyBhdHRhY2hlZC4KQEAgLTU5LDYgKzYxLDggQEAgc3RydWN0IF9TdHJl YW0gewogICAgIC8vIE1pZ2h0IGJlIDAsIGUuZy4gZm9yIFZQOC9WUDkuCiAgICAgR3N0RWxlbWVu dCogcGFyc2VyOwogICAgIEdSZWZQdHI8R3N0Q2Fwcz4gY2FwczsKKworICAgIC8vIE9ubHkgYXVk aW8sIHZpZGVvIG9yIG5vdGhpbmcgYXQgYSBnaXZlbiB0aW1lLgogICAgIFJlZlB0cjxXZWJDb3Jl OjpBdWRpb1RyYWNrUHJpdmF0ZUdTdHJlYW1lcj4gYXVkaW9UcmFjazsKICAgICBSZWZQdHI8V2Vi Q29yZTo6VmlkZW9UcmFja1ByaXZhdGVHU3RyZWFtZXI+IHZpZGVvVHJhY2s7CiAgICAgV2ViQ29y ZTo6RmxvYXRTaXplIHByZXNlbnRhdGlvblNpemU7CkBAIC02OCw2ICs3Miw3IEBAIHN0cnVjdCBf U3RyZWFtIHsKICAgICBib29sIGFwcHNyY05lZWREYXRhRmxhZzsKIAogICAgIC8vIFVzZWQgdG8g ZW5mb3JjZSBjb250aW51aXR5IGluIHRoZSBhcHBlbmRlZCBkYXRhIGFuZCBhdm9pZCBicmVha2lu ZyB0aGUgZGVjb2Rlci4KKyAgICAvLyBPbmx5IHVzZWQgZnJvbSB0aGUgbWFpbiB0aHJlYWQuCiAg ICAgTWVkaWFUaW1lIGxhc3RFbnF1ZXVlZFRpbWU7CiB9OwogCkBAIC05Nyw3ICsxMDIsOSBAQCBz dHJ1Y3QgX1dlYktpdE1lZGlhU3JjUHJpdmF0ZSB7CiAgICAgTG9jayBzdHJlYW1Mb2NrOwogICAg IENvbmRpdGlvbiBzdHJlYW1Db25kaXRpb247CiAKLSAgICBEZXF1ZTxTdHJlYW0qPiBzdHJlYW1z OworICAgIC8vIFN0cmVhbXMgYXJlIG9ubHkgYWRkZWQvcmVtb3ZlZCBpbiB0aGUgbWFpbiB0aHJl YWQuCisgICAgVmVjdG9yPFN0cmVhbSo+IHN0cmVhbXM7CisKICAgICBHVW5pcXVlUHRyPGdjaGFy PiBsb2NhdGlvbjsKICAgICBpbnQgbnVtYmVyT2ZBdWRpb1N0cmVhbXM7CiAgICAgaW50IG51bWJl ck9mVmlkZW9TdHJlYW1zOwo=