177402 2017-09-22 18:20:01 -0700 Web Inspector: Reduce work during resizing 2017-09-27 12:17:21 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1351903 0 joepeck 2017-09-22 18:20:01 -0700 Reduce work during resizing We don't need to refresh CodeMirror in the ConsolePrompt when it is empty. Nothing changes in the prompt but we are spending a bunch of time there under refresh. CodeMirror has its own resize detection as well. 1351904 1 321606 joepeck 2017-09-22 18:21:10 -0700 Created attachment 321606 [PATCH] Proposed Fix 1351908 2 321606 joepeck 2017-09-22 18:24:33 -0700 Comment on attachment 321606 [PATCH] Proposed Fix Actually I wonder if we can just remove this. 1351911 3 321609 joepeck 2017-09-22 18:29:45 -0700 Created attachment 321609 [PATCH] Proposed Fix The only case where the refresh() mattered was switching tabs (causing sidebars to go away and the console size to change size). For an empty console we shouldn't need to refresh anything. 1352081 4 321609 mattbaker 2017-09-24 11:27:13 -0700 Comment on attachment 321609 [PATCH] Proposed Fix r=me 1352084 5 321609 commit-queue 2017-09-24 11:55:07 -0700 Comment on attachment 321609 [PATCH] Proposed Fix Clearing flags on attachment: 321609 Committed r222436: <http://trac.webkit.org/changeset/222436> 1352085 6 commit-queue 2017-09-24 11:55:08 -0700 All reviewed patches have been landed. Closing bug. 1353262 7 webkit-bug-importer 2017-09-27 12:17:21 -0700 <rdar://problem/34692954> 321606 2017-09-22 18:21:10 -0700 2017-09-22 18:24:33 -0700 [PATCH] Proposed Fix resize-1.patch text/plain 1154 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM0ZGY1M2E5Y2RmLi5iMDZmNTZlZTMwZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDktMjIgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBSZWR1Y2Ugd29yayBkdXJpbmcgcmVzaXppbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzQwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlUHJvbXB0 LmpzOgorICAgICAgICAoV0kuQ29uc29sZVByb21wdC5wcm90b3R5cGUubGF5b3V0KToKKwogMjAx Ny0wOS0xOSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IEluY2x1ZGUgYSB0YWJsZSBpbiBOZXcgTmV0d29yayBUYWIKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVQ cm9tcHQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25z b2xlUHJvbXB0LmpzCmluZGV4IGJmYmQ3NGE4ZjEyLi4wMTA0MmZkOWZkMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZVByb21wdC5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xl UHJvbXB0LmpzCkBAIC0xNDQsNiArMTQ0LDEwIEBAIFdJLkNvbnNvbGVQcm9tcHQgPSBjbGFzcyBD b25zb2xlUHJvbXB0IGV4dGVuZHMgV0kuVmlldwogCiAgICAgbGF5b3V0KCkKICAgICB7CisgICAg ICAgIC8vIEF2b2lkIHJlZnJlc2hpbmcgaWYgZW1wdHkuCisgICAgICAgIGlmICghdGhpcy50ZXh0 KQorICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIHRoaXMuX2NvZGVNaXJyb3IucmVmcmVz aCgpOwogICAgIH0KIAo= 321609 2017-09-22 18:29:45 -0700 2017-09-24 11:55:07 -0700 [PATCH] Proposed Fix resize-2.patch text/plain 1285 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM0ZGY1M2E5Y2RmLi4zZjE4YTgzZDE1NCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDktMjIgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBSZWR1Y2Ugd29yayBkdXJpbmcgcmVzaXppbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzQwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlUHJvbXB0 LmpzOgorICAgICAgICAoV0kuQ29uc29sZVByb21wdC5wcm90b3R5cGUubGF5b3V0KToKKyAgICAg ICAgSW4gdGhlIG1vc3QgY29tbW9uIGNhc2UgdGhlcmUgaXMgbm8gdGV4dCBzbyBhdm9pZCBkb2lu ZyB3b3JrIGluIENvZGVNaXJyb3IuCisKIDIwMTctMDktMTkgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbmNsdWRlIGEgdGFi bGUgaW4gTmV3IE5ldHdvcmsgVGFiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlUHJvbXB0LmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZVByb21wdC5qcwppbmRleCBiZmJkNzRhOGYx Mi4uNjUwM2JmMzk3YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0NvbnNvbGVQcm9tcHQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZVByb21wdC5qcwpAQCAtMTQ0LDcgKzE0NCw4IEBA IFdJLkNvbnNvbGVQcm9tcHQgPSBjbGFzcyBDb25zb2xlUHJvbXB0IGV4dGVuZHMgV0kuVmlldwog CiAgICAgbGF5b3V0KCkKICAgICB7Ci0gICAgICAgIHRoaXMuX2NvZGVNaXJyb3IucmVmcmVzaCgp OworICAgICAgICBpZiAodGhpcy5sYXlvdXRSZWFzb24gPT09IFdJLlZpZXcuTGF5b3V0UmVhc29u LlJlc2l6ZSAmJiB0aGlzLnRleHQpCisgICAgICAgICAgICB0aGlzLl9jb2RlTWlycm9yLnJlZnJl c2goKTsKICAgICB9CiAKICAgICAvLyBQcml2YXRlCg==