177379 2017-09-22 13:17:47 -0700 Web Inspector: NavigationBar should coalesce consecutive dividers when items are hidden 2017-09-27 12:18:55 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1351798 0 mattbaker 2017-09-22 13:17:47 -0700 Summary: NavigationBar should coalesce consecutive dividers when items are hidden. Currently this is only done when items are forced hidden when collapsing the bar to fit the available space. We should always coalesce dividers during a layout, since hiding items (NavigationItem.prototype.hidden) can also cause dividers to pile up. 1351800 1 321587 mattbaker 2017-09-22 13:19:02 -0700 Created attachment 321587 Patch 1351808 2 321587 joepeck 2017-09-22 13:39:49 -0700 Comment on attachment 321587 Patch r=me 1351821 3 321587 commit-queue 2017-09-22 14:08:31 -0700 Comment on attachment 321587 Patch Clearing flags on attachment: 321587 Committed r222405: <http://trac.webkit.org/changeset/222405> 1351822 4 commit-queue 2017-09-22 14:08:32 -0700 All reviewed patches have been landed. Closing bug. 1353283 5 webkit-bug-importer 2017-09-27 12:18:55 -0700 <rdar://problem/34693012> 321587 2017-09-22 13:19:02 -0700 2017-09-22 14:08:31 -0700 Patch bug-177379-20170922131901.patch text/plain 2668 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm NGI5OGY5NjNiNWM0NjY5YWM4ZmY4NDY3MjdjYmJlMzliNmRmNjNjLi4yY2VmZjRhMTVlMTM1ZDQ4 N2YyNzA3YWZlMjg5MDRmNDZhYjNmYzdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNy0wOS0yMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTmF2aWdhdGlvbkJhciBzaG91bGQgY29hbGVzY2Ug Y29uc2VjdXRpdmUgZGl2aWRlcnMgd2hlbiBpdGVtcyBhcmUgaGlkZGVuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzczNzkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv TmF2aWdhdGlvbkJhci5qczoKKyAgICAgICAgKFdJLk5hdmlnYXRpb25CYXIucHJvdG90eXBlLmxh eW91dCk6CisKIDIwMTctMDktMjEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgYXV0b2NvbXBsZXRpb24gc3VnZ2VzdGlv bnMgZm9yIENTUyBmdW5jdGlvbnMgKGNvbnN0YW50KCksIGxpbmVhci1ncmFkaWVudCgpLCBldGMp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9O YXZpZ2F0aW9uQmFyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvTmF2aWdhdGlvbkJhci5qcwppbmRleCA2ZWFjMmVhMmMxOGYxN2JhYjM4OGYzMmM3N2YwNTdm MjZhYjRjODM1Li5mYjhhMjdmMTVjZDlkMjlkZmNmNWYzNjA1NTI3NGM3NzhhYzlhZWZmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0 aW9uQmFyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L05hdmlnYXRpb25CYXIuanMKQEAgLTI0OSwyMCArMjQ5LDIwIEBAIFdJLk5hdmlnYXRpb25CYXIg PSBjbGFzcyBOYXZpZ2F0aW9uQmFyIGV4dGVuZHMgV0kuVmlldwogICAgICAgICAgICAgaXRlbS51 cGRhdGVMYXlvdXQoZmFsc2UpOwogCiAgICAgICAgIHRvdGFsSXRlbVdpZHRoID0gY2FsY3VsYXRl VmlzaWJsZUl0ZW1XaWR0aCgpOwotICAgICAgICBpZiAodG90YWxJdGVtV2lkdGggPD0gYmFyV2lk dGgpCi0gICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgLy8gSGlkZSB2aXNpYmxlIGl0ZW1z LCBzdGFydGluZyB3aXRoIHRoZSBsb3dlc3QgcHJpb3JpdHkgaXRlbSwgdW50aWwgdGhlCi0gICAg ICAgIC8vIGJhciBmaXRzIHRoZSBhdmFpbGFibGUgd2lkdGguCi0gICAgICAgIHZpc2libGVOYXZp Z2F0aW9uSXRlbXMuc29ydCgoYSwgYikgPT4gYS52aXNpYmlsaXR5UHJpb3JpdHkgLSBiLnZpc2li aWxpdHlQcmlvcml0eSk7CisgICAgICAgIGlmICh0b3RhbEl0ZW1XaWR0aCA+IGJhcldpZHRoKSB7 CisgICAgICAgICAgICAvLyBIaWRlIHZpc2libGUgaXRlbXMsIHN0YXJ0aW5nIHdpdGggdGhlIGxv d2VzdCBwcmlvcml0eSBpdGVtLCB1bnRpbAorICAgICAgICAgICAgLy8gdGhlIGJhciBmaXRzIHRo ZSBhdmFpbGFibGUgd2lkdGguCisgICAgICAgICAgICB2aXNpYmxlTmF2aWdhdGlvbkl0ZW1zLnNv cnQoKGEsIGIpID0+IGEudmlzaWJpbGl0eVByaW9yaXR5IC0gYi52aXNpYmlsaXR5UHJpb3JpdHkp OwogCi0gICAgICAgIHdoaWxlICh0b3RhbEl0ZW1XaWR0aCA+IGJhcldpZHRoICYmIHZpc2libGVO YXZpZ2F0aW9uSXRlbXMubGVuZ3RoKSB7Ci0gICAgICAgICAgICBsZXQgbmF2aWdhdGlvbkl0ZW0g PSB2aXNpYmxlTmF2aWdhdGlvbkl0ZW1zLnNoaWZ0KCk7Ci0gICAgICAgICAgICB0b3RhbEl0ZW1X aWR0aCAtPSBuYXZpZ2F0aW9uSXRlbS53aWR0aDsKLSAgICAgICAgICAgIGZvcmNlSXRlbUhpZGRl bihuYXZpZ2F0aW9uSXRlbSwgdHJ1ZSk7Ci0gICAgICAgIH0KKyAgICAgICAgICAgIHdoaWxlICh0 b3RhbEl0ZW1XaWR0aCA+IGJhcldpZHRoICYmIHZpc2libGVOYXZpZ2F0aW9uSXRlbXMubGVuZ3Ro KSB7CisgICAgICAgICAgICAgICAgbGV0IG5hdmlnYXRpb25JdGVtID0gdmlzaWJsZU5hdmlnYXRp b25JdGVtcy5zaGlmdCgpOworICAgICAgICAgICAgICAgIHRvdGFsSXRlbVdpZHRoIC09IG5hdmln YXRpb25JdGVtLndpZHRoOworICAgICAgICAgICAgICAgIGZvcmNlSXRlbUhpZGRlbihuYXZpZ2F0 aW9uSXRlbSwgdHJ1ZSk7CisgICAgICAgICAgICB9CiAKLSAgICAgICAgdmlzaWJsZU5hdmlnYXRp b25JdGVtcyA9IHRoaXMuX3Zpc2libGVOYXZpZ2F0aW9uSXRlbXM7CisgICAgICAgICAgICB2aXNp YmxlTmF2aWdhdGlvbkl0ZW1zID0gdGhpcy5fdmlzaWJsZU5hdmlnYXRpb25JdGVtczsKKyAgICAg ICAgfQogCiAgICAgICAgIC8vIEhpZGUgbGVhZGluZywgdHJhaWxpbmcsIGFuZCBjb25zZWN1dGl2 ZSBkaXZpZGVycy4KICAgICAgICAgbGV0IHByZXZpb3VzSXRlbSA9IG51bGw7Cg==