177369 2017-09-22 10:46:32 -0700 Align Media Source Extension IDL with spec 2017-09-27 12:17:58 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 nael.ouedp nael.ouedp calvaris commit-queue mcatanzaro sam webkit-bug-importer oldest_to_newest 1351711 0 nael.ouedp 2017-09-22 10:46:32 -0700 Align Media Source Extension IDL with spec. 1351714 1 321565 nael.ouedp 2017-09-22 10:51:05 -0700 Created attachment 321565 Patch 1351805 2 321565 sam 2017-09-22 13:29:31 -0700 Comment on attachment 321565 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321565&action=review > Source/WebCore/ChangeLog:9 > + Align IDL as per specification: > + - https://www.w3.org/TR/media-source/ Can you add tests for these (probably only the SourceBuffer.idl one is directly testable actually). 1352166 3 nael.ouedp 2017-09-25 04:59:30 -0700 Thanks for the review. > Can you add tests for these (probably only the SourceBuffer.idl one is > directly testable actually). There is a test (mediasource-remove.html) in WPT that already checks that an exception is thrown when calling remove method with non-finite start values. 1352169 4 321565 commit-queue 2017-09-25 05:27:40 -0700 Comment on attachment 321565 Patch Clearing flags on attachment: 321565 Committed r222443: <http://trac.webkit.org/changeset/222443> 1352170 5 commit-queue 2017-09-25 05:27:42 -0700 All reviewed patches have been landed. Closing bug. 1353270 6 webkit-bug-importer 2017-09-27 12:17:58 -0700 <rdar://problem/34692980> 321565 2017-09-22 10:51:05 -0700 2017-09-25 05:27:40 -0700 Patch bug-177369-20170922195104.patch text/plain 3327 nael.ouedp U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjg3ZTUzOGIzNTFkYjM5 NzRiMGU5MTg3Zjg5NmMyY2FjNmExZjEzMi4uZjI4ODE3OGQ0NTNlYTk1ZDRkZGI1NjM0MzM0OWM3 NDIzNzU1YjY1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA5LTIyICBOYWVs IE91ZWRyYW9nbyAgPG5hZWwub3VlZHJhb2dvQGNyZi5jYW5vbi5mcj4KKworICAgICAgICBBbGln biBNZWRpYSBTb3VyY2UgRXh0ZW5zaW9uIElETCB3aXRoIHNwZWMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzM2OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsaWduIElETCBhcyBwZXIgc3BlY2lmaWNh dGlvbjoKKyAgICAgICAgIC0gaHR0cHM6Ly93d3cudzMub3JnL1RSL21lZGlhLXNvdXJjZS8KKwor ICAgICAgICAqIE1vZHVsZXMvbWVkaWFzb3VyY2UvQXVkaW9UcmFja01lZGlhU291cmNlLmlkbDoK KyAgICAgICAgKiBNb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlci5pZGw6CisgICAgICAg ICogTW9kdWxlcy9tZWRpYXNvdXJjZS9UZXh0VHJhY2tNZWRpYVNvdXJjZS5pZGw6CisgICAgICAg ICogTW9kdWxlcy9tZWRpYXNvdXJjZS9WaWRlb1RyYWNrTWVkaWFTb3VyY2UuaWRsOgorCiAyMDE3 LTA5LTIxICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJF R1JFU1NJT04gKHIyMjEwMTcpOiBpQ2xvdWQgbWFpbCBsb2dzIG1lIG91dCBhZnRlciBsb29raW5n IGF0IGEgZmV3IG1lc3NhZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhc291cmNlL0F1ZGlvVHJhY2tNZWRpYVNvdXJjZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhc291cmNlL0F1ZGlvVHJhY2tNZWRpYVNvdXJjZS5pZGwKaW5kZXggNzE0MjQxMzkx MTQ1OWViZWIxM2NlYmE0ZGM4YTk2ZTQwZGQzMDEwNS4uNzgyOTI0OTE2NmViNjBkNGU2YzRmYzBj NmQ2NGQwMmJmODdiM2EwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXNvdXJjZS9BdWRpb1RyYWNrTWVkaWFTb3VyY2UuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzb3VyY2UvQXVkaW9UcmFja01lZGlhU291cmNlLmlkbApAQCAtMjcsNSArMjcs NSBAQAogICAgIENvbmRpdGlvbmFsPU1FRElBX1NPVVJDRSZWSURFT19UUkFDSywKIF0KIHBhcnRp YWwgaW50ZXJmYWNlIEF1ZGlvVHJhY2sgewotICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBTb3VyY2VC dWZmZXIgc291cmNlQnVmZmVyOworICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBTb3VyY2VCdWZmZXI/ IHNvdXJjZUJ1ZmZlcjsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhc291cmNlL1NvdXJjZUJ1ZmZlci5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c291cmNlL1NvdXJjZUJ1ZmZlci5pZGwKaW5kZXggOWM4NDdjNzJhOTQ0YjE1Y2MzNjkwYjQ1NDhh NTQ2YTRlMGUyMGRmYS4uMDQwYjI0MzIzMWY2ZGI2Njg4OWNmNjY3NWM1ZDM3MDBlNTQwYjRhYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZm ZXIuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVm ZmVyLmlkbApAQCAtNjEsNyArNjEsNyBAQAogCiAgICAgLy8gQWJvcnQgdGhlIGN1cnJlbnQgc2Vn bWVudCBhcHBlbmQgc2VxdWVuY2UuCiAgICAgW01heVRocm93RXhjZXB0aW9uXSB2b2lkIGFib3J0 KCk7Ci0gICAgW01heVRocm93RXhjZXB0aW9uXSB2b2lkIHJlbW92ZSh1bnJlc3RyaWN0ZWQgZG91 YmxlIHN0YXJ0LCB1bnJlc3RyaWN0ZWQgZG91YmxlIGVuZCk7CisgICAgW01heVRocm93RXhjZXB0 aW9uXSB2b2lkIHJlbW92ZShkb3VibGUgc3RhcnQsIHVucmVzdHJpY3RlZCBkb3VibGUgZW5kKTsK IAogICAgIGF0dHJpYnV0ZSBFdmVudEhhbmRsZXIgb251cGRhdGVzdGFydDsKICAgICBhdHRyaWJ1 dGUgRXZlbnRIYW5kbGVyIG9udXBkYXRlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYXNvdXJjZS9UZXh0VHJhY2tNZWRpYVNvdXJjZS5pZGwgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL21lZGlhc291cmNlL1RleHRUcmFja01lZGlhU291cmNlLmlkbAppbmRleCA4OGVk MjJmMzEzYmE4NDI2YTdkNTBmOGUwZDQ2YTg3OGM3Yzg0ZTM3Li41M2U1MmNlOGNmNzk4M2YyZDA1 MWY1MjE0NTAwZTUwOGZjYTEwYWI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhc291cmNlL1RleHRUcmFja01lZGlhU291cmNlLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL21lZGlhc291cmNlL1RleHRUcmFja01lZGlhU291cmNlLmlkbApAQCAtMjcsNSAr MjcsNSBAQAogICAgIENvbmRpdGlvbmFsPU1FRElBX1NPVVJDRSZWSURFT19UUkFDSywKIF0KIHBh cnRpYWwgaW50ZXJmYWNlIFRleHRUcmFjayB7Ci0gICAgcmVhZG9ubHkgYXR0cmlidXRlIFNvdXJj ZUJ1ZmZlciBzb3VyY2VCdWZmZXI7CisgICAgcmVhZG9ubHkgYXR0cmlidXRlIFNvdXJjZUJ1ZmZl cj8gc291cmNlQnVmZmVyOwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzb3VyY2UvVmlkZW9UcmFja01lZGlhU291cmNlLmlkbCBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzb3VyY2UvVmlkZW9UcmFja01lZGlhU291cmNlLmlkbAppbmRleCAwZjdjNjVi MjVhMjhhMTNhNWIxNWY5YTNiNTg2ZDQ0ZTRlNzhlYzMyLi5kODBhMGY0MmRhZWVjYzI0YWFlMDI3 N2FlN2I3MGRiMzlkMjY0NGZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhc291cmNlL1ZpZGVvVHJhY2tNZWRpYVNvdXJjZS5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXNvdXJjZS9WaWRlb1RyYWNrTWVkaWFTb3VyY2UuaWRsCkBAIC0yNiw1ICsy Niw1IEBACiAgICAgQ29uZGl0aW9uYWw9TUVESUFfU09VUkNFJlZJREVPX1RSQUNLLAogXQogcGFy dGlhbCBpbnRlcmZhY2UgVmlkZW9UcmFjayB7Ci0gICAgcmVhZG9ubHkgYXR0cmlidXRlIFNvdXJj ZUJ1ZmZlciBzb3VyY2VCdWZmZXI7CisgICAgcmVhZG9ubHkgYXR0cmlidXRlIFNvdXJjZUJ1ZmZl cj8gc291cmNlQnVmZmVyOwogfTsK