177361 2017-09-22 06:14:01 -0700 Add asserts against layout time render tree mutations 2017-09-24 16:26:46 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue darin simon.fraser webkit-bug-importer zalan oldest_to_newest 1351623 0 koivisto 2017-09-22 06:14:01 -0700 Make sure this doesn't happen anymore. 1351624 1 321538 koivisto 2017-09-22 06:17:26 -0700 Created attachment 321538 patch 1351634 2 321542 koivisto 2017-09-22 07:12:35 -0700 Created attachment 321542 patch 1351692 3 webkit-bug-importer 2017-09-22 10:24:39 -0700 <rdar://problem/34597308> 1351707 4 321542 commit-queue 2017-09-22 10:45:13 -0700 Comment on attachment 321542 patch Clearing flags on attachment: 321542 Committed r222393: <http://trac.webkit.org/changeset/222393> 1351708 5 commit-queue 2017-09-22 10:45:14 -0700 All reviewed patches have been landed. Closing bug. 1352016 6 321542 darin 2017-09-23 17:33:37 -0700 Comment on attachment 321542 patch How did you chose RELEASE_ASSERT over ASSERT? 1352047 7 koivisto 2017-09-24 00:00:57 -0700 These are pretty dangerous and the check is cheap. I'm also interested in finding if our test coverage is missing anything. 1352048 8 koivisto 2017-09-24 00:02:09 -0700 I don't know if we have some sort of policy on when to use RELEASE_ASSERT. 1352090 9 darin 2017-09-24 16:26:46 -0700 (In reply to Antti Koivisto from comment #8) > I don't know if we have some sort of policy on when to use RELEASE_ASSERT. I think we should, although I don’t know what it should be. Not a "policy" necessarily, but some conceptual framework for when to use one vs. the other. I will help us implement it consistently once we decide. 321538 2017-09-22 06:17:26 -0700 2017-09-22 07:12:35 -0700 patch layout-mutation-assert.patch text/plain 1786 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMjM4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA5LTIyICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYXNzZXJ0cyBhZ2FpbnN0 IGxheW91dCB0aW1lIHJlbmRlciB0cmVlIG11dGF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3MzYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZG9uJ3QgaGF2ZSBhbnkgbXV0YXRpb25zIGxl ZnQuIEFkZCBhc3NlcnRzLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRWxlbWVudDo6aW5zZXJ0Q2hpbGRJbnRlcm5hbCk6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJFbGVtZW50OjpyZW1vdmVDaGlsZEludGVybmFsKToK KwogMjAxNy0wOS0yMSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAg ICAgICBSRUdSRVNTSU9OIChyMjIxMDE3KTogaUNsb3VkIG1haWwgbG9ncyBtZSBvdXQgYWZ0ZXIg bG9va2luZyBhdCBhIGZldyBtZXNzYWdlcwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJFbGVtZW50LmNwcAkocmV2aXNpb24gMjIyMzc5KQorKysgU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MDgsNiArNTA4 LDggQEAgdm9pZCBSZW5kZXJFbGVtZW50OjpkZXN0cm95TGVmdG92ZXJDaGlsZAogCiB2b2lkIFJl bmRlckVsZW1lbnQ6Omluc2VydENoaWxkSW50ZXJuYWwoUmVuZGVyT2JqZWN0KiBuZXdDaGlsZCwg UmVuZGVyT2JqZWN0KiBiZWZvcmVDaGlsZCwgTm90aWZ5Q2hpbGRyZW5UeXBlIG5vdGlmeUNoaWxk cmVuKQogeworICAgIFJFTEVBU0VfQVNTRVJUKCF2aWV3KCkubGF5b3V0U3RhdGUoKSk7CisKICAg ICBBU1NFUlQoY2FuSGF2ZUNoaWxkcmVuKCkgfHwgY2FuSGF2ZUdlbmVyYXRlZENoaWxkcmVuKCkp OwogICAgIEFTU0VSVCghbmV3Q2hpbGQtPnBhcmVudCgpKTsKICAgICBBU1NFUlQoIWlzUmVuZGVy QmxvY2tGbG93KCkgfHwgKCFuZXdDaGlsZC0+aXNUYWJsZVNlY3Rpb24oKSAmJiAhbmV3Q2hpbGQt PmlzVGFibGVSb3coKSAmJiAhbmV3Q2hpbGQtPmlzVGFibGVDZWxsKCkpKTsKQEAgLTU2NSw2ICs1 NjcsOCBAQCB2b2lkIFJlbmRlckVsZW1lbnQ6Omluc2VydENoaWxkSW50ZXJuYWwoCiAKIHZvaWQg UmVuZGVyRWxlbWVudDo6cmVtb3ZlQ2hpbGRJbnRlcm5hbChSZW5kZXJPYmplY3QmIG9sZENoaWxk LCBOb3RpZnlDaGlsZHJlblR5cGUgbm90aWZ5Q2hpbGRyZW4pCiB7CisgICAgUkVMRUFTRV9BU1NF UlQoIXZpZXcoKS5sYXlvdXRTdGF0ZSgpKTsKKwogICAgIEFTU0VSVChjYW5IYXZlQ2hpbGRyZW4o KSB8fCBjYW5IYXZlR2VuZXJhdGVkQ2hpbGRyZW4oKSk7CiAgICAgQVNTRVJUKG9sZENoaWxkLnBh cmVudCgpID09IHRoaXMpOwogCg== 321542 2017-09-22 07:12:35 -0700 2017-09-22 10:45:13 -0700 patch layout-mutation-assert-2.patch text/plain 1888 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMjM4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA5LTIyICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYXNzZXJ0cyBhZ2FpbnN0 IGxheW91dCB0aW1lIHJlbmRlciB0cmVlIG11dGF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3MzYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZG9uJ3QgaGF2ZSBhbnkgbXV0YXRpb25zIGxl ZnQuIEFkZCBhc3NlcnRzLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRWxlbWVudDo6aW5zZXJ0Q2hpbGRJbnRlcm5hbCk6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJFbGVtZW50OjpyZW1vdmVDaGlsZEludGVybmFsKToK KwogMjAxNy0wOS0yMSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAg ICAgICBSRUdSRVNTSU9OIChyMjIxMDE3KTogaUNsb3VkIG1haWwgbG9ncyBtZSBvdXQgYWZ0ZXIg bG9va2luZyBhdCBhIGZldyBtZXNzYWdlcwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJFbGVtZW50LmNwcAkocmV2aXNpb24gMjIyMzc5KQorKysgU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MDgsNiArNTA4 LDggQEAgdm9pZCBSZW5kZXJFbGVtZW50OjpkZXN0cm95TGVmdG92ZXJDaGlsZAogCiB2b2lkIFJl bmRlckVsZW1lbnQ6Omluc2VydENoaWxkSW50ZXJuYWwoUmVuZGVyT2JqZWN0KiBuZXdDaGlsZCwg UmVuZGVyT2JqZWN0KiBiZWZvcmVDaGlsZCwgTm90aWZ5Q2hpbGRyZW5UeXBlIG5vdGlmeUNoaWxk cmVuKQogeworICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhfTUVTU0FHRSghdmlldygpLmxheW91dFN0 YXRlKCksICJMYXlvdXQgbXVzdCBub3QgbXV0YXRlIHJlbmRlciB0cmVlIik7CisKICAgICBBU1NF UlQoY2FuSGF2ZUNoaWxkcmVuKCkgfHwgY2FuSGF2ZUdlbmVyYXRlZENoaWxkcmVuKCkpOwogICAg IEFTU0VSVCghbmV3Q2hpbGQtPnBhcmVudCgpKTsKICAgICBBU1NFUlQoIWlzUmVuZGVyQmxvY2tG bG93KCkgfHwgKCFuZXdDaGlsZC0+aXNUYWJsZVNlY3Rpb24oKSAmJiAhbmV3Q2hpbGQtPmlzVGFi bGVSb3coKSAmJiAhbmV3Q2hpbGQtPmlzVGFibGVDZWxsKCkpKTsKQEAgLTU2NSw2ICs1NjcsOCBA QCB2b2lkIFJlbmRlckVsZW1lbnQ6Omluc2VydENoaWxkSW50ZXJuYWwoCiAKIHZvaWQgUmVuZGVy RWxlbWVudDo6cmVtb3ZlQ2hpbGRJbnRlcm5hbChSZW5kZXJPYmplY3QmIG9sZENoaWxkLCBOb3Rp ZnlDaGlsZHJlblR5cGUgbm90aWZ5Q2hpbGRyZW4pCiB7CisgICAgUkVMRUFTRV9BU1NFUlRfV0lU SF9NRVNTQUdFKCF2aWV3KCkubGF5b3V0U3RhdGUoKSwgIkxheW91dCBtdXN0IG5vdCBtdXRhdGUg cmVuZGVyIHRyZWUiKTsKKwogICAgIEFTU0VSVChjYW5IYXZlQ2hpbGRyZW4oKSB8fCBjYW5IYXZl R2VuZXJhdGVkQ2hpbGRyZW4oKSk7CiAgICAgQVNTRVJUKG9sZENoaWxkLnBhcmVudCgpID09IHRo aXMpOwogCg==