177356 2017-09-22 05:14:19 -0700 Require <form> to be connected 2020-06-27 09:45:21 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 annevk rbuis cdumez changseok darin esprehn+autocc ews-watchlist gyuyoung.kim mifenton rbuis sam webkit-bug-importer oldest_to_newest 1351607 0 annevk 2017-09-22 05:14:19 -0700 web-platform-tests: http://w3c-test.org/html/semantics/forms/form-submission-0/submission-checks.window.html HTML Standard PR: https://github.com/whatwg/html/pull/2613 1666112 1 402755 rbuis 2020-06-25 11:43:34 -0700 Created attachment 402755 Patch 1666553 2 402755 darin 2020-06-26 12:41:24 -0700 Comment on attachment 402755 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402755&action=review > Source/WebCore/html/HTMLFormElement.cpp:337 > + // FIXME: duplicated in case prepareForSubmission was called. I don’t understand what "duplicated" means here. Could we be use a few more words and be explicit. I don’t understand what "in case prepareForSubmission was called. This doesn’t match our "sentence-case" comment formatting. Maybe this is the comment we want? // The prepareForSubmission function also does this check, but need to do it here too, since there are some code paths that bypass that function. But honestly, I don’t know if that’s what we’re trying to say. 1666574 3 402755 rbuis 2020-06-26 13:16:51 -0700 Comment on attachment 402755 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402755&action=review >> Source/WebCore/html/HTMLFormElement.cpp:337 >> + // FIXME: duplicated in case prepareForSubmission was called. > > I don’t understand what "duplicated" means here. Could we be use a few more words and be explicit. > > I don’t understand what "in case prepareForSubmission was called. > > This doesn’t match our "sentence-case" comment formatting. > > Maybe this is the comment we want? > > // The prepareForSubmission function also does this check, but need to do it here too, since there are some code paths that bypass that function. > > But honestly, I don’t know if that’s what we’re trying to say. Your statement is better. Basically I do not like to check for isConnected in two places, my wording was probably off (I guess I wrote it so that I would understand what to do, but maybe not others :)). How about "FIXME: ideally we have only one place to check isConnected in the submit process"? Or I can leave the comment off if we do not think it is a big deal. 1666578 4 402755 darin 2020-06-26 13:29:26 -0700 Comment on attachment 402755 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402755&action=review >>> Source/WebCore/html/HTMLFormElement.cpp:337 >>> + // FIXME: duplicated in case prepareForSubmission was called. >> >> I don’t understand what "duplicated" means here. Could we be use a few more words and be explicit. >> >> I don’t understand what "in case prepareForSubmission was called. >> >> This doesn’t match our "sentence-case" comment formatting. >> >> Maybe this is the comment we want? >> >> // The prepareForSubmission function also does this check, but need to do it here too, since there are some code paths that bypass that function. >> >> But honestly, I don’t know if that’s what we’re trying to say. > > Your statement is better. Basically I do not like to check for isConnected in two places, my wording was probably off (I guess I wrote it so that I would understand what to do, but maybe not others :)). How about "FIXME: ideally we have only one place to check isConnected in the submit process"? Or I can leave the comment off if we do not think it is a big deal. I would not comment that "it would be better to only check once". The best purpose for a comment is to help people the reason behind something non-obvious. So a comment here would answer "why is this check also here since it’s already checked elsewhere" or be omitted. 1666754 5 402955 rbuis 2020-06-27 08:14:01 -0700 Created attachment 402955 Patch 1666781 6 ews-feeder 2020-06-27 09:44:06 -0700 Committed r263624: <https://trac.webkit.org/changeset/263624> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402955. 1666782 7 webkit-bug-importer 2020-06-27 09:45:21 -0700 <rdar://problem/64844813> 402755 2020-06-25 11:43:34 -0700 2020-06-27 08:13:55 -0700 Patch bug-177356-20200625204332.patch text/plain 3505 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzcyNjY3MzljNGRmNTJm YjkzZGM3MGRmNWM4MDBmYWIzNjQwZTUyNC4uZTA3NmZmNDY2ZTk5MzBiOWFlNTA2MzY2MTk3MGI4 NzcxMTM5OTFkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA2LTI1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVxdWlyZSA8Zm9ybT4gdG8gYmUg Y29ubmVjdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzczNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbXBsZW1lbnQgc3RlcCAxIG9mIFsxXSwgaS5lLiBkbyBub3Qgc3VibWl0IGZvcm0gaWYgaXQK KyAgICAgICAgaXMgbm90IGNvbm5lY3RlZC4KKworICAgICAgICBUZXN0OiBpbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2Zvcm1zL2Zvcm0tc3VibWlzc2lvbi0w L3N1Ym1pc3Npb24tY2hlY2tzLmh0bWwKKworICAgICAgICBbMV0gaHR0cHM6Ly9odG1sLnNwZWMu d2hhdHdnLm9yZy9tdWx0aXBhZ2UvZm9ybS1jb250cm9sLWluZnJhc3RydWN0dXJlLmh0bWwjY29u Y2VwdC1mb3JtLXN1Ym1pdAorCisgICAgICAgICogaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1FbGVtZW50OjpzdWJtaXQpOgorCiAyMDIwLTA2LTI0 ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtX aW5DYWlyb10gLXdlYmtpdC1mb250LXNtb290aGluZzphbnRpYWxpYXNlZCBtYWtlcyBmb250cyBi bHVycnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAppbmRleCBlNTQ5NWY0 NzkzMTM1Yjk0Nzg2YzYxYTE3NzMxMzIwNmE5MjhhM2YzLi5jZTNkMjRhNzY5YzI0N2FiMTIxN2I5 ZDJlZjM0NjdlMzZmMTU4ZGYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxG b3JtRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQu Y3BwCkBAIC0zMzQsNiArMzM0LDEwIEBAIFN0cmluZ1BhaXJWZWN0b3IgSFRNTEZvcm1FbGVtZW50 Ojp0ZXh0RmllbGRWYWx1ZXMoKSBjb25zdAogCiB2b2lkIEhUTUxGb3JtRWxlbWVudDo6c3VibWl0 KEV2ZW50KiBldmVudCwgYm9vbCBhY3RpdmF0ZVN1Ym1pdEJ1dHRvbiwgYm9vbCBwcm9jZXNzaW5n VXNlckdlc3R1cmUsIEZvcm1TdWJtaXNzaW9uVHJpZ2dlciBmb3JtU3VibWlzc2lvblRyaWdnZXIp CiB7CisgICAgLy8gRklYTUU6IGR1cGxpY2F0ZWQgaW4gY2FzZSBwcmVwYXJlRm9yU3VibWlzc2lv biB3YXMgY2FsbGVkLgorICAgIGlmICghaXNDb25uZWN0ZWQoKSkKKyAgICAgICAgcmV0dXJuOwor CiAgICAgUmVmUHRyPEZyYW1lVmlldz4gdmlldyA9IGRvY3VtZW50KCkudmlldygpOwogICAgIFJl ZlB0cjxGcmFtZT4gZnJhbWUgPSBkb2N1bWVudCgpLmZyYW1lKCk7CiAgICAgaWYgKCF2aWV3IHx8 ICFmcmFtZSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDA0OGU1Yzk1ODMxNGZh ZDhlOGJlY2NjZDg5MjI2MTkwYmNjZDM5MDQuLjU4N2JlMTk4ZmE3Y2I1OWJiZjE1MmQ3MTBiOGY0 ZGIzMWFjODVjOGYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIwLTA2LTI1ICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAg UmVxdWlyZSA8Zm9ybT4gdG8gYmUgY29ubmVjdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzczNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgaW1wcm92ZWQgdGVzdCByZXN1bHQuCisKKyAg ICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZm9ybXMvZm9ybS1zdWJt aXNzaW9uLTAvc3VibWlzc2lvbi1jaGVja3Mud2luZG93LWV4cGVjdGVkLnR4dDoKKwogMjAyMC0w Ni0yNCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbV2ViWFJdIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLiBVcGRhdGVkIGV4cGVjdGF0aW9ucyBhbmQg bmV3IHBhc3NpbmcgdGVzdHMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2Zvcm1zL2Zvcm0tc3VibWlzc2lvbi0w L3N1Ym1pc3Npb24tY2hlY2tzLndpbmRvdy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2Zvcm1zL2Zvcm0tc3Vi bWlzc2lvbi0wL3N1Ym1pc3Npb24tY2hlY2tzLndpbmRvdy1leHBlY3RlZC50eHQKaW5kZXggNjky YmZmNGY4NzMwODZiYWMwMThhM2ViYjY1YmJmOGU1YWQ5YmRjMi4uOTVjNmI5MjdiZjY3MmU0NTBm MzE2ZGVlMzczYWE1ZDU4NmU3Y2JmMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQv dzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9mb3Jtcy9mb3JtLXN1Ym1pc3Np b24tMC9zdWJtaXNzaW9uLWNoZWNrcy53aW5kb3ctZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZm9ybXMv Zm9ybS1zdWJtaXNzaW9uLTAvc3VibWlzc2lvbi1jaGVja3Mud2luZG93LWV4cGVjdGVkLnR4dApA QCAtMSw1ICsxLDUgQEAKIAotRkFJTCA8Zm9ybT4gbm90IGNvbm5lY3RlZCB0byBhIGRvY3VtZW50 IGNhbm5vdCBuYXZpZ2F0ZSBhc3NlcnRfdW5yZWFjaGVkOiBSZWFjaGVkIHVucmVhY2hhYmxlIGNv ZGUKLUZBSUwgPGZvcm0+IG5vdCBjb25uZWN0ZWQgdG8gYSBkb2N1bWVudCBhZnRlciBzdWJtaXQg ZXZlbnQgY2Fubm90IG5hdmlnYXRlIGFzc2VydF91bnJlYWNoZWQ6IFJlYWNoZWQgdW5yZWFjaGFi bGUgY29kZQorUEFTUyA8Zm9ybT4gbm90IGNvbm5lY3RlZCB0byBhIGRvY3VtZW50IGNhbm5vdCBu YXZpZ2F0ZSAKK1BBU1MgPGZvcm0+IG5vdCBjb25uZWN0ZWQgdG8gYSBkb2N1bWVudCBhZnRlciBz dWJtaXQgZXZlbnQgY2Fubm90IG5hdmlnYXRlIAogUEFTUyA8Zm9ybT4gaW4gYSBuYXZpZ2F0ZWQg ZG9jdW1lbnQgY2Fubm90IG5hdmlnYXRlIAogCg== 402955 2020-06-27 08:14:01 -0700 2020-06-27 09:44:07 -0700 Patch bug-177356-20200627171359.patch text/plain 3609 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjNmYjNlZWVhOGI1MDk3 NzViNTY3NjJmMDUzZjFjYzk4NTc0MmFjZC4uZmZjMWFkOTZiYmNiMWQ3NTQ2YTE0ODczYjNhMDMx MzkzYzhlY2RkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA2LTI3ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVxdWlyZSA8Zm9ybT4gdG8gYmUg Y29ubmVjdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzczNTYKKworICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgorCisgICAgICAgIElt cGxlbWVudCBzdGVwIDEgb2YgWzFdLCBpLmUuIGRvIG5vdCBzdWJtaXQgZm9ybSBpZiBpdAorICAg ICAgICBpcyBub3QgY29ubmVjdGVkLgorCisgICAgICAgIFRlc3Q6IGltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZm9ybXMvZm9ybS1zdWJtaXNzaW9uLTAvc3Vi bWlzc2lvbi1jaGVja3MuaHRtbAorCisgICAgICAgIFsxXSBodHRwczovL2h0bWwuc3BlYy53aGF0 d2cub3JnL211bHRpcGFnZS9mb3JtLWNvbnRyb2wtaW5mcmFzdHJ1Y3R1cmUuaHRtbCNjb25jZXB0 LWZvcm0tc3VibWl0CisKKyAgICAgICAgKiBodG1sL0hUTUxGb3JtRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MRm9ybUVsZW1lbnQ6OnN1Ym1pdCk6CisKIDIwMjAtMDYtMjYgIEpl ciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgQ1JBU0g6IGluY29tcGF0 aWJsZSBkb3duY2FzdDw+IG9wZXJhdGlvbiBpbiBTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQzo6 c2V0Q0RNSW5zdGFuY2UoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9y bUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCmlu ZGV4IGU1NDk1ZjQ3OTMxMzViOTQ3ODZjNjFhMTc3MzEzMjA2YTkyOGEzZjMuLjk2MzI3MjVhODNh OTZhMzFlYjViODY5Y2E0ODJhZDNlNGI2ZTY3MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxG b3JtRWxlbWVudC5jcHAKQEAgLTMzNCw2ICszMzQsMTEgQEAgU3RyaW5nUGFpclZlY3RvciBIVE1M Rm9ybUVsZW1lbnQ6OnRleHRGaWVsZFZhbHVlcygpIGNvbnN0CiAKIHZvaWQgSFRNTEZvcm1FbGVt ZW50OjpzdWJtaXQoRXZlbnQqIGV2ZW50LCBib29sIGFjdGl2YXRlU3VibWl0QnV0dG9uLCBib29s IHByb2Nlc3NpbmdVc2VyR2VzdHVyZSwgRm9ybVN1Ym1pc3Npb25UcmlnZ2VyIGZvcm1TdWJtaXNz aW9uVHJpZ2dlcikKIHsKKyAgICAvLyBUaGUgcHJlcGFyZUZvclN1Ym1pc3Npb24gZnVuY3Rpb24g YWxzbyBkb2VzIHRoaXMgY2hlY2ssIGJ1dCB3ZSBuZWVkIHRvIGRvIGl0IGhlcmUKKyAgICAvLyB0 b28sIHNpbmNlIHRoZXJlIGFyZSBzb21lIGNvZGUgcGF0aHMgdGhhdCBieXBhc3MgdGhhdCBmdW5j dGlvbi4KKyAgICBpZiAoIWlzQ29ubmVjdGVkKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIFJl ZlB0cjxGcmFtZVZpZXc+IHZpZXcgPSBkb2N1bWVudCgpLnZpZXcoKTsKICAgICBSZWZQdHI8RnJh bWU+IGZyYW1lID0gZG9jdW1lbnQoKS5mcmFtZSgpOwogICAgIGlmICghdmlldyB8fCAhZnJhbWUp CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCBlMTU5MWI5NDQ1ODFkM2M3NmE1ZTNh YzQyMTFhOThjNWJlOTY1ZDIwLi4yMTJmOTAyZGRhOTkyZjA2Zjg2ZTUyZDY4OGEzZjcxOGJlNTJl YzE3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAy MC0wNi0yNyAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJlcXVpcmUg PGZvcm0+IHRvIGJlIGNvbm5lY3RlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc3MzU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4K KworICAgICAgICBVcGRhdGUgaW1wcm92ZWQgdGVzdCByZXN1bHQuCisKKyAgICAgICAgKiB3ZWIt cGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZm9ybXMvZm9ybS1zdWJtaXNzaW9uLTAvc3Vi bWlzc2lvbi1jaGVja3Mud2luZG93LWV4cGVjdGVkLnR4dDoKKwogMjAyMC0wNi0yNiAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGRyb3AgdGVz dHMgdGhhdCBnb3QgcmVuYW1lZCBpbiByMjYzNTk4IHdoZW4gcmUtc3luY2luZyBXZWJDcnlwdEFQ SSB0ZXN0cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZm9ybXMvZm9ybS1zdWJtaXNzaW9uLTAvc3VibWlzc2lv bi1jaGVja3Mud2luZG93LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZm9ybXMvZm9ybS1zdWJtaXNzaW9uLTAv c3VibWlzc2lvbi1jaGVja3Mud2luZG93LWV4cGVjdGVkLnR4dAppbmRleCA2OTJiZmY0Zjg3MzA4 NmJhYzAxOGEzZWJiNjViYmY4ZTVhZDliZGMyLi45NWM2YjkyN2JmNjcyZTQ1MGYzMTZkZWUzNzNh YTVkNTg2ZTdjYmYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2Zvcm1zL2Zvcm0tc3VibWlzc2lvbi0wL3N1Ym1p c3Npb24tY2hlY2tzLndpbmRvdy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9mb3Jtcy9mb3JtLXN1Ym1p c3Npb24tMC9zdWJtaXNzaW9uLWNoZWNrcy53aW5kb3ctZXhwZWN0ZWQudHh0CkBAIC0xLDUgKzEs NSBAQAogCi1GQUlMIDxmb3JtPiBub3QgY29ubmVjdGVkIHRvIGEgZG9jdW1lbnQgY2Fubm90IG5h dmlnYXRlIGFzc2VydF91bnJlYWNoZWQ6IFJlYWNoZWQgdW5yZWFjaGFibGUgY29kZQotRkFJTCA8 Zm9ybT4gbm90IGNvbm5lY3RlZCB0byBhIGRvY3VtZW50IGFmdGVyIHN1Ym1pdCBldmVudCBjYW5u b3QgbmF2aWdhdGUgYXNzZXJ0X3VucmVhY2hlZDogUmVhY2hlZCB1bnJlYWNoYWJsZSBjb2RlCitQ QVNTIDxmb3JtPiBub3QgY29ubmVjdGVkIHRvIGEgZG9jdW1lbnQgY2Fubm90IG5hdmlnYXRlIAor UEFTUyA8Zm9ybT4gbm90IGNvbm5lY3RlZCB0byBhIGRvY3VtZW50IGFmdGVyIHN1Ym1pdCBldmVu dCBjYW5ub3QgbmF2aWdhdGUgCiBQQVNTIDxmb3JtPiBpbiBhIG5hdmlnYXRlZCBkb2N1bWVudCBj YW5ub3QgbmF2aWdhdGUgCiAK