177355 2017-09-22 05:03:12 -0700 [GTK] Initial webm support in MSE 2017-09-27 02:21:49 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya webkit-unassigned bugs-noreply calvaris commit-queue cturner eocanha zan oldest_to_newest 1351605 0 aboya 2017-09-22 05:03:12 -0700 The attached patch adds initial experimental support for webm in WebKitGTK+ with VP8, VP9, Vorbis and Opus formats, as long as suitable plugins are installed in GStreamer. 1351629 1 321540 aboya 2017-09-22 06:33:49 -0700 Created attachment 321540 Patch 1352173 2 321540 zan 2017-09-25 05:57:55 -0700 Comment on attachment 321540 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321540&action=review > Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:143 > + else > + ASSERT_NOT_REACHED(); This is the only concern I have. I suppose AppendPipeline wouldn't get created if the type doesn't match one of the two conditions? 1352201 3 aboya 2017-09-25 08:30:49 -0700 Indeed. The process is stopped much earlier in the call stack, in MediaSource::addSourceBuffer() 1352612 4 321540 calvaris 2017-09-26 01:05:07 -0700 Comment on attachment 321540 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321540&action=review >> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:143 >> + ASSERT_NOT_REACHED(); > > This is the only concern I have. I suppose AppendPipeline wouldn't get created if the type doesn't match one of the two conditions? A test here would be interesting if there is none. Feel free to submit it to the spec tests if there is none about this yet. If it is not accepted because of whatever, I think it still pays off to keep it as WebKit test. I guess the test would consist of creating a SourceBuffer with crap as type, try appending some allowed format and try to play it, expecting an error. If the test fails already without calling this constructor, then we are good to go with the ASSERT_NOT_REACHED. If not, I agree with Žan here. I think the proper thing to do here would be to setting the AppendPipeline to Invalid state. Then I see another problem coming and it is that apparently all state transitions from Invalid are "ok" and I think it shouldn't be like that. Only Invalid -> Invalid should be allowed. Everything else should be ok = false. I guess then we would have some ASSERTs in Debug mode that we'd have to fix in cases where somebody appends something to a pipeline in Invalid state. Am I missing anything? 1352631 5 aboya 2017-09-26 04:26:15 -0700 (In reply to Xabier Rodríguez Calvar from comment #4) > A test here would be interesting if there is none. There is already a test for that: imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html If that did not work as expected it would crash but that's not the case. 1353048 6 321540 calvaris 2017-09-27 01:50:50 -0700 Comment on attachment 321540 Patch (In reply to Alicia Boya García from comment #5) > There is already a test for that: > imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html > > If that did not work as expected it would crash but that's not the case. Good, you're landing then. 1353056 7 321540 commit-queue 2017-09-27 02:21:47 -0700 Comment on attachment 321540 Patch Clearing flags on attachment: 321540 Committed r222550: <http://trac.webkit.org/changeset/222550> 1353057 8 commit-queue 2017-09-27 02:21:49 -0700 All reviewed patches have been landed. Closing bug. 321540 2017-09-22 06:33:49 -0700 2017-09-27 02:21:47 -0700 Patch bug-177355-20170922153344.patch text/plain 6743 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjZjNzcxYzlkYzFmZjFi MDgyODI0YTUxODgzZDkwNGNmMGViZjZiZC4uM2VkMjAzYTVmYmRkMDk5ZjJlNWE2MzhhZDg2ZDQ4 MjA2ZjlkNTFiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA5LTIyICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBBZGQgaW5pdGlh bCBleHBlcmltZW50YWwgc3VwcG9ydCBmb3Igd2VibSBpbiBXZWJLaXRHVEsrIHdpdGggVlA4LCBW UDksCisgICAgICAgIFZvcmJpcyBhbmQgT3B1cyBmb3JtYXRzLCBhcyBsb25nIGFzIHN1aXRhYmxl IHBsdWdpbnMgYXJlIGluc3RhbGxlZCBpbgorICAgICAgICBHU3RyZWFtZXIuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzczNTUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXBw ZW5kUGlwZWxpbmU6OkFwcGVuZFBpcGVsaW5lKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvbXNlL1NvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIuaDoKKwogMjAxNy0w OS0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBPbiBNYWMs IGRhdGFUcmFuc2ZlciBjbGFpbXMgdG8gY29udGFpbiBVUkwgbGlzdCB3aGVuIGRyb3BwaW5nIGZp bGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvbXNlL0FwcGVuZFBpcGVsaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwCmluZGV4IGZmMDc1MDJkYjk2Y2Y4 MjA5Y2IzNDBkMGE3MGQyODNhN2ZmNjBiMmUuLjIyYjIzNWFjNTMzN2FhMmM1ZGY0YTA5YzQxNGQz ZmFmYmRkODQ1NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwCkBAIC0xLDYg KzEsNiBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxNiBNZXRyb2xvZ2ljYWwgR3JvdXAgQi5W LgotICogQ29weXJpZ2h0IChDKSAyMDE2IElnYWxpYSBTLkwKKyAqIENvcHlyaWdodCAoQykgMjAx NiwgMjAxNyBNZXRyb2xvZ2ljYWwgR3JvdXAgQi5WLgorICogQ29weXJpZ2h0IChDKSAyMDE2LCAy MDE3IElnYWxpYSBTLkwKICAqCiAgKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91 IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAgKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1z IG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYwpAQCAtMTMzLDcgKzEzMywxNSBAQCBB cHBlbmRQaXBlbGluZTo6QXBwZW5kUGlwZWxpbmUoUmVmPE1lZGlhU291cmNlQ2xpZW50R1N0cmVh bWVyTVNFPiBtZWRpYVNvdXJjZUNsaQogICAgIC8vIFdlIGFzc2lnbiB0aGUgY3JlYXRlZCBpbnN0 YW5jZXMgaGVyZSBpbnN0ZWFkIG9mIGFkb3B0UmVmKCkgYmVjYXVzZSBnc3RfYmluX2FkZF9tYW55 KCkKICAgICAvLyBiZWxvdyB3aWxsIGFscmVhZHkgdGFrZSB0aGUgaW5pdGlhbCByZWZlcmVuY2Ug YW5kIHdlIG5lZWQgYW4gYWRkaXRpb25hbCBvbmUgZm9yIHVzLgogICAgIG1fYXBwc3JjID0gZ3N0 X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJhcHBzcmMiLCBudWxscHRyKTsKLSAgICBtX2RlbXV4ID0g Z3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJxdGRlbXV4IiwgbnVsbHB0cik7CisKKyAgICBjb25z dCBTdHJpbmcmIHR5cGUgPSBtX3NvdXJjZUJ1ZmZlclByaXZhdGUtPnR5cGUoKS5jb250YWluZXJU eXBlKCk7CisgICAgaWYgKHR5cGUuZW5kc1dpdGgoIm1wNCIpKQorICAgICAgICBtX2RlbXV4ID0g Z3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJxdGRlbXV4IiwgbnVsbHB0cik7CisgICAgZWxzZSBp ZiAodHlwZS5lbmRzV2l0aCgid2VibSIpKQorICAgICAgICBtX2RlbXV4ID0gZ3N0X2VsZW1lbnRf ZmFjdG9yeV9tYWtlKCJtYXRyb3NrYWRlbXV4IiwgbnVsbHB0cik7CisgICAgZWxzZQorICAgICAg ICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKwogICAgIG1fYXBwc2luayA9IGdzdF9lbGVtZW50X2Zh Y3RvcnlfbWFrZSgiYXBwc2luayIsIG51bGxwdHIpOwogCiAgICAgZ3N0X2FwcF9zaW5rX3NldF9l bWl0X3NpZ25hbHMoR1NUX0FQUF9TSU5LKG1fYXBwc2luay5nZXQoKSksIFRSVUUpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXJNU0UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJNU0UuY3Bw CmluZGV4IDY0Yjg3NTJiYzJmNzk3MDM3ZDgzYzM2YjUwYjRkM2VhM2JkMTBiMjYuLjIyYzJhOWFh MTAwYWIwZTJkNDA5ZTA5ODdmYjI4Y2U1NDIwMTZlYTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyTVNFLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvbXNlL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRS5jcHAKQEAgLTMsOSArMyw5 IEBACiAgKiBDb3B5cmlnaHQgKEMpIDIwMDcgQ29sbGFib3JhIEx0ZC4gIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDcgQWxwIFRva2VyIDxhbHBAYXRva2VyLmNvbT4K ICAqIENvcHlyaWdodCAoQykgMjAwOSBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5v cmc+Ci0gKiBDb3B5cmlnaHQgKEMpIDIwMDksIDIwMTAsIDIwMTEsIDIwMTIsIDIwMTMsIDIwMTYg SWdhbGlhIFMuTAorICogQ29weXJpZ2h0IChDKSAyMDA5LCAyMDEwLCAyMDExLCAyMDEyLCAyMDEz LCAyMDE2LCAyMDE3IElnYWxpYSBTLkwKICAqIENvcHlyaWdodCAoQykgMjAxNSBTZWJhc3RpYW4g RHLDtmdlIDxzZWJhc3RpYW5AY2VudHJpY3VsYXIuY29tPgotICogQ29weXJpZ2h0IChDKSAyMDE1 LCAyMDE2IE1ldHJvbG9naWNhbCBHcm91cCBCLlYuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTUsIDIw MTYsIDIwMTcgTWV0cm9sb2dpY2FsIEdyb3VwIEIuVi4KICAqCiAgKiBUaGlzIGxpYnJhcnkgaXMg ZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAgKiBtb2RpZnkg aXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYwpAQCAt NzE0LDcgKzcxNCw5IEBAIHN0YXRpYyBIYXNoU2V0PFN0cmluZywgQVNDSUlDYXNlSW5zZW5zaXRp dmVIYXNoPiYgbWltZVR5cGVDYWNoZSgpCiAgICAgICAgIEhhc2hTZXQ8U3RyaW5nLCBBU0NJSUNh c2VJbnNlbnNpdGl2ZUhhc2g+IHNldDsKICAgICAgICAgY29uc3QgY2hhciogbWltZVR5cGVzW10g PSB7CiAgICAgICAgICAgICAidmlkZW8vbXA0IiwKLSAgICAgICAgICAgICJhdWRpby9tcDQiCisg ICAgICAgICAgICAiYXVkaW8vbXA0IiwKKyAgICAgICAgICAgICJ2aWRlby93ZWJtIiwKKyAgICAg ICAgICAgICJhdWRpby93ZWJtIgogICAgICAgICB9OwogICAgICAgICBmb3IgKGF1dG8mIHR5cGUg OiBtaW1lVHlwZXMpCiAgICAgICAgICAgICBzZXQuYWRkKHR5cGUpOwpAQCAtNzc1LDEwICs3Nzcs MTQgQEAgY29uc3Qgc3RhdGljIEhhc2hTZXQ8QXRvbWljU3RyaW5nPiYgY29kZWNTZXQoKQogICAg ICAgICAgICAgVmVjdG9yPEF0b21pY1N0cmluZz4gd2Via2l0Q29kZWNzOwogICAgICAgICB9Owog Ci0gICAgICAgIHN0ZDo6YXJyYXk8R3N0Q2Fwc1dlYktpdE1hcHBpbmcsIDM+IG1hcHBpbmcgPSB7 IHsKKyAgICAgICAgc3RkOjphcnJheTxHc3RDYXBzV2ViS2l0TWFwcGluZywgNz4gbWFwcGluZyA9 IHsgewogICAgICAgICAgICAgeyBWaWRlb0RlY29kZXIsICJ2aWRlby94LWgyNjQsICBwcm9maWxl PShzdHJpbmcpeyBjb25zdHJhaW5lZC1iYXNlbGluZSwgYmFzZWxpbmUgfSIsIHsgIngtaDI2NCIg fSB9LAogICAgICAgICAgICAgeyBWaWRlb0RlY29kZXIsICJ2aWRlby94LWgyNjQsIHN0cmVhbS1m b3JtYXQ9YXZjIiwgeyAiYXZjKiJ9IH0sCi0gICAgICAgICAgICB7IFZpZGVvRGVjb2RlciwgInZp ZGVvL21wZWcsIG1wZWd2ZXJzaW9uPShpbnQpezEsMn0sIHN5c3RlbXN0cmVhbT0oYm9vbGVhbilm YWxzZSIsIHsgIm1wZWciIH0gfQorICAgICAgICAgICAgeyBWaWRlb0RlY29kZXIsICJ2aWRlby9t cGVnLCBtcGVndmVyc2lvbj0oaW50KXsxLDJ9LCBzeXN0ZW1zdHJlYW09KGJvb2xlYW4pZmFsc2Ui LCB7ICJtcGVnIiB9IH0sCisgICAgICAgICAgICB7IFZpZGVvRGVjb2RlciwgInZpZGVvL3gtdnA4 IiwgeyAidnA4IiwgIngtdnA4IiB9IH0sCisgICAgICAgICAgICB7IFZpZGVvRGVjb2RlciwgInZp ZGVvL3gtdnA5IiwgeyAidnA5IiwgIngtdnA5IiB9IH0sCisgICAgICAgICAgICB7IEF1ZGlvRGVj b2RlciwgImF1ZGlvL3gtdm9yYmlzIiwgeyAidm9yYmlzIiwgIngtdm9yYmlzIiB9IH0sCisgICAg ICAgICAgICB7IEF1ZGlvRGVjb2RlciwgImF1ZGlvL3gtb3B1cyIsIHsgIm9wdXMiLCAieC1vcHVz IiB9IH0KICAgICAgICAgfSB9OwogCiAgICAgICAgIGZvciAoYXV0byYgY3VycmVudCA6IG1hcHBp bmcpIHsKQEAgLTg2NCw5ICs4NzAsNiBAQCBNZWRpYVBsYXllcjo6U3VwcG9ydHNUeXBlIE1lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRTo6c3VwcG9ydHNUeXBlKGNvbnN0IE1lZAogICAgICAg ICByZXR1cm4gcmVzdWx0OwogCiAgICAgYXV0byBjb250YWluZXJUeXBlID0gcGFyYW1ldGVycy50 eXBlLmNvbnRhaW5lclR5cGUoKTsKLSAgICAvLyBEaXNhYmxlIFZQWC9PcHVzIG9uIE1TRSBmb3Ig bm93LCBtcDQvYXZjMSBzZWVtcyB3YXkgbW9yZSByZWxpYWJsZSBjdXJyZW50bHkuCi0gICAgaWYg KGNvbnRhaW5lclR5cGUuZW5kc1dpdGgoIndlYm0iKSkKLSAgICAgICAgcmV0dXJuIHJlc3VsdDsK IAogICAgIC8vIFlvdVR1YmUgVFYgcHJvdmlkZXMgZW1wdHkgdHlwZXMgZm9yIHNvbWUgdmlkZW9z IGFuZCB3ZSB3YW50IHRvIGJlIHNlbGVjdGVkIGFzIGJlc3QgbWVkaWEgZW5naW5lIGZvciB0aGVt LgogICAgIGlmIChjb250YWluZXJUeXBlLmlzRW1wdHkoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9Tb3VyY2VCdWZmZXJQcml2 YXRlR1N0cmVhbWVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvbXNlL1NvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIuaAppbmRleCA1NjcxMzEwZmY4MmM4 M2Y5OGMyNjBlODdiNDhmMTM0MWVjOGFmNjFhLi4zM2VkOTE0ZjkyNWIwNWFiYzg5YWY2NmFlMzAz YWI3YWE3ZjA3MzE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvbXNlL1NvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL1NvdXJjZUJ1ZmZlclBy aXZhdGVHU3RyZWFtZXIuaApAQCAtMiw4ICsyLDggQEAKICAqIENvcHlyaWdodCAoQykgMjAxMyBH b29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICogQ29weXJpZ2h0IChDKSAyMDEzIE9y YW5nZQogICogQ29weXJpZ2h0IChDKSAyMDE0IFNlYmFzdGlhbiBEcsO2Z2UgPHNlYmFzdGlhbkBj ZW50cmljdWxhci5jb20+Ci0gKiBDb3B5cmlnaHQgKEMpIDIwMTUsIDIwMTYgTWV0cm9sb2dpY2Fs IEdyb3VwIEIuVi4KLSAqIENvcHlyaWdodCAoQykgMjAxNSwgMjAxNiBJZ2FsaWEsIFMuTAorICog Q29weXJpZ2h0IChDKSAyMDE1LCAyMDE2LCAyMDE3IE1ldHJvbG9naWNhbCBHcm91cCBCLlYuCisg KiBDb3B5cmlnaHQgKEMpIDIwMTUsIDIwMTYsIDIwMTcgSWdhbGlhLCBTLkwKICAqCiAgKiBSZWRp c3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdp dGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBm b2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKQEAgLTc2LDYgKzc2LDggQEAgcHVibGljOgogICAgIHZv aWQgZGlkUmVjZWl2ZVNhbXBsZShNZWRpYVNhbXBsZSYpOwogICAgIHZvaWQgZGlkUmVjZWl2ZUFs bFBlbmRpbmdTYW1wbGVzKCk7CiAKKyAgICBDb250ZW50VHlwZSB0eXBlKCkgY29uc3QgeyByZXR1 cm4gbV90eXBlOyB9CisKIHByaXZhdGU6CiAgICAgU291cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1l cihNZWRpYVNvdXJjZUdTdHJlYW1lciosIFJlZjxNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1T RT4sIGNvbnN0IENvbnRlbnRUeXBlJik7CiAgICAgZnJpZW5kIGNsYXNzIE1lZGlhU291cmNlQ2xp ZW50R1N0cmVhbWVyTVNFOwo=