177331 2017-09-21 16:37:34 -0700 LayoutTest webrtc/video-mute.html is very often failing 2017-09-27 12:22:50 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen commit-queue darin jonlee webkit-bug-importer youennf oldest_to_newest 1351459 0 youennf 2017-09-21 16:37:34 -0700 LayoutTest webrtc/video-mute.html is very often failing 1351461 1 321492 youennf 2017-09-21 16:39:19 -0700 Created attachment 321492 Patch 1352017 2 321492 darin 2017-09-23 17:36:51 -0700 Comment on attachment 321492 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321492&action=review > LayoutTests/webrtc/video-mute.html:-70 > - internals.observeMediaStreamTrack(remoteTrack); If observeMediaStreamTrack doesn’t work reliably, should we also be removing it? 1352202 3 youennf 2017-09-25 08:32:43 -0700 Thanks for the review. (In reply to Darin Adler from comment #2) > Comment on attachment 321492 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321492&action=review > > > LayoutTests/webrtc/video-mute.html:-70 > > - internals.observeMediaStreamTrack(remoteTrack); > > If observeMediaStreamTrack doesn’t work reliably, should we also be removing > it? observeMediaStreamTrack works but it seems that trackVideoSampleCount is not always working properly for this particular test. It is used in LayoutTests/fast/mediastream/captureStream/canvas2d-heavy-drawing.html and seems to work fine there (we cannot replace it there). Since we just want to make sure that one frame is sent at the webrtc level, getStats is more appropriate anyway. 1352207 4 321492 commit-queue 2017-09-25 09:00:02 -0700 Comment on attachment 321492 Patch Clearing flags on attachment: 321492 Committed r222445: <http://trac.webkit.org/changeset/222445> 1352208 5 commit-queue 2017-09-25 09:00:03 -0700 All reviewed patches have been landed. Closing bug. 1353339 6 webkit-bug-importer 2017-09-27 12:22:50 -0700 <rdar://problem/34693164> 321492 2017-09-21 16:39:19 -0700 2017-09-25 09:00:02 -0700 Patch bug-177331-20170921163918.patch text/plain 2875 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMzI1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDgzZjdlMGUxNTE3M2I1NTUyZGFm Nzg1YTk3MGY3ODk3YzAwZmM5OC4uNjRkMjUwZjJjZTM2N2M4OGI0NjhlMzEyZjA2YzY2ZGViMmIx ZDQ1YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA5LTIxICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBMYXlvdXRUZXN0IHdlYnJ0Yy92aWRlby1tdXRl Lmh0bWwgaXMgdmVyeSBvZnRlbiBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNzczMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHdlYnJ0Yy92aWRlby1tdXRlLmh0bWw6IHVzaW5nIGdldFN0 YXRzIGluc3RlYWQgb2YgaW50ZXJuYWxzIHRvIGNoZWNrIHdoZXRoZXIgYmxhY2sgZnJhbWVzIGFy ZSByZWNlaXZlZC4KKwogMjAxNy0wOS0yMSAgWmhpZmVpIEZBTkcgIDxmYWNldG90aGVmYXRlQGdt YWlsLmNvbT4KIAogICAgICAgICBJbiByZWd1bGFyIGJsb2NrIGxheW91dCwgdGhlIHdpZHRoIG9m IGEgY2hpbGQncyBtYXJnaW4gYm94IHNob3VsZCBhbHdheXMgYmUgZXF1YWwgdG8gdGhhdCBvZiBp dHMgY29udGFpbmluZyBibG9jawpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2VicnRjL3ZpZGVv LW11dGUuaHRtbCBiL0xheW91dFRlc3RzL3dlYnJ0Yy92aWRlby1tdXRlLmh0bWwKaW5kZXggNTNj ZGViNDJjYWUzZTliNWVmYWY3MTE2NjgzMWIyNTI3MGE2ZWI4Yy4uZjI3OWMxMzVkYWU4ZWVkNGM0 MTEyMTM1OTRkNWRlZDY0MzZiZmIxNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2VicnRjL3Zp ZGVvLW11dGUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy93ZWJydGMvdmlkZW8tbXV0ZS5odG1sCkBA IC02NCwxOSArNjQsMzggQEAgcHJvbWlzZV90ZXN0KCh0ZXN0KSA9PiB7CiAgICAgcmV0dXJuIGNo ZWNrVmlkZW9CbGFjayh0cnVlLCBjYW52YXMyLCB2aWRlbyk7CiB9LCAiVHJhY2sgaXMgZGlzYWJs ZWQsIHZpZGVvIHNob3VsZCBiZSBibGFjayIpOwogCi1wcm9taXNlX3Rlc3QoKHRlc3QpID0+IHsK LSAgICBpZiAoIXdpbmRvdy5pbnRlcm5hbHMpCi0gICAgICAgIHJldHVybiBQcm9taXNlLnJlamVj dCgiVGhpcyB0ZXN0IHJlcXVpcmVzIGludGVybmFscyBBUEkiKTsKLSAgICBpbnRlcm5hbHMub2Jz ZXJ2ZU1lZGlhU3RyZWFtVHJhY2socmVtb3RlVHJhY2spOwotICAgIGxldCBjb3VudGVyID0gaW50 ZXJuYWxzLnRyYWNrVmlkZW9TYW1wbGVDb3VudDsKLSAgICByZXR1cm4gbmV3IFByb21pc2UoKHJl c29sdmUsIHJlamVjdCkgPT4gewotICAgICAgICBzZXRJbnRlcnZhbCgoKSA9PiB7Ci0gICAgICAg ICAgICAvLyBTaG91bGQgZ2V0IDEgZnJhbWUgcGVyIHNlY29uZC4KLSAgICAgICAgICAgIGlmIChp bnRlcm5hbHMudHJhY2tWaWRlb1NhbXBsZUNvdW50IC0gY291bnRlciA+PSAyKQotICAgICAgICAg ICAgICAgIHJlc29sdmUoKTsKLSAgICAgICAgfSwgMzAwKTsKLSAgICAgICAgc2V0VGltZW91dCgo KSA9PiByZWplY3QoImRpZCBub3QgZ2V0IGZyYW1lcyIpLCA1MDAwKTsKK2FzeW5jIGZ1bmN0aW9u IGdldEluYm91bmRSVFBTdGF0c051bWJlck9mRGVjb2RlZEZyYW1lcyhjb25uZWN0aW9uKQorewor ICAgIHZhciByZXBvcnQgPSBhd2FpdCBjb25uZWN0aW9uLmdldFN0YXRzKCk7CisgICAgdmFyIGZy YW1lc0RlY29kZWQ7CisgICAgcmVwb3J0LmZvckVhY2goKHN0YXRJdGVtKSA9PiB7CisgICAgICAg IGlmIChzdGF0SXRlbS50eXBlID09PSAiaW5ib3VuZC1ydHAiKQorICAgICAgICAgICAgZnJhbWVz RGVjb2RlZCA9IHN0YXRJdGVtLmZyYW1lc0RlY29kZWQ7CiAgICAgfSk7CisgICAgcmV0dXJuIGZy YW1lc0RlY29kZWQ7Cit9CisKK2FzeW5jIGZ1bmN0aW9uIHRlc3RGcmFtZURlY29kZWRJbmNyZWFz ZWQoY29ubmVjdGlvbiwgY291bnQsIHByZXZpb3VzRnJhbWVzTnVtYmVyKQoreworICAgIGlmIChw cmV2aW91c0ZyYW1lc051bWJlciA9PT0gdW5kZWZpbmVkKSB7CisgICAgICAgIGxldCBudW1iZXIg PSBhd2FpdCBnZXRJbmJvdW5kUlRQU3RhdHNOdW1iZXJPZkRlY29kZWRGcmFtZXMoY29ubmVjdGlv bik7CisgICAgICAgIGF3YWl0IHdhaXRGb3IoMTAwMCk7CisgICAgICAgIHJldHVybiB0ZXN0RnJh bWVEZWNvZGVkSW5jcmVhc2VkKGNvbm5lY3Rpb24sIDAsIG51bWJlcik7CisgICAgfQorCisgICAg dmFyIG51bWJlciA9IGF3YWl0IGdldEluYm91bmRSVFBTdGF0c051bWJlck9mRGVjb2RlZEZyYW1l cyhjb25uZWN0aW9uKTsKKyAgICBpZiAocHJldmlvdXNGcmFtZXNOdW1iZXIgJiYgbnVtYmVyID4g cHJldmlvdXNGcmFtZXNOdW1iZXIpCisgICAgICAgIHJldHVybjsKKworICAgIGlmIChjb3VudCA+ PSAyMCkKKyAgICAgICAgcmV0dXJuIFByb21pc2UucmVqZWN0KCJ0ZXN0IGluY3JlYXNpbmcgZnJh bWUgZW5jb2RlZCB0aW1lZCBvdXQiKTsKKworICAgIGF3YWl0IHdhaXRGb3IoMTAwMCk7CisgICAg cmV0dXJuIHRlc3RGcmFtZURlY29kZWRJbmNyZWFzZWQoY29ubmVjdGlvbiwgKytjb3VudCwgcHJl dmlvdXNGcmFtZXNOdW1iZXIpOworfQorCitwcm9taXNlX3Rlc3QoKHRlc3QpID0+IHsKKyAgICBy ZXR1cm4gdGVzdEZyYW1lRGVjb2RlZEluY3JlYXNlZChyZWNlaXZpbmdDb25uZWN0aW9uKTsKIH0s ICJJZiBkaXNhYmxlZCwgYmxhY2sgZnJhbWVzIHNob3VsZCBzdGlsbCBiZSBjb21pbmciKTsKIAog cHJvbWlzZV90ZXN0KCh0ZXN0KSA9PiB7Cg==