177321 2017-09-21 12:59:21 -0700 Regression(r222308): new API tests are failing for !NETWORK_SESSION 2017-09-27 12:19:13 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 176628 1 cdumez cdumez achristensen commit-queue ggaren jlewis3 ryanhaddad webkit-bug-importer oldest_to_newest 1351338 0 cdumez 2017-09-21 12:59:21 -0700 new API tests are failing for !NETWORK_SESSION. 1351341 1 321468 cdumez 2017-09-21 13:02:33 -0700 Created attachment 321468 Patch 1351342 2 cdumez 2017-09-21 13:03:15 -0700 Failures look like so: FAIL _WKDownload.RedirectedLoadConvertedToDownload /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:472 Value of: [url.absoluteString UTF8String] Actual: "http://pass/" Expected: "http://redirect/?pass" /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:481 Value of: redirectChain.count Actual: 4 Expected: 3U Which is: 3 /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:545 Value of: redirectCount Actual: 1 Expected: 0U Which is: 0 FAIL _WKDownload.RedirectedSubframeLoadConvertedToDownload /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:472 Value of: [url.absoluteString UTF8String] Actual: "http://pass/" Expected: "http://redirect/?pass" /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:481 Value of: redirectChain.count Actual: 4 Expected: 3U Which is: 3 /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:567 Value of: redirectCount Actual: 1 Expected: 0U Which is: 0 1351353 3 321470 cdumez 2017-09-21 13:21:26 -0700 Created attachment 321470 Patch 1351409 4 321470 commit-queue 2017-09-21 15:08:43 -0700 Comment on attachment 321470 Patch Clearing flags on attachment: 321470 Committed r222355: <http://trac.webkit.org/changeset/222355> 1351410 5 commit-queue 2017-09-21 15:08:44 -0700 All reviewed patches have been landed. Closing bug. 1353288 6 webkit-bug-importer 2017-09-27 12:19:13 -0700 <rdar://problem/34693029> 321468 2017-09-21 13:02:33 -0700 2017-09-21 13:21:24 -0700 Patch bug-177321-20170921130232.patch text/plain 2046 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGIzODcxMjQ1ZDIwMDRjMjZi NmMxN2Q2NDhhMzk0M2I2NzAwYzAwYWIuLjg4NzU1MWM1OWQwODdjYjNhYmJiYjExOWU3Y2M4NzQy MmNmNzlhM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTctMDktMjEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAorICAgICAgICBSZWdyZXNzaW9uKHIyMjIzMDgpOiBu ZXcgQVBJIHRlc3RzIGFyZSBmYWlsaW5nIGZvciAhTkVUV09SS19TRVNTSU9OCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzczMjEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGEgbG9hZCBpcyByZWRp cmVjdGVkIGFuZCB0aGVuIGNvbnZlcnRlZCBpbnRvIGEgZG93bmxvYWQsIENGTmV0d29yaworICAg ICAgICBzZWVtcyB0byBjYWxsIFtOU1VSTERvd25sb2FkRGVsZWdhdGUgd2lsbFNlbmRSZXF1ZXN0 Ol0gb24gdGhlIGRvd25sb2FkCisgICAgICAgIHdpdGggYSBub24tbmlsIHJlZGlyZWN0UmVzcG9u c2UsIHdoaWNoIHdhcyB1bmV4cGVjdGVkLgorCisgICAgICAgIFRvIGFkZHJlc3MgdGhlIGlzc3Vl LCB3ZSBub3cgaWdub3JlIHRoZSB3aWxsU2VuZFJlcXVlc3QgY2FsbCBpZiB0aGUKKyAgICAgICAg bmV3IHJlcXVlc3QncyBVUkwgaXMgdGhlIHNhbWUgYXMgdGhlIHJlZGlyZWN0UmVzcG9uc2Ugb25l LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL21hYy9Eb3dubG9hZE1hYy5t bToKKyAgICAgICAgKC1bV0tEb3dubG9hZEFzRGVsZWdhdGUgZG93bmxvYWQ6d2lsbFNlbmRSZXF1 ZXN0OnJlZGlyZWN0UmVzcG9uc2U6XSk6CisKKzIwMTctMDktMjEgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KKwogICAgICAgICBbV0syXSBBZGQgQVBJIHRvIGdldCB0aGUgcmVkaXJl Y3QgY2hhaW4gb2YgYSBXS0Rvd25sb2FkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzY2MjgKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM0MzM4Mjc5 PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMvbWFj L0Rvd25sb2FkTWFjLm1tIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMv bWFjL0Rvd25sb2FkTWFjLm1tCmluZGV4IDVjNjNmNWE4NTNhOGEwYjdjZWY1NTcxZDU4MWI1ODhm YWFhNDJlY2UuLjUyMTgyZjI3MTUyMzNjYzcxNDVmODA5ZTE4Y2YyNzM2ODk5M2EyMzUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL21hYy9Eb3dubG9h ZE1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0Rvd25sb2Fkcy9tYWMv RG93bmxvYWRNYWMubW0KQEAgLTIwOSw3ICsyMDksNyBAQCAtICh2b2lkKWRvd25sb2FkRGlkQmVn aW46KE5TVVJMRG93bmxvYWQgKilkb3dubG9hZAogLSAoTlNVUkxSZXF1ZXN0ICopZG93bmxvYWQ6 KE5TVVJMRG93bmxvYWQgKilkb3dubG9hZCB3aWxsU2VuZFJlcXVlc3Q6KE5TVVJMUmVxdWVzdCAq KXJlcXVlc3QgcmVkaXJlY3RSZXNwb25zZTooTlNVUkxSZXNwb25zZSAqKXJlZGlyZWN0UmVzcG9u c2UKIHsKICAgICBkaXNwYXRjaE9uTWFpblRocmVhZCheIHsKLSAgICAgICAgaWYgKF9kb3dubG9h ZCAmJiByZWRpcmVjdFJlc3BvbnNlKQorICAgICAgICBpZiAoX2Rvd25sb2FkICYmIHJlZGlyZWN0 UmVzcG9uc2UgJiYgIVtyZXF1ZXN0LlVSTCBpc0VxdWFsOnJlZGlyZWN0UmVzcG9uc2UuVVJMXSkK ICAgICAgICAgICAgIF9kb3dubG9hZC0+d2lsbFNlbmRSZWRpcmVjdGVkUmVxdWVzdChyZXF1ZXN0 LCByZWRpcmVjdFJlc3BvbnNlKTsKICAgICB9KTsKICAgICByZXR1cm4gcmVxdWVzdDsK 321470 2017-09-21 13:21:26 -0700 2017-09-21 15:08:43 -0700 Patch bug-177321-20170921132125.patch text/plain 3910 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGIzODcxMjQ1ZDIwMDRjMjZi NmMxN2Q2NDhhMzk0M2I2NzAwYzAwYWIuLjg4NzU1MWM1OWQwODdjYjNhYmJiYjExOWU3Y2M4NzQy MmNmNzlhM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTctMDktMjEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAorICAgICAgICBSZWdyZXNzaW9uKHIyMjIzMDgpOiBu ZXcgQVBJIHRlc3RzIGFyZSBmYWlsaW5nIGZvciAhTkVUV09SS19TRVNTSU9OCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzczMjEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGEgbG9hZCBpcyByZWRp cmVjdGVkIGFuZCB0aGVuIGNvbnZlcnRlZCBpbnRvIGEgZG93bmxvYWQsIENGTmV0d29yaworICAg ICAgICBzZWVtcyB0byBjYWxsIFtOU1VSTERvd25sb2FkRGVsZWdhdGUgd2lsbFNlbmRSZXF1ZXN0 Ol0gb24gdGhlIGRvd25sb2FkCisgICAgICAgIHdpdGggYSBub24tbmlsIHJlZGlyZWN0UmVzcG9u c2UsIHdoaWNoIHdhcyB1bmV4cGVjdGVkLgorCisgICAgICAgIFRvIGFkZHJlc3MgdGhlIGlzc3Vl LCB3ZSBub3cgaWdub3JlIHRoZSB3aWxsU2VuZFJlcXVlc3QgY2FsbCBpZiB0aGUKKyAgICAgICAg bmV3IHJlcXVlc3QncyBVUkwgaXMgdGhlIHNhbWUgYXMgdGhlIHJlZGlyZWN0UmVzcG9uc2Ugb25l LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL21hYy9Eb3dubG9hZE1hYy5t bToKKyAgICAgICAgKC1bV0tEb3dubG9hZEFzRGVsZWdhdGUgZG93bmxvYWQ6d2lsbFNlbmRSZXF1 ZXN0OnJlZGlyZWN0UmVzcG9uc2U6XSk6CisKKzIwMTctMDktMjEgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KKwogICAgICAgICBbV0syXSBBZGQgQVBJIHRvIGdldCB0aGUgcmVkaXJl Y3QgY2hhaW4gb2YgYSBXS0Rvd25sb2FkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzY2MjgKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM0MzM4Mjc5 PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMvbWFj L0Rvd25sb2FkTWFjLm1tIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMv bWFjL0Rvd25sb2FkTWFjLm1tCmluZGV4IDVjNjNmNWE4NTNhOGEwYjdjZWY1NTcxZDU4MWI1ODhm YWFhNDJlY2UuLjUyMTgyZjI3MTUyMzNjYzcxNDVmODA5ZTE4Y2YyNzM2ODk5M2EyMzUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL21hYy9Eb3dubG9h ZE1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0Rvd25sb2Fkcy9tYWMv RG93bmxvYWRNYWMubW0KQEAgLTIwOSw3ICsyMDksNyBAQCAtICh2b2lkKWRvd25sb2FkRGlkQmVn aW46KE5TVVJMRG93bmxvYWQgKilkb3dubG9hZAogLSAoTlNVUkxSZXF1ZXN0ICopZG93bmxvYWQ6 KE5TVVJMRG93bmxvYWQgKilkb3dubG9hZCB3aWxsU2VuZFJlcXVlc3Q6KE5TVVJMUmVxdWVzdCAq KXJlcXVlc3QgcmVkaXJlY3RSZXNwb25zZTooTlNVUkxSZXNwb25zZSAqKXJlZGlyZWN0UmVzcG9u c2UKIHsKICAgICBkaXNwYXRjaE9uTWFpblRocmVhZCheIHsKLSAgICAgICAgaWYgKF9kb3dubG9h ZCAmJiByZWRpcmVjdFJlc3BvbnNlKQorICAgICAgICBpZiAoX2Rvd25sb2FkICYmIHJlZGlyZWN0 UmVzcG9uc2UgJiYgIVtyZXF1ZXN0LlVSTCBpc0VxdWFsOnJlZGlyZWN0UmVzcG9uc2UuVVJMXSkK ICAgICAgICAgICAgIF9kb3dubG9hZC0+d2lsbFNlbmRSZWRpcmVjdGVkUmVxdWVzdChyZXF1ZXN0 LCByZWRpcmVjdFJlc3BvbnNlKTsKICAgICB9KTsKICAgICByZXR1cm4gcmVxdWVzdDsKZGlmZiAt LWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkZjZiMDgxZWU4 M2U5OTgwYTMyNzQ3MjQxYzkxYTZiNWQwMjAwZDNmLi5lNGMwZWNhZGY1ZGEyYjM0MjQyYWY3ODY3 NTk1ZDFkMjg5NWJkNTVhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTctMDktMjEgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KIAorICAgICAgICBSZWdyZXNzaW9uKHIyMjIzMDgpOiBuZXcgQVBJIHRl c3RzIGFyZSBmYWlsaW5nIGZvciAhTkVUV09SS19TRVNTSU9OCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzczMjEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbnNraXAgQVBJIHRlc3RzIG5vdyB0aGF0IHRo ZXkgcGFzcyBldmVyeXdoZXJlLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9Eb3dubG9hZC5tbToKKyAgICAgICAgKFRFU1QpOgorCisyMDE3LTA5LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZCwgdGVtcG9y YXJpbHkgZGlzYWJsZSBuZXcgQVBJIHRlc3RzIGludHJvZHVjZWQgaW4gcjIyMjMwOCB1bnRpbCB0 aGV5IHBhc3Mgb24gRWwgQ2FwaXRhbgogCiAgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXRDb2NvYS9Eb3dubG9hZC5tbToKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvRG93bmxvYWQubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdENvY29hL0Rvd25sb2FkLm1tCmluZGV4IDcyMzk4NzAyMGQzMDFhY2QxMTNlZTYxYzE3 ZWRjYjkyOTYyNWNmY2YuLmQ2ZTQyNTI4YTBkYTlhMDE5NmJiMTE1YTQ3YmVmZTg2OTQzYTc5Yzcg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvRG93bmxv YWQubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Eb3dubG9h ZC5tbQpAQCAtNTI1LDggKzUyNSw3IEBAIFRFU1QoX1dLRG93bmxvYWQsIFJlZGlyZWN0ZWREb3du bG9hZCkKICAgICBbVGVzdFByb3RvY29sIHVucmVnaXN0ZXJdOwogfQogCi0vLyBGSVhNRTogUmUt ZW5hYmxlIG9uY2UgaXQgcGFzc2VzIG9uIEVsIENhcGl0YW4gKGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNzczMjEpLgotVEVTVChfV0tEb3dubG9hZCwgRElTQUJMRURf UmVkaXJlY3RlZExvYWRDb252ZXJ0ZWRUb0Rvd25sb2FkKQorVEVTVChfV0tEb3dubG9hZCwgUmVk aXJlY3RlZExvYWRDb252ZXJ0ZWRUb0Rvd25sb2FkKQogewogICAgIFtUZXN0UHJvdG9jb2wgcmVn aXN0ZXJXaXRoU2NoZW1lOkAiaHR0cCJdOwogCkBAIC01NDgsOCArNTQ3LDcgQEAgVEVTVChfV0tE b3dubG9hZCwgRElTQUJMRURfUmVkaXJlY3RlZExvYWRDb252ZXJ0ZWRUb0Rvd25sb2FkKQogICAg IFtUZXN0UHJvdG9jb2wgdW5yZWdpc3Rlcl07CiB9CiAKLS8vIEZJWE1FOiBSZS1lbmFibGUgb25j ZSBpdCBwYXNzZXMgb24gRWwgQ2FwaXRhbiAoaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3NzMyMSkuCi1URVNUKF9XS0Rvd25sb2FkLCBESVNBQkxFRF9SZWRpcmVjdGVk U3ViZnJhbWVMb2FkQ29udmVydGVkVG9Eb3dubG9hZCkKK1RFU1QoX1dLRG93bmxvYWQsIFJlZGly ZWN0ZWRTdWJmcmFtZUxvYWRDb252ZXJ0ZWRUb0Rvd25sb2FkKQogewogICAgIFtUZXN0UHJvdG9j b2wgcmVnaXN0ZXJXaXRoU2NoZW1lOkAiaHR0cCJdOwogCg==