177311 2017-09-21 10:51:53 -0700 Make StringBuilder movable 2017-09-27 12:22:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen benjamin buildbot cdumez cmarcelo dbates webkit-bug-importer oldest_to_newest 1351264 0 achristensen 2017-09-21 10:51:53 -0700 Make StringBuilder movable 1351265 1 321449 achristensen 2017-09-21 10:52:03 -0700 Created attachment 321449 Patch 1351267 2 321449 cdumez 2017-09-21 10:55:42 -0700 Comment on attachment 321449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321449&action=review > Source/WTF/wtf/text/StringBuilder.h:48 > + StringBuilder(StringBuilder&&) = default; I believe StringBuilder is movable already. Why wouldn't it be? See rules at http://en.cppreference.com/w/cpp/language/move_constructor ("Implicitly-declared move constructor" section). 1351268 3 achristensen 2017-09-21 10:57:05 -0700 I'm trying to put it as a value in a HashMap, which requires this. HashMap uses a lot of = std::forward<T>(value). 1351271 4 achristensen 2017-09-21 11:01:27 -0700 In this case there is a user-defined copy constructor and operator= from WTF_MAKE_NONCOPYABLE. These need to be explicit. 1351366 5 achristensen 2017-09-21 13:45:11 -0700 http://trac.webkit.org/r222346 1353337 6 webkit-bug-importer 2017-09-27 12:22:37 -0700 <rdar://problem/34693155> 321449 2017-09-21 10:52:03 -0700 2017-09-21 11:49:41 -0700 Patch bug-177311-20170921105202.patch text/plain 1234 achristensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjIzMzEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA5LTIxICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTWFrZSBTdHJpbmdCdWlsZGVyIG1v dmFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NzMxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog d3RmL3RleHQvU3RyaW5nQnVpbGRlci5oOgorICAgICAgICAoV1RGOjpTdHJpbmdCdWlsZGVyOjpT dHJpbmdCdWlsZGVyKToKKwogMjAxNy0wOS0yMCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVy QGFwcGxlLmNvbT4KIAogICAgICAgICBKU0Mgc2hvdWxkIHVzZSB1bmlmaWVkIHNvdXJjZXMgZm9y IHBsYXRmb3JtIHNwZWNpZmljIGZpbGVzLgpJbmRleDogU291cmNlL1dURi93dGYvdGV4dC9TdHJp bmdCdWlsZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdCdWls ZGVyLmgJKHJldmlzaW9uIDIyMjMwNSkKKysrIFNvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQnVp bGRlci5oCSh3b3JraW5nIGNvcHkpCkBAIC00Miw5ICs0MiwxMSBAQCBwdWJsaWM6CiAgICAgU3Ry aW5nQnVpbGRlcigpCiAgICAgICAgIDogbV9sZW5ndGgoMCkKICAgICAgICAgLCBtX2lzOEJpdCh0 cnVlKQotICAgICAgICAsIG1fYnVmZmVyQ2hhcmFjdGVyczgoMCkKKyAgICAgICAgLCBtX2J1ZmZl ckNoYXJhY3RlcnM4KG51bGxwdHIpCiAgICAgewogICAgIH0KKyAgICBTdHJpbmdCdWlsZGVyKFN0 cmluZ0J1aWxkZXImJikgPSBkZWZhdWx0OworICAgIFN0cmluZ0J1aWxkZXImIG9wZXJhdG9yPShT dHJpbmdCdWlsZGVyJiYpID0gZGVmYXVsdDsKIAogICAgIFdURl9FWFBPUlRfUFJJVkFURSB2b2lk IGFwcGVuZChjb25zdCBVQ2hhciosIHVuc2lnbmVkKTsKICAgICBXVEZfRVhQT1JUX1BSSVZBVEUg dm9pZCBhcHBlbmQoY29uc3QgTENoYXIqLCB1bnNpZ25lZCk7Cg==