177308 2017-09-21 09:52:36 -0700 eventInitDict parameter to GamepadEvent constructor should be optional 2017-09-27 12:19:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=154246 InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson buildbot commit-queue darin esprehn+autocc ggaren kondapallykalyan sam webkit-bug-importer oldest_to_newest 1351233 0 cdumez 2017-09-21 09:52:36 -0700 eventInitDict parameter to GamepadEvent constructor should be optional to match Firefox and Chrome. 1351234 1 cdumez 2017-09-21 09:54:55 -0700 Per Web IDL: """ If the type of an argument is a dictionary type (or a union type that has a dictionary as one of its flattened member types), and that dictionary type and its ancestors have no required members, and the argument is either the final argument or is followed only by optional arguments, then the argument must be specified as optional. Such arguments are always considered to have a default value of an empty dictionary, unless otherwise specified. """ 1351244 2 321443 cdumez 2017-09-21 10:25:31 -0700 Created attachment 321443 Patch 1351257 3 cdumez 2017-09-21 10:40:00 -0700 Spec at https://w3c.github.io/gamepad/#gamepadevent-interface is wrong, see https://github.com/w3c/gamepad/issues/35 1351365 4 321443 sam 2017-09-21 13:44:55 -0700 Comment on attachment 321443 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321443&action=review > Source/WebCore/ChangeLog:9 > + and Chrome. Having such dictionary parameter is also not valid Web IDL: Can you make this an error in the generator? 1351368 5 321443 cdumez 2017-09-21 13:46:57 -0700 Comment on attachment 321443 Patch Clearing flags on attachment: 321443 Committed r222348: <http://trac.webkit.org/changeset/222348> 1351369 6 cdumez 2017-09-21 13:46:59 -0700 All reviewed patches have been landed. Closing bug. 1351995 7 321443 darin 2017-09-23 14:59:25 -0700 Comment on attachment 321443 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321443&action=review >> Source/WebCore/ChangeLog:9 >> + and Chrome. Having such dictionary parameter is also not valid Web IDL: > > Can you make this an error in the generator? Heh, I came here to ask the same question. 1352229 8 cdumez 2017-09-25 09:44:24 -0700 (In reply to Darin Adler from comment #7) > Comment on attachment 321443 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321443&action=review > > >> Source/WebCore/ChangeLog:9 > >> + and Chrome. Having such dictionary parameter is also not valid Web IDL: > > > > Can you make this an error in the generator? > > Heh, I came here to ask the same question. Yes, will take a look once I am done with some urgent tasks. 1353293 9 webkit-bug-importer 2017-09-27 12:19:34 -0700 <rdar://problem/34693049> 321443 2017-09-21 10:25:31 -0700 2017-09-21 13:46:57 -0700 Patch bug-177308-20170921102531.patch text/plain 4958 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmQ5MmNmNGFkNjUxNzlh NmYwOTY4NTc1OGZlOTAyNzEzMjU4YWY0YS4uNzNkN2MyODQ5Mjg1MmI3YWEwZWY0YzZmNzA5NDM3 NGMzMzYxZjQwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE3LTA5LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgZXZlbnRJbml0RGljdCBwYXJh bWV0ZXIgdG8gR2FtZXBhZEV2ZW50IGNvbnN0cnVjdG9yIHNob3VsZCBiZSBvcHRpb25hbAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3MzA4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZXZlbnRJbml0RGlj dCBwYXJhbWV0ZXIgdG8gR2FtZXBhZEV2ZW50IGNvbnN0cnVjdG9yIHNob3VsZCBiZSBvcHRpb25h bCB0byBtYXRjaCBGaXJlZm94CisgICAgICAgIGFuZCBDaHJvbWUuIEhhdmluZyBzdWNoIGRpY3Rp b25hcnkgcGFyYW1ldGVyIGlzIGFsc28gbm90IHZhbGlkIFdlYiBJREw6CisgICAgICAgICIiIgor ICAgICAgICBJZiB0aGUgdHlwZSBvZiBhbiBhcmd1bWVudCBpcyBhIGRpY3Rpb25hcnkgdHlwZSAo b3IgYSB1bmlvbiB0eXBlIHRoYXQgaGFzIGEgZGljdGlvbmFyeSBhcyBvbmUKKyAgICAgICAgb2Yg aXRzIGZsYXR0ZW5lZCBtZW1iZXIgdHlwZXMpLCBhbmQgdGhhdCBkaWN0aW9uYXJ5IHR5cGUgYW5k IGl0cyBhbmNlc3RvcnMgaGF2ZSBubyByZXF1aXJlZAorICAgICAgICBtZW1iZXJzLCBhbmQgdGhl IGFyZ3VtZW50IGlzIGVpdGhlciB0aGUgZmluYWwgYXJndW1lbnQgb3IgaXMgZm9sbG93ZWQgb25s eSBieSBvcHRpb25hbCBhcmd1bWVudHMsCisgICAgICAgIHRoZW4gdGhlIGFyZ3VtZW50IG11c3Qg YmUgc3BlY2lmaWVkIGFzIG9wdGlvbmFsLiBTdWNoIGFyZ3VtZW50cyBhcmUgYWx3YXlzIGNvbnNp ZGVyZWQgdG8gaGF2ZSBhCisgICAgICAgIGRlZmF1bHQgdmFsdWUgb2YgYW4gZW1wdHkgZGljdGlv bmFyeSwgdW5sZXNzIG90aGVyd2lzZSBzcGVjaWZpZWQuCisgICAgICAgICIiIgorCisgICAgICAg IFRlc3Q6IGdhbWVwYWQvZ2FtZXBhZC1ldmVudC5odG1sCisKKyAgICAgICAgKiBNb2R1bGVzL2dh bWVwYWQvR2FtZXBhZEV2ZW50LmlkbDoKKwogMjAxNy0wOS0yMSAgWmhpZmVpIEZBTkcgIDxmYWNl dG90aGVmYXRlQGdtYWlsLmNvbT4KIAogICAgICAgICBJbiByZWd1bGFyIGJsb2NrIGxheW91dCwg dGhlIHdpZHRoIG9mIGEgY2hpbGQncyBtYXJnaW4gYm94IHNob3VsZCBhbHdheXMgYmUgZXF1YWwg dG8gdGhhdCBvZiBpdHMgY29udGFpbmluZyBibG9jawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9nYW1lcGFkL0dhbWVwYWRFdmVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL2dhbWVwYWQvR2FtZXBhZEV2ZW50LmlkbAppbmRleCBkOTliMzc5ZjkwMDMyNmJmZDRiZDQ3 OTU5ZDZiYzVjYzQwMjFiNzNjLi44Nzc2NmU1YTdhNGViMjNjNjZiOTYzYzQyZGFjZjU4MTEwMGJk YmRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dhbWVwYWQvR2FtZXBhZEV2 ZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dhbWVwYWQvR2FtZXBhZEV2ZW50 LmlkbApAQCAtMjUsNyArMjUsNyBAQAogCiBbCiAgICAgQ29uZGl0aW9uYWw9R0FNRVBBRCwKLSAg ICBDb25zdHJ1Y3RvcihET01TdHJpbmcgdHlwZSwgR2FtZXBhZEV2ZW50SW5pdCBldmVudEluaXRE aWN0KSwKKyAgICBDb25zdHJ1Y3RvcihET01TdHJpbmcgdHlwZSwgb3B0aW9uYWwgR2FtZXBhZEV2 ZW50SW5pdCBldmVudEluaXREaWN0KSwKICAgICBFbmFibGVkQXRSdW50aW1lPUdhbWVwYWRzLAog XSBpbnRlcmZhY2UgR2FtZXBhZEV2ZW50IDogRXZlbnQgewogICAgIHJlYWRvbmx5IGF0dHJpYnV0 ZSBHYW1lcGFkPyBnYW1lcGFkOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQ4M2Y3ZTBlMTUxNzNiNTU1MmRhZjc4NWE5NzBm Nzg5N2MwMGZjOTguLjZjZjdjMzU0YjQ3YjU1YWE2MTgyZTUyYWQ4MjNjZDI3NzI1ODFkMGEgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wOS0yMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgorCisgICAgICAgIGV2ZW50SW5pdERpY3QgcGFyYW1ldGVyIHRvIEdhbWVwYWRFdmVu dCBjb25zdHJ1Y3RvciBzaG91bGQgYmUgb3B0aW9uYWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzMwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBsYXlvdXQgdGVzdCBjb3ZlcmFnZS4KKworICAg ICAgICAqIGdhbWVwYWQvZ2FtZXBhZC1ldmVudC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGdhbWVwYWQvZ2FtZXBhZC1ldmVudC5odG1sOiBBZGRlZC4KKwogMjAxNy0wOS0yMSAgWmhp ZmVpIEZBTkcgIDxmYWNldG90aGVmYXRlQGdtYWlsLmNvbT4KIAogICAgICAgICBJbiByZWd1bGFy IGJsb2NrIGxheW91dCwgdGhlIHdpZHRoIG9mIGEgY2hpbGQncyBtYXJnaW4gYm94IHNob3VsZCBh bHdheXMgYmUgZXF1YWwgdG8gdGhhdCBvZiBpdHMgY29udGFpbmluZyBibG9jawpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZ2FtZXBhZC9nYW1lcGFkLWV2ZW50LWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2dhbWVwYWQvZ2FtZXBhZC1ldmVudC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzU3 ZjM2NzAxMTM3M2FiMzA0MmU1YTdkZWI0ZWQzODVmOTIxZjQwNwotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2dhbWVwYWQvZ2FtZXBhZC1ldmVudC1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSwyMiBAQAorVGVzdHMgdGhlIEdhbWVwYWRFdmVudCBjb25zdHJ1Y3RvcgorCitPbiBzdWNjZXNz LCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAi VEVTVCBDT01QTEVURSIuCisKKworUEFTUyBuZXcgR2FtZXBhZEV2ZW50KCkgdGhyZXcgZXhjZXB0 aW9uIFR5cGVFcnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMuCitQQVNTIGV2ZW50ID0gbmV3IEdh bWVwYWRFdmVudCgndGVzdCcpIGRpZCBub3QgdGhyb3cgZXhjZXB0aW9uLgorUEFTUyBldmVudC50 eXBlIGlzICJ0ZXN0IgorUEFTUyBldmVudC5nYW1lcGFkIGlzIG51bGwKK1BBU1MgZXZlbnQuYnVi YmxlcyBpcyBmYWxzZQorUEFTUyBldmVudC5jYW5jZWxhYmxlIGlzIGZhbHNlCitQQVNTIGV2ZW50 LmNvbXBvc2VkIGlzIGZhbHNlCitQQVNTIGV2ZW50ID0gbmV3IEdhbWVwYWRFdmVudCgndGVzdCcs IHsnYnViYmxlcyc6IHRydWUsICdjYW5jZWxhYmxlJzogdHJ1ZSwgJ2NvbXBvc2VkJzogdHJ1ZSB9 KSBkaWQgbm90IHRocm93IGV4Y2VwdGlvbi4KK1BBU1MgZXZlbnQuZ2FtZXBhZCBpcyBudWxsCitQ QVNTIGV2ZW50LmJ1YmJsZXMgaXMgdHJ1ZQorUEFTUyBldmVudC5jYW5jZWxhYmxlIGlzIHRydWUK K1BBU1MgZXZlbnQuY29tcG9zZWQgaXMgdHJ1ZQorUEFTUyBuYXZpZ2F0b3IuZ2V0R2FtZXBhZHMg aXMgZGVmaW5lZC4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01Q TEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9nYW1lcGFkL2dhbWVwYWQtZXZlbnQuaHRt bCBiL0xheW91dFRlc3RzL2dhbWVwYWQvZ2FtZXBhZC1ldmVudC5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmIx M2ZiYjVjYmRkYmQwY2E4MWU3OWU0Mjk1YjcwOTRjOGM0ODNkNGMKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9nYW1lcGFkL2dhbWVwYWQtZXZlbnQuaHRtbApAQCAtMCwwICsxLDIzIEBA Cis8IURPQ1RZUEUgaHRtbD4KKzxib2R5PgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10 ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisgICAgZGVzY3JpcHRpb24oIlRlc3RzIHRoZSBH YW1lcGFkRXZlbnQgY29uc3RydWN0b3IiKTsKKworICAgIHNob3VsZFRocm93RXJyb3JOYW1lKCJu ZXcgR2FtZXBhZEV2ZW50KCkiLCAiVHlwZUVycm9yIik7CisgICAgc2hvdWxkTm90VGhyb3coImV2 ZW50ID0gbmV3IEdhbWVwYWRFdmVudCgndGVzdCcpIik7CisgICAgc2hvdWxkQmVFcXVhbFRvU3Ry aW5nKCJldmVudC50eXBlIiwgInRlc3QiKTsKKyAgICBzaG91bGRCZU51bGwoImV2ZW50LmdhbWVw YWQiKTsKKyAgICBzaG91bGRCZUZhbHNlKCJldmVudC5idWJibGVzIik7CisgICAgc2hvdWxkQmVG YWxzZSgiZXZlbnQuY2FuY2VsYWJsZSIpOworICAgIHNob3VsZEJlRmFsc2UoImV2ZW50LmNvbXBv c2VkIik7CisKKyAgICBzaG91bGROb3RUaHJvdygiZXZlbnQgPSBuZXcgR2FtZXBhZEV2ZW50KCd0 ZXN0JywgeydidWJibGVzJzogdHJ1ZSwgJ2NhbmNlbGFibGUnOiB0cnVlLCAnY29tcG9zZWQnOiB0 cnVlIH0pIik7CisgICAgc2hvdWxkQmVOdWxsKCJldmVudC5nYW1lcGFkIik7CisgICAgc2hvdWxk QmVUcnVlKCJldmVudC5idWJibGVzIik7CisgICAgc2hvdWxkQmVUcnVlKCJldmVudC5jYW5jZWxh YmxlIik7CisgICAgc2hvdWxkQmVUcnVlKCJldmVudC5jb21wb3NlZCIpOworCisgICAgc2hvdWxk QmVEZWZpbmVkKCJuYXZpZ2F0b3IuZ2V0R2FtZXBhZHMiKTsKKzwvc2NyaXB0PgorPC9ib2R5Pgo=