177306 2017-09-21 09:36:11 -0700 REGRESSION(r221465) WKWebViews without WebGL delegate callbacks crash when WebGL contexts are created 2017-09-27 12:19:35 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez darin webkit-bug-importer oldest_to_newest 1351219 0 achristensen 2017-09-21 09:36:11 -0700 REGRESSION(r221465) WKWebViews without WebGL delegate callbacks crash when WebGL contexts are created 1351221 1 321438 achristensen 2017-09-21 09:37:11 -0700 Created attachment 321438 Patch 1351223 2 321438 cdumez 2017-09-21 09:38:40 -0700 Comment on attachment 321438 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321438&action=review r=me > Source/WebKit/UIProcess/Cocoa/NavigationState.mm:311 > + return completionHandler(WebGLAllowCreation); I seem to remember Darin not liking this pattern and preferring doing this on 2 lines. > Source/WebKit/UIProcess/Cocoa/NavigationState.mm:326 > + return completionHandler(WebGLAllowCreation); ditto. 1351224 3 achristensen 2017-09-21 09:41:30 -0700 http://trac.webkit.org/r222322 1352098 4 321438 darin 2017-09-24 17:09:20 -0700 Comment on attachment 321438 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321438&action=review >> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:311 >> + return completionHandler(WebGLAllowCreation); > > I seem to remember Darin not liking this pattern and preferring doing this on 2 lines. I think that for the WebKit project style guide we have said we should do it on two lines. Maybe should write that out explicitly. But, to be clear, I personally am OK with this pattern, and might adopt it as the style for my own programming outside the WebKit project. As I understand it, this feature was originally added to C++ make template programming easier, rather than because the people proposing it thought it was elegant for non-template cases like this one. 1353294 5 webkit-bug-importer 2017-09-27 12:19:35 -0700 <rdar://problem/34693051> 321438 2017-09-21 09:37:11 -0700 2017-09-21 09:38:40 -0700 Patch bug-177306-20170921093710.patch text/plain 6556 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjIzMDYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA5LTIxICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjIxNDY1KSBXS1dlYlZpZXdzIHdpdGhvdXQgV2ViR0wgZGVsZWdhdGUgY2FsbGJhY2tzIGNyYXNo IHdoZW4gV2ViR0wgY29udGV4dHMgYXJlIGNyZWF0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzMwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0 ZS5tbToKKyAgICAgICAgKFdlYktpdDo6TmF2aWdhdGlvblN0YXRlOjpOYXZpZ2F0aW9uQ2xpZW50 Ojp3ZWJHTExvYWRQb2xpY3kgY29uc3QpOgorICAgICAgICAoV2ViS2l0OjpOYXZpZ2F0aW9uU3Rh dGU6Ok5hdmlnYXRpb25DbGllbnQ6OnJlc29sdmVXZWJHTExvYWRQb2xpY3kgY29uc3QpOgorICAg ICAgICBJIGZvcmdvdCB0byBlYXJseSByZXR1cm4gYWZ0ZXIgY2FsbGluZyB0aGUgZGVmYXVsdCBj b21wbGV0aW9uIGhhbmRsZXIgaWYgdGhlcmUncyBubyBkZWxlZ2F0ZSBzZWxlY3Rvci4KKwogMjAx Ny0wOS0yMCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAg ICAgICAgIEFkZCBpbmZyYXN0cnVjdHVyZSBmb3IgYWRkaW5nIGN1c3RvbSBoZWFkZXJzIHRvIHJl cXVlc3RzIHBlciB3ZWJzaXRlCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9O YXZpZ2F0aW9uU3RhdGUubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv Q29jb2EvTmF2aWdhdGlvblN0YXRlLm1tCShyZXZpc2lvbiAyMjIzMDUpCisrKyBTb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUubW0JKHdvcmtpbmcgY29weSkKQEAg LTMwOCw3ICszMDgsNyBAQCBpbmxpbmUgV2ViQ29yZTo6V2ViR0xMb2FkUG9saWN5IHRvV2ViQ29y CiB2b2lkIE5hdmlnYXRpb25TdGF0ZTo6TmF2aWdhdGlvbkNsaWVudDo6d2ViR0xMb2FkUG9saWN5 KFdlYlBhZ2VQcm94eSYsIGNvbnN0IFdlYkNvcmU6OlVSTCYgdXJsLCBXVEY6OkZ1bmN0aW9uPHZv aWQoV2ViQ29yZTo6V2ViR0xMb2FkUG9saWN5KT4mJiBjb21wbGV0aW9uSGFuZGxlcikgY29uc3QK IHsKICAgICBpZiAoIW1fbmF2aWdhdGlvblN0YXRlLm1fbmF2aWdhdGlvbkRlbGVnYXRlTWV0aG9k cy53ZWJWaWV3V2ViR0xMb2FkUG9saWN5Rm9yVVJMKQotICAgICAgICBjb21wbGV0aW9uSGFuZGxl cihXZWJHTEFsbG93Q3JlYXRpb24pOworICAgICAgICByZXR1cm4gY29tcGxldGlvbkhhbmRsZXIo V2ViR0xBbGxvd0NyZWF0aW9uKTsKIAogICAgIGF1dG8gbmF2aWdhdGlvbkRlbGVnYXRlID0gbV9u YXZpZ2F0aW9uU3RhdGUubV9uYXZpZ2F0aW9uRGVsZWdhdGUuZ2V0KCk7CiAgICAgUmVmPENvbXBs ZXRpb25IYW5kbGVyQ2FsbENoZWNrZXI+IGNoZWNrZXIgPSBDb21wbGV0aW9uSGFuZGxlckNhbGxD aGVja2VyOjpjcmVhdGUobmF2aWdhdGlvbkRlbGVnYXRlLmdldCgpLCBAc2VsZWN0b3IoX3dlYlZp ZXc6d2ViR0xMb2FkUG9saWN5Rm9yVVJMOmRlY2lzaW9uSGFuZGxlcjopKTsKQEAgLTMyMyw3ICsz MjMsNyBAQCB2b2lkIE5hdmlnYXRpb25TdGF0ZTo6TmF2aWdhdGlvbkNsaWVudDo6CiB2b2lkIE5h dmlnYXRpb25TdGF0ZTo6TmF2aWdhdGlvbkNsaWVudDo6cmVzb2x2ZVdlYkdMTG9hZFBvbGljeShX ZWJQYWdlUHJveHkmLCBjb25zdCBXZWJDb3JlOjpVUkwmIHVybCwgV1RGOjpGdW5jdGlvbjx2b2lk KFdlYkNvcmU6OldlYkdMTG9hZFBvbGljeSk+JiYgY29tcGxldGlvbkhhbmRsZXIpIGNvbnN0CiB7 CiAgICAgaWYgKCFtX25hdmlnYXRpb25TdGF0ZS5tX25hdmlnYXRpb25EZWxlZ2F0ZU1ldGhvZHMu d2ViVmlld1Jlc29sdmVXZWJHTExvYWRQb2xpY3lGb3JVUkwpCi0gICAgICAgIGNvbXBsZXRpb25I YW5kbGVyKFdlYkdMQWxsb3dDcmVhdGlvbik7CisgICAgICAgIHJldHVybiBjb21wbGV0aW9uSGFu ZGxlcihXZWJHTEFsbG93Q3JlYXRpb24pOwogICAgIAogICAgIGF1dG8gbmF2aWdhdGlvbkRlbGVn YXRlID0gbV9uYXZpZ2F0aW9uU3RhdGUubV9uYXZpZ2F0aW9uRGVsZWdhdGUuZ2V0KCk7CiAgICAg UmVmPENvbXBsZXRpb25IYW5kbGVyQ2FsbENoZWNrZXI+IGNoZWNrZXIgPSBDb21wbGV0aW9uSGFu ZGxlckNhbGxDaGVja2VyOjpjcmVhdGUobmF2aWdhdGlvbkRlbGVnYXRlLmdldCgpLCBAc2VsZWN0 b3IoX3dlYlZpZXc6cmVzb2x2ZVdlYkdMTG9hZFBvbGljeUZvclVSTDpkZWNpc2lvbkhhbmRsZXI6 KSk7CkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjIzMjEpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNSBAQAorMjAxNy0wOS0yMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIyMTQ2NSkgV0tXZWJWaWV3cyB3 aXRob3V0IFdlYkdMIGRlbGVnYXRlIGNhbGxiYWNrcyBjcmFzaCB3aGVuIFdlYkdMIGNvbnRleHRz IGFyZSBjcmVhdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzczMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV2ViR0xQb2xpY3kubW06Cisg ICAgICAgICgtW1dlYkdMVGVzdERlbGVnYXRlIHdlYlZpZXc6c3RhcnRVUkxTY2hlbWVUYXNrOl0p OgorICAgICAgICAoLVtEZWxlZ2F0ZVdpdGhvdXRXZWJHTCB3ZWJWaWV3OnJ1bkphdmFTY3JpcHRB bGVydFBhbmVsV2l0aE1lc3NhZ2U6aW5pdGlhdGVkQnlGcmFtZTpjb21wbGV0aW9uSGFuZGxlcjpd KToKKyAgICAgICAgKFRFU1QpOgorCiAyMDE3LTA5LTIwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNv cmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIHRlc3QyNjIgdGVzdHMKSW5kZXg6IFRv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV2ViR0xQb2xpY3kubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJHTFBvbGlj eS5tbQkocmV2aXNpb24gMjIyMzA1KQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9XZWJHTFBvbGljeS5tbQkod29ya2luZyBjb3B5KQpAQCAtNDMsNiArNDMsMjAgQEAg c3RhdGljIFJldGFpblB0cjxOU1N0cmluZz4gYWxlcnQ7CiBzdGF0aWMgYm9vbCB0ZXN0Q29tcGxl dGUgeyBmYWxzZSB9Owogc3RhdGljIFJldGFpblB0cjxOU1VSTD4gaHRtbFVSTDsKIAorc3RhdGlj IE5TU3RyaW5nICpkYXRhID0gQCI8c2NyaXB0PiIKKyAgICAidmFyIGNhbnZhcyA9IGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoJ2NhbnZhcycpOyIKKyAgICAidmFyIGNvbnRleHQgPSBjYW52YXMuZ2V0 Q29udGV4dCgnd2ViZ2wnKTsiCisgICAgImlmIChjb250ZXh0KSB7IgorICAgICAgICAidmFyIGZy YW1lYnVmZmVyID0gY29udGV4dC5jcmVhdGVGcmFtZWJ1ZmZlcigpOyIKKyAgICAgICAgInZhciBz dGF0dXMgPSBjb250ZXh0LmNoZWNrRnJhbWVidWZmZXJTdGF0dXMoY29udGV4dC5GUkFNRUJVRkZF Uik7IgorICAgICAgICAiaWYgKHN0YXR1cyA9PSBjb250ZXh0LkZSQU1FQlVGRkVSX1VOU1VQUE9S VEVEKSIKKyAgICAgICAgICAgICJhbGVydCgnZG9pbmcgc3R1ZmYgd2l0aCB3ZWJnbCBjb250ZXh0 IGZhaWxlZCcpOyIKKyAgICAgICAgImVsc2UgaWYgKHN0YXR1cyA9PSBjb250ZXh0LkZSQU1FQlVG RkVSX0NPTVBMRVRFKSIKKyAgICAgICAgICAgICJhbGVydCgnZG9pbmcgc3R1ZmYgd2l0aCB3ZWJn bCBjb250ZXh0IHN1Y2NlZWRlZCcpOyIKKyAgICAgICAgImVsc2UgYWxlcnQoJ3VuZXhwZWN0ZWQg c3RhdHVzJyk7IgorICAgICJ9IGVsc2UgYWxlcnQoJ3dlYmdsIGNvbnRleHQgY3JlYXRpb24gZmFp bGVkJyk7IgorIjwvc2NyaXB0PiI7CisKIEBpbnRlcmZhY2UgV2ViR0xUZXN0RGVsZWdhdGUgOiBO U09iamVjdCA8V0tOYXZpZ2F0aW9uRGVsZWdhdGVQcml2YXRlLCBXS1VJRGVsZWdhdGUsIFdLVVJM U2NoZW1lSGFuZGxlcj4KIEBlbmQKICAgICAKQEAgLTUwLDE5ICs2NCw2IEBAIEBpbnRlcmZhY2Ug V2ViR0xUZXN0RGVsZWdhdGUgOiBOU09iamVjdCAKIAogLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZp ZXcgKil3ZWJWaWV3IHN0YXJ0VVJMU2NoZW1lVGFzazooaWQgPFdLVVJMU2NoZW1lVGFzaz4pdXJs U2NoZW1lVGFzawogewotICAgIE5TU3RyaW5nICpkYXRhID0gQCI8c2NyaXB0PiIKLSAgICAgICAg InZhciBjYW52YXMgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdjYW52YXMnKTsiCi0gICAgICAg ICJ2YXIgY29udGV4dCA9IGNhbnZhcy5nZXRDb250ZXh0KCd3ZWJnbCcpOyIKLSAgICAgICAgImlm IChjb250ZXh0KSB7IgotICAgICAgICAgICAgInZhciBmcmFtZWJ1ZmZlciA9IGNvbnRleHQuY3Jl YXRlRnJhbWVidWZmZXIoKTsiCi0gICAgICAgICAgICAidmFyIHN0YXR1cyA9IGNvbnRleHQuY2hl Y2tGcmFtZWJ1ZmZlclN0YXR1cyhjb250ZXh0LkZSQU1FQlVGRkVSKTsiCi0gICAgICAgICAgICAi aWYgKHN0YXR1cyA9PSBjb250ZXh0LkZSQU1FQlVGRkVSX1VOU1VQUE9SVEVEKSIKLSAgICAgICAg ICAgICAgICAiYWxlcnQoJ2RvaW5nIHN0dWZmIHdpdGggd2ViZ2wgY29udGV4dCBmYWlsZWQnKTsi Ci0gICAgICAgICAgICAiZWxzZSBpZiAoc3RhdHVzID09IGNvbnRleHQuRlJBTUVCVUZGRVJfQ09N UExFVEUpIgotICAgICAgICAgICAgICAgICJhbGVydCgnZG9pbmcgc3R1ZmYgd2l0aCB3ZWJnbCBj b250ZXh0IHN1Y2NlZWRlZCcpOyIKLSAgICAgICAgICAgICJlbHNlIGFsZXJ0KCd1bmV4cGVjdGVk IHN0YXR1cycpOyIKLSAgICAgICAgIn0gZWxzZSBhbGVydCgnd2ViZ2wgY29udGV4dCBjcmVhdGlv biBmYWlsZWQnKTsiCi0gICAgIjwvc2NyaXB0PiI7CiAgICAgW3VybFNjaGVtZVRhc2sgZGlkUmVj ZWl2ZVJlc3BvbnNlOltbW05TVVJMUmVzcG9uc2UgYWxsb2NdIGluaXRXaXRoVVJMOnVybFNjaGVt ZVRhc2sucmVxdWVzdC5VUkwgTUlNRVR5cGU6QCJ0ZXh0L2h0bWwiIGV4cGVjdGVkQ29udGVudExl bmd0aDpkYXRhLmxlbmd0aCB0ZXh0RW5jb2RpbmdOYW1lOm5pbF0gYXV0b3JlbGVhc2VdXTsKICAg ICBbdXJsU2NoZW1lVGFzayBkaWRSZWNlaXZlRGF0YTpbZGF0YSBkYXRhVXNpbmdFbmNvZGluZzpO U1VURjhTdHJpbmdFbmNvZGluZ11dOwogICAgIFt1cmxTY2hlbWVUYXNrIGRpZEZpbmlzaF07CkBA IC0xNDAsNCArMTQxLDI3IEBAIFRFU1QoV2ViS2l0LCBXZWJHTFBvbGljeSkKICAgICBFWFBFQ1Rf VFJVRShbaHRtbFVSTCBpc0VxdWFsOnNlY29uZFVSTC5nZXQoKV0pOwogfQogCitAaW50ZXJmYWNl IERlbGVnYXRlV2l0aG91dFdlYkdMIDogTlNPYmplY3QgPFdLVUlEZWxlZ2F0ZT4KK0BlbmQKKwor QGltcGxlbWVudGF0aW9uIERlbGVnYXRlV2l0aG91dFdlYkdMCisKKy0gKHZvaWQpd2ViVmlldzoo V0tXZWJWaWV3ICopd2ViVmlldyBydW5KYXZhU2NyaXB0QWxlcnRQYW5lbFdpdGhNZXNzYWdlOihO U1N0cmluZyAqKW1lc3NhZ2UgaW5pdGlhdGVkQnlGcmFtZTooV0tGcmFtZUluZm8gKilmcmFtZSBj b21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikodm9pZCkpY29tcGxldGlvbkhhbmRsZXIKK3sKKyAg ICBhbGVydCA9IG1lc3NhZ2U7CisgICAgdGVzdENvbXBsZXRlID0gdHJ1ZTsKKyAgICBjb21wbGV0 aW9uSGFuZGxlcigpOworfQorCitAZW5kCisKK1RFU1QoV2ViS2l0LCBXZWJHTFBvbGljeU5vRGVs ZWdhdGUpCit7CisgICAgYXV0byBkZWxlZ2F0ZSA9IGFkb3B0TlMoW1tEZWxlZ2F0ZVdpdGhvdXRX ZWJHTCBhbGxvY10gaW5pdF0pOworICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tXS1dlYlZp ZXcgYWxsb2NdIGluaXRdKTsKKyAgICBbd2ViVmlldyBzZXRVSURlbGVnYXRlOmRlbGVnYXRlLmdl dCgpXTsKKyAgICBbd2ViVmlldyBsb2FkSFRNTFN0cmluZzpkYXRhIGJhc2VVUkw6W05TVVJMIFVS TFdpdGhTdHJpbmc6QCJodHRwOi8vZXhhbXBsZS5jb20vIl1dOworICAgIFRlc3RXZWJLaXRBUEk6 OlV0aWw6OnJ1bigmdGVzdENvbXBsZXRlKTsKK30KKwogI2VuZGlmIC8vIFdLX0FQSV9FTkFCTEVE Cg==