177295 2017-09-21 02:14:23 -0700 [GTK] Couple of pasteboard related tests are failing after r222228 2017-09-22 07:45:54 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez Ms2ger bugs-noreply commit-queue mcatanzaro Ms2ger rniwa oldest_to_newest 1351159 0 magomez 2017-09-21 02:14:23 -0700 editing/pasteboard/copy-without-selection.html [ Failure ] editing/pasteboard/pasting-empty-html-falls-back-to-text.html [ Failure ] 1351199 1 Ms2ger 2017-09-21 09:03:20 -0700 I looked at editing/pasteboard/copy-without-selection.html for a bit. So far I've found that DataTransfer::createForCopyAndPaste only creates a StaticPasteboard when mode is StoreMode::ReadWrite; this is the case for the copy event, but not the paste event. I'm not sure how this is supposed to work, given that both events get a different pasteboard. 1351621 2 321536 Ms2ger 2017-09-22 06:05:48 -0700 Created attachment 321536 Patch 1351639 3 321536 mcatanzaro 2017-09-22 07:17:12 -0700 Comment on attachment 321536 Patch Good job, thanks! The only thing I'm not sure about is why r222228 caused this regression, but it's clear that not calling writeToClipboard() is bad. 1351654 4 321536 commit-queue 2017-09-22 07:45:52 -0700 Comment on attachment 321536 Patch Clearing flags on attachment: 321536 Committed r222387: <http://trac.webkit.org/changeset/222387> 1351655 5 commit-queue 2017-09-22 07:45:54 -0700 All reviewed patches have been landed. Closing bug. 321536 2017-09-22 06:05:48 -0700 2017-09-22 07:45:52 -0700 Patch bug-177295-20170922150546.patch text/plain 3823 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjg3ZTUzOGIzNTFkYjM5 NzRiMGU5MTg3Zjg5NmMyY2FjNmExZjEzMi4uZmI0ZGRiZTAwNGEzNmJkZTAyZDg2ZTlhNmNhZjQx MjliZDdjZTA0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA5LTIyICBNczJn ZXIgIDxNczJnZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBDb3VwbGUgb2YgcGFzdGVi b2FyZCByZWxhdGVkIHRlc3RzIGFyZSBmYWlsaW5nIGFmdGVyIHIyMjIyMjgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzI5NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGwgd3JpdGVUb0NsaXBib2Fy ZCgpIGZyb20gUGFzdGVib2FyZDo6d3JpdGVTdHJpbmcoKSBvbiBHVEsuCisKKyAgICAgICAgV2hl biB3cml0ZVBhc3RlYm9hcmQgd2FzIHJlcGxhY2VkIGJ5IGNvbW1pdFRvUGFzdGVib2FyZCBpbiBy MjIyMjI4LAorICAgICAgICB0aGUgY2FsbCB0byB3cml0ZVRvQ2xpcGJvYXJkKCkgZGlkIG5vdCBt YWtlIGl0IGludG8gdGhlCisgICAgICAgIHBsYXRmb3JtLW5ldXRyYWwgY29kZS4gVGhpcyBhdHRl bXB0cyB0byBmaW5kIGFub3RoZXIgcGxhY2UgaW4gdGhlCisgICAgICAgIEdUSy1zcGVjaWZpYyBj b2RlIHRvIG1ha2UgdGhlIGNhbGwuCisKKyAgICAgICAgVGVzdHM6IGVkaXRpbmcvcGFzdGVib2Fy ZC9jb3B5LXdpdGhvdXQtc2VsZWN0aW9uLmh0bWwKKyAgICAgICAgICAgICAgIGVkaXRpbmcvcGFz dGVib2FyZC9wYXN0aW5nLWVtcHR5LWh0bWwtZmFsbHMtYmFjay10by10ZXh0Lmh0bWwKKworICAg ICAgICAqIHBsYXRmb3JtL2d0ay9QYXN0ZWJvYXJkR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlBhc3RlYm9hcmQ6OndyaXRlU3RyaW5nKToKKwogMjAxNy0wOS0yMSAgQnJlbnQgRnVsZ2hhbSAg PGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjIxMDE3KTogaUNs b3VkIG1haWwgbG9ncyBtZSBvdXQgYWZ0ZXIgbG9va2luZyBhdCBhIGZldyBtZXNzYWdlcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRHdGsuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRHdGsuY3BwCmluZGV4IGJkOTJh MjcxMTQ4ZWZmZGE4ZDEwNGU5YzJlZDY3YThjM2IyYTdmZGUuLjk3NGQzZWEyYjAyNjJjMTlhYjVj YTUxMzA4OGVmNjg0NzYwN2I3MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9QYXN0ZWJvYXJkR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv UGFzdGVib2FyZEd0ay5jcHAKQEAgLTEzMywxOSArMTMzLDIwIEBAIHZvaWQgUGFzdGVib2FyZDo6 d3JpdGVTdHJpbmcoY29uc3QgU3RyaW5nJiB0eXBlLCBjb25zdCBTdHJpbmcmIGRhdGEpCiAgICAg Y2FzZSBDbGlwYm9hcmREYXRhVHlwZVVSSUxpc3Q6CiAgICAgY2FzZSBDbGlwYm9hcmREYXRhVHlw ZVVSTDoKICAgICAgICAgbV9zZWxlY3Rpb25EYXRhLT5zZXRVUklMaXN0KGRhdGEpOwotICAgICAg ICByZXR1cm47CisgICAgICAgIGJyZWFrOwogICAgIGNhc2UgQ2xpcGJvYXJkRGF0YVR5cGVNYXJr dXA6CiAgICAgICAgIG1fc2VsZWN0aW9uRGF0YS0+c2V0TWFya3VwKGRhdGEpOwotICAgICAgICBy ZXR1cm47CisgICAgICAgIGJyZWFrOwogICAgIGNhc2UgQ2xpcGJvYXJkRGF0YVR5cGVUZXh0Ogog ICAgICAgICBtX3NlbGVjdGlvbkRhdGEtPnNldFRleHQoZGF0YSk7Ci0gICAgICAgIHJldHVybjsK KyAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBDbGlwYm9hcmREYXRhVHlwZVVua25vd246CiAgICAg ICAgIG1fc2VsZWN0aW9uRGF0YS0+c2V0VW5rbm93blR5cGVEYXRhKHR5cGUsIGRhdGEpOwotICAg ICAgICByZXR1cm47CisgICAgICAgIGJyZWFrOwogICAgIGNhc2UgQ2xpcGJvYXJkRGF0YVR5cGVJ bWFnZToKICAgICAgICAgYnJlYWs7CiAgICAgfQorICAgIHdyaXRlVG9DbGlwYm9hcmQoKTsKIH0K IAogdm9pZCBQYXN0ZWJvYXJkOjp3cml0ZVBsYWluVGV4dChjb25zdCBTdHJpbmcmIHRleHQsIFNt YXJ0UmVwbGFjZU9wdGlvbiBzbWFydFJlcGxhY2VPcHRpb24pCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjM2NTM4MzM2ZTIx MmI1YjQ5MDNjNDQ2MjVmYjIxMzlhZGQ5YTBjNi4uYWQzMzY2MmU2NDYxOWUwOThhMjQ4NWJhYjRl NjVhYTgyMzgwOTMxYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA5LTIyICBNczJnZXIg IDxNczJnZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBDb3VwbGUgb2YgcGFzdGVib2Fy ZCByZWxhdGVkIHRlc3RzIGFyZSBmYWlsaW5nIGFmdGVyIHIyMjIyMjgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzI5NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBl Y3RhdGlvbnM6IG1hcmsgdGhlIHRlc3RzIGFzIHBhc3NpbmcgYWdhaW4uCisKIDIwMTctMDktMjEg IEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lP TiAocjIyMTAxNyk6IGlDbG91ZCBtYWlsIGxvZ3MgbWUgb3V0IGFmdGVyIGxvb2tpbmcgYXQgYSBm ZXcgbWVzc2FnZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhw ZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5k ZXggNzhlYzhhNWU2NTgwMmZlZmQ5YzAyYTNjZWQ3MDliYWFhODI5NTM1Ni4uYTQ2MWNjNWEzY2Iy MmQ1M2IzMzgzZWEyOWI0ZDM5NDY5YjRmZmI1YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTM0NjUsOSArMzQ2NSw2IEBAIHdlYmtpdC5vcmcvYi8xNzY2 NTIgaHR0cC90ZXN0cy9jYWNoZS1zdG9yYWdlL2NhY2hlLW9yaWdpbnMuaHR0cHMuaHRtbCBbIEZh aWx1cmUKIHdlYmtpdC5vcmcvYi8xNzcyOTQgcGxhdGZvcm0vZ3RrL2ZvbnRzL2ZvbnRjb25maWct YWxpYXNpbmctc2V0dGluZ3MuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE3NzI5NCBm YXN0L3RleHQvZml0enBhdHJpY2stY29tYmluYXRpb24uaHRtbCBbIEltYWdlT25seUZhaWx1cmUg XQogCi13ZWJraXQub3JnL2IvMTc3Mjk1IGVkaXRpbmcvcGFzdGVib2FyZC9jb3B5LXdpdGhvdXQt c2VsZWN0aW9uLmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xNzcyOTUgZWRpdGluZy9w YXN0ZWJvYXJkL3Bhc3RpbmctZW1wdHktaHRtbC1mYWxscy1iYWNrLXRvLXRleHQuaHRtbCBbIEZh aWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMTc3Mjk2IGVkaXRpbmcvZGVsZXRpbmcvc21hcnQtZGVs ZXRlLTAwMi5odG1sIFsgRmFpbHVyZSBdCiAKICMvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vCg==