<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>177279</bug_id>
          
          <creation_ts>2017-09-20 15:58:56 -0700</creation_ts>
          <short_desc>[Win][JSCOnly] Make jsconly build testapi and dlls and copy dlls when running tests</short_desc>
          <delta_ts>2017-11-15 13:06:28 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Stephan Szabo">stephan.szabo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>commit-queue</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>lforschler</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1351039</commentid>
    <comment_count>0</comment_count>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2017-09-20 15:58:56 -0700</bug_when>
    <thetext>Non-jsc-only Windows builds of the JSC shell build a jscLib.dll and testapi* differently from other builds.
Do the same for jsc-only windows builds and copy the dll along with the jsc executable when copying in run-jsc-stress-tests on Windows.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1351047</commentid>
    <comment_count>1</comment_count>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2017-09-20 16:13:28 -0700</bug_when>
    <thetext>Also, there are some definitions we set up in OptionsWin that we probably should also be setting in OptionsJSCOnly when we&apos;re on Windows.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1351426</commentid>
    <comment_count>2</comment_count>
      <attachid>321487</attachid>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2017-09-21 15:55:32 -0700</bug_when>
    <thetext>Created attachment 321487
Build jsc/testapi/testmasm on windows jsc-only similar to win platform</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1351691</commentid>
    <comment_count>3</comment_count>
      <attachid>321487</attachid>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2017-09-22 10:19:36 -0700</bug_when>
    <thetext>Comment on attachment 321487
Build jsc/testapi/testmasm on windows jsc-only similar to win platform

So, it seems like we do need more of the Windows configuration than initially thought in order for the whole test side to be happier. I&apos;m not sure if it&apos;s time to move some of those options elsewhere or if this is still okay.

Added Yusuke Suzuki to cc list because he made a comment on the subject in https://bugs.webkit.org/show_bug.cgi?id=172833 and seemed like it would be good to get opinion.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1359233</commentid>
    <comment_count>4</comment_count>
      <attachid>321487</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-10-11 10:27:18 -0700</bug_when>
    <thetext>Comment on attachment 321487
Build jsc/testapi/testmasm on windows jsc-only similar to win platform

View in context: https://bugs.webkit.org/attachment.cgi?id=321487&amp;action=review

Making JSC tests work in Windows (in JSCOnly port) is great. I have several questions.

&gt; Source/JavaScriptCore/shell/PlatformJSCOnly.cmake:3
&gt; +    add_definitions(-DWIN_CAIRO)

Is this necessary? JSCOnly port is not relying on Cairo.

&gt; Source/JavaScriptCore/shell/PlatformJSCOnly.cmake:4
&gt; +endif ()

Why can&apos;t we do the same to the other non-Windows port (and removing PlatformWin.cmake)?
Is there any specific issues for Windows port?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1359248</commentid>
    <comment_count>5</comment_count>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2017-10-11 10:52:54 -0700</bug_when>
    <thetext>&gt; &gt; Source/JavaScriptCore/shell/PlatformJSCOnly.cmake:3
&gt; &gt; +    add_definitions(-DWIN_CAIRO)
&gt; Is this necessary? JSCOnly port is not relying on Cairo.

Right now shell/DLLLauncherMain.cpp checks for WIN_CAIRO in places to separate it from applewin, for example 
https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/shell/DLLLauncherMain.cpp#L125
where the library path added differs. And we&apos;re currently really only handling the wincairo paths in jsc-only, but that might change.

That file&apos;s related to the tiny launcher app mentioned in the below.

&gt; Why can&apos;t we do the same to the other non-Windows port (and removing  PlatformWin.cmake)?
&gt; Is there any specific issues for Windows port?

I&apos;m not sure of the history, but the shell, testapi, etc on Windows (non-jsc-only) build a separate &lt;something&gt;Lib.dll and then a small launcher to run the code from the dll. The description from when the launcher seemed to be added seemed like it was related to getting the apple support libraries for the testapi and similar apps.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1359252</commentid>
    <comment_count>6</comment_count>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2017-10-11 11:00:02 -0700</bug_when>
    <thetext>And I guess even for wincairo-ish builds it prevents you from needing to add the support library directory to your PATH if you have WEBKIT_LIBRARIES defined properly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1363725</commentid>
    <comment_count>7</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-10-24 10:30:24 -0700</bug_when>
    <thetext>(In reply to Stephan Szabo from comment #5)
&gt; Right now shell/DLLLauncherMain.cpp checks for WIN_CAIRO in places to
&gt; separate it from applewin, for example 
&gt; https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/shell/
&gt; DLLLauncherMain.cpp#L125
&gt; where the library path added differs. And we&apos;re currently really only
&gt; handling the wincairo paths in jsc-only, but that might change.
&gt; 
&gt; That file&apos;s related to the tiny launcher app mentioned in the below.
&gt;
&gt; I&apos;m not sure of the history, but the shell, testapi, etc on Windows
&gt; (non-jsc-only) build a separate &lt;something&gt;Lib.dll and then a small launcher
&gt; to run the code from the dll. The description from when the launcher seemed
&gt; to be added seemed like it was related to getting the apple support
&gt; libraries for the testapi and similar apps.

OK, if there is no reason for this, I believe Windows difference should be removed. But it&apos;s ok for now.
Could you add FIXME to clean up these things if there is no reason to make Win build results separated from others?
Adding the FIXME comment to PlatformJSCOnly.cmake is preferable.

# FIXME: https://bugs.webkit.org/url-to-newly-filed-bug
# description...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1363752</commentid>
    <comment_count>8</comment_count>
      <attachid>324684</attachid>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2017-10-24 11:00:17 -0700</bug_when>
    <thetext>Created attachment 324684
Build jsc/testapi/testmasm on windows jsc-only similar to win platform - added fixme</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1363785</commentid>
    <comment_count>9</comment_count>
      <attachid>324684</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-10-24 11:46:35 -0700</bug_when>
    <thetext>Comment on attachment 324684
Build jsc/testapi/testmasm on windows jsc-only similar to win platform - added fixme

Clearing flags on attachment: 324684

Committed r223904: &lt;https://trac.webkit.org/changeset/223904&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1372363</commentid>
    <comment_count>10</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-11-15 13:06:28 -0800</bug_when>
    <thetext>&lt;rdar://problem/35568802&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>321487</attachid>
            <date>2017-09-21 15:55:32 -0700</date>
            <delta_ts>2017-10-24 10:30:30 -0700</delta_ts>
            <desc>Build jsc/testapi/testmasm on windows jsc-only similar to win platform</desc>
            <filename>177279-1.diff</filename>
            <type>text/plain</type>
            <size>4635</size>
            <attacher name="Stephan Szabo">stephan.szabo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzZmUzOGI1M2YyOC4uNzJk
MDA3ZDE5NTcgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxMiBAQAorMjAxNy0wOS0yMSAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5j
b20+CisKKyAgICAgICAgW1dpbl1bSlNDT25seV0gTWFrZSBqc2Nvbmx5IGJ1aWxkIHRlc3RhcGkg
YW5kIGRsbHMgYW5kIGNvcHkgZGxscyB3aGVuIHJ1bm5pbmcgdGVzdHMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzI3OQorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNK
U0NPbmx5LmNtYWtlOgorCiAyMDE3LTA5LTE5ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAg
PGNsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDTWFrZV0gQWRkIEVOQUJMRV9XRUJfQ1JZ
UFRPIG9wdGlvbiBhbmQgbWFrZSBFTkFCTEVfU1VCVExFX0NSWVBUTyBkZXBlbmQgb24gaXQuCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFT
Y3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAzNjU3NWY0MTAwMy4uYzRiMDIzYzg3MzEgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFT
Y3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA5LTIxICBTdGVwaGFu
IFN6YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4KKworICAgICAgICBbV2luXVtKU0NPbmx5
XSBNYWtlIGpzY29ubHkgYnVpbGQgdGVzdGFwaSBhbmQgZGxscyBhbmQgY29weSBkbGxzIHdoZW4g
cnVubmluZyB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTc3Mjc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgKiBzaGVsbC9QbGF0Zm9ybUpTQ09ubHkuY21ha2U6IEFkZGVkLgorCiAyMDE3LTA5LTE4
ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgRXJyb3JJbnN0YW5j
ZSBhbmQgRXhjZXB0aW9uIG5lZWQgZGVzdHJveSBtZXRob2RzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvc2hlbGwvUGxhdGZvcm1KU0NPbmx5LmNtYWtlIGIvU291cmNlL0phdmFT
Y3JpcHRDb3JlL3NoZWxsL1BsYXRmb3JtSlNDT25seS5jbWFrZQpuZXcgZmlsZSBtb2RlIDEwMDY0
NAppbmRleCAwMDAwMDAwMDAwMC4uNmFhYTQwYjliNjcKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvc2hlbGwvUGxhdGZvcm1KU0NPbmx5LmNtYWtlCkBAIC0wLDAgKzEs
NCBAQAoraWYgKFdJTjMyKQorICAgIGluY2x1ZGUoUGxhdGZvcm1XaW4uY21ha2UpCisgICAgYWRk
X2RlZmluaXRpb25zKC1EV0lOX0NBSVJPKQorZW5kaWYgKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9j
bWFrZS9PcHRpb25zSlNDT25seS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zSlNDT25seS5j
bWFrZQppbmRleCA5ZTNmNjBkYzZhNS4uZDEzMzcyZjUxOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9j
bWFrZS9PcHRpb25zSlNDT25seS5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0pTQ09u
bHkuY21ha2UKQEAgLTUzLDYgKzUzLDggQEAgZW5kaWYgKCkKIAogaWYgKFdJTjMyKQogICAgIGFk
ZF9kZWZpbml0aW9ucygtRE5PTUlOTUFYKQorICAgIGFkZF9kZWZpbml0aW9ucygtRF9XSU5ET1dT
IC1EV0lOVkVSPTB4NjAxIC1EX1dJTjMyX1dJTk5UPTB4NjAxKQorICAgIGFkZF9kZWZpbml0aW9u
cygtRFVOSUNPREUgLURfVU5JQ09ERSkKIAogICAgIGlmIChOT1QgV0VCS0lUX0xJQlJBUklFU19E
SVIpCiAgICAgICAgIGlmIChERUZJTkVEIEVOVntXRUJLSVRfTElCUkFSSUVTfSkKQEAgLTcxLDYg
KzczLDEzIEBAIGlmIChXSU4zMikKICAgICAgICAgc2V0KENNQUtFX0xJQlJBUllfT1VUUFVUX0RJ
UkVDVE9SWSAke0NNQUtFX0JJTkFSWV9ESVJ9L2xpYjY0KQogICAgICAgICBzZXQoQ01BS0VfUlVO
VElNRV9PVVRQVVRfRElSRUNUT1JZICR7Q01BS0VfQklOQVJZX0RJUn0vYmluKQogICAgIGVuZGlm
ICgpCisKKyAgICBzZXQoQ01BS0VfQVJDSElWRV9PVVRQVVRfRElSRUNUT1JZX0RFQlVHICIke0NN
QUtFX0FSQ0hJVkVfT1VUUFVUX0RJUkVDVE9SWX0iKQorICAgIHNldChDTUFLRV9BUkNISVZFX09V
VFBVVF9ESVJFQ1RPUllfUkVMRUFTRSAiJHtDTUFLRV9BUkNISVZFX09VVFBVVF9ESVJFQ1RPUll9
IikKKyAgICBzZXQoQ01BS0VfTElCUkFSWV9PVVRQVVRfRElSRUNUT1JZX0RFQlVHICIke0NNQUtF
X0xJQlJBUllfT1VUUFVUX0RJUkVDVE9SWX0iKQorICAgIHNldChDTUFLRV9MSUJSQVJZX09VVFBV
VF9ESVJFQ1RPUllfUkVMRUFTRSAiJHtDTUFLRV9MSUJSQVJZX09VVFBVVF9ESVJFQ1RPUll9IikK
KyAgICBzZXQoQ01BS0VfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZX0RFQlVHICIke0NNQUtFX1JV
TlRJTUVfT1VUUFVUX0RJUkVDVE9SWX0iKQorICAgIHNldChDTUFLRV9SVU5USU1FX09VVFBVVF9E
SVJFQ1RPUllfUkVMRUFTRSAiJHtDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUll9IikKIGVu
ZGlmICgpCiAKIHN0cmluZyhUT0xPV0VSICR7RVZFTlRfTE9PUF9UWVBFfSBMT1dFUkNBU0VfRVZF
TlRfTE9PUF9UWVBFKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdl
TG9nCmluZGV4IGRhYzY1ZGJmNDU1Li4wYjU4NGRhMDQ4NCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hh
bmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA5LTIx
ICBTdGVwaGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4KKworICAgICAgICBbV2lu
XVtKU0NPbmx5XSBNYWtlIGpzY29ubHkgYnVpbGQgdGVzdGFwaSBhbmQgZGxscyBhbmQgY29weSBk
bGxzIHdoZW4gcnVubmluZyB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTc3Mjc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLWpzYzoKKyAgICAgICAgKiBTY3JpcHRzL3J1
bi1qc2Mtc3RyZXNzLXRlc3RzOgorCiAyMDE3LTA5LTIwICBNczJnZXIgIDxNczJnZXJAaWdhbGlh
LmNvbT4KIAogICAgICAgICBbV1BFXSBVcGRhdGUgZm9udGNvbmZpZyB0byAyLjEyLjQuCmRpZmYg
LS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNj
CmluZGV4IDcyNDM2MTI3YWIyLi5mMDc1NWQzMzUxNiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0
cy9idWlsZC1qc2MKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MKQEAgLTE0Myw3ICsxNDMs
NyBAQCBpZiAoaXNDTWFrZUJ1aWxkKCkpIHsKICAgICAgICAgJG1ha2VBcmdzIC49ICgkbWFrZUFy
Z3MgPyAiICIgOiAiIikgLiAiLWoiIC4gbnVtYmVyT2ZDUFVzKCkgaWYgJG1ha2VBcmdzICF+IC8t
alxzKlxkKy87CiAgICAgICAgICRidWlsZFRhcmdldCA9ICJqc2MgdGVzdGIzIHRlc3RhaXIgdGVz
dGFwaSAkbWFrZUFyZ3MiOwogICAgIH0gZWxzaWYgKGNhblVzZU5pbmphKCkpIHsKLSAgICAgICAg
JGJ1aWxkVGFyZ2V0IC49ICJqc2MgdGVzdGFwaSI7CisgICAgICAgICRidWlsZFRhcmdldCAuPSAi
anNjIHRlc3RhcGkgdGVzdG1hc20iOwogICAgIH0KIAogICAgICMgVGhpcyBjYWxsIG9ubHkgcmV0
dXJucyBpZiBub3RoaW5nIHdyb25nIGhhcHBlbmVkCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz
L3J1bi1qc2Mtc3RyZXNzLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0
cwppbmRleCBmNTU3NDZmOTRhNy4uYjA5NDMzOTdhY2IgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Njcmlw
dHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVz
cy10ZXN0cwpAQCAtMTU1MSw2ICsxNTUxLDE0IEBAIGRlZiBwcmVwYXJlQnVuZGxlCiAgICAgICAg
IGlmIGZyYW1ld29ya1BhdGgKICAgICAgICAgICAgIHNvdXJjZSA9IGZyYW1ld29ya1BhdGgKICAg
ICAgICAgICAgIGRlc3RpbmF0aW9uID0gUGF0aG5hbWUubmV3KCIudm0iKQorICAgICAgICBlbHNp
ZiAkaG9zdE9TID09ICJ3aW5kb3dzIgorICAgICAgICAgICAgIyBNYWtlIHN1cmUgdG8gY29weSBk
bGwgYWxvbmcgd2l0aCBqc2Mgb24gV2luZG93cworICAgICAgICAgICAgc291cmNlID0gW29yaWdp
bmFsSlNDUGF0aF0gKyBEaXIuZ2xvYihGaWxlLmRpcm5hbWUob3JpZ2luYWxKU0NQYXRoKSArICIv
anNjTGliLmRsbCIpCisgICAgICAgICAgICBkZXN0aW5hdGlvbiA9ICRqc2NQYXRoLmRpcm5hbWUK
KworICAgICAgICAgICAgRGlyLmNoZGlyKCRvdXRwdXREaXIpIHsKKyAgICAgICAgICAgICAgICBG
aWxlVXRpbHMubWtkaXJfcCBkZXN0aW5hdGlvbgorICAgICAgICAgICAgfQogICAgICAgICBlbHNl
CiAgICAgICAgICAgICBzb3VyY2UgPSBvcmlnaW5hbEpTQ1BhdGgKICAgICAgICAgICAgIGRlc3Rp
bmF0aW9uID0gJGpzY1BhdGgK
</data>
<flag name="review"
          id="341527"
          type_id="1"
          status="+"
          setter="ysuzuki"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>324684</attachid>
            <date>2017-10-24 11:00:17 -0700</date>
            <delta_ts>2017-10-24 11:46:35 -0700</delta_ts>
            <desc>Build jsc/testapi/testmasm on windows jsc-only similar to win platform - added fixme</desc>
            <filename>177279-2.diff</filename>
            <type>text/plain</type>
            <size>4847</size>
            <attacher name="Stephan Szabo">stephan.szabo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA0ZmMyMzhkZjJhNy4uZGE2
Njk2YjNiNmEgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxMiBAQAorMjAxNy0xMC0yNCAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5j
b20+CisKKyAgICAgICAgW1dpbl1bSlNDT25seV0gTWFrZSBqc2Nvbmx5IGJ1aWxkIHRlc3RhcGkg
YW5kIGRsbHMgYW5kIGNvcHkgZGxscyB3aGVuIHJ1bm5pbmcgdGVzdHMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzI3OQorCisgICAgICAgIFJldmll
d2VkIGJ5IFl1c3VrZSBTdXp1a2kuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0pT
Q09ubHkuY21ha2U6CisKIDIwMTctMTAtMjEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBh
cHBsZS5jb20+CiAKICAgICAgICAgVHVybiBvbiBjY2FjaGUgZm9yIE1hYyBjbWFrZSBidWlsZHMg
YnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBi
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggOTQwZjBjODQ0YzkuLmNjMjgx
NWY4NGQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBi
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNy0x
MC0yNCAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5jb20+CisKKyAgICAgICAg
W1dpbl1bSlNDT25seV0gTWFrZSBqc2Nvbmx5IGJ1aWxkIHRlc3RhcGkgYW5kIGRsbHMgYW5kIGNv
cHkgZGxscyB3aGVuIHJ1bm5pbmcgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTE3NzI3OQorCisgICAgICAgIFJldmlld2VkIGJ5IFl1c3VrZSBT
dXp1a2kuCisKKyAgICAgICAgKiBzaGVsbC9QbGF0Zm9ybUpTQ09ubHkuY21ha2U6IEFkZGVkLgor
CiAyMDE3LTEwLTIzICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4KIAogICAgICAg
ICBXZWJBc3NlbWJseTogdG9wRW50cnlGcmFtZSBvbiBXYXNtOjpJbnN0YW5jZQpkaWZmIC0tZ2l0
IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3NoZWxsL1BsYXRmb3JtSlNDT25seS5jbWFrZSBiL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9zaGVsbC9QbGF0Zm9ybUpTQ09ubHkuY21ha2UKbmV3IGZpbGUg
bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmNhNGYxMjcxY2Y3Ci0tLSAvZGV2L251bGwK
KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3NoZWxsL1BsYXRmb3JtSlNDT25seS5jbWFrZQpA
QCAtMCwwICsxLDkgQEAKKyMgRklYTUU6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xNzg3MzAKKyMgTWFrZSB0aGUgV2luZG93cyBidWlsZCBhbmQgb3RoZXIgYnVpbGRz
IHdvcmsgbW9yZSBzaW1pbGFybHkKKyMgcmF0aGVyIHRoYW4gaGF2aW5nIGEgdmVyeSBkaWZmZXJl
bnQgYnVpbGQgcHJvY2VzcyB3aXRoCisjIGxpYnJhcnkvbGF1bmNoZXIgb24gV2luZG93cyBhbmQg
YnVpbGQgZGlyZWN0bHkgaW50bworIyBleGVjdXRhYmxlIGVsc2V3aGVyZQoraWYgKFdJTjMyKQor
ICAgIGluY2x1ZGUoUGxhdGZvcm1XaW4uY21ha2UpCisgICAgYWRkX2RlZmluaXRpb25zKC1EV0lO
X0NBSVJPKQorZW5kaWYgKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zSlNDT25s
eS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zSlNDT25seS5jbWFrZQppbmRleCA5ZTNmNjBk
YzZhNS4uZDEzMzcyZjUxOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zSlNDT25s
eS5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0pTQ09ubHkuY21ha2UKQEAgLTUzLDYg
KzUzLDggQEAgZW5kaWYgKCkKIAogaWYgKFdJTjMyKQogICAgIGFkZF9kZWZpbml0aW9ucygtRE5P
TUlOTUFYKQorICAgIGFkZF9kZWZpbml0aW9ucygtRF9XSU5ET1dTIC1EV0lOVkVSPTB4NjAxIC1E
X1dJTjMyX1dJTk5UPTB4NjAxKQorICAgIGFkZF9kZWZpbml0aW9ucygtRFVOSUNPREUgLURfVU5J
Q09ERSkKIAogICAgIGlmIChOT1QgV0VCS0lUX0xJQlJBUklFU19ESVIpCiAgICAgICAgIGlmIChE
RUZJTkVEIEVOVntXRUJLSVRfTElCUkFSSUVTfSkKQEAgLTcxLDYgKzczLDEzIEBAIGlmIChXSU4z
MikKICAgICAgICAgc2V0KENNQUtFX0xJQlJBUllfT1VUUFVUX0RJUkVDVE9SWSAke0NNQUtFX0JJ
TkFSWV9ESVJ9L2xpYjY0KQogICAgICAgICBzZXQoQ01BS0VfUlVOVElNRV9PVVRQVVRfRElSRUNU
T1JZICR7Q01BS0VfQklOQVJZX0RJUn0vYmluKQogICAgIGVuZGlmICgpCisKKyAgICBzZXQoQ01B
S0VfQVJDSElWRV9PVVRQVVRfRElSRUNUT1JZX0RFQlVHICIke0NNQUtFX0FSQ0hJVkVfT1VUUFVU
X0RJUkVDVE9SWX0iKQorICAgIHNldChDTUFLRV9BUkNISVZFX09VVFBVVF9ESVJFQ1RPUllfUkVM
RUFTRSAiJHtDTUFLRV9BUkNISVZFX09VVFBVVF9ESVJFQ1RPUll9IikKKyAgICBzZXQoQ01BS0Vf
TElCUkFSWV9PVVRQVVRfRElSRUNUT1JZX0RFQlVHICIke0NNQUtFX0xJQlJBUllfT1VUUFVUX0RJ
UkVDVE9SWX0iKQorICAgIHNldChDTUFLRV9MSUJSQVJZX09VVFBVVF9ESVJFQ1RPUllfUkVMRUFT
RSAiJHtDTUFLRV9MSUJSQVJZX09VVFBVVF9ESVJFQ1RPUll9IikKKyAgICBzZXQoQ01BS0VfUlVO
VElNRV9PVVRQVVRfRElSRUNUT1JZX0RFQlVHICIke0NNQUtFX1JVTlRJTUVfT1VUUFVUX0RJUkVD
VE9SWX0iKQorICAgIHNldChDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUllfUkVMRUFTRSAi
JHtDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUll9IikKIGVuZGlmICgpCiAKIHN0cmluZyhU
T0xPV0VSICR7RVZFTlRfTE9PUF9UWVBFfSBMT1dFUkNBU0VfRVZFTlRfTE9PUF9UWVBFKQpkaWZm
IC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDljZjY3OTRl
ZmExLi5mMTEyZGJmZmIxYiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTEwLTI0ICBTdGVwaGFuIFN6YWJvICA8
c3RlcGhhbi5zemFib0Bzb255LmNvbT4KKworICAgICAgICBbV2luXVtKU0NPbmx5XSBNYWtlIGpz
Y29ubHkgYnVpbGQgdGVzdGFwaSBhbmQgZGxscyBhbmQgY29weSBkbGxzIHdoZW4gcnVubmluZyB0
ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3
Mjc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgWXVzdWtlIFN1enVraS4KKworICAgICAgICAqIFNj
cmlwdHMvYnVpbGQtanNjOgorICAgICAgICAqIFNjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHM6
CisKIDIwMTctMTAtMjMgIEx1Y2FzIEZvcnNjaGxlciAgPGxmb3JzY2hsZXJAYXBwbGUuY29tPgog
CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTA0NTQ0NT4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj
cmlwdHMvYnVpbGQtanNjIGIvVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MKaW5kZXggNzI0MzYxMjdh
YjIuLmYwNzU1ZDMzNTE2IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYworKysg
Yi9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYwpAQCAtMTQzLDcgKzE0Myw3IEBAIGlmIChpc0NNYWtl
QnVpbGQoKSkgewogICAgICAgICAkbWFrZUFyZ3MgLj0gKCRtYWtlQXJncyA/ICIgIiA6ICIiKSAu
ICItaiIgLiBudW1iZXJPZkNQVXMoKSBpZiAkbWFrZUFyZ3MgIX4gLy1qXHMqXGQrLzsKICAgICAg
ICAgJGJ1aWxkVGFyZ2V0ID0gImpzYyB0ZXN0YjMgdGVzdGFpciB0ZXN0YXBpICRtYWtlQXJncyI7
CiAgICAgfSBlbHNpZiAoY2FuVXNlTmluamEoKSkgewotICAgICAgICAkYnVpbGRUYXJnZXQgLj0g
ImpzYyB0ZXN0YXBpIjsKKyAgICAgICAgJGJ1aWxkVGFyZ2V0IC49ICJqc2MgdGVzdGFwaSB0ZXN0
bWFzbSI7CiAgICAgfQogCiAgICAgIyBUaGlzIGNhbGwgb25seSByZXR1cm5zIGlmIG5vdGhpbmcg
d3JvbmcgaGFwcGVuZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3Mt
dGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCmluZGV4IDRhNzA3Yzc2
MmY1Li40MTFlOWE3NTMyMyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVz
cy10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCkBAIC0xNTY3
LDYgKzE1NjcsMTQgQEAgZGVmIHByZXBhcmVCdW5kbGUKICAgICAgICAgaWYgZnJhbWV3b3JrUGF0
aAogICAgICAgICAgICAgc291cmNlID0gZnJhbWV3b3JrUGF0aAogICAgICAgICAgICAgZGVzdGlu
YXRpb24gPSBQYXRobmFtZS5uZXcoIi52bSIpCisgICAgICAgIGVsc2lmICRob3N0T1MgPT0gIndp
bmRvd3MiCisgICAgICAgICAgICAjIE1ha2Ugc3VyZSB0byBjb3B5IGRsbCBhbG9uZyB3aXRoIGpz
YyBvbiBXaW5kb3dzCisgICAgICAgICAgICBzb3VyY2UgPSBbb3JpZ2luYWxKU0NQYXRoXSArIERp
ci5nbG9iKEZpbGUuZGlybmFtZShvcmlnaW5hbEpTQ1BhdGgpICsgIi9qc2NMaWIuZGxsIikKKyAg
ICAgICAgICAgIGRlc3RpbmF0aW9uID0gJGpzY1BhdGguZGlybmFtZQorCisgICAgICAgICAgICBE
aXIuY2hkaXIoJG91dHB1dERpcikgeworICAgICAgICAgICAgICAgIEZpbGVVdGlscy5ta2Rpcl9w
IGRlc3RpbmF0aW9uCisgICAgICAgICAgICB9CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIHNv
dXJjZSA9IG9yaWdpbmFsSlNDUGF0aAogICAgICAgICAgICAgZGVzdGluYXRpb24gPSAkanNjUGF0
aAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>