177273 2017-09-20 14:43:50 -0700 REGRESSION(r222194) [WPE] Library and executable output names broken 2017-09-27 12:16:39 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 174558 1 clopez mcatanzaro bugs-noreply cgarcia commit-queue mcatanzaro webkit-bug-importer zan oldest_to_newest 1350996 0 clopez 2017-09-20 14:43:50 -0700 Not sure what caused this but it was something recent. $ Tools/Scripts/run-minibrowser --wpe Can't find built framework at "/home/clopez/webkit/wpe/WebKitBuild/Release/lib/libWPEWebKit.so". And if I try this patch --- a/Tools/Scripts/webkitdirs.pm +++ b/Tools/Scripts/webkitdirs.pm @@ -959,7 +959,7 @@ sub builtDylibPathForName } } if (isWPE()) { - return "$configurationProductDir/lib/libWPEWebKit.so"; + return "$configurationProductDir/lib/libWebKit.so"; } die "Unsupported platform, can't determine built library locations.\nTry `build-webkit --help` for more information.\n"; Then i get: $ Tools/Scripts/run-minibrowser --wpe Starting dyz lib/wpe.lua:3: libWPEWebKit.so: cannot open shared object file: No such file or directory 1351001 1 clopez 2017-09-20 14:51:48 -0700 This was caused by r222194 <https://trac.webkit.org/r222194> I reverted it locally, triggered a clean build and now I get libWPEWebKit.so generated correctly and the minibrowser works back as expected. BTW.. I have just triggered clean builds on the WPE bots, as I suspect they were running all this time using the old libWPEWebKit.so (from <r222194) 1351018 2 321379 mcatanzaro 2017-09-20 15:10:06 -0700 Created attachment 321379 Patch 1351028 3 321379 clopez 2017-09-20 15:35:47 -0700 Comment on attachment 321379 Patch Tested. it works ok. Thanks! 1351043 4 321379 commit-queue 2017-09-20 16:05:27 -0700 Comment on attachment 321379 Patch Clearing flags on attachment: 321379 Committed r222296: <http://trac.webkit.org/changeset/222296> 1351044 5 commit-queue 2017-09-20 16:05:30 -0700 All reviewed patches have been landed. Closing bug. 321379 2017-09-20 15:10:06 -0700 2017-09-20 16:05:27 -0700 Patch bug-177273-20170920171005.patch text/plain 2733 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFkNGM5ZmU1YmFmNGNjYTZm MjdhOGFmNWFjMzNiY2Y2MTA0YzZlMWMuLjlmNWU2Nzg0YTg4MzcwZTlmMDFlYTNhZDQwZDhlNGQ4 ZjNkYmNmNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDktMjAgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04o cjIyMjE5NCkgW1dQRV0gTGlicmFyeSBhbmQgZXhlY3V0YWJsZSBvdXRwdXQgbmFtZXMgYnJva2Vu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzcyNzMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlIHRo ZSBXZWJLaXQyIG91dHB1dCBuYW1lIHZhcmlhYmxlcyB0byBoZXJlIGZyb20gU291cmNlL2NtYWtl LCBzaW5jZSB0aGlzIGlzIGEgYmV0dGVyCisgICAgICAgIHBsYWNlIGFuZCB3aGVyZSB0aGV5IGFy ZSBzZXQgb24gYWxsIG90aGVyIHBvcnRzLiBVcGRhdGUgdGhlbSBmb3IgdGhlIGNoYW5nZXMgaW4g cjIyMjE5NC4KKworICAgICAgICAqIFBsYXRmb3JtV1BFLmNtYWtlOgorCiAyMDE3LTA5LTIwICBK b25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmVkIG51 bGxhYmxlIGZyb20gVUlEcmFnSXRlbSBwcm9wZXJ0eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9QbGF0Zm9ybVdQRS5jbWFrZSBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XUEUuY21ha2UKaW5k ZXggNjJmODlkYzc3MDBkMDA4ZjY2NWMzZjFhNTU5NzY3MjM2NGE4YmU1ZS4uNjdlYzU0Yjk2N2Rm MzNjOWQxMDJiMTc4NzZiYjY4OTI3ZmU1NmU1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9Q bGF0Zm9ybVdQRS5jbWFrZQorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtV1BFLmNtYWtlCkBA IC0xLDMgKzEsOCBAQAorc2V0KFdlYktpdF9PVVRQVVRfTkFNRSBXUEVXZWJLaXQpCitzZXQoV2Vi S2l0X1dlYlByb2Nlc3NfT1VUUFVUX05BTUUgV1BFV2ViUHJvY2VzcykKK3NldChXZWJLaXRfTmV0 d29ya1Byb2Nlc3NfT1VUUFVUX05BTUUgV1BFTmV0d29ya1Byb2Nlc3MpCitzZXQoV2ViS2l0X1N0 b3JhZ2VQcm9jZXNzX09VVFBVVF9OQU1FIFdQRVN0b3JhZ2VQcm9jZXNzKQorCiBmaWxlKE1BS0Vf RElSRUNUT1JZICR7REVSSVZFRF9TT1VSQ0VTX1dQRV9BUElfRElSfSkKIGZpbGUoTUFLRV9ESVJF Q1RPUlkgJHtGT1JXQVJESU5HX0hFQURFUlNfV1BFX0RJUn0pCiBmaWxlKE1BS0VfRElSRUNUT1JZ ICR7Rk9SV0FSRElOR19IRUFERVJTX1dQRV9FWFRFTlNJT05fRElSfSkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21h a2UKaW5kZXggMDI1YTg0MWJhMDliMTU5ZDdlYmMzNjI1NjgxMDViNGQyZmQxMzFjNC4uMWJiYjg5 OWU3ZTdkNzY0YmI1ZTUxNmQ4ZmYwMDg4ZGZiNjg2OTU5ZSAxMDA2NDQKLS0tIGEvU291cmNlL2Nt YWtlL09wdGlvbnNXUEUuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UK QEAgLTU0LDEwICs1NCw2IEBAIHNldChFTkFCTEVfQVBJX1RFU1RTICR7REVWRUxPUEVSX01PREV9 KQogCiBzZXQoSmF2YVNjcmlwdENvcmVfTElCUkFSWV9UWVBFIFNUQVRJQykKIHNldChXZWJDb3Jl X0xJQlJBUllfVFlQRSBTVEFUSUMpCi1zZXQoV2ViS2l0Ml9PVVRQVVRfTkFNRSBXUEVXZWJLaXQp Ci1zZXQoV2ViS2l0Ml9XZWJQcm9jZXNzX09VVFBVVF9OQU1FIFdQRVdlYlByb2Nlc3MpCi1zZXQo V2ViS2l0Ml9OZXR3b3JrUHJvY2Vzc19PVVRQVVRfTkFNRSBXUEVOZXR3b3JrUHJvY2VzcykKLXNl dChXZWJLaXQyX1N0b3JhZ2VQcm9jZXNzX09VVFBVVF9OQU1FIFdQRVN0b3JhZ2VQcm9jZXNzKQog CiBmaW5kX3BhY2thZ2UoSUNVIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKFRocmVhZHMgUkVRVUlS RUQpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNWFjZmEwZTFiYmM2 YTRlODBkN2ZlYWZmNjUwNjdlNDQ0MTEyMTRhMi4uYzVkZDhlNTI5MTU2ODgwOGUyYjRlM2ZlMDIx NzAyZDk1MDhkZDJhOSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE0IEBACisyMDE3LTA5LTIwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9A aWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMjIxOTQpIFtXUEVdIExpYnJhcnkg YW5kIGV4ZWN1dGFibGUgb3V0cHV0IG5hbWVzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3MjczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSB0aGUgV2ViS2l0MiBvdXRwdXQgbmFtZSB2 YXJpYWJsZXMgZnJvbSBoZXJlIHRvIFNvdXJjZS9XZWJLaXQuCisKKyAgICAgICAgKiBTb3VyY2Uv Y21ha2UvT3B0aW9uc1dQRS5jbWFrZToKKwogMjAxNy0wOS0yMCAgQWxiZXJ0byBHYXJjaWEgIDxi ZXJ0b0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEZpeCBIUFBBIGFuZCBBbHBoYSBidWlsZHMK