177244 2017-09-20 09:38:25 -0700 [Win] Cygwin 64-bit EWS process cannot find Visual Studio installation. 2017-09-27 12:23:32 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 177316 1 pvollan pvollan achristensen bfulgham commit-queue lforschler webkit-bug-importer oldest_to_newest 1350792 0 pvollan 2017-09-20 09:38:25 -0700 The 64-bit shell process should try to find Visual Studio in the 32-bit program files folder, not the 64-bit program files folder. 1350795 1 321324 pvollan 2017-09-20 09:41:23 -0700 Created attachment 321324 Patch 1350809 2 pvollan 2017-09-20 10:03:09 -0700 Thanks for reviewing! 1350852 3 321324 commit-queue 2017-09-20 11:04:47 -0700 Comment on attachment 321324 Patch Clearing flags on attachment: 321324 Committed r222272: <http://trac.webkit.org/changeset/222272> 1350853 4 commit-queue 2017-09-20 11:04:48 -0700 All reviewed patches have been landed. Closing bug. 1351291 5 achristensen 2017-09-21 11:35:13 -0700 This broke some EWS bots. See https://webkit-queues.webkit.org/results/4617782 for an example. 1351296 6 pvollan 2017-09-21 11:41:15 -0700 (In reply to Alex Christensen from comment #5) > This broke some EWS bots. See > https://webkit-queues.webkit.org/results/4617782 for an example. I'll look into it, thanks! 1351309 7 commit-queue 2017-09-21 12:12:04 -0700 Re-opened since this is blocked by bug 177316 1352213 8 321690 pvollan 2017-09-25 09:03:07 -0700 Created attachment 321690 Patch 1352217 9 321692 pvollan 2017-09-25 09:25:05 -0700 Created attachment 321692 Patch 1352326 10 321692 pvollan 2017-09-25 12:29:03 -0700 Comment on attachment 321692 Patch Thanks for reviewing! 1352356 11 321692 commit-queue 2017-09-25 12:55:35 -0700 Comment on attachment 321692 Patch Clearing flags on attachment: 321692 Committed r222458: <http://trac.webkit.org/changeset/222458> 1352357 12 commit-queue 2017-09-25 12:55:36 -0700 All reviewed patches have been landed. Closing bug. 1353343 13 webkit-bug-importer 2017-09-27 12:23:32 -0700 <rdar://problem/34693186> 321324 2017-09-20 09:41:23 -0700 2017-09-25 09:03:06 -0700 Patch bug-177244-20170920184123.patch text/plain 1505 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMjI2NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTA5LTIwICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBDeWd3aW4gNjQtYml0IEVXUyBwcm9jZXNzIGNhbm5vdCBmaW5k IFZpc3VhbCBTdHVkaW8gaW5zdGFsbGF0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3MjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIDY0LWJpdCBFV1Mgc2hlbGwgcHJvY2VzcyBzaG91bGQg dHJ5IHRvIGZpbmQgVmlzdWFsIFN0dWRpbyBpbiB0aGUgMzItYml0IHByb2dyYW0gZmlsZXMgZm9s ZGVyLgorCisgICAgICAgICogRVdTVG9vbHMvc3RhcnQtcXVldWUtd2luLnNoOgorCiAyMDE3LTA5 LTIwICBNczJnZXIgIDxNczJnZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXSBVcGRhdGUg Zm9udGNvbmZpZyB0byAyLjEyLjQuCkluZGV4OiBUb29scy9FV1NUb29scy9zdGFydC1xdWV1ZS13 aW4uc2gKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRVdTVG9vbHMvc3RhcnQtcXVldWUtd2luLnNoCShy ZXZpc2lvbiAyMjIyMDYpCisrKyBUb29scy9FV1NUb29scy9zdGFydC1xdWV1ZS13aW4uc2gJKHdv cmtpbmcgY29weSkKQEAgLTEyLDcgKzEyLDcgQEAgZnVuY3Rpb24gc3RhcnRfZXdzKCkKIHsKICAg ICB0cmFwICdlcnJvcl9oYW5kbGVyICR7TElORU5PfSAkPycgRVJSCiAKLSAgICAiJFBST0dSQU1G SUxFUy9NaWNyb3NvZnQgVmlzdWFsIFN0dWRpbyAxNC4wL1ZDL3ZjdmFyc2FsbC5iYXQiCisgICAg IiRQUk9HUkFNRklMRVMoWDg2KS9NaWNyb3NvZnQgVmlzdWFsIFN0dWRpbyAxNC4wL1ZDL3ZjdmFy c2FsbC5iYXQiCiAKICAgICB3aGlsZSA6CiAgICAgZG8KQEAgLTI0LDcgKzI0LDcgQEAgZnVuY3Rp b24gc3RhcnRfZXdzKCkKICAgICAgICAgZmluZCB+L3dpbi1ld3MtbG9ncyAtbXRpbWUgKzcgLWV4 ZWMgcm0gLWYge30gXDsKICAgICAgICAgZWNobyAiVEFTSzogU3RhcnRpbmcgdXAiCiAgICAgICAg IGNkIH4vV2ViS2l0Ci0gICAgICAgIGV4cG9ydCBWU0lOU1RBTExESVI9IiRQUk9HUkFNRklMRVNc TWljcm9zb2Z0IFZpc3VhbCBTdHVkaW8gMTQuMCIKKyAgICAgICAgZXhwb3J0IFZTSU5TVEFMTERJ Uj0iJFBST0dSQU1GSUxFUyhYODYpXE1pY3Jvc29mdCBWaXN1YWwgU3R1ZGlvIDE0LjAiCiAgICAg ICAgIGVjaG8gIlRBU0s6IENsZWFuaW5nIFdlYktpdEJ1aWxkIgogICAgICAgICBybSAtcmYgV2Vi S2l0QnVpbGQKICAgICAgICAgZGF0ZQo= 321690 2017-09-25 09:03:07 -0700 2017-09-25 09:25:04 -0700 Patch bug-177244-20170925180309.patch text/plain 1741 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMjQ0NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTA5LTI1ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBDeWd3aW4gNjQtYml0IEVXUyBwcm9jZXNzIGNhbm5vdCBmaW5k IFZpc3VhbCBTdHVkaW8gaW5zdGFsbGF0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3MjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIDY0LWJpdCBFV1Mgc2hlbGwgcHJvY2VzcyBzaG91bGQg dHJ5IHRvIGZpbmQgVmlzdWFsIFN0dWRpbyBpbiB0aGUgMzItYml0IHByb2dyYW0gZmlsZXMgZm9s ZGVyLgorCisgICAgICAgICogRVdTVG9vbHMvc3RhcnQtcXVldWUtd2luLnNoOgorCiAyMDE3LTA5 LTI1ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04ocjIyMjE2MCkgW0dUS10gW0RlYnVnXSBJbnRlcm5hbCBjb21waWxl ciBlcnJvciBvbiB0aGUgYnVpbGRib3QgKGh1Z2UgbWVtb3J5IHVzYWdlIGJ5IEdDQykKSW5kZXg6 IFRvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVlLXdpbi5zaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9F V1NUb29scy9zdGFydC1xdWV1ZS13aW4uc2gJKHJldmlzaW9uIDIyMjQ0NCkKKysrIFRvb2xzL0VX U1Rvb2xzL3N0YXJ0LXF1ZXVlLXdpbi5zaAkod29ya2luZyBjb3B5KQpAQCAtMTIsNyArMTIsMTMg QEAgZnVuY3Rpb24gc3RhcnRfZXdzKCkKIHsKICAgICB0cmFwICdlcnJvcl9oYW5kbGVyICR7TElO RU5PfSAkPycgRVJSCiAKLSAgICAiJFBST0dSQU1GSUxFUy9NaWNyb3NvZnQgVmlzdWFsIFN0dWRp byAxNC4wL1ZDL3ZjdmFyc2FsbC5iYXQiCisgICAgaWYgW1sgJFBST0dSQU1GSUxFUyA9fiAiKHg4 NikiIF1dCisgICAgICAgIFBST0dSQU1GSUxFU19YODYgPSAkUFJPR1JBTUZJTEVTCisgICAgZWxz ZQorICAgICAgICBQUk9HUkFNRklMRVNfWDg2ID0gIiRQUk9HUkFNRklMRVMgKHg4NikiCisgICAg ZmkKKworICAgICIkUFJPR1JBTUZJTEVTX1g4Ni9NaWNyb3NvZnQgVmlzdWFsIFN0dWRpbyAxNC4w L1ZDL3ZjdmFyc2FsbC5iYXQiCiAKICAgICB3aGlsZSA6CiAgICAgZG8KQEAgLTI0LDcgKzMwLDcg QEAgZnVuY3Rpb24gc3RhcnRfZXdzKCkKICAgICAgICAgZmluZCB+L3dpbi1ld3MtbG9ncyAtbXRp bWUgKzcgLWV4ZWMgcm0gLWYge30gXDsKICAgICAgICAgZWNobyAiVEFTSzogU3RhcnRpbmcgdXAi CiAgICAgICAgIGNkIH4vV2ViS2l0Ci0gICAgICAgIGV4cG9ydCBWU0lOU1RBTExESVI9IiRQUk9H UkFNRklMRVNcTWljcm9zb2Z0IFZpc3VhbCBTdHVkaW8gMTQuMCIKKyAgICAgICAgZXhwb3J0IFZT SU5TVEFMTERJUj0iJFBST0dSQU1GSUxFU19YODZcTWljcm9zb2Z0IFZpc3VhbCBTdHVkaW8gMTQu MCIKICAgICAgICAgZWNobyAiVEFTSzogQ2xlYW5pbmcgV2ViS2l0QnVpbGQiCiAgICAgICAgIHJt IC1yZiBXZWJLaXRCdWlsZAogICAgICAgICBkYXRlCg== 321692 2017-09-25 09:25:05 -0700 2017-09-25 12:55:35 -0700 Patch bug-177244-20170925182504.patch text/plain 1747 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMjQ0NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTA5LTI1ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBDeWd3aW4gNjQtYml0IEVXUyBwcm9jZXNzIGNhbm5vdCBmaW5k IFZpc3VhbCBTdHVkaW8gaW5zdGFsbGF0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3MjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIDY0LWJpdCBFV1Mgc2hlbGwgcHJvY2VzcyBzaG91bGQg dHJ5IHRvIGZpbmQgVmlzdWFsIFN0dWRpbyBpbiB0aGUgMzItYml0IHByb2dyYW0gZmlsZXMgZm9s ZGVyLgorCisgICAgICAgICogRVdTVG9vbHMvc3RhcnQtcXVldWUtd2luLnNoOgorCiAyMDE3LTA5 LTI1ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04ocjIyMjE2MCkgW0dUS10gW0RlYnVnXSBJbnRlcm5hbCBjb21waWxl ciBlcnJvciBvbiB0aGUgYnVpbGRib3QgKGh1Z2UgbWVtb3J5IHVzYWdlIGJ5IEdDQykKSW5kZXg6 IFRvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVlLXdpbi5zaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9F V1NUb29scy9zdGFydC1xdWV1ZS13aW4uc2gJKHJldmlzaW9uIDIyMjQ0NCkKKysrIFRvb2xzL0VX U1Rvb2xzL3N0YXJ0LXF1ZXVlLXdpbi5zaAkod29ya2luZyBjb3B5KQpAQCAtMTIsNyArMTIsMTQg QEAgZnVuY3Rpb24gc3RhcnRfZXdzKCkKIHsKICAgICB0cmFwICdlcnJvcl9oYW5kbGVyICR7TElO RU5PfSAkPycgRVJSCiAKLSAgICAiJFBST0dSQU1GSUxFUy9NaWNyb3NvZnQgVmlzdWFsIFN0dWRp byAxNC4wL1ZDL3ZjdmFyc2FsbC5iYXQiCisgICAgaWYgW1sgJFBST0dSQU1GSUxFUyA9fiAiKHg4 NikiIF1dCisgICAgdGhlbgorICAgICAgICBQUk9HUkFNRklMRVNfWDg2PSRQUk9HUkFNRklMRVMK KyAgICBlbHNlCisgICAgICAgIFBST0dSQU1GSUxFU19YODY9IiRQUk9HUkFNRklMRVMgKHg4Niki CisgICAgZmkKKworICAgICIkUFJPR1JBTUZJTEVTX1g4Ni9NaWNyb3NvZnQgVmlzdWFsIFN0dWRp byAxNC4wL1ZDL3ZjdmFyc2FsbC5iYXQiCiAKICAgICB3aGlsZSA6CiAgICAgZG8KQEAgLTI0LDcg KzMxLDcgQEAgZnVuY3Rpb24gc3RhcnRfZXdzKCkKICAgICAgICAgZmluZCB+L3dpbi1ld3MtbG9n cyAtbXRpbWUgKzcgLWV4ZWMgcm0gLWYge30gXDsKICAgICAgICAgZWNobyAiVEFTSzogU3RhcnRp bmcgdXAiCiAgICAgICAgIGNkIH4vV2ViS2l0Ci0gICAgICAgIGV4cG9ydCBWU0lOU1RBTExESVI9 IiRQUk9HUkFNRklMRVNcTWljcm9zb2Z0IFZpc3VhbCBTdHVkaW8gMTQuMCIKKyAgICAgICAgZXhw b3J0IFZTSU5TVEFMTERJUj0iJFBST0dSQU1GSUxFU19YODZcTWljcm9zb2Z0IFZpc3VhbCBTdHVk aW8gMTQuMCIKICAgICAgICAgZWNobyAiVEFTSzogQ2xlYW5pbmcgV2ViS2l0QnVpbGQiCiAgICAg ICAgIHJtIC1yZiBXZWJLaXRCdWlsZAogICAgICAgICBkYXRlCg==