17722 2008-03-08 03:29:39 -0800 HTML5 spec violation: </><!doctype html> or </x><!doctype html> SHOULD NOT imply standards mode 2010-09-16 02:05:27 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 webkit abarth abarth annevk commit-queue eric oldest_to_newest 73075 0 webkit 2008-03-08 03:29:39 -0800 The code: </><!doctype html> or </x><!doctype html> makes Webkit to render page in standards mode (CSS1Compat). According to HTML5 spec: "Documents must consist of the following parts, in the given order: 1. Optionally, a single U+FEFF BYTE ORDER MARK (BOM) character. 2. Any number of comments and space characters. 3. A DOCTYPE." Only BOM, comments and space characters are allowed before DOCTYPE. Steps to reproduce: 1) Go to a page: http://software.hixie.ch/utilities/js/live-dom-viewer/?%20%3C%2F%3E%3C!doctype%20html%3E%0A and notice "CSS1Compat" in log section. Expected result: BackCompat in log section Current result: CSS1Compat in log section 260680 1 abarth 2010-08-05 10:17:43 -0700 The spec mandates that we render this document standards mode. Our current behavior is correct. 261110 2 annevk 2010-08-05 23:24:12 -0700 As far as I can tell anything but whitespace, comments, and DOCTYPEs throws you out of the "initial" insertion mode and puts the document in standards mode so if this bug still applies with the new parser there is a bug. (And a lack of tests :/) 261111 3 annevk 2010-08-05 23:24:53 -0700 I meant to say puts the document in quirks mode. Argh. 261119 4 abarth 2010-08-05 23:33:24 -0700 Ok. I'll take another look. 278578 5 abarth 2010-09-13 16:59:09 -0700 Looking now. 278593 6 abarth 2010-09-13 17:32:16 -0700 Looks like our behavior is correct. Adding tests. 278595 7 67494 abarth 2010-09-13 17:38:03 -0700 Created attachment 67494 Patch 278608 8 67494 eric 2010-09-13 18:08:12 -0700 Comment on attachment 67494 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67494&action=prettypatch Better to have it say PASS or FAIL, but this is OK. 279055 9 abarth 2010-09-14 11:45:28 -0700 PASS/FAIL tests are hard to change latter if we're intentionally changing behavior. 279078 10 67494 commit-queue 2010-09-14 12:24:15 -0700 Comment on attachment 67494 Patch Clearing flags on attachment: 67494 Committed r67484: <http://trac.webkit.org/changeset/67484> 279079 11 commit-queue 2010-09-14 12:24:20 -0700 All reviewed patches have been landed. Closing bug. 279388 12 webkit 2010-09-14 22:36:15 -0700 (In reply to comment #6) > Looks like our behavior is correct. Adding tests. Adam, could you explain why the current behavior is correct? 279434 13 abarth 2010-09-15 00:32:54 -0700 > Adam, could you explain why the current behavior is correct? Sure. </x><!doctype html> This case generates a close tag token for the </x>, which kicks us out of the initial model, so the doctype doesn't trigger standards mode. Hence, quirks. </><!doctype html> or This case doesn't generate any token for </>. It just gets eaten by the tokenizer. That means the first token we see is the doctype, which triggers standards mode. Hence, standards. 279979 14 webkit 2010-09-16 01:41:36 -0700 (In reply to comment #13) > </><!doctype html> or > > This case doesn't generate any token for </>. It just gets eaten by the tokenizer. That means the first token we see is the doctype, which triggers standards mode. Hence, standards. Is it correct behavior according HTML5 specification [http://www.w3.org/TR/html5/syntax.html#writing]? 279983 15 abarth 2010-09-16 02:05:27 -0700 > Is it correct behavior according HTML5 specification [http://www.w3.org/TR/html5/syntax.html#writing]? Yes. Notice the first sentence of that section: [[ This section only applies to documents, authoring tools, and markup generators. In particular, it does not apply to conformance checkers; conformance checkers must use the requirements given in the next section ("parsing HTML documents"). ]] 67494 2010-09-13 17:38:03 -0700 2010-09-14 12:24:15 -0700 Patch bug-17722-20100913173802.patch text/plain 2705 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY3NDI0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDktMTMgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBIVE1MNSBzcGVjIHZpb2xhdGlvbjogPC8+PCFkb2N0eXBlIGh0bWw+IG9yIDwveD48 IWRvY3R5cGUgaHRtbD4gU0hPVUxEIE5PVCBpbXBseSBzdGFuZGFyZHMgbW9kZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3MjIKKworICAgICAgICBJ IGJlbGlldmUgb3VyIGJlaGF2aW9yIG1hdGNoZXMgdGhlIEhUTUw1IHNwZWMuICBXaGVuIHdlIHNl ZSBhIDwveD4sIHdlCisgICAgICAgIGNvcnJlY3RseSBraWNrIG91dCBvZiBzdGFuZGFyZHMgbW9k ZS4gIEluIHRoZSA8Lz4gY2FzZSwgaG93ZXZlciwgdGhlCisgICAgICAgIHRva2VuaXplciBqdXN0 IGVhdHMgdGhlIGJ5dGVzLCB3aXRob3V0IGVtaXR0aW5nIGEgdG9rZW4sIHdoaWNoIG1lYW5zIHdl CisgICAgICAgIGRvbid0IGdldCBraWNrZWQgb3V0IG9mIHN0YW5kYXJkcyBtb2RlLiAgT3VyIGJl aGF2aW9yIG1hdGNoZXMgTWluZWZpZWxkLgorCisgICAgICAgICogZmFzdC9wYXJzZXIvc3RyYW5n ZS1kb2N0eXBlLWNvbXBhdG1vZGUtMS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvcGFyc2VyL3N0cmFuZ2UtZG9jdHlwZS1jb21wYXRtb2RlLTEuaHRtbDogQWRkZWQuCisgICAg ICAgICogZmFzdC9wYXJzZXIvc3RyYW5nZS1kb2N0eXBlLWNvbXBhdG1vZGUtMi1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcGFyc2VyL3N0cmFuZ2UtZG9jdHlwZS1jb21wYXRt b2RlLTIuaHRtbDogQWRkZWQuCisKIDIwMTAtMDktMTMgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6 YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6 IExheW91dFRlc3RzL2Zhc3QvcGFyc2VyL3N0cmFuZ2UtZG9jdHlwZS1jb21wYXRtb2RlLTEtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvcGFyc2VyL3N0cmFuZ2Ut ZG9jdHlwZS1jb21wYXRtb2RlLTEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvZmFzdC9wYXJzZXIvc3RyYW5nZS1kb2N0eXBlLWNvbXBhdG1vZGUtMS1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK0JhY2tDb21wYXQKSW5kZXg6IExheW91dFRl c3RzL2Zhc3QvcGFyc2VyL3N0cmFuZ2UtZG9jdHlwZS1jb21wYXRtb2RlLTEuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9zdHJhbmdlLWRvY3R5cGUtY29tcGF0bW9k ZS0xLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9zdHJhbmdl LWRvY3R5cGUtY29tcGF0bW9kZS0xLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNiBAQAor PC94PjwhZG9jdHlwZSBodG1sPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworZG9jdW1lbnQu d3JpdGUoZG9jdW1lbnQuY29tcGF0TW9kZSk7Cis8L3NjcmlwdD4KSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvcGFyc2VyL3N0cmFuZ2UtZG9jdHlwZS1jb21wYXRtb2RlLTItZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvcGFyc2VyL3N0cmFuZ2UtZG9jdHlwZS1jb21w YXRtb2RlLTItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9w YXJzZXIvc3RyYW5nZS1kb2N0eXBlLWNvbXBhdG1vZGUtMi1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEgQEAKK0NTUzFDb21wYXQKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvcGFy c2VyL3N0cmFuZ2UtZG9jdHlwZS1jb21wYXRtb2RlLTIuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L3BhcnNlci9zdHJhbmdlLWRvY3R5cGUtY29tcGF0bW9kZS0yLmh0bWwJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9zdHJhbmdlLWRvY3R5cGUtY29t cGF0bW9kZS0yLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNiBAQAorPC8+PCFkb2N0eXBl IGh0bWw+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Citkb2N1bWVudC53cml0ZShkb2N1bWVu dC5jb21wYXRNb2RlKTsKKzwvc2NyaXB0Pgo=