177199 2017-09-19 15:03:01 -0700 Quiet media player private logging 2017-09-27 12:20:24 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue jer.noble webkit-bug-importer oldest_to_newest 1350533 0 eric.carlson 2017-09-19 15:03:01 -0700 Quiet media player private logging. 1350536 1 321249 eric.carlson 2017-09-19 15:17:21 -0700 Created attachment 321249 Proposed patch. 1350572 2 321249 commit-queue 2017-09-19 16:28:53 -0700 Comment on attachment 321249 Proposed patch. Clearing flags on attachment: 321249 Committed r222234: <http://trac.webkit.org/changeset/222234> 1350573 3 commit-queue 2017-09-19 16:28:54 -0700 All reviewed patches have been landed. Closing bug. 1353307 4 webkit-bug-importer 2017-09-27 12:20:24 -0700 <rdar://problem/34693081> 321249 2017-09-19 15:17:21 -0700 2017-09-19 16:28:53 -0700 Proposed patch. avf_cleanup_patch_1.txt text/plain 5335 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMjA5MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA5LTE5ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFF1aWV0IG1lZGlhIHBs YXllciBwcml2YXRlIGxvZ2dpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3NzE5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQ bGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbToKKyAgICAgICAgKC1bV2ViQ29yZUFWRk1v dmllT2JzZXJ2ZXIgb2JzZXJ2ZVZhbHVlRm9yS2V5UGF0aDpvZk9iamVjdDpjaGFuZ2U6Y29udGV4 dDpdKToKKwogMjAxNy0wOS0xNSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNv bT4KIAogICAgICAgICBTd2l0Y2ggdGV4dCB0cmFja3MgdG8gcmVsZWFzZSBsb2dnaW5nCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRp YVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJp dmF0ZUFWRm91bmRhdGlvbk9iakMubW0JKHJldmlzaW9uIDIyMjA5MSkKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0 ZUFWRm91bmRhdGlvbk9iakMubW0JKHdvcmtpbmcgY29weSkKQEAgLTMzNDEsOCArMzM0MSw3IEBA IC0gKHZvaWQpb2JzZXJ2ZVZhbHVlRm9yS2V5UGF0aDprZXlQYXRoIG8KICAgICAgICAgcmV0dXJu OwogCiAgICAgYm9vbCB3aWxsQ2hhbmdlID0gW1tjaGFuZ2UgdmFsdWVGb3JLZXk6TlNLZXlWYWx1 ZUNoYW5nZU5vdGlmaWNhdGlvbklzUHJpb3JLZXldIGJvb2xWYWx1ZV07Ci0gICAgYm9vbCBzaG91 bGRMb2dWYWx1ZSA9IHRydWU7Ci0gICAgYm9vbCBzaG91bGRMb2cgPSB0cnVlOworICAgIGJvb2wg c2hvdWxkTG9nVmFsdWUgPSAhd2lsbENoYW5nZTsKICAgICBXVEY6OkZ1bmN0aW9uPHZvaWQgKCk+ IGZ1bmN0aW9uOwogCiAgICAgaWYgKGNvbnRleHQgPT0gTWVkaWFQbGF5ZXJBVkZvdW5kYXRpb25P YnNlcnZhdGlvbkNvbnRleHRBVlBsYXllckxheWVyKSB7CkBAIC0zMzc3LDEzICszMzc2LDExIEBA IC0gKHZvaWQpb2JzZXJ2ZVZhbHVlRm9yS2V5UGF0aDprZXlQYXRoIG8KICAgICAgICAgZWxzZSBp ZiAoW2tleVBhdGggaXNFcXVhbFRvU3RyaW5nOkAiYXNzZXQiXSkgewogICAgICAgICAgICAgZnVu Y3Rpb24gPSBzdGQ6OmJpbmQoJk1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OnNl dEFzc2V0LCBtX2NhbGxiYWNrLCBSZXRhaW5QdHI8aWQ+KG5ld1ZhbHVlKSk7CiAgICAgICAgICAg ICBzaG91bGRMb2dWYWx1ZSA9IGZhbHNlOwotICAgICAgICB9IGVsc2UgaWYgKFtrZXlQYXRoIGlz RXF1YWxUb1N0cmluZzpAImxvYWRlZFRpbWVSYW5nZXMiXSkgeworICAgICAgICB9IGVsc2UgaWYg KFtrZXlQYXRoIGlzRXF1YWxUb1N0cmluZzpAImxvYWRlZFRpbWVSYW5nZXMiXSkKICAgICAgICAg ICAgIGZ1bmN0aW9uID0gc3RkOjpiaW5kKCZNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25P YmpDOjpsb2FkZWRUaW1lUmFuZ2VzRGlkQ2hhbmdlLCBtX2NhbGxiYWNrLCBSZXRhaW5QdHI8TlNB cnJheT4obmV3VmFsdWUpKTsKLSAgICAgICAgICAgIHNob3VsZExvZyA9IGZhbHNlOwotICAgICAg ICB9IGVsc2UgaWYgKFtrZXlQYXRoIGlzRXF1YWxUb1N0cmluZzpAInNlZWthYmxlVGltZVJhbmdl cyJdKSB7CisgICAgICAgIGVsc2UgaWYgKFtrZXlQYXRoIGlzRXF1YWxUb1N0cmluZzpAInNlZWth YmxlVGltZVJhbmdlcyJdKQogICAgICAgICAgICAgZnVuY3Rpb24gPSBzdGQ6OmJpbmQoJk1lZGlh UGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OnNlZWthYmxlVGltZVJhbmdlc0RpZENoYW5n ZSwgbV9jYWxsYmFjaywgUmV0YWluUHRyPE5TQXJyYXk+KG5ld1ZhbHVlKSk7Ci0gICAgICAgICAg ICBzaG91bGRMb2cgPSBmYWxzZTsKLSAgICAgICAgfSBlbHNlIGlmIChba2V5UGF0aCBpc0VxdWFs VG9TdHJpbmc6QCJ0cmFja3MiXSkgeworICAgICAgICBlbHNlIGlmIChba2V5UGF0aCBpc0VxdWFs VG9TdHJpbmc6QCJ0cmFja3MiXSkgewogICAgICAgICAgICAgZnVuY3Rpb24gPSBzdGQ6OmJpbmQo Jk1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OnRyYWNrc0RpZENoYW5nZSwgbV9j YWxsYmFjaywgUmV0YWluUHRyPE5TQXJyYXk+KG5ld1ZhbHVlKSk7CiAgICAgICAgICAgICBzaG91 bGRMb2dWYWx1ZSA9IGZhbHNlOwogICAgICAgICB9IGVsc2UgaWYgKFtrZXlQYXRoIGlzRXF1YWxU b1N0cmluZzpAImhhc0VuYWJsZWRBdWRpbyJdKQpAQCAtMzQyMCwyMSArMzQxNywxOCBAQCAtICh2 b2lkKW9ic2VydmVWYWx1ZUZvcktleVBhdGg6a2V5UGF0aCBvCiAgICAgfQogCiAjaWYgIVJFTEVB U0VfTE9HX0RJU0FCTEVECi0gICAgaWYgKHNob3VsZExvZyAmJiBtX2NhbGxiYWNrLT5sb2dnZXIo KS53aWxsTG9nKG1fY2FsbGJhY2stPmxvZ0NoYW5uZWwoKSwgV1RGTG9nTGV2ZWxEZWJ1ZykpIHsK KyAgICBpZiAobV9jYWxsYmFjay0+bG9nZ2VyKCkud2lsbExvZyhtX2NhbGxiYWNrLT5sb2dDaGFu bmVsKCksIFdURkxvZ0xldmVsRGVidWcpICYmICEoW2tleVBhdGggaXNFcXVhbFRvU3RyaW5nOkAi bG9hZGVkVGltZVJhbmdlcyJdIHx8IFtrZXlQYXRoIGlzRXF1YWxUb1N0cmluZzpAInNlZWthYmxl VGltZVJhbmdlcyJdKSkgeworICAgICAgICBhdXRvIGlkZW50aWZpZXIgPSBQQUw6OkxvZ2dlcjo6 TG9nU2l0ZUlkZW50aWZpZXIoIk1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbiIsICJvYnNl cnZlVmFsdWVGb3JLZXlQYXRoIiwgbV9jYWxsYmFjay0+bG9nSWRlbnRpZmllcigpKTsKIAotICAg ICAgICBpZiAod2lsbENoYW5nZSkKLSAgICAgICAgICAgIG1fY2FsbGJhY2stPmxvZ2dlcigpLmRl YnVnKG1fY2FsbGJhY2stPmxvZ0NoYW5uZWwoKSwgUEFMOjpMb2dnZXI6OkxvZ1NpdGVJZGVudGlm aWVyKCJNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24iLCAib2JzZXJ2ZVZhbHVlRm9yS2V5 UGF0aCIsIG1fY2FsbGJhY2stPmxvZ0lkZW50aWZpZXIoKSksICJ3aWxsIGNoYW5nZSAnIiwgW2tl eVBhdGggVVRGOFN0cmluZ10sICInIik7Ci0gICAgICAgIGVsc2UgewotICAgICAgICAgICAgaWYg KHNob3VsZExvZ1ZhbHVlKSB7Ci0gICAgICAgICAgICAgICAgaWYgKFtrZXlQYXRoIGlzRXF1YWxU b1N0cmluZzpAImR1cmF0aW9uIl0pCi0gICAgICAgICAgICAgICAgICAgIG1fY2FsbGJhY2stPmxv Z2dlcigpLmRlYnVnKG1fY2FsbGJhY2stPmxvZ0NoYW5uZWwoKSwgUEFMOjpMb2dnZXI6OkxvZ1Np dGVJZGVudGlmaWVyKCJNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24iLCAib2JzZXJ2ZVZh bHVlRm9yS2V5UGF0aCIsIG1fY2FsbGJhY2stPmxvZ0lkZW50aWZpZXIoKSksICJkaWQgY2hhbmdl ICciLCBba2V5UGF0aCBVVEY4U3RyaW5nXSwgIicgdG8gIiwgdG9NZWRpYVRpbWUoW25ld1ZhbHVl IENNVGltZVZhbHVlXSkpOwotICAgICAgICAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgICAg ICAgICBSZXRhaW5QdHI8TlNTdHJpbmc+IHZhbHVlU3RyaW5nID0gYWRvcHROUyhbW05TU3RyaW5n IGFsbG9jXSBpbml0V2l0aEZvcm1hdDpAIiVAIiwgbmV3VmFsdWVdKTsKLSAgICAgICAgICAgICAg ICAgICAgbV9jYWxsYmFjay0+bG9nZ2VyKCkuZGVidWcobV9jYWxsYmFjay0+bG9nQ2hhbm5lbCgp LCBQQUw6OkxvZ2dlcjo6TG9nU2l0ZUlkZW50aWZpZXIoIk1lZGlhUGxheWVyUHJpdmF0ZUFWRm91 bmRhdGlvbiIsICJvYnNlcnZlVmFsdWVGb3JLZXlQYXRoIiwgbV9jYWxsYmFjay0+bG9nSWRlbnRp ZmllcigpKSwgImRpZCBjaGFuZ2UgJyIsIFtrZXlQYXRoIFVURjhTdHJpbmddLCAiJyB0byAiLCBb dmFsdWVTdHJpbmcuZ2V0KCkgVVRGOFN0cmluZ10pOwotICAgICAgICAgICAgICAgIH0KLSAgICAg ICAgICAgIH0gZWxzZQotICAgICAgICAgICAgICAgIG1fY2FsbGJhY2stPmxvZ2dlcigpLmRlYnVn KG1fY2FsbGJhY2stPmxvZ0NoYW5uZWwoKSwgUEFMOjpMb2dnZXI6OkxvZ1NpdGVJZGVudGlmaWVy KCJNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24iLCAib2JzZXJ2ZVZhbHVlRm9yS2V5UGF0 aCIsIG1fY2FsbGJhY2stPmxvZ0lkZW50aWZpZXIoKSksICJkaWQgY2hhbmdlICciLCBba2V5UGF0 aCBVVEY4U3RyaW5nXSwgIiciKTsKLSAgICAgICAgfQorICAgICAgICBpZiAoc2hvdWxkTG9nVmFs dWUpIHsKKyAgICAgICAgICAgIGlmIChba2V5UGF0aCBpc0VxdWFsVG9TdHJpbmc6QCJkdXJhdGlv biJdKQorICAgICAgICAgICAgICAgIG1fY2FsbGJhY2stPmxvZ2dlcigpLmRlYnVnKG1fY2FsbGJh Y2stPmxvZ0NoYW5uZWwoKSwgaWRlbnRpZmllciwgImRpZCBjaGFuZ2UgJyIsIFtrZXlQYXRoIFVU RjhTdHJpbmddLCAiJyB0byAiLCB0b01lZGlhVGltZShbbmV3VmFsdWUgQ01UaW1lVmFsdWVdKSk7 CisgICAgICAgICAgICBlbHNlIHsKKyAgICAgICAgICAgICAgICBSZXRhaW5QdHI8TlNTdHJpbmc+ IHZhbHVlU3RyaW5nID0gYWRvcHROUyhbW05TU3RyaW5nIGFsbG9jXSBpbml0V2l0aEZvcm1hdDpA IiVAIiwgbmV3VmFsdWVdKTsKKyAgICAgICAgICAgICAgICBtX2NhbGxiYWNrLT5sb2dnZXIoKS5k ZWJ1ZyhtX2NhbGxiYWNrLT5sb2dDaGFubmVsKCksIGlkZW50aWZpZXIsICJkaWQgY2hhbmdlICci LCBba2V5UGF0aCBVVEY4U3RyaW5nXSwgIicgdG8gIiwgW3ZhbHVlU3RyaW5nLmdldCgpIFVURjhT dHJpbmddKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfSBlbHNlCisgICAgICAgICAgICBtX2Nh bGxiYWNrLT5sb2dnZXIoKS5kZWJ1ZyhtX2NhbGxiYWNrLT5sb2dDaGFubmVsKCksIGlkZW50aWZp ZXIsIHdpbGxDaGFuZ2UgPyAid2lsbCIgOiAiZGlkIiwgIiBjaGFuZ2UgJyIsIFtrZXlQYXRoIFVU RjhTdHJpbmddLCAiJyIpOwogICAgIH0KICNlbmRpZgogCg==