177189 2017-09-19 13:45:29 -0700 Web Inspector: View should automatically layout when attached to the DOM 2017-09-27 12:21:46 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue hi inspector-bugzilla-changes ross.kirsling webkit-bug-importer oldest_to_newest 1350485 0 mattbaker 2017-09-19 13:45:29 -0700 Summary: A View should automatically layout when it becomes attached to the DOM. Currently a layout has to be scheduled with needsLayout/updateLayout. It shouldn't be possible to have a view attached to the DOM that hasn't had it's initialLayout method called. This is the behavior that 99% of views will want. If the need arises, we can make it possible to opt out with View constructor options or something. 1350492 1 321239 mattbaker 2017-09-19 13:56:17 -0700 Created attachment 321239 Patch 1351892 2 321239 hi 2017-09-22 17:01:13 -0700 Comment on attachment 321239 Patch r=me Nice! 1351894 3 321239 commit-queue 2017-09-22 17:27:42 -0700 Comment on attachment 321239 Patch Clearing flags on attachment: 321239 Committed r222416: <http://trac.webkit.org/changeset/222416> 1351895 4 commit-queue 2017-09-22 17:27:43 -0700 All reviewed patches have been landed. Closing bug. 1353330 5 webkit-bug-importer 2017-09-27 12:21:46 -0700 <rdar://problem/34693128> 321239 2017-09-19 13:56:17 -0700 2017-09-22 17:27:42 -0700 Patch bug-177189-20170919135616.patch text/plain 7132 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 MTNlYTRiZmMwYWM4MGQxMDgxYWFjN2VjNDRkNmVhN2IzZWZlYjk5Li41NDczYThjZTc5NDA1NWU1 NzE0ZDAyYjBiYzU1M2Y5YmFiOGRjMTY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzOSBAQAorMjAxNy0wOS0xOSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVmlldyBzaG91bGQgYXV0b21hdGljYWxseSBsYXlv dXQgd2hlbiBpdCBiZWNvbWVzIGF0dGFjaGVkIHRvIHRoZSBET00KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzE4OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgZ3VhcmFudGVlcyB0aGF0IGEgbGF5 b3V0IGlzIGFsd2F5cyBzY2hlZHVsZWQgYXMgc29vbiBhcyBhIHZpZXcgaXMKKyAgICAgICAgYXR0 YWNoZWQgdG8gdGhlIERPTS4gTm93IHRoYXQgbmVhcmx5IGFsbCB2aWV3cyBhcmUgY3JlYXRlZCBs YXppbHksIGl0CisgICAgICAgIGlzIHNhZmUgdG8gbWFrZSB0aGlzIGNoYW5nZSBldmVuIHdpdGhv dXQgaGF2aW5nIGEgdmlzaWJpbGl0eSBjb25jZXB0IGluCisgICAgICAgIHRoZSBWaWV3IGNsYXNz IHRoYXQgd291bGQgcHJldmVudCBsYXlvdXRzIGZvciBiYWNrZ3JvdW5kIHZpZXdzLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9WaWV3cy9WaWV3LmpzOgorICAgICAgICAoV0kuVmlldyk6Cisg ICAgICAgIFJlbW92ZSBgdGhpcy5fbmVlZHNMYXlvdXRXaGVuQXR0YWNoZWRUb1Jvb3RgIGZsYWcs IHdoaWNoIGlzIG5vdyBpbXBsaWNpdC4KKyAgICAgICAgVGhpcyB3YXMgc2V0IGlmIGEgbGF5b3V0 IHdhcyByZXF1ZXN0ZWQgYmVmb3JlIHRoZSB2aWV3IGhhZCBiZWVuIGF0dGFjaGVkCisgICAgICAg IHRvIHRoZSBET00uCisKKyAgICAgICAgKFdJLlZpZXcucHJvdG90eXBlLmdldCBlbGVtZW50KToK KyAgICAgICAgKFdJLlZpZXcucHJvdG90eXBlLmdldCBsYXlvdXRQZW5kaW5nKToKKyAgICAgICAg KFdJLlZpZXcucHJvdG90eXBlLmdldCBwYXJlbnRWaWV3KToKKyAgICAgICAgKFdJLlZpZXcucHJv dG90eXBlLmdldCBzdWJ2aWV3cyk6CisgICAgICAgIChXSS5WaWV3LnByb3RvdHlwZS5nZXQgaXNB dHRhY2hlZCk6CisgICAgICAgIChXSS5WaWV3LnByb3RvdHlwZS5pbnNlcnRTdWJ2aWV3QmVmb3Jl KToKKyAgICAgICAgKFdJLlZpZXcucHJvdG90eXBlLnJlbW92ZVN1YnZpZXcpOgorICAgICAgICAo V0kuVmlldy5wcm90b3R5cGUucmVtb3ZlQWxsU3Vidmlld3MpOgorICAgICAgICAoV0kuVmlldy5w cm90b3R5cGUuYXR0YWNoZWQpOgorICAgICAgICAoV0kuVmlldy5wcm90b3R5cGUuZGV0YWNoZWQp OgorICAgICAgICBIb29rcyBmb3Igc3ViY2xhc3NlcyB0byBkZWZpbmUgYmVoYXZpb3IgYWRkZWQg b3IgcmVtb3ZlZCBmcm9tIHRoZSBET00uCisgICAgICAgIChXSS5WaWV3LnByb3RvdHlwZS5fZGlk TW92ZVRvUGFyZW50KToKKyAgICAgICAgKFdJLlZpZXcucHJvdG90eXBlLl9kaWRNb3ZlVG9XaW5k b3cpOgorICAgICAgICAoV0kuVmlldy5fc2NoZWR1bGVMYXlvdXRGb3JWaWV3KToKKyAgICAgICAg KFdJLlZpZXcucHJvdG90eXBlLmRpZE1vdmVUb1dpbmRvdyk6IERlbGV0ZWQuCisgICAgICAgIChX SS5WaWV3LnByb3RvdHlwZS5kaWRNb3ZlVG9QYXJlbnQpOiBEZWxldGVkLgorICAgICAgICBUaGVz ZSB3ZXJlIG9ubHkgdXNlZCBieSBWaWV3LCBhbmQgaGF2ZSBiZWVuIG1hZGUgcHJpdmF0ZS4KKwog MjAxNy0wOS0xOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogUmVtb3RlT2JqZWN0LnJlc29sdmVOb2RlIHNob3VsZCByZXR1cm4gYSBQ cm9taXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9WaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv Vmlldy5qcwppbmRleCAwYTM5ODUzM2ZhMjZhYjE1MDVhMjFmODYxYWVlYjJiNTIzMWNlN2ZmLi40 ZTdjNGIxZWQ1NzdkNDFlMWRhYzQyYjgwMzBmYjI2MDY5YjEzNTlmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaWV3LmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1ZpZXcuanMKQEAgLTM1LDcgKzM1 LDYgQEAgV0kuVmlldyA9IGNsYXNzIFZpZXcgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgdGhp cy5fc3Vidmlld3MgPSBbXTsKICAgICAgICAgdGhpcy5fZGlydHkgPSBmYWxzZTsKICAgICAgICAg dGhpcy5fZGlydHlEZXNjZW5kYW50c0NvdW50ID0gMDsKLSAgICAgICAgdGhpcy5fbmVlZHNMYXlv dXRXaGVuQXR0YWNoZWRUb1Jvb3QgPSBmYWxzZTsKICAgICAgICAgdGhpcy5faXNBdHRhY2hlZFRv Um9vdCA9IGZhbHNlOwogICAgICAgICB0aGlzLl9sYXlvdXRSZWFzb24gPSBudWxsOwogICAgICAg ICB0aGlzLl9kaWRJbml0aWFsTGF5b3V0ID0gZmFsc2U7CkBAIC01MywyNSArNTIsMTEgQEAgV0ku VmlldyA9IGNsYXNzIFZpZXcgZXh0ZW5kcyBXSS5PYmplY3QKIAogICAgIC8vIFB1YmxpYwogCi0g ICAgZ2V0IGVsZW1lbnQoKQotICAgIHsKLSAgICAgICAgcmV0dXJuIHRoaXMuX2VsZW1lbnQ7Ci0g ICAgfQotCi0gICAgZ2V0IGxheW91dFBlbmRpbmcoKQotICAgIHsKLSAgICAgICAgcmV0dXJuIHRo aXMuX2RpcnR5OwotICAgIH0KLQotICAgIGdldCBwYXJlbnRWaWV3KCkKLSAgICB7Ci0gICAgICAg IHJldHVybiB0aGlzLl9wYXJlbnRWaWV3OwotICAgIH0KLQotICAgIGdldCBzdWJ2aWV3cygpCi0g ICAgewotICAgICAgICByZXR1cm4gdGhpcy5fc3Vidmlld3M7Ci0gICAgfQorICAgIGdldCBlbGVt ZW50KCkgeyByZXR1cm4gdGhpcy5fZWxlbWVudDsgfQorICAgIGdldCBsYXlvdXRQZW5kaW5nKCkg eyByZXR1cm4gdGhpcy5fZGlydHk7IH0KKyAgICBnZXQgcGFyZW50VmlldygpIHsgcmV0dXJuIHRo aXMuX3BhcmVudFZpZXc7IH0KKyAgICBnZXQgc3Vidmlld3MoKSB7IHJldHVybiB0aGlzLl9zdWJ2 aWV3czsgfQorICAgIGdldCBpc0F0dGFjaGVkKCkgeyByZXR1cm4gdGhpcy5faXNBdHRhY2hlZFRv Um9vdDsgfQogCiAgICAgaXNEZXNjZW5kYW50T2YodmlldykKICAgICB7CkBAIC0xMTIsNyArOTcs NyBAQCBXSS5WaWV3ID0gY2xhc3MgVmlldyBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICBpZiAo IXZpZXcuZWxlbWVudC5wYXJlbnROb2RlKQogICAgICAgICAgICAgdGhpcy5fZWxlbWVudC5pbnNl cnRCZWZvcmUodmlldy5lbGVtZW50LCByZWZlcmVuY2VWaWV3ID8gcmVmZXJlbmNlVmlldy5lbGVt ZW50IDogbnVsbCk7CiAKLSAgICAgICAgdmlldy5kaWRNb3ZlVG9QYXJlbnQodGhpcyk7CisgICAg ICAgIHZpZXcuX2RpZE1vdmVUb1BhcmVudCh0aGlzKTsKICAgICB9CiAKICAgICByZW1vdmVTdWJ2 aWV3KHZpZXcpCkBAIC0xMjksMTMgKzExNCwxMyBAQCBXSS5WaWV3ID0gY2xhc3MgVmlldyBleHRl bmRzIFdJLk9iamVjdAogICAgICAgICB0aGlzLl9zdWJ2aWV3cy5zcGxpY2UoaW5kZXgsIDEpOwog ICAgICAgICB0aGlzLl9lbGVtZW50LnJlbW92ZUNoaWxkKHZpZXcuZWxlbWVudCk7CiAKLSAgICAg ICAgdmlldy5kaWRNb3ZlVG9QYXJlbnQobnVsbCk7CisgICAgICAgIHZpZXcuX2RpZE1vdmVUb1Bh cmVudChudWxsKTsKICAgICB9CiAKICAgICByZW1vdmVBbGxTdWJ2aWV3cygpCiAgICAgewogICAg ICAgICBmb3IgKGxldCBzdWJ2aWV3IG9mIHRoaXMuX3N1YnZpZXdzKQotICAgICAgICAgICAgc3Vi dmlldy5kaWRNb3ZlVG9QYXJlbnQobnVsbCk7CisgICAgICAgICAgICBzdWJ2aWV3Ll9kaWRNb3Zl VG9QYXJlbnQobnVsbCk7CiAKICAgICAgICAgdGhpcy5fc3Vidmlld3MgPSBbXTsKICAgICAgICAg dGhpcy5fZWxlbWVudC5yZW1vdmVDaGlsZHJlbigpOwpAQCAtMTg1LDM4ICsxNzAsMTQgQEAgV0ku VmlldyA9IGNsYXNzIFZpZXcgZXh0ZW5kcyBXSS5PYmplY3QKICAgICBnZXQgbGF5b3V0UmVhc29u KCkgeyByZXR1cm4gdGhpcy5fbGF5b3V0UmVhc29uOyB9CiAgICAgZ2V0IGRpZEluaXRpYWxMYXlv dXQoKSB7IHJldHVybiB0aGlzLl9kaWRJbml0aWFsTGF5b3V0OyB9CiAKLSAgICBkaWRNb3ZlVG9X aW5kb3coaXNBdHRhY2hlZFRvUm9vdCkKKyAgICBhdHRhY2hlZCgpCiAgICAgewotICAgICAgICB0 aGlzLl9pc0F0dGFjaGVkVG9Sb290ID0gaXNBdHRhY2hlZFRvUm9vdDsKLQotICAgICAgICBpZiAo dGhpcy5faXNBdHRhY2hlZFRvUm9vdCAmJiB0aGlzLl9uZWVkc0xheW91dFdoZW5BdHRhY2hlZFRv Um9vdCkgewotICAgICAgICAgICAgV0kuVmlldy5fc2NoZWR1bGVMYXlvdXRGb3JWaWV3KHRoaXMp OwotICAgICAgICAgICAgdGhpcy5fbmVlZHNMYXlvdXRXaGVuQXR0YWNoZWRUb1Jvb3QgPSBmYWxz ZTsKLSAgICAgICAgfQotCi0gICAgICAgIGZvciAobGV0IHZpZXcgb2YgdGhpcy5fc3Vidmlld3Mp Ci0gICAgICAgICAgICB2aWV3LmRpZE1vdmVUb1dpbmRvdyhpc0F0dGFjaGVkVG9Sb290KTsKKyAg ICAgICAgLy8gSW1wbGVtZW50ZWQgYnkgc3ViY2xhc3Nlcy4KICAgICB9CiAKLSAgICBkaWRNb3Zl VG9QYXJlbnQocGFyZW50VmlldykKKyAgICBkZXRhY2hlZCgpCiAgICAgewotICAgICAgICB0aGlz Ll9wYXJlbnRWaWV3ID0gcGFyZW50VmlldzsKLQotICAgICAgICBsZXQgaXNBdHRhY2hlZFRvUm9v dCA9IHRoaXMuaXNEZXNjZW5kYW50T2YoV0kuVmlldy5fcm9vdFZpZXcpOwotICAgICAgICB0aGlz LmRpZE1vdmVUb1dpbmRvdyhpc0F0dGFjaGVkVG9Sb290KTsKLQotICAgICAgICBpZiAoIXRoaXMu X3BhcmVudFZpZXcpCi0gICAgICAgICAgICByZXR1cm47Ci0KLSAgICAgICAgbGV0IHBlbmRpbmdM YXlvdXRzQ291bnQgPSB0aGlzLl9kaXJ0eURlc2NlbmRhbnRzQ291bnQ7Ci0gICAgICAgIGlmICh0 aGlzLl9kaXJ0eSkKLSAgICAgICAgICAgIHBlbmRpbmdMYXlvdXRzQ291bnQrKzsKLQotICAgICAg ICBsZXQgdmlldyA9IHRoaXMuX3BhcmVudFZpZXc7Ci0gICAgICAgIHdoaWxlICh2aWV3KSB7Ci0g ICAgICAgICAgICB2aWV3Ll9kaXJ0eURlc2NlbmRhbnRzQ291bnQgKz0gcGVuZGluZ0xheW91dHND b3VudDsKLSAgICAgICAgICAgIHZpZXcgPSB2aWV3LnBhcmVudFZpZXc7Ci0gICAgICAgIH0KKyAg ICAgICAgLy8gSW1wbGVtZW50ZWQgYnkgc3ViY2xhc3Nlcy4KICAgICB9CiAKICAgICBpbml0aWFs TGF5b3V0KCkKQEAgLTI0NSw2ICsyMDYsNDMgQEAgV0kuVmlldyA9IGNsYXNzIFZpZXcgZXh0ZW5k cyBXSS5PYmplY3QKIAogICAgIC8vIFByaXZhdGUKIAorICAgIF9kaWRNb3ZlVG9QYXJlbnQocGFy ZW50VmlldykKKyAgICB7CisgICAgICAgIHRoaXMuX3BhcmVudFZpZXcgPSBwYXJlbnRWaWV3Owor CisgICAgICAgIGxldCBpc0F0dGFjaGVkVG9Sb290ID0gdGhpcy5pc0Rlc2NlbmRhbnRPZihXSS5W aWV3Ll9yb290Vmlldyk7CisgICAgICAgIHRoaXMuX2RpZE1vdmVUb1dpbmRvdyhpc0F0dGFjaGVk VG9Sb290KTsKKworICAgICAgICBpZiAoIXRoaXMuX3BhcmVudFZpZXcpCisgICAgICAgICAgICBy ZXR1cm47CisKKyAgICAgICAgbGV0IHBlbmRpbmdMYXlvdXRzQ291bnQgPSB0aGlzLl9kaXJ0eURl c2NlbmRhbnRzQ291bnQ7CisgICAgICAgIGlmICh0aGlzLl9kaXJ0eSkKKyAgICAgICAgICAgIHBl bmRpbmdMYXlvdXRzQ291bnQrKzsKKworICAgICAgICBsZXQgdmlldyA9IHRoaXMuX3BhcmVudFZp ZXc7CisgICAgICAgIHdoaWxlICh2aWV3KSB7CisgICAgICAgICAgICB2aWV3Ll9kaXJ0eURlc2Nl bmRhbnRzQ291bnQgKz0gcGVuZGluZ0xheW91dHNDb3VudDsKKyAgICAgICAgICAgIHZpZXcgPSB2 aWV3LnBhcmVudFZpZXc7CisgICAgICAgIH0KKyAgICB9CisKKyAgICBfZGlkTW92ZVRvV2luZG93 KGlzQXR0YWNoZWRUb1Jvb3QpCisgICAgeworICAgICAgICBpZiAodGhpcy5faXNBdHRhY2hlZFRv Um9vdCA9PT0gaXNBdHRhY2hlZFRvUm9vdCkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAg ICB0aGlzLl9pc0F0dGFjaGVkVG9Sb290ID0gaXNBdHRhY2hlZFRvUm9vdDsKKyAgICAgICAgaWYg KHRoaXMuX2lzQXR0YWNoZWRUb1Jvb3QpIHsKKyAgICAgICAgICAgIHRoaXMuYXR0YWNoZWQoKTsK KyAgICAgICAgICAgIFdJLlZpZXcuX3NjaGVkdWxlTGF5b3V0Rm9yVmlldyh0aGlzKTsKKyAgICAg ICAgfSBlbHNlCisgICAgICAgICAgICB0aGlzLmRldGFjaGVkKCk7CisKKyAgICAgICAgZm9yIChs ZXQgdmlldyBvZiB0aGlzLl9zdWJ2aWV3cykKKyAgICAgICAgICAgIHZpZXcuX2RpZE1vdmVUb1dp bmRvdyhpc0F0dGFjaGVkVG9Sb290KTsKKyAgICB9CisKICAgICBfbGF5b3V0U3VidHJlZSgpCiAg ICAgewogICAgICAgICB0aGlzLl9kaXJ0eSA9IGZhbHNlOwpAQCAtMzA5LDEyICszMDcsOCBAQCBX SS5WaWV3ID0gY2xhc3MgVmlldyBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICAgICAgcGFyZW50 VmlldyA9IHBhcmVudFZpZXcucGFyZW50VmlldzsKICAgICAgICAgfQogCi0gICAgICAgIGlmICgh dmlldy5faXNBdHRhY2hlZFRvUm9vdCkgewotICAgICAgICAgICAgLy8gRG9uJ3Qgc2NoZWR1bGUg bGF5b3V0IG9mIHRoZSB2aWV3IHVubGVzcyBpdCBpcyBhIGRlc2NlbmRhbnQgb2YgdGhlIHJvb3Qg dmlldy4KLSAgICAgICAgICAgIC8vIFdoZW4gaXQgbW92ZXMgdG8gYSByb290ZWQgdmlldyB0cmVl LCBzY2hlZHVsZSBhbiBpbml0aWFsIGxheW91dC4KLSAgICAgICAgICAgIHZpZXcuX25lZWRzTGF5 b3V0V2hlbkF0dGFjaGVkVG9Sb290ID0gdHJ1ZTsKKyAgICAgICAgaWYgKCF2aWV3Ll9pc0F0dGFj aGVkVG9Sb290KQogICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICB9CiAKICAgICAgICAgaWYg KFdJLlZpZXcuX3NjaGVkdWxlZExheW91dFVwZGF0ZUlkZW50aWZpZXIpCiAgICAgICAgICAgICBy ZXR1cm47Cg==