177180 2017-09-19 12:03:47 -0700 [CMake] Add ENABLE_WEB_CRYPTO option and make ENABLE_SUBTLE_CRYPTO depend on it. 2017-09-27 12:17:18 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=172758 P2 Normal --- 1 clopez clopez achristensen bugs-noreply cgarcia commit-queue mcatanzaro sam webkit-bug-importer ysuzuki oldest_to_newest 1350447 0 clopez 2017-09-19 12:03:47 -0700 On r220445 <https://trac.webkit.org/r172758> the GTK port introduced the public configure option ENABLE_WEB_CRYPTO. The idea is that users pass ENABLE_WEB_CRYPTO instead of ENABLE_SUBTLE_CRYPTO (subtle crypto is a terrible name) I think we should use this naming also on the WPE port to enable SUBTLE crypto. As someone that works on build recipes (Yocto) for WPE and GTK+, I will appreciate to have as much as possible identical config flags for the same features between both ports, to make easier code-sharing of recipe configs So, if both GTK and WPE are going to use this naming then it make sense to mave also the definition to general CMake config like we do with other options 1350452 1 321231 clopez 2017-09-19 12:18:54 -0700 Created attachment 321231 Patch 1350481 2 321231 commit-queue 2017-09-19 13:42:30 -0700 Comment on attachment 321231 Patch Clearing flags on attachment: 321231 Committed r222222: <http://trac.webkit.org/changeset/222222> 1350482 3 commit-queue 2017-09-19 13:42:31 -0700 All reviewed patches have been landed. Closing bug. 321231 2017-09-19 12:18:54 -0700 2017-09-19 13:42:30 -0700 Patch bug-177180-20170919211853.patch text/plain 5616 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGY3ZmIx ZWZhZTBlNGExZGI3YmIwNDEwM2MxNWQ0NjMwM2Q3ZDEzMjkuLjM2MWJlZTFkZTYzNjQ4N2Y0YWYy ZDg5NGJiODM3MWU4OTUyYmNhYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC04OSw3ICs4OSw2 IEBAIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9QTFVHSU5fUFJPQ0VTU19HVEsyICJXaGV0 aGVyIHRvIGJ1aWxkIFdlYktpdFBsdWdpblByCiBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVf UVVBUlRaX1RBUkdFVCAiV2hldGhlciB0byBlbmFibGUgc3VwcG9ydCBmb3IgdGhlIFF1YXJ0eiB3 aW5kb3dpbmcgdGFyZ2V0LiIgUFVCTElDICR7R1RLM19TVVBQT1JUU19RVUFSVFp9KQogV0VCS0lU X09QVElPTl9ERUZJTkUoRU5BQkxFX1gxMV9UQVJHRVQgIldoZXRoZXIgdG8gZW5hYmxlIHN1cHBv cnQgZm9yIHRoZSBYMTEgd2luZG93aW5nIHRhcmdldC4iIFBVQkxJQyAke0dUSzNfU1VQUE9SVFNf WDExfSkKIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9XQVlMQU5EX1RBUkdFVCAiV2hldGhl ciB0byBlbmFibGUgc3VwcG9ydCBmb3IgdGhlIFdheWxhbmQgd2luZG93aW5nIHRhcmdldC4iIFBV QkxJQyAke0dUSzNfU1VQUE9SVFNfV0FZTEFORH0pCi1XRUJLSVRfT1BUSU9OX0RFRklORShFTkFC TEVfV0VCX0NSWVBUTyAiV2hldGhlciB0byBlbmFibGUgc3VwcG9ydCBmb3IgV2ViIENyeXB0byBB UEkuIiBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRklORShVU0VfTElCTk9USUZZICJXaGV0 aGVyIHRvIGVuYWJsZSB0aGUgZGVmYXVsdCB3ZWIgbm90aWZpY2F0aW9uIGltcGxlbWVudGF0aW9u LiIgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX0xJQkhZUEhFTiAiV2hldGhl ciB0byBlbmFibGUgdGhlIGRlZmF1bHQgYXV0b21hdGljIGh5cGhlbmF0aW9uIGltcGxlbWVudGF0 aW9uLiIgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX0xJQlNFQ1JFVCAiV2hl dGhlciB0byBlbmFibGUgdGhlIHBlcnNpc3RlbnQgY3JlZGVudGlhbCBzdG9yYWdlIHVzaW5nIGxp YnNlY3JldC4iIFBVQkxJQyBPTikKQEAgLTEwNiw3ICsxMDUsNiBAQCBXRUJLSVRfT1BUSU9OX0RF UEVORChFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTIEVOQUJMRV9PUEVOR0wpCiBXRUJLSVRf T1BUSU9OX0RFUEVORChFTkFCTEVfR0xFUzIgRU5BQkxFX09QRU5HTCkKIFdFQktJVF9PUFRJT05f REVQRU5EKEVOQUJMRV9QTFVHSU5fUFJPQ0VTU19HVEsyIEVOQUJMRV9YMTFfVEFSR0VUKQogV0VC S0lUX09QVElPTl9ERVBFTkQoRU5BQkxFX1dFQkdMIEVOQUJMRV9PUEVOR0wpCi1XRUJLSVRfT1BU SU9OX0RFUEVORChFTkFCTEVfU1VCVExFX0NSWVBUTyBFTkFCTEVfV0VCX0NSWVBUTykKIFdFQktJ VF9PUFRJT05fREVQRU5EKFVTRV9SRURJUkVDVEVEX1hDT01QT1NJVEVfV0lORE9XIEVOQUJMRV9P UEVOR0wpCiBXRUJLSVRfT1BUSU9OX0RFUEVORChVU0VfUkVESVJFQ1RFRF9YQ09NUE9TSVRFX1dJ TkRPVyBFTkFCTEVfWDExX1RBUkdFVCkKIApAQCAtMTQxLDYgKzEzOSw3IEBAIFdFQktJVF9PUFRJ T05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9KSVQgUFVCTElDIE9OKQogV0VCS0lUX09QVElP Tl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1NBTVBMSU5HX1BST0ZJTEVSIFBVQkxJQyBPTikK IFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TUEVMTENIRUNLIFBVQkxJ QyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9UT1VDSF9FVkVO VFMgUFVCTElDIE9OKQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dF Ql9DUllQVE8gUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B QkxFX1dFQkRSSVZFUiBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxV RShVU0VfU1lTVEVNX01BTExPQyBQVUJMSUMgT0ZGKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21h a2UvT3B0aW9uc1dQRS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCmluZGV4 IDZjMzdiZTM3MjRlZjY3ZjcxNzEyNjYxMzkxOGY5NTNhNDYyNjc3MDEuLjAyNWE4NDFiYTA5YjE1 OWQ3ZWJjMzYyNTY4MTA1YjRkMmZkMTMxYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zV1BFLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCkBAIC0yOSwx MCArMjksMTEgQEAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01IVE1M IFBSSVZBVEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTkVU U0NBUEVfUExVR0lOX0FQSSBQUklWQVRFIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JU X1ZBTFVFKEVOQUJMRV9QVUJMSUNfU1VGRklYX0xJU1QgUFJJVkFURSBPTikKIFdFQktJVF9PUFRJ T05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9SRU1PVEVfSU5TUEVDVE9SIFBSSVZBVEUgT04p Ci1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU1VCVExFX0NSWVBUTyBQ VUJMSUMgT04pCitXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU1VCVExF X0NSWVBUTyBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B QkxFX1RPVUNIX0VWRU5UUyBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfVVNFUl9NRVNTQUdFX0hBTkRMRVJTIFBSSVZBVEUgT04pCiBXRUJLSVRfT1BU SU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfV0VCX0FOSU1BVElPTlMgUFJJVkFURSBPTikK K1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJfQ1JZUFRPIFBVQkxJ QyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJHTCBQVUJM SUMgT04pCiAKIGlmIChDTUFLRV9TWVNURU1fTkFNRSBNQVRDSEVTICJMaW51eCIpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UKaW5kZXggYjFlMjBlY2ExMTNhYjQxNGY4MTNhZThkZDFlY2QzNzEy ZTk0ODNlMy4uMWE4ZWYwYzY5YWFkOGZjNDhhODI4ZWRmYzYxZDM0NzNmNjY3ZWMzMiAxMDA2NDQK LS0tIGEvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFr ZS9XZWJLaXRGZWF0dXJlcy5jbWFrZQpAQCAtMTgzLDYgKzE4Myw3IEBAIG1hY3JvKFdFQktJVF9P UFRJT05fQkVHSU4pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1dFQlZUVF9SRUdJ T05TICJUb2dnbGUgd2VidnR0IHJlZ2lvbiBzdXBwb3J0IiBQUklWQVRFIE9GRikKICAgICBXRUJL SVRfT1BUSU9OX0RFRklORShFTkFCTEVfV0VCX0FOSU1BVElPTlMgIlRvZ2dsZSBXZWIgQW5pbWF0 aW9ucyBzdXBwb3J0IiBQUklWQVRFIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFC TEVfV0VCX0FVRElPICJUb2dnbGUgV2ViIEF1ZGlvIHN1cHBvcnQiIFBSSVZBVEUgT0ZGKQorICAg IFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9XRUJfQ1JZUFRPICJXaGV0aGVyIHRvIGVuYWJs ZSBzdXBwb3J0IGZvciBXZWIgQ3J5cHRvIEFQSS4iIFBSSVZBVEUgT0ZGKQogICAgIFdFQktJVF9P UFRJT05fREVGSU5FKEVOQUJMRV9XRUJfUlRDICJUb2dnbGUgV2ViUlRDIEFQSSBzdXBwb3J0IiBQ UklWQVRFIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfWFNMVCAiVG9nZ2xl IFhTTFQgc3VwcG9ydCIgUFJJVkFURSBPTikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShVU0Vf U1lTVEVNX01BTExPQyAiVG9nZ2xlIHN5c3RlbSBhbGxvY2F0b3IgaW5zdGVhZCBvZiBXZWJLaXQn cyBjdXN0b20gYWxsb2NhdG9yIiBQUklWQVRFIE9GRikKQEAgLTE5OSw2ICsyMDAsNyBAQCBtYWNy byhXRUJLSVRfT1BUSU9OX0JFR0lOKQogICAgIFdFQktJVF9PUFRJT05fREVQRU5EKEVOQUJMRV9N RURJQV9TVFJFQU0gRU5BQkxFX1ZJREVPKQogICAgIFdFQktJVF9PUFRJT05fREVQRU5EKEVOQUJM RV9WSURFT19UUkFDSyBFTkFCTEVfVklERU8pCiAgICAgV0VCS0lUX09QVElPTl9ERVBFTkQoRU5B QkxFX1RPVUNIX1NMSURFUiBFTkFCTEVfVE9VQ0hfRVZFTlRTKQorICAgIFdFQktJVF9PUFRJT05f REVQRU5EKEVOQUJMRV9TVUJUTEVfQ1JZUFRPIEVOQUJMRV9XRUJfQ1JZUFRPKQogZW5kbWFjcm8o KQogCiBtYWNybyhfV0VCS0lUX09QVElPTl9FTkZPUkNFX0RFUEVORFMgX25hbWUpCmRpZmYgLS1n aXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYjgzYTVjODhkNDBkYjFhMDVkNGM3Y2U5 YzRjNDY1NWJiY2I0OGFhNi4uY2JhMDU4ZDk2NDU4YjlmZTJhYTU0YzdlMWExNjI4ZTY4YzEzMGVj MyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDE3LTA5LTE5ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEu Y29tPgorCisgICAgICAgIFtDTWFrZV0gQWRkIEVOQUJMRV9XRUJfQ1JZUFRPIG9wdGlvbiBhbmQg bWFrZSBFTkFCTEVfU1VCVExFX0NSWVBUTyBkZXBlbmQgb24gaXQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzcxODAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGFkZHMgYSBFTkFCTEVfV0VCX0NS WVBUTyBmbGFnIGFuZCBtYWtlcyBFTkFCTEVfU1VCVExFX0NSWVBUTyBkZXBlbmQgb24gaXQuCisg ICAgICAgIFRoZSBHVEsgYW5kIFdQRSBwb3J0cyBlbmFibGUgdGhlbSBhbmQgc2V0IEVOQUJMRV9X RUJfQ1JZUFRPIHRvIHB1YmxpYy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlOiBTZXQgYm90aCBmZWF0dXJlcyB0byBPTiBhbmQgRU5BQkxFX1dFQl9DUllQVE8gdG8g cHVibGljLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3VyIGZvciBHVEsuCisgICAgICAgICogU291cmNl L2NtYWtlL09wdGlvbnNXUEUuY21ha2U6IERvIGxpa2Ugb24gdGhlIEdUSyBwb3J0LiBUaGUgcHVi bGljIGZsYWcgaXMgbm93IEVOQUJMRV9XRUJfQ1JZUFRPLgorICAgICAgICAqIFNvdXJjZS9jbWFr ZS9XZWJLaXRGZWF0dXJlcy5jbWFrZTogQWRkIHRoZSBkZWZpbml0aW9uIG9mIEVOQUJMRV9XRUJf Q1JZUFRPIGFuZCBtYWtlIEVOQUJMRV9TVUJUTEVfQ1JZUFRPIGRlcGVuZCBvbiBpdC4KKwogMjAx Ny0wOS0xOCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0NNYWtlXSBSZW5hbWUgV2ViS2l0IHRhcmdldCB0byBXZWJLaXRMZWdhY3kgYW5kIHJl bmFtZSBXZWJLaXQyIHRhcmdldCB0byBXZWJLaXQK