177128 2017-09-19 02:11:02 -0700 [Curl] Fix r222147 2017-09-27 12:28:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 daewoong.jang daewoong.jang achristensen basuke bfulgham buildbot commit-queue darin don.olmstead galpeter webkit-bug-importer oldest_to_newest 1350274 0 daewoong.jang 2017-09-19 02:11:02 -0700 -Fix can't load https pages. -Build fix for platforms other than Windows. -Replace OS(WINDOWS) with PLATFORM(WIN). -Some style fix. 1350275 1 321189 daewoong.jang 2017-09-19 02:13:51 -0700 Created attachment 321189 patch 1350462 2 321189 basuke 2017-09-19 13:07:40 -0700 Comment on attachment 321189 patch View in context: https://bugs.webkit.org/attachment.cgi?id=321189&action=review > Source/WebCore/platform/network/curl/CurlSSLVerifier.cpp:56 > + if (!verifier) Oh my. Sorry about this. 1350463 3 321189 don.olmstead 2017-09-19 13:08:40 -0700 Comment on attachment 321189 patch I don't see how changing to PLATFORM(WIN) solves anything here. 1350473 4 basuke 2017-09-19 13:30:19 -0700 (In reply to Don Olmstead from comment #3) > Comment on attachment 321189 [details] > patch > > I don't see how changing to PLATFORM(WIN) solves anything here. I guess that for Qt on Windows? 1350495 5 don.olmstead 2017-09-19 14:04:36 -0700 (In reply to Basuke Suzuki from comment #4) > (In reply to Don Olmstead from comment #3) > > Comment on attachment 321189 [details] > > patch > > > > I don't see how changing to PLATFORM(WIN) solves anything here. > > I guess that for Qt on Windows? Believe this is for his Android port. I'm just not sure wanted to know why it would be a problem as android shouldn't be OS(WINDOWS) in this case. 1350561 6 daewoong.jang 2017-09-19 15:52:13 -0700 (In reply to Don Olmstead from comment #5) > (In reply to Basuke Suzuki from comment #4) > > (In reply to Don Olmstead from comment #3) > > > Comment on attachment 321189 [details] > > > patch > > > > > > I don't see how changing to PLATFORM(WIN) solves anything here. > > > > I guess that for Qt on Windows? > > Believe this is for his Android port. I'm just not sure wanted to know why > it would be a problem as android shouldn't be OS(WINDOWS) in this case. I'd have kept these changes downstream if it only affects Android port. I submitted it because the guarded code shouldn't be OS dependent. 1350590 7 321189 achristensen 2017-09-19 17:52:30 -0700 Comment on attachment 321189 patch View in context: https://bugs.webkit.org/attachment.cgi?id=321189&action=review I don't understand the need for this patch. > Source/WebCore/ChangeLog:3 > + [Curl] Fix r222147 What exactly does this fix? Does it fix the build? Does it fix https on Windows? Does it fix https on non-windows? Does it fix bypassing certificate warnings on certain systems? 1350597 8 daewoong.jang 2017-09-19 18:10:47 -0700 (In reply to Alex Christensen from comment #7) > Comment on attachment 321189 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321189&action=review > > I don't understand the need for this patch. > > > Source/WebCore/ChangeLog:3 > > + [Curl] Fix r222147 > > What exactly does this fix? Does it fix the build? Does it fix https on > Windows? Does it fix https on non-windows? Does it fix bypassing > certificate warnings on certain systems? Does it fix the build? >> Yes. It fixes building curl without OS(WINDOWS). Does it fix https on Windows? Does it fix https on non-windows? >> Yes. https://bugs.webkit.org/show_bug.cgi?id=177128#c2 Does it fix bypassing certificate warnings on certain systems? >> I don't know. The problem is not loading https pages at all, not bypassing certificate warnings. I'm sure this is needed. 1350604 9 daewoong.jang 2017-09-19 18:34:45 -0700 (In reply to Alex Christensen from comment #7) > Comment on attachment 321189 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321189&action=review > > I don't understand the need for this patch. > > > Source/WebCore/ChangeLog:3 > > + [Curl] Fix r222147 > > What exactly does this fix? Does it fix the build? Does it fix https on > Windows? Does it fix https on non-windows? Does it fix bypassing > certificate warnings on certain systems? Thanks for your review and giving a cq+ but you set r? instead of r+. Is this a mistake or should I have to ask another reviewer to give a r+? Thank you. 1350641 10 321189 achristensen 2017-09-19 20:56:19 -0700 Comment on attachment 321189 patch mistake. r=me 1350650 11 321189 commit-queue 2017-09-19 21:25:56 -0700 Comment on attachment 321189 patch Clearing flags on attachment: 321189 Committed r222248: <http://trac.webkit.org/changeset/222248> 1350651 12 commit-queue 2017-09-19 21:25:57 -0700 All reviewed patches have been landed. Closing bug. 1353412 13 webkit-bug-importer 2017-09-27 12:28:24 -0700 <rdar://problem/34693341> 321189 2017-09-19 02:13:51 -0700 2017-09-19 21:25:56 -0700 patch bug177128.diff text/plain 3530 daewoong.jang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMjIwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA5LTE5ICBEYWV3b29u ZyBKYW5nICA8ZGFld29vbmcuamFuZ0BuYXZlcmxhYnMuY29tPgorCisgICAgICAgIFtDdXJsXSBG aXggcjIyMjE0NworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTc3MTI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFNTTEhhbmRsZS5oOgorICAgICAgICAqIHBs YXRmb3JtL25ldHdvcmsvY3VybC9DdXJsU1NMVmVyaWZpZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Q3VybFNTTFZlcmlmaWVyOjpjZXJ0VmVyaWZ5Q2FsbGJhY2spOgorICAgICAgICAqIHBsYXRm b3JtL25ldHdvcmsvY3VybC9DdXJsU1NMVmVyaWZpZXIuaDoKKwogMjAxNy0wOS0xOSAgTmFlbCBP dWVkcmFvZ28gIDxuYWVsLm91ZWRyYW9nb0BjcmYuY2Fub24uZnI+CiAKICAgICAgICAgW0dUS10g VGhlIGJpbmRpbmcgY29kZSBvZiBNZWRpYSBTb3VyY2UgRXh0ZW5zaW9uIG9mIEF1ZGlvVHJhY2ss IFZpZGVvVHJhY2sgYW5kIFRleHRUcmFjayBpcyBub3QgZ2VuZXJhdGVkCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFNTTEhhbmRsZS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsU1NMSGFuZGxlLmgJ KHJldmlzaW9uIDIyMjE5NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3Vy bC9DdXJsU1NMSGFuZGxlLmgJKHdvcmtpbmcgY29weSkKQEAgLTI2LDEwICsyNiw2IEBACiAKICNw cmFnbWEgb25jZQogCi0jaWYgT1MoV0lORE9XUykKLSNpbmNsdWRlIDx3aW5zb2NrMi5oPgotI2Vu ZGlmCi0KICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogI2luY2x1ZGUgPHd0Zi9MaXN0SGFzaFNl dC5oPgogI2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxTU0xWZXJpZmllci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxTU0xWZXJpZmllci5jcHAJ KHJldmlzaW9uIDIyMjE5NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3Vy bC9DdXJsU1NMVmVyaWZpZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MywxMiArNTMsMTIgQEAg aW50IEN1cmxTU0xWZXJpZmllcjo6Y2VydFZlcmlmeUNhbGxiYWNrKAogICAgIFNTTCogc3NsID0g c3RhdGljX2Nhc3Q8U1NMKj4oWDUwOV9TVE9SRV9DVFhfZ2V0X2V4X2RhdGEoc3RvcmVDdHgsIFNT TF9nZXRfZXhfZGF0YV9YNTA5X1NUT1JFX0NUWF9pZHgoKSkpOwogICAgIFNTTF9DVFgqIHNzbEN0 eCA9IFNTTF9nZXRfU1NMX0NUWChzc2wpOwogICAgIEN1cmxTU0xWZXJpZmllciogdmVyaWZpZXIg PSBzdGF0aWNfY2FzdDxDdXJsU1NMVmVyaWZpZXIqPihTU0xfQ1RYX2dldF9hcHBfZGF0YShzc2xD dHgpKTsKLSAgICBpZiAodmVyaWZpZXIpCisgICAgaWYgKCF2ZXJpZmllcikKICAgICAgICAgcmV0 dXJuIDA7CiAKICAgICB2ZXJpZmllci0+bV9zc2xFcnJvcnMgPSBzdGF0aWNfY2FzdDxpbnQ+KHZl cmlmaWVyLT5jb252ZXJ0VG9TU0xDZXJ0aWZpY2F0ZUZsYWdzKGNlcnRFcnJDZCkpOwogCi0jaWYg T1MoV0lORE9XUykKKyNpZiBQTEFURk9STShXSU4pCiAgICAgb2sgPSBDdXJsQ29udGV4dDo6c2lu Z2xldG9uKCkuc3NsSGFuZGxlKCkuaXNBbGxvd2VkSFRUUFNDZXJ0aWZpY2F0ZUhvc3QodmVyaWZp ZXItPm1faG9zdE5hbWUpOwogI2Vsc2UKICAgICBMaXN0SGFzaFNldDxTdHJpbmc+IGNlcnRpZmlj YXRlczsKQEAgLTc4LDcgKzc4LDcgQEAgaW50IEN1cmxTU0xWZXJpZmllcjo6Y2VydFZlcmlmeUNh bGxiYWNrKAogICAgIHJldHVybiBvazsKIH0KIAotI2lmICFPUyhXSU5ET1dTKQorI2lmICFQTEFU Rk9STShXSU4pCiAKIGJvb2wgQ3VybFNTTFZlcmlmaWVyOjpnZXRQZW1EYXRhRnJvbUN0eChYNTA5 X1NUT1JFX0NUWCogY3R4LCBMaXN0SGFzaFNldDxTdHJpbmc+JiBjZXJ0aWZpY2F0ZXMpCiB7Cklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFNTTFZlcmlmaWVy LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1 cmxTU0xWZXJpZmllci5oCShyZXZpc2lvbiAyMjIxOTQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFNTTFZlcmlmaWVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTI2 LDEwICsyNiw3IEBACiAKICNwcmFnbWEgb25jZQogCi0jaWYgT1MoV0lORE9XUykKLSNpbmNsdWRl IDx3aW5zb2NrMi5oPgotI2VuZGlmCi0KKyNpbmNsdWRlIDx3dGYvTGlzdEhhc2hTZXQuaD4KICNp bmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcu aD4KIApAQCAtNDEsOCArMzgsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFzcyBDdXJsSGFu ZGxlOwogCiBjbGFzcyBDdXJsU1NMVmVyaWZpZXIgewotV1RGX01BS0VfTk9OQ09QWUFCTEUoQ3Vy bFNTTFZlcmlmaWVyKTsKLQorICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKEN1cmxTU0xWZXJpZmll cik7CiBwdWJsaWM6CiAgICAgZW51bSBjbGFzcyBTU0xDZXJ0aWZpY2F0ZUZsYWdzIHsKICAgICAg ICAgU1NMX0NFUlRJRklDQVRFX1VOS05PV05fQ0EgPSAoMSA8PCAwKSwgLy8gVGhlIHNpZ25pbmcg Y2VydGlmaWNhdGUgYXV0aG9yaXR5IGlzIG5vdCBrbm93bi4KQEAgLTY1LDggKzYxLDggQEAgcHVi bGljOgogcHJpdmF0ZToKICAgICBzdGF0aWMgaW50IGNlcnRWZXJpZnlDYWxsYmFjayhpbnQsIFg1 MDlfU1RPUkVfQ1RYKik7CiAKLSNpZiAhT1MoV0lORE9XUykKLSAgICBib29sIGdldFBlbURhdGFG cm9tQ3R4KFg1MDlfU1RPUkVfQ1RYKiwgTGlzdEhhc2hTZXQ8U3RyaW5nPiYpOworI2lmICFQTEFU Rk9STShXSU4pCisgICAgc3RhdGljIGJvb2wgZ2V0UGVtRGF0YUZyb21DdHgoWDUwOV9TVE9SRV9D VFgqLCBMaXN0SGFzaFNldDxTdHJpbmc+Jik7CiAjZW5kaWYKIAogICAgIFNTTENlcnRpZmljYXRl RmxhZ3MgY29udmVydFRvU1NMQ2VydGlmaWNhdGVGbGFncyhjb25zdCB1bnNpZ25lZCYpOwo=