177114 2017-09-18 17:04:21 -0700 REGRESSION(r214494): Web Inspector: Ignore cache button does not work in Network tab 2017-09-19 09:03:14 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1350169 0 joepeck 2017-09-18 17:04:21 -0700 Summary: Ignore cache button does not work in Network tab Steps to reproduce: 1. Inspect this page 2. Show Network Tab 3. Reload => Some resources came from cache 4. Toggle Ignore Cache button to be activated 5. Reload => Still shows resources came from cache, expected them not to Notes: <https://webkit.org/b/169865> Web Inspector: Add "Disable Caches" option that only applies to the inspected page while Web Inspector is open <http://trac.webkit.org/changeset/214494> - The "only do this if enabled" post-review change was too liberal 1350170 1 webkit-bug-importer 2017-09-18 17:05:44 -0700 <rdar://problem/34505265> 1350172 2 321155 joepeck 2017-09-18 17:07:19 -0700 Created attachment 321155 [PATCH] Proposed Fix 1350313 3 321155 bburg 2017-09-19 08:34:28 -0700 Comment on attachment 321155 [PATCH] Proposed Fix r=me 1350327 4 321155 commit-queue 2017-09-19 09:03:12 -0700 Comment on attachment 321155 [PATCH] Proposed Fix Clearing flags on attachment: 321155 Committed r222209: <http://trac.webkit.org/changeset/222209> 1350328 5 commit-queue 2017-09-19 09:03:14 -0700 All reviewed patches have been landed. Closing bug. 321155 2017-09-18 17:07:19 -0700 2017-09-19 09:03:12 -0700 [PATCH] Proposed Fix ignore-cache-1.patch text/plain 1795 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMyZjMwMjkyMTExLi43MTgwMGUwODA3MiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDktMTggIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIy MTQ0OTQpOiBXZWIgSW5zcGVjdG9yOiBJZ25vcmUgY2FjaGUgYnV0dG9uIGRvZXMgbm90IHdvcmsg aW4gTmV0d29yayB0YWIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3NzExNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzQ1MDUyNjU+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L0Jhc2UvTWFpbi5qczoKKyAgICAgICAgKFdJLmxvYWRlZCk6CisgICAgICAgIFdlIG5lZWQgdG8g cmVnaXN0ZXIgdGhlIHNldHRpbmdzIGNoYW5nZSBoYW5kbGVyIHJlZ2FyZGxlc3Mgb2Ygd2hhdCB0 aGUKKyAgICAgICAgaW5pdGlhbCB2YWx1ZSBvZiB0aGUgc2V0dGluZyBpcy4KKwogMjAxNy0wOS0x MSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IEFkZCBFeHBlcmltZW50YWwgc2V0dGluZyBmb3IgbmV3IE5ldHdvcmsgdGFiCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4u anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKaW5k ZXggY2M0ZTliYTQxNDQuLjU2YmJiMGM3MDY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC0xOTEsOCArMTkxLDkgQEAgV0kubG9h ZGVkID0gZnVuY3Rpb24oKQogCiAgICAgLy8gQ09NUEFUSUJJTElUWSAoaU9TIDEwLjMpOiBOZXR3 b3JrLnNldERpc2FibGVSZXNvdXJjZUNhY2hpbmcgZGlkIG5vdCBleGlzdC4KICAgICB0aGlzLnJl c291cmNlQ2FjaGluZ0Rpc2FibGVkU2V0dGluZyA9IG5ldyBXSS5TZXR0aW5nKCJkaXNhYmxlLXJl c291cmNlLWNhY2hpbmciLCBmYWxzZSk7Ci0gICAgaWYgKHdpbmRvdy5OZXR3b3JrQWdlbnQgJiYg TmV0d29ya0FnZW50LnNldFJlc291cmNlQ2FjaGluZ0Rpc2FibGVkICYmIHRoaXMucmVzb3VyY2VD YWNoaW5nRGlzYWJsZWRTZXR0aW5nLnZhbHVlKSB7Ci0gICAgICAgIE5ldHdvcmtBZ2VudC5zZXRS ZXNvdXJjZUNhY2hpbmdEaXNhYmxlZCh0cnVlKTsKKyAgICBpZiAod2luZG93Lk5ldHdvcmtBZ2Vu dCAmJiBOZXR3b3JrQWdlbnQuc2V0UmVzb3VyY2VDYWNoaW5nRGlzYWJsZWQpIHsKKyAgICAgICAg aWYgKHRoaXMucmVzb3VyY2VDYWNoaW5nRGlzYWJsZWRTZXR0aW5nLnZhbHVlKQorICAgICAgICAg ICAgTmV0d29ya0FnZW50LnNldFJlc291cmNlQ2FjaGluZ0Rpc2FibGVkKHRydWUpOwogICAgICAg ICB0aGlzLnJlc291cmNlQ2FjaGluZ0Rpc2FibGVkU2V0dGluZy5hZGRFdmVudExpc3RlbmVyKFdJ LlNldHRpbmcuRXZlbnQuQ2hhbmdlZCwgdGhpcy5fcmVzb3VyY2VDYWNoaW5nRGlzYWJsZWRTZXR0 aW5nQ2hhbmdlZCwgdGhpcyk7CiAgICAgfQogCg==