177108 2017-09-18 16:09:44 -0700 [Win] Compile error in InbandTextTrackPrivateAVCF::readNativeSampleBuffer. 2017-09-27 12:22:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue webkit-bug-importer oldest_to_newest 1350144 0 pvollan 2017-09-18 16:09:44 -0700 The InbandTextTrackPrivateAVF::m_sampleInputBuffer is used in this method, but it is private. 1350148 1 321148 pvollan 2017-09-18 16:14:46 -0700 Created attachment 321148 Patch 1350176 2 321148 bfulgham 2017-09-18 17:24:31 -0700 Comment on attachment 321148 Patch r=me 1350196 3 pvollan 2017-09-18 18:26:14 -0700 (In reply to Brent Fulgham from comment #2) > Comment on attachment 321148 [details] > Patch > > r=me Thanks for reviewing! 1350202 4 321148 commit-queue 2017-09-18 18:56:37 -0700 Comment on attachment 321148 Patch Clearing flags on attachment: 321148 Committed r222195: <http://trac.webkit.org/changeset/222195> 1350203 5 commit-queue 2017-09-18 18:56:39 -0700 All reviewed patches have been landed. Closing bug. 1353334 6 webkit-bug-importer 2017-09-27 12:22:16 -0700 <rdar://problem/34693147> 321148 2017-09-18 16:14:46 -0700 2017-09-18 18:56:37 -0700 Patch bug-177108-20170919011446.patch text/plain 1590 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMjE4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA5LTE4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBDb21waWxlIGVy cm9yIGluIEluYmFuZFRleHRUcmFja1ByaXZhdGVBVkNGOjpyZWFkTmF0aXZlU2FtcGxlQnVmZmVy LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3MTA4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIElu YmFuZFRleHRUcmFja1ByaXZhdGVBVkY6Om1fc2FtcGxlSW5wdXRCdWZmZXIgaXMgcHJpdmF0ZSBh bmQgbm90IGFjY2Vzc2libGUgaW4gdGhpcyBtZXRob2QuCisgCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvYXZmb3VuZGF0aW9uL0luYmFuZFRleHRUcmFja1ByaXZhdGVBVkYuaDoKKwogMjAx Ny0wOS0xOCAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CiAKICAgICAg ICAgW0N1cmxdIE1vdmUgZXJyb3IgZ2VuZXJhdGlvbiB0YXNrIGludG8gUmVzb3VyY2VFcnJvcgpJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL0luYmFu ZFRleHRUcmFja1ByaXZhdGVBVkYuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vSW5iYW5kVGV4dFRyYWNrUHJpdmF0ZUFWRi5oCShy ZXZpc2lvbiAyMjIxODYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZv dW5kYXRpb24vSW5iYW5kVGV4dFRyYWNrUHJpdmF0ZUFWRi5oCSh3b3JraW5nIGNvcHkpCkBAIC04 Niw2ICs4Niw4IEBAIHByb3RlY3RlZDoKICAgICB2b2lkIHByb2Nlc3NOYXRpdmVTYW1wbGVzKENG QXJyYXlSZWYsIGNvbnN0IE1lZGlhVGltZSYpOwogICAgIHZvaWQgcmVtb3ZlQ29tcGxldGVkQ3Vl cygpOwogCisgICAgVmVjdG9yPGNoYXI+IG1fc2FtcGxlSW5wdXRCdWZmZXI7CisKIHByaXZhdGU6 CiAjaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECiAgICAgY29uc3QgY2hhciogbG9nQ2xhc3NOYW1l KCkgY29uc3QgZmluYWwgeyByZXR1cm4gIkluYmFuZFRleHRUcmFja1ByaXZhdGVBVkYiOyB9CkBA IC05Nyw4ICs5OSw2IEBAIHByaXZhdGU6CiAgICAgVmVjdG9yPFJlZlB0cjxHZW5lcmljQ3VlRGF0 YT4+IG1fY3VlczsKICAgICBBVkZJbmJhbmRUcmFja1BhcmVudCogbV9vd25lcjsKIAotICAgIFZl Y3RvcjxjaGFyPiBtX3NhbXBsZUlucHV0QnVmZmVyOwotCiAgICAgZW51bSBQZW5kaW5nQ3VlU3Rh dHVzIHsKICAgICAgICAgTm9uZSwKICAgICAgICAgRGVsaXZlcmVkRHVyaW5nU2VlaywK