177073 2017-09-18 08:57:19 -0700 WebDriver: HTTP responses should include Cache-Control header with no-cache value 2017-09-27 12:25:40 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg joepeck svillar webkit-bug-importer oldest_to_newest 1349912 0 cgarcia 2017-09-18 08:57:19 -0700 6.3 Processing Model Set the response’s header with name and value with the following values: Content-Type "application/json; charset=utf-8" Cache-Control "no-cache" https://w3c.github.io/webdriver/webdriver-spec.html#dfn-send-a-response 1349916 1 321097 cgarcia 2017-09-18 09:01:02 -0700 Created attachment 321097 Patch 1349940 2 321097 svillar 2017-09-18 09:40:38 -0700 Comment on attachment 321097 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321097&action=review > Source/WebDriver/ChangeLog:9 > + Set the response’s header with name and value with the following values: Weird character here > Source/WebDriver/soup/HTTPServerSoup.cpp:52 > + // §6.3 Processing Model. Weird character here 1350257 3 321097 cgarcia 2017-09-18 23:39:28 -0700 Comment on attachment 321097 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321097&action=review Thanks for the review. >> Source/WebDriver/ChangeLog:9 >> + Set the response’s header with name and value with the following values: > > Weird character here It's the review tool that screws this, open the diff and see it's correct. >> Source/WebDriver/soup/HTTPServerSoup.cpp:52 >> + // §6.3 Processing Model. > > Weird character here Ditto. 1350258 4 cgarcia 2017-09-18 23:40:11 -0700 Committed r222203: <http://trac.webkit.org/changeset/222203> 1353369 5 webkit-bug-importer 2017-09-27 12:25:40 -0700 <rdar://problem/34693258> 321097 2017-09-18 09:01:02 -0700 2017-09-18 09:40:38 -0700 Patch wd-cache-control.diff text/plain 2181 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggMTU2ZTgyYTJhODUuLjgyMjhkMjEzZDMwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA5LTE4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IEhUVFAgcmVzcG9uc2VzIHNo b3VsZCBpbmNsdWRlIENhY2hlLUNvbnRyb2wgaGVhZGVyIHdpdGggbm8tY2FjaGUgdmFsdWUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzA3MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIDYuMyBQcm9jZXNz aW5nIE1vZGVsLgorICAgICAgICBTZXQgdGhlIHJlc3BvbnNl4oCZcyBoZWFkZXIgd2l0aCBuYW1l IGFuZCB2YWx1ZSB3aXRoIHRoZSBmb2xsb3dpbmcgdmFsdWVzOgorCisgICAgICAgIENvbnRlbnQt VHlwZSAiYXBwbGljYXRpb24vanNvbjsgY2hhcnNldD11dGYtOCIKKyAgICAgICAgQ2FjaGUtQ29u dHJvbCAibm8tY2FjaGUiCisKKyAgICAgICAgaHR0cHM6Ly93M2MuZ2l0aHViLmlvL3dlYmRyaXZl ci93ZWJkcml2ZXItc3BlYy5odG1sI2Rmbi1zZW5kLWEtcmVzcG9uc2UKKworICAgICAgICBXZSB3 ZXJlIHNldHRpbmcgdGhlIENvbnRlbnQtVHlwZSwgYnV0IG5vdCB0aGUgQ2FjaGUtQ29udHJvbC4g VGhpcyBpcyBjaGVja2VkIGJ5IGFsbCBXUFQgV2ViRHJpdmVyIHRlc3RzLgorCisgICAgICAgICog c291cC9IVFRQU2VydmVyU291cC5jcHA6CisgICAgICAgIChXZWJEcml2ZXI6OkhUVFBTZXJ2ZXI6 Omxpc3Rlbik6IEFkZCBDYWNoZS1Db250cm9sIGhlYWRlci4KKwogMjAxNy0wOS0xNSAgSkYgQmFz dGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CiAKICAgICAgICAgV1RGOiB1c2UgRm9yd2FyZC5o IHdoZW4gYXBwcm9wcmlhdGUgaW5zdGVhZCBvZiBWZWN0b3IuaApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkRyaXZlci9zb3VwL0hUVFBTZXJ2ZXJTb3VwLmNwcCBiL1NvdXJjZS9XZWJEcml2ZXIvc291 cC9IVFRQU2VydmVyU291cC5jcHAKaW5kZXggNzc1OTkyNGNkNTguLmM3MzIwYmUxZmVlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViRHJpdmVyL3NvdXAvSFRUUFNlcnZlclNvdXAuY3BwCisrKyBiL1Nv dXJjZS9XZWJEcml2ZXIvc291cC9IVFRQU2VydmVyU291cC5jcHAKQEAgLTQ5LDcgKzQ5LDEwIEBA IGJvb2wgSFRUUFNlcnZlcjo6bGlzdGVuKHVuc2lnbmVkIHBvcnQpCiAgICAgICAgICAgICBbc2Vy dmVyLCBtZXNzYWdlID0gV1RGTW92ZShwcm90ZWN0ZWRNZXNzYWdlKV0oSFRUUFJlcXVlc3RIYW5k bGVyOjpSZXNwb25zZSYmIHJlc3BvbnNlKSB7CiAgICAgICAgICAgICAgICAgc291cF9tZXNzYWdl X3NldF9zdGF0dXMobWVzc2FnZS5nZXQoKSwgcmVzcG9uc2Uuc3RhdHVzQ29kZSk7CiAgICAgICAg ICAgICAgICAgaWYgKCFyZXNwb25zZS5kYXRhLmlzTnVsbCgpKSB7CisgICAgICAgICAgICAgICAg ICAgIC8vIMKnNi4zIFByb2Nlc3NpbmcgTW9kZWwuCisgICAgICAgICAgICAgICAgICAgIC8vIGh0 dHBzOi8vdzNjLmdpdGh1Yi5pby93ZWJkcml2ZXIvd2ViZHJpdmVyLXNwZWMuaHRtbCNkZm4tc2Vu ZC1hLXJlc3BvbnNlCiAgICAgICAgICAgICAgICAgICAgIHNvdXBfbWVzc2FnZV9oZWFkZXJzX2Fw cGVuZChtZXNzYWdlLT5yZXNwb25zZV9oZWFkZXJzLCAiQ29udGVudC1UeXBlIiwgcmVzcG9uc2Uu Y29udGVudFR5cGUudXRmOCgpLmRhdGEoKSk7CisgICAgICAgICAgICAgICAgICAgIHNvdXBfbWVz c2FnZV9oZWFkZXJzX2FwcGVuZChtZXNzYWdlLT5yZXNwb25zZV9oZWFkZXJzLCAiQ2FjaGUtQ29u dHJvbCIsICJuby1jYWNoZSIpOwogICAgICAgICAgICAgICAgICAgICBzb3VwX21lc3NhZ2VfYm9k eV9hcHBlbmQobWVzc2FnZS0+cmVzcG9uc2VfYm9keSwgU09VUF9NRU1PUllfQ09QWSwgcmVzcG9u c2UuZGF0YS5kYXRhKCksIHJlc3BvbnNlLmRhdGEubGVuZ3RoKCkpOwogICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgICAgICBzb3VwX3NlcnZlcl91bnBhdXNlX21lc3NhZ2Uoc2VydmVyLCBt ZXNzYWdlLmdldCgpKTsK