17707 2008-03-07 11:49:44 -0800 Conditionalize use of SAFARI_THEME in WebKitClassFactory 2008-03-07 13:16:27 -0800 1 1 1 Unclassified WebKit WebKit Misc. 523.x (Safari 3) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 bfulgham webkit-unassigned oldest_to_newest 73010 0 bfulgham 2008-03-07 11:49:44 -0800 The windows-only WebKitClassFactory.cpp class links to the SAFARI_THEME library. This is a problem if you want to build a Cario-backed version of WebKit since it requires CoreGraphics to work. Someday, the themes will be standardized under a more modular infrastructure, but until then a reasonable work-around is to not link to SAFARI_THEME when the "USE(SAFARI_THEME)" test fails. 73011 1 19592 bfulgham 2008-03-07 11:55:37 -0800 Created attachment 19592 Patch to avoid linking to SafariTheme.dll if not using safari theme 73012 2 19592 aroben 2008-03-07 11:57:52 -0800 Comment on attachment 19592 Patch to avoid linking to SafariTheme.dll if not using safari theme r=me 73028 3 mrowe 2008-03-07 13:16:27 -0800 Landed in r30877. 19592 2008-03-07 11:55:37 -0800 2008-03-07 11:57:52 -0800 Patch to avoid linking to SafariTheme.dll if not using safari theme SafariTheme.patch text/plain 1657 bfulgham SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiAzMDg3MCkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDMtMDYgIEJyZW50IEZ1bGdoYW0gIDxiZnVs Z2hhbUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRG8gbm90IGxpbmsgKG9yIGF0dGVtcHQgdG8gaW5pdGlhbGl6ZSkgdGhlIFNhZmFy aVRoZW1lLmRsbAorICAgICAgICB3aGVuIG5vdCBidWlsZGluZyB3aXRoIFVTRShTQUZBUklfVEhF TUUpIGVuYWJsZWQuCisgICAgICAgIChodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzcwNykKKworICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENI QU5HRUQKKworICAgICAgICAqIFdlYktpdC93aW4vV2ViS2l0Q2xhc3NGYWN0b3J5LmNwcDogIENv bmRpdGlvbmFsaXplIHVzZSBvZiBTYWZhcmlUaGVtZS5kbGwKKwogMjAwOC0wMy0wNiAgRGFyaW4g QWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWl0ei4KSW5k ZXg6IFdlYktpdC93aW4vV2ViS2l0Q2xhc3NGYWN0b3J5LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvd2luL1dlYktpdENsYXNzRmFjdG9yeS5jcHAJKHJldmlzaW9uIDMwODcwKQorKysgV2ViS2l0 L3dpbi9XZWJLaXRDbGFzc0ZhY3RvcnkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Niw3ICs1Niw3 IEBACiAjcHJhZ21hIHdhcm5pbmcocG9wKQogCiAvLyBXZWJLaXRDbGFzc0ZhY3RvcnkgLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCi0KKyNp ZiBVU0UoU0FGQVJJX1RIRU1FKQogI2lmICFkZWZpbmVkKE5ERUJVRykgJiYgZGVmaW5lZChVU0Vf REVCVUdfU0FGQVJJX1RIRU1FKQogU09GVF9MSU5LX0RFQlVHX0xJQlJBUlkoU2FmYXJpVGhlbWUp CiAjZWxzZQpAQCAtNjQsMTcgKzY0LDIwIEBAIFNPRlRfTElOS19MSUJSQVJZKFNhZmFyaVRoZW1l KQogI2VuZGlmCiAKIFNPRlRfTElOSyhTYWZhcmlUaGVtZSwgU1RJbml0aWFsaXplLCB2b2lkLCBB UElFTlRSWSwgKCksICgpKQorI2VuZGlmCiAKIFdlYktpdENsYXNzRmFjdG9yeTo6V2ViS2l0Q2xh c3NGYWN0b3J5KENMU0lEIHRhcmdldENsYXNzKQogOiBtX3RhcmdldENsYXNzKHRhcmdldENsYXNz KQogLCBtX3JlZkNvdW50KDApCiB7CisjaWYgVVNFKFNBRkFSSV9USEVNRSkKICAgICBzdGF0aWMg Ym9vbCBkaWRJbml0aWFsaXplU2FmYXJpVGhlbWU7CiAgICAgaWYgKCFkaWRJbml0aWFsaXplU2Fm YXJpVGhlbWUpIHsKICAgICAgICAgaWYgKFNhZmFyaVRoZW1lTGlicmFyeSgpKQogICAgICAgICAg ICAgU1RJbml0aWFsaXplKCk7CiAgICAgICAgIGRpZEluaXRpYWxpemVTYWZhcmlUaGVtZSA9IHRy dWU7CiAgICAgfQorI2VuZGlmCiAKICAgICBXZWJDb3JlOjpwb3B1bGF0ZUZvbnREYXRhYmFzZSgp OwogCg==